GitLab

On X11, primary monitor is often set to an inactive output.
However, nvidia-control-panel and other tools will still show
that one of the active montiors is the primary one. While I'm
not sure how this works, the list of monitors returned by
xrandr --listmonitors should always have the primary monitor
first, so let's fall back on the order of the monitors if
available.

Change-Id: I9f06754d95130957338a8dfcc4541ef350794b49
Reviewed-on: https://chromium-review.googlesource.com/1020150Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553759}

https://skia.googlesource.com/skia.git/+log/27988f76b25e..25af671a3d7d

$ git log 27988f76b..25af671a3 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 egdaniel Add GrCap check for whether we can do a copy or not, and implement in Vk backend
2018-04-25 borenet [infra] Run presubmit like a normal bot
2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms a893aa3..2c9b55f (1 commits)
2018-04-25 enne Add CheckGeneratedFiles recipe check for gpu workarounds
2018-04-25 bungeman Clean up xfermodes3 gm.
2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 509a65e..a893aa3 (1 commits)
2018-04-25 liyuqian Snap bitmap for SkThreadedBMPDevice::drawBitmapRect
2018-04-25 bsalomon Revert "Revert "Add arcs as a specialized geometry to GrShape.""
2018-04-25 kjlubick Move Baytrail to stretch
2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 48c6ca0..509a65e (1 commits)
2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 9e351c0..48c6ca0 (1 commits)
2018-04-25 angle-skia-autoroll Roll third_party/externals/angle2/ 023371b3a..f827123d9 (5 commits)
2018-04-25 brianosman Don't 'require' external image extensions, 'enable' them
2018-04-25 reed Experiment to track coverage in a layer
2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms f3a576b..9e351c0 (1 commits)
2018-04-24 ethannicholas cache SkSL headers
2018-04-24 benjaminwagner Upgrade Win Radeon driver.
2018-04-25 robertphillips Fix GrRRectBlurEffect.fp
2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 40a5028..f3a576b (1 commits)
2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 86807d3..40a5028 (1 commits)
2018-04-25 kjlubick Migrate ShuttleA bots to Debian9 stretch

Created with:
  roll-dep src/third_party/skia
BUG=chromium: 829614


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I573306e5aee3463fe005e9f9ae679ee0fa7bdf95
Reviewed-on: https://chromium-review.googlesource.com/1028625
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553758}

Bug: 781703
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If6fda4644b20764c0561d03a826c97e561f80337
Reviewed-on: https://chromium-review.googlesource.com/1024967
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553757}

https://pdfium.googlesource.com/pdfium.git/+log/d9da586dd3db..7132ee35925f

$ git log d9da586dd..7132ee359 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 thestig Clean up CCodec_FlateScanlineDecoder.
2018-04-25 tsepez Introduce ScopedFPDF types in public/cpp/fpdf_scopers.h
2018-04-25 rharrison Allow failing to build CFXA_FWLTheme if unable to load fonts
2018-04-25 thestig Remove unused PNGEncode() code.
2018-04-25 thestig Roll third_party/googletest/src/ a325ad2db..4bd8c4638 (125 commits)
2018-04-25 thestig Use WindowsPrintMode in more places in place of ints.
2018-04-25 hnakashima Fix behavior of Delete key in XFA edit.
2018-04-25 tsepez Fix slight type inconsistencies discovered with strict FPDF API types.
2018-04-25 thestig Remove CDWriteExt.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:835608,chromium:820104


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ib3baadc56b41581755208c483b861b5587ef7953
Reviewed-on: https://chromium-review.googlesource.com/1028661
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553756}

Add a new content type with no per-type volume control (only
per-stream).

Bug: internal b/78533406

Change-Id: If0d7280c54ba95fd583e7292814e476862d52335
Reviewed-on: https://chromium-review.googlesource.com/1026452
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553755}

Implement anonymous set of functions that extract U2F request commands
from WebAuthN style Ctap{MakeCredential GetAssertion} Request.

Bug: 798573
Change-Id: I3431b0769db20b39a2e590d5a7d4136a3a920fe8
Reviewed-on: https://chromium-review.googlesource.com/1018739
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553754}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=sadrul@chromium.org

Bug: 825327
Change-Id: Id090f93a7156fcef4c60defd5fb6bc2682e732af
Reviewed-on: https://chromium-review.googlesource.com/1024650Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553753}

Make WorkletAnimation implement AnimationEffectOwner interface which
enables it to attach to its effect and update its inherited time.

For now, we use "0" as inherited time of the effect but follow up
patches will instead use local time values that will be plumbed from
animation worklet instead.

TODO:
 - Plumb the time values from worklet and use that
 - WorkletAnimation should allow its effect to cancel and restart it.

Bug: 814851
Change-Id: I8f0b9ff914130cdf73d0e9df41dec13ccc03bcf9
Reviewed-on: https://chromium-review.googlesource.com/902725Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553752}

Adding myself to OWNERS for chromeos so I can unblock folks when needed.

R=alemate@chromium.org, stevenjb@chromium.org

Bug: None
Change-Id: Ibed17c33a099ccf08e99ba8b45f3aa863d786d5a
Reviewed-on: https://chromium-review.googlesource.com/1028612Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553751}

BUG=818754

Change-Id: I66c89c85f79d6599837abec757e89116c3de53eb
Reviewed-on: https://chromium-review.googlesource.com/1028226Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553750}

Update ExtensionServiceTestBase and all derived tests to use
manifest v2 extensions. Update old .crx files, Preferences files,
and dynamically-created extensions. Remove the allowance for
manifest v1 extensions.

Bug: 816679

Change-Id: Ib07447a9cde9017f250d8100d3e55a9fd790d48c
Reviewed-on: https://chromium-review.googlesource.com/1024642Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553749}

This removes a bunch of complexity around formats that is superfluous,
and removes format selection from the LayerTreeResourceProvider,
eliminating a use of the ContextProvider from it. This might help
with implmenting 826886, or just be a cleanup that I found while
trying it out.

The RasterBufferProvider impls were using a format specified in the
LayerTreeSettings if it was supported, based on the opacity of the
content. However the only possible format that the settings would
specify other than the default was RGBA_4444 which is always
supported if specified. And opacity doesn't actually play into any
decisions made anymore.

So stop passing around opacity, and ask viz::PlatformColor for a
format to use in the RasterBufferProvider impls, with the caveat that
RGBA_4444 should be preferred (for gpu compositing) if specified by
the settings.

R=kylechar@chromium.org
TBR=piman

Bug: 826886
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I74200eb54bef57fa663eede861661c876a87a408
Reviewed-on: https://chromium-review.googlesource.com/1024703
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553748}

ResizeParams is a misnomer. VisualProperties is better although
perhaps confusing because changing the LocalSurfaceId can cause
a new CompositorFrame to be generated without any change in visuals.

I can't really think of a better name and VisualProperties can also
be interpreted as properties that affect the visuals (compositing)
system so it still works. It's definitely an improvement from
ResizeParams which is totally wrong.

Change-Id: Ie8e1f5e8c354851e4efdf3aa5d975f1edfe77f5d
Bug: 836367, 672962
TBR: tsepez@chromium.org for IPC rename.
Reviewed-on: https://chromium-review.googlesource.com/1028460
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553747}

Many existing rebaselined tests had to be rebaselined again
because borders looked different.

Bug: 714962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia4114b66e322550b1a8dc5fc96568071d50a951e
Reviewed-on: https://chromium-review.googlesource.com/1027073
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553746}

When downloading to a file, if code deleted the SimpleURLLoader on
completion, and then tried to access the FilePath object passed to them
by the SimpleURLLoader, they're run into a use-after-free. This CL fixes
that.

Bug: 835963
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8b840544be743aa979145bf46c8d35de4b25c12c
Reviewed-on: https://chromium-review.googlesource.com/1024694
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553745}

This CL adds input event predictor in main thread event queue
under a flag kResampleInputEvents.
It is the basic structure for resample events, without only an
empty predictor. The input predictor handled events before the
event is dispatched. And apply current time to the event.

design doc:
https://docs.google.com/document/d/1DLfibi2NkV85p7AfEtNkvy24d283VRBSd3hz1Qh24Jw/edit?usp=sharing

Bug: 836352
Change-Id: I7c17a33b2e0e5e9a51920e54a9b8ce795537f4ef
Reviewed-on: https://chromium-review.googlesource.com/860429Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553744}

As dewittj@ pointed out, in StartupMaintenanceTask some raw pointers to
the objects on UI thread are being used in background thread, which is
unsafe. This CL fixes the issue by making copy of objects on UI thread
and bind them before hopping to background thread.

Fortunately other tasks didn't have the wrong implementation.

Bug: 832232
Change-Id: Ia8913ba6036b9c2ce357d53857f968fe1629c03d
Reviewed-on: https://chromium-review.googlesource.com/1027130
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553743}

There have been many fixes in the network service path since this was disabled, and running locally (100x) doesn't show any flakes.

TBR=cmumford@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I80466b2696bd58dc35ae254e47908bad99c1c5ac
Reviewed-on: https://chromium-review.googlesource.com/1028753
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553742}

See https://groups.google.com/a/chromium.org/d/msg/storage-dev/7LPVIl2dx_M/-rQaqjCTDAAJ
for some data and discussion.

Bug: 793109
Change-Id: I342af261c094fbf26a934737b56960fb2c244011
Reviewed-on: https://chromium-review.googlesource.com/1026164Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553741}

This method is needed for positioning the find bar in Views browser mode.

Bug: 834754
Change-Id: Id984e5281bf970c0c99af8696a6cebbb8ca4c2a3
Reviewed-on: https://chromium-review.googlesource.com/1028450Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553740}

Bug: 833716
Change-Id: I7295b8db2b0904ee30f78f3bc452236fefd4f3f0
Reviewed-on: https://chromium-review.googlesource.com/1026558
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553739}

Subpixel positioning was needed because text layout was performed at 1x
device scale factor and then rastered to the final display device scale
factor leading to glyph artifacts and inconsistent glyph positioning.
With pixel canvas enabled on chrome os, the text layout is now always
performed at the final display device scale factor. This, coupled with
the replacement of ui scale with display zoom, the text on Chrome OS
is now always rastered with the correct glyph positioning and it no
longer requires subpixel positioning.

Updates unittests.

Bug: 835187,824154,716662
Change-Id: Ibcf6314321777da81335769927d65d52911855df
Component: Text render, subpixel positioning, font
Reviewed-on: https://chromium-review.googlesource.com/1027005Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553738}

When using Android J, we have to use ListPopupWindow instead of
using AnchoredPopupWindow for autofill popups. This will resolve
the problem with selection of autofill items on Android J.

Bug: 820898
Change-Id: Ic8f695468df4e31494fcd26b43a032b968f72301
Reviewed-on: https://chromium-review.googlesource.com/1023985
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553737}

A valid use case in a browser test was recently presented to me. And
while I ultimately plan to support this in ScopedTaskEnvironment as
well, it isn't for now.

R=dpranke@chromium.org

Bug: None
Change-Id: Id4197c8a8cd567c5daaf4b1b39fe8f34fb8b3549
Reviewed-on: https://chromium-review.googlesource.com/1027809Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553736}

Thread/SequenceCheckerImpl is the right type for tests that went to
verify threading correctness (even when compiled in non-dcheck builds).

This presubmit was only aimed at plain Thread/SequenceChecker usage.

R=dpranke@chromium.org

Bug: 825327
Change-Id: I04ed1351728c84a60acee9fe9103e16405992015
Reviewed-on: https://chromium-review.googlesource.com/1028352Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553735}

This is necessary for out-of-process ash (go/mustash). Eliminate a call
to ash::Shell::GetRootWindowForNewWindows(). The notification is only
shown if the primary display is an internal Chromebook display (existing
behavior) and it will now always appear on that display instead of
potentially appearing on a secondary, non-internal display.

Bug: 756082
Test: manual test on device
Change-Id: Id56a87b56fd2e51a215a2dfeecfaee2417549257
Reviewed-on: https://chromium-review.googlesource.com/1028576Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553734}

R=eroman@chromium.org

Bug: 825327
Change-Id: I34f97a20ce9d7e3f61ae58bba839d2a7d490ddcd
Reviewed-on: https://chromium-review.googlesource.com/1002657Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553733}

This change adds media controls (play/pause, close) on the
Picture-in-Picture window for desktop (OverlayWindowViews). This adds
three vectorized icons used for these controls. These are currently
rendered as white when the user mouses over the window, and disappears
when the mouse is not hovering over the window.

The intended sizes of the icons are currently hardcoded. They will be
updated when we've determined how we want them to be sized or scaled.

Future work includes making the controls accessible and handling events
triggered by keyboard or touch inputs.

BUG: 836389
Change-Id: I37987286b531c1ce1ddcf867f72510194657053d
Reviewed-on: https://chromium-review.googlesource.com/1026519Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553732}

pkasting convinced me a while back that forcing an error on these wasn't
great as it blocks refactorings, I've now hit this as well a few times
recently (uploading refactorings with --bypass-hooks and
NOPRESUBMIT=True isn't great)

Warning still encourages developers to do the right thing. While the dev's
decision to continue is unfortunately hidden from the reviewer, these
methods already being named "Deprecated" is a strong enough hint to the
reviewer.

R=dpranke@chromium.org

Bug: None
Change-Id: I29a2624e5217e743ab46799b326577d52cb29d8c
Reviewed-on: https://chromium-review.googlesource.com/1028554Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553731}

TBR=ellyjones@chromium.org,liaoyuke@chromium.org

Bug: 828031
Change-Id: I1df91e8a002d3bbb6852d5fa40cbf4b8cae2680a
Reviewed-on: https://chromium-review.googlesource.com/1028669Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553730}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/96706998..69a2f03a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I66f0dc50ffeb7e5de1c5bec3c928740115afc81c
Reviewed-on: https://chromium-review.googlesource.com/1028184Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553729}

This was introduced in the following patch as a typo:
https://codereview.chromium.org/1927803002/diff/320001/components/arc/bluetooth/arc_bluetooth_bridge.cc

BUG=727843
TEST=Run CtsVerifier and confirm that non-bonded devices don't show up as paired

Change-Id: Id50a5564257a270b62bc78c63835e194af772cce
Reviewed-on: https://chromium-review.googlesource.com/1028574Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#553728}

WebViewTests and WebViewInteractiveTests now only run for the
GuestViewCrossProcessFrames enabled case.

Bug: 533069, 544782, 627962, 796344, 807116, 818161, 818205, 829846
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic3a971b553fe343466a440ed4363389cd9e89214
Reviewed-on: https://chromium-review.googlesource.com/1000137
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553727}

The FileReaders themselves will abort once they realize the context is
destroyed anyway, so it is pretty pointless (and potentially
problematic) to start new FileReaders after the context is destroyed.

Bug: 836724
Change-Id: I7bcbdf7d7905448df794df423a3fb0fe1697dd95
Reviewed-on: https://chromium-review.googlesource.com/1028555
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553726}

This new UMA will replace
DataReductionProxy.SavingsCleared.NegativeSystemClock and add on more
enum values for all the possible reasons the data savings could have
been cleared. This will be done in a follow up CL.

Bug: 812922
Change-Id: Ibc82d187045444b6ca7812e2fc2097549501c0aa
Reviewed-on: https://chromium-review.googlesource.com/1024880
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553725}

The LSI allocators previously did not store a copy of the last generated
LSI. As a result, many call sites would have to keep their own copies.

Now that the LSI allocators have their own copies, the call sites can be
updated to no longer store a separate copy.

RenderFrameProxy is one such call site.

BUG=759031

Change-Id: Id40e679f2c41876fd7e23aa8f2e70817445be420
Reviewed-on: https://chromium-review.googlesource.com/1024747
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553724}

Currently, we reset the media ID associated with Picture-in-Picture
when OnMediaDestroyed is called, which includes when the video stops
playing. This causes crashes when we attempt to control the video from
the Picture-in-Picture window, such as play/pause and close.

This also means that even if we leave Picture-in-Picture mode, the
video media player will still show the Picture-in-Picture interstitial
because the WebMediaPlayer isn't updated with the fact we've left
Picture-in-Picture mode.

It is okay to keep the id around; when another video is PiP'd, the ID
will be updated.

BUG: 726619
Change-Id: I0e665047b85f20bc7bb9795273a5640460e7612f
Reviewed-on: https://chromium-review.googlesource.com/1026974Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553723}

The exclusion space already didn't use it, but rather returned a pure
LayoutUnit set to LayoutUnit::Min() if there was no clearance to apply.
Do this everywhere, instead of using Optional<LayoutUnit> some places.

Better have one way of saying "no clearance", than two
(Optional<LayoutUnit> not set OR Optional<LayoutUnit> set to

LayoutUnit: :Min()).
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I3a858397c28ca83ba96ae4d749f97dfa5e7b0cb3
Reviewed-on: https://chromium-review.googlesource.com/1027810Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553722}

Ozone demo is intended to be the simplest possible program that uses the
ozone API to create a window and render to it. Porters use this to see if
their platform implements the API correctly without having to build or
run the entire browser.

Ozone demo recently started using skia infrastructure for rendering via
GL. However, this arguably makes the demo less useful to porters because
it is additional complexity that is not relevant to implementing the
platform window or rendering surface.

This splits the skia demo into a new executable and brings back the
"simple" renderer that just clears the screen to a solid color.

Bug: none
Test: ozone_demo, skia_demo
Change-Id: I8570d43949d68dcf87175c53057c7c72cf45ea6e
Reviewed-on: https://chromium-review.googlesource.com/1028579Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553721}

R=amineer@chromium.org

Change-Id: Ib73b7a656694a80810402b4a3e8f078448e54e9f
Reviewed-on: https://chromium-review.googlesource.com/1028723Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553720}