1. 28 Oct, 2019 40 commits
    • Klaus Weidner's avatar
      WebXR: ensure magic window sessions get disconnected · 22b78662
      Klaus Weidner authored
      Ensure that magic window sessions get disconnected when VRServiceImpl is
      destroyed. The default destructors don't do so, and this resulted in ID
      collisions when the metrics helper is reused across page navigation.
      
      Also add DVLOG(2) lifecycle logging to help with debugging in case we
      run into similar issues in the future, the initialization sequence
      is a bit complicated.
      
      Bug: 1017959
      Change-Id: Ib7876ec10c0db7076b599ec212762cb455ec5c0c
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884373
      Commit-Queue: Klaus Weidner <klausw@chromium.org>
      Reviewed-by: default avatarAlexander Cooper <alcooper@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710012}
      22b78662
    • Henrique Nakashima's avatar
      Fix crash when Background Memory metrics task is scheduled immediately. · bc7fb7d7
      Henrique Nakashima authored
      It is scheduled with a random delay between 0ms and 59999ms. When it is
      exactly 0, the delayed task is actually executed as a regular task,
      and since it is scheduled just before the task that starts native,
      it runs without native, causing a crash.
      
      Moving recordMemoryUsageWithRandomDelay() to after native is initialized
      fixes the issue.
      
      https://chromium-review.googlesource.com/c/chromium/src/+/1880172 fixed
      this issue incorrectly. This is a corrected version.
      
      Bug: 1017130
      Change-Id: Ia79a4c3dcf639ffc01d1eacbfe53d082419c8ed7
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884272Reviewed-by: default avatarMohamed Heikal <mheikal@chromium.org>
      Reviewed-by: default avatarXi Han <hanxi@chromium.org>
      Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710011}
      bc7fb7d7
    • Robert Liao's avatar
      Remove View::GetPageScrollIncrement and View::GetLineScrollIncrement · 31a68bd2
      Robert Liao authored
      Both of these methods always returned 0 and are not overridable.
      
      BUG=
      
      Change-Id: I014897e1533442232e6dbfd973186e094077cf87
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879721
      Auto-Submit: Robert Liao <robliao@chromium.org>
      Commit-Queue: Scott Violet <sky@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710010}
      31a68bd2
    • Brian Sheedy's avatar
      Switch performance_browser_tests to histograms · 00d9c53b
      Brian Sheedy authored
      Switches use of PrintResult in performance_browser_tests to
      PerfResultReporter and whitelists the tests for conversion to histograms
      before being uploaded to the perf dashboard.
      
      Bug: 923564
      Change-Id: Ica64da69d6fe0a0de680c673b63fe54ff235bc1b
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877151
      Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
      Reviewed-by: default avatarYuri Wiitala <miu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710009}
      00d9c53b
    • balabasik's avatar
      Fix "Stuck at CONNECTION_NONE" issue in NetworkChangeNotifier (Linux). · 42b97a68
      balabasik authored
      NetworkChangeNotifier::NetworkChangeCalculator::OnIPAddressChanged()
      never updated the potentially incorrect |pending_connection_type_|
      initial value of CONNECTION_NONE.
      This caused detected IP address changes to trigger OnNetworkChanged()
      events with incorrect connection types.
      This fix sets |pending_connection_type_| accurately.
      
      The issue was observed on home devices, where CONNECTION_NONE state
      determines that the device is offline and blocks the OOBE flow.
      
      Bug: 142898314
      Change-Id: I8d15bd231beac73fc91963ebe162ae6fb59f6d4a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873377
      Commit-Queue: Valeriy Balabanov <balabasik@google.com>
      Auto-Submit: Valeriy Balabanov <balabasik@google.com>
      Reviewed-by: default avatarPaul Jensen <pauljensen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710008}
      42b97a68
    • liberato@chromium.org's avatar
      Make MediaWebContentsObserver use MediaExperimentManager · b0a785a1
      liberato@chromium.org authored
      This adds calls to MediaExperimentManager when players start / stop,
      and receives callbacks when a player is the only one playing.  Right
      now, these callbacks are ignored.
      
      Adds a switch "MediaPowerExperiment" to enable tracking players, in
      preparation for the power experiment.
      
      This CL also simplifies MediaExperimentManager.
      
      Change-Id: I02aa61971c7ca59093dcf2d7336709e25b8a70a7
      Bug: 1017783
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879751
      Commit-Queue: Frank Liberato <liberato@chromium.org>
      Reviewed-by: default avatarChrome Cunningham <chcunningham@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710007}
      b0a785a1
    • Peter Kasting's avatar
      Do not clear layer delegates when destroying the compositor. · 3c9e618c
      Peter Kasting authored
      This is the Mac version of
      https://chromium-review.googlesource.com/c/chromium/src/+/1848911 .
      
      Bug: 1016900
      Change-Id: I59d2327d0c48f15b929247c0cce76aa35ee88678
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877191
      Auto-Submit: Peter Kasting <pkasting@chromium.org>
      Commit-Queue: ccameron <ccameron@chromium.org>
      Reviewed-by: default avatarccameron <ccameron@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710006}
      3c9e618c
    • Peng Huang's avatar
      Fix raster decoder crashes with Vulkan · af97e47a
      Peng Huang authored
      Bug: 1018725
      Change-Id: I293f493fa87b43d3c7809d5cef960bb068588cb1
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883417Reviewed-by: default avatarVasiliy Telezhnikov <vasilyt@chromium.org>
      Commit-Queue: Peng Huang <penghuang@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710005}
      af97e47a
    • Anastasiia Nikolaienko's avatar
      Send device id for secondary accounts on Chrome OS · 7aa9321d
      Anastasiia Nikolaienko authored
      Attach a device id for Secondary Account sign-ins on Chrome OS.
      
      Bug: 1012723
      Change-Id: Ic7d8fc22bd82c62354d66d4f49e6070bc65e4ae1
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859784Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
      Reviewed-by: default avatarKush Sinha <sinhak@chromium.org>
      Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710004}
      7aa9321d
    • chromium-autoroll's avatar
      Roll src/third_party/skia 18f5b1a6dd77..a1991f5e3b58 (6 commits) · c5c61416
      chromium-autoroll authored
      https://skia.googlesource.com/skia.git/+log/18f5b1a6dd77..a1991f5e3b58
      
      git log 18f5b1a6dd77..a1991f5e3b58 --date=short --no-merges --format='%ad %ae %s'
      2019-10-28 mtklein@google.com experimental support for go/fibers
      2019-10-28 robertphillips@google.com Add helper to determine the index buffer that will be used
      2019-10-28 jcgregorio@google.com Revert "Add variety of bulk API benchmarks"
      2019-10-28 kjlubick@google.com [canvaskit] Use skia's version of png and zlib
      2019-10-28 michaelludwig@google.com Add variety of bulk API benchmarks
      2019-10-28 kjlubick@google.com [canvaskit] Use newer freetype
      
      Created with:
        gclient setdep -r src/third_party/skia@a1991f5e3b58
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/skia-autoroll
      Please CC jcgregorio@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
      TBR=jcgregorio@google.com
      
      Bug: None
      Change-Id: I04dd91f1d67ee96330ac2abc8cbc570f71d88498
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884431Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#710003}
      c5c61416
    • Luke Zielinski's avatar
      Include wpt_internal/README as a dep of wpt_tests_isolate, · e3437217
      Luke Zielinski authored
      in order to make the wpt_internal directory exist on the bot so
      that the manifest can be written into it.
      
      Bug: 1018829
      Change-Id: I1c15caf5abd37c50839587f7713d7636d56a5cd9
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884812
      Commit-Queue: Luke Z <lpz@chromium.org>
      Reviewed-by: default avatarRobert Ma <robertma@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710002}
      e3437217
    • chromium-internal-autoroll's avatar
      Roll src-internal 3c3f17f3c2e1..4592a8d52f74 (1 commits) · 37d09405
      chromium-internal-autoroll authored
      https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c3f17f3c2e1..4592a8d52f74
      
      
      Created with:
        gclient setdep -r src-internal@4592a8d52f74
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
      Please CC jbudorick@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
      TBR=jbudorick@google.com
      
      Bug: chromium:None
      Change-Id: I1d63ff9f4d7b834c6fdc4af13985f74cdab0d473
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884510Reviewed-by: default avatarchromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#710001}
      37d09405
    • Mustaq Ahmed's avatar
      Fix web-tests that failed with UAv2 same-origin visibility. · 2feae05a
      Mustaq Ahmed authored
      The two fullscreen tests change back to pre-UAv2 expectations.  The
      user activation query api test shows consumption in transient state
      only.
      
      Fixed: 922725
      Change-Id: Ia7402d4ce08a89edef13bcba2dd2c4405739e872
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883118Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
      Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#710000}
      2feae05a
    • Xiaohui Chen's avatar
      Revert "Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..78d6a7767 (333 commits)" · 192a9aee
      Xiaohui Chen authored
      This reverts commit 4f3e0042.
      
      Reason for revert: revert as planned
      
      Original change's description:
      > Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..78d6a7767 (333 commits)
      > 
      > This will break CrOS due to a libassistant issue, see bug 996754. The plan is
      > to land this, then revert it immediately, then do some prep work on the assistant
      > side, and then reland once that prep work is done.
      > 
      > This CL is necessary to fix the gcc 4.8 build:
      > https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/ad464887b93526235ce06bbf97cd396ed6232b9a
      > 
      > Wanted for this CL, which improves the debugging experience:
      > https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+/78822a68537b5941eb86e11a5066aa549c30998f
      > 
      > https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+log/5938e0582bac..78d6a7767ed5
      > 
      > $ git log 5938e0582..78d6a7767 --date=short --no-merges --format='%ad %ae %s'
      > 2019-10-22 z.zoelec2     [libcxx] Remove shared_ptr::make_shared
      > 2019-10-21 ldionne [NFC] Fix typos in CMake comment
      > 2019-10-19 dimitry Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
      > 2019-10-19 richard-llvm P1152R4: Fix deprecation warnings in libc++ testsuite and in uses of is_invocable that would internally conjure up a deprecated function type.
      > 2019-10-15 Casey [libc++][test] Use <version> to get config on MSVC
      > 2019-10-14 Casey [libc++][test] Portability fix for std::any tests
      > 2019-10-14 Casey [libc++][test] Add license headers to test/support/archetypes.*
      > 2019-10-14 Casey [libc++][test] Silence more warnings in variant tests
      > 2019-10-13 Casey [libc++][test] std::variant test cleanup
      > 2019-10-13 Casey [libc++][test] <=> now has a feature-test macro
      > 2019-10-12 Casey [libc++][test] Silence MSVC warning in std::optional test
      > 2019-10-11 phosek [libc++] Fix linker script generation
      > 2019-10-10 Casey [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer
      > 2019-10-09 Casey [libc++][test] Miscellaneous MSVC cleanups
      > 2019-10-09 eric Optimize operator=(const basic_string&) for tail call.
      > 2019-10-08 ldionne [libc++] Workaround old versions of CMake that don't understand list(JOIN)
      > 2019-10-08 ldionne [libc++] Move the linker script generation step to CMake
      > 2019-10-08 ldionne [libc++] Make sure we link all system libraries into the benchmarks
      > 2019-10-08 ldionne [libc++] TAKE 2: Make system libraries PRIVATE dependencies of libc++
      > 2019-10-08 ldionne [libc++] Add missing link-time dependencies to the benchmarks
      > 2019-10-08 ldionne [libc++] Use PRIVATE to link benchmark dependencies
      > 2019-10-07 z.zoelec2     [libc++] Remove C++03 variadics in shared_ptr (v2)
      > 2019-10-04 apl [libc++] Guard cxx_experimental settings behind LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY
      > 2019-10-04 ldionne [libc++] Localize common build flags into a single CMake function
      > 2019-10-04 saugustine Add an off-by-default option to enable testing for gdb pretty printers.
      > 2019-10-04 ldionne [libc++] Make the modules-related flags PUBLIC instead of PRIVATE
      > 2019-10-04 ldionne [libc++] Move more CMake flags to per-target definitions
      > 2019-10-04 maskray Make libc++ gdb pretty printer Python 3 compatible
      > 2019-10-03 eric Attempt to remove linker workaround on the buildbots: Attempt 2
      > 2019-10-03 eric Attempt to remove linker workaround on the buildbots.
      > 2019-10-03 ldionne [libc++] Add a per-target flag to include the generated config_site
      > 2019-10-03 ldionne [libc++] Add missing revision number in ABI changelog
      > 2019-10-03 maskray Fix libc++ pretty printer test for Python 3 after D67238 (take 2)
      > 2019-10-02 ldionne [libc++] Use functions instead of global variables to set libc++ build flags
      > 2019-10-02 ldionne [libc++] Use a function to set warning flags per target
      > 2019-10-02 ldionne [libc++] Revert to using PUBLIC instead of PRIVATE when linking system libs
      > 2019-10-02 ldionne [libc++] Use PRIVATE instead of PUBLIC when linking against system libs
      > 2019-10-02 maskray Fix libc++ pretty printer test for Python 3 after D67238
      > 2019-10-01 saugustine Determine endianness at a time when it doesn't inadvertantly clear gdb's wrap_buffer via gdb.execute.
      > 2019-10-01 ldionne [NFC] Fix typos in libc++ documentation
      > 2019-10-01 ldionne [libc++] Re-apply workaround for D63883
      > 2019-10-01 ldionne [libc++] Remove workaround for D63883
      > 2019-10-01 ldionne [libc++] Harden usage of static_assert against C++03
      > 2019-09-30 eric Refactor default constructor SFINAE in pair and tuple.
      > 2019-09-27 ldionne [libc++] Take 2: Implement LWG 3158
      > 2019-09-26 ldionne [libc++] Take 2: Implement LWG 2510
      > 2019-09-26 dave [libcxx] Do not implicitly #include assert.h
      > 2019-09-25 ldionne [libc++] Purge mentions of GCC 4 from the test suite
      > 2019-09-25 eric Add forward declaration of operator<< in <string_view> as required.
      > 2019-09-25 eric add tests that debug mode catches nullptr->string_view conversions in comparison operators
      > (...)
      > 2019-06-12 ldionne [libcxx] XFAIL set/multiset CTAD tests on Apple Clang 10
      > 2019-06-12 ldionne [libcxx] XFAIL some CTAD tests on AppleClang 10
      > 2019-06-12 eric Apply [[nodebug]] to typedefs throughout the STL.
      > 2019-06-11 eric Move libc++ specific tests for std::function out of the std directory
      > 2019-06-11 eric Add documentation and tests for Clangs C++11 extensions in C++03.
      > 2019-06-11 ldionne [libcxx] Mark CTAD tests for set and multiset as unsupported on older Apple Clangs
      > 2019-06-11 mclow.lists Mark CTAD fail tests for set/multiset as XFAIL for older compilers that give different error messages
      > 2019-06-11 mclow.lists XFAIL a couple of tests on apple-clang-9.1, which is a compiler that I didn't know existed
      > 2019-06-11 eric Check in test that demonstrates ABI break for std::function.
      > 2019-06-11 ldionne [libc++] Implement deduction guides for <set>
      > 2019-06-11 ldionne [libcxx] Make std::tuple<> trivially constructible
      > 2019-06-11 ldionne [libcxx] Slightly improved policy for handling experimental features
      > 2019-06-11 mclow.lists Add a test for is_base_of and incomplete types. Because this trait uses a compiler intrinsic which was broken in many clangs, have lots of XFAILs.
      > 2019-06-11 mclow.lists XFAIL a couple of CTAD tests on clang-6; it gives different error messages than clang 7/8/9
      > 2019-06-10 mclow.lists Recommit r362649, which was reverted in r262680 because of bugs in std::to_chars (which have now been fixed). Speedup to_string and to_wstring for integers using stack buffer and SSO
      > 2019-06-10 mclow.lists Implement deduction guides for map/multimap. Reviewed as https://reviews.llvm.org/D58587. Thanks to Quuxplusone for the submission.
      > 2019-06-10 zy [libc++] Fix leading zeros in std::to_chars
      > 2019-06-08 eric update debugging docs to be less out of date
      > 2019-06-08 eric Substantially reduce instantiations and debug size of std::function
      > 2019-06-08 eric Fix some incorrect std::function tests
      > 2019-06-06 vlad Revert "Speedup to_string and to_wstring for integers using stack buffer and SSO."
      > 2019-06-05 ldionne [libcxx][test] Include test_workarounds.h where needed
      > 2019-06-05 mclow.lists Update issue statuses. Reviewed as https://reviews.llvm.org/D62932
      > 2019-06-05 mclow.lists Speedup to_string and to_wstring for integers using stack buffer and SSO. Reviewed as https://reviews.llvm.org/D59178  Thanks to ivafanas for all his work on this patch.
      > 2019-06-04 ldionne [libcxx] Add test to check min/max requirement to regular expression
      > 2019-06-04 mclow.lists No longer reject inputs when using a locale that has grouping information _and_ the input has no grouping characters at all. We continue to reject cases when the input has grouping characters in the wrong place. Fixes PR#28704
      > 2019-06-04 mclow.lists We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863
      > 2019-06-02 phosek [libcxx] Use libtool when merging archives on Apple platforms
      > 2019-05-31 mclow.lists Add include for 'test_macros.h' to all the tests that were missing them. Thanks to Zoe for the (big, but simple) patch. NFC intended.
      > 2019-05-30 ldionne [libcxx] Add regex test cases from PR40904
      > 2019-05-30 jryans [Docs] Modernize references to macOS
      > 2019-05-30 phosek [runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files
      > 2019-05-30 phosek [libcxx][libcxxabi] Remove the unused CMake checks
      > 2019-05-30 phosek [runtimes] Use -Wunknown-pragmas for the pragma check
      > 2019-05-30 phosek [runtimes] Check if pragma comment(lib, ...) is supported first
      > 2019-05-30 phosek [runtimes] Support ELF dependent libraries feature
      > 2019-05-29 ldionne [NFC][libcxx] Remove trailing whitespace
      > 2019-05-29 mclow.lists Add additional constraints on midpoint(pointer, pointer). Fixes PR#42037.
      > 2019-05-29 eric Fix build breakage on 32-bit machines
      > 2019-05-29 eric Rework std::type_info definition to support systems without fully merged type info names.
      > 2019-05-28 mclow.lists Fix test that used raw string literals. Doesn't work in C++03
      > 2019-05-28 mclow.lists Fix an incorrect 'Throws' in the regex code. Add a test for the new behavior. Reviewed as https://reviews.llvm.org/D61828. Thanks to Mark for the catch and the fix.
      > 2019-05-24 eric fix test for older clang versions
      > 2019-05-24 eric fix destroying delete test with older apple compilers
      > 2019-05-24 eric Update C++2a status for destroying delete
      > 2019-05-23 eric P0722R3:  Implement library support for destroying delete
      > 2019-05-23 chris.bieneman [CMake] Copy C++ headers before configuring runtimes build
      > 2019-05-23 ldionne [libcxx][tests] Fix order checking in unordered_multiset tests.
      > 2019-05-22 phosek [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++
      > 2019-05-22 ldionne [libcxx][test] Fix order checking in some more unordered_multimap tests
      > 
      > Created with:
      >   roll-dep src/buildtools/third_party/libc++/trunk
      > 
      > BUG=996754
      > R=​thakis
      > 
      > Change-Id: I6b4d224b3feca206161d642baae7be8da23592ef
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881953
      > Reviewed-by: Nico Weber <thakis@chromium.org>
      > Commit-Queue: Nico Weber <thakis@chromium.org>
      > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#709997}
      
      TBR=thakis@chromium.org,thomasanderson@chromium.org
      
      Change-Id: Ib2cf8d93086f3b6bedc2f81406a620a4f54bfaab
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 996754
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884754Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
      Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709999}
      192a9aee
    • chromium-autoroll's avatar
      Roll src/third_party/dawn f6281a5530c0..cab352c2f679 (2 commits) · a91b62ba
      chromium-autoroll authored
      https://dawn.googlesource.com/dawn.git/+log/f6281a5530c0..cab352c2f679
      
      git log f6281a5530c0..cab352c2f679 --date=short --no-merges --format='%ad %ae %s'
      2019-10-28 cwallez@chromium.org Make end2end and perf tests use webgpu.h
      2019-10-28 bryan.bernhart@intel.com D3D12: Use CheckHRESULT for allocator errors.
      
      Created with:
        gclient setdep -r src/third_party/dawn@cab352c2f679
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/dawn-chromium-autoroll
      Please CC cwallez@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
      TBR=cwallez@google.com
      
      Bug: None
      Change-Id: Ib41e3f1e20f6c19ae9169ff14fcf25912cfb7885
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884512Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#709998}
      a91b62ba
    • Tom Anderson's avatar
      Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..78d6a7767 (333 commits) · 4f3e0042
      Tom Anderson authored
      This will break CrOS due to a libassistant issue, see bug 996754. The plan is
      to land this, then revert it immediately, then do some prep work on the assistant
      side, and then reland once that prep work is done.
      
      This CL is necessary to fix the gcc 4.8 build:
      https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/ad464887b93526235ce06bbf97cd396ed6232b9a
      
      Wanted for this CL, which improves the debugging experience:
      https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+/78822a68537b5941eb86e11a5066aa549c30998f
      
      https://chromium.googlesource.com/chromium/llvm-project/libcxx.git/+log/5938e0582bac..78d6a7767ed5
      
      $ git log 5938e0582..78d6a7767 --date=short --no-merges --format='%ad %ae %s'
      2019-10-22 z.zoelec2     [libcxx] Remove shared_ptr::make_shared
      2019-10-21 ldionne [NFC] Fix typos in CMake comment
      2019-10-19 dimitry Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
      2019-10-19 richard-llvm P1152R4: Fix deprecation warnings in libc++ testsuite and in uses of is_invocable that would internally conjure up a deprecated function type.
      2019-10-15 Casey [libc++][test] Use <version> to get config on MSVC
      2019-10-14 Casey [libc++][test] Portability fix for std::any tests
      2019-10-14 Casey [libc++][test] Add license headers to test/support/archetypes.*
      2019-10-14 Casey [libc++][test] Silence more warnings in variant tests
      2019-10-13 Casey [libc++][test] std::variant test cleanup
      2019-10-13 Casey [libc++][test] <=> now has a feature-test macro
      2019-10-12 Casey [libc++][test] Silence MSVC warning in std::optional test
      2019-10-11 phosek [libc++] Fix linker script generation
      2019-10-10 Casey [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer
      2019-10-09 Casey [libc++][test] Miscellaneous MSVC cleanups
      2019-10-09 eric Optimize operator=(const basic_string&) for tail call.
      2019-10-08 ldionne [libc++] Workaround old versions of CMake that don't understand list(JOIN)
      2019-10-08 ldionne [libc++] Move the linker script generation step to CMake
      2019-10-08 ldionne [libc++] Make sure we link all system libraries into the benchmarks
      2019-10-08 ldionne [libc++] TAKE 2: Make system libraries PRIVATE dependencies of libc++
      2019-10-08 ldionne [libc++] Add missing link-time dependencies to the benchmarks
      2019-10-08 ldionne [libc++] Use PRIVATE to link benchmark dependencies
      2019-10-07 z.zoelec2     [libc++] Remove C++03 variadics in shared_ptr (v2)
      2019-10-04 apl [libc++] Guard cxx_experimental settings behind LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY
      2019-10-04 ldionne [libc++] Localize common build flags into a single CMake function
      2019-10-04 saugustine Add an off-by-default option to enable testing for gdb pretty printers.
      2019-10-04 ldionne [libc++] Make the modules-related flags PUBLIC instead of PRIVATE
      2019-10-04 ldionne [libc++] Move more CMake flags to per-target definitions
      2019-10-04 maskray Make libc++ gdb pretty printer Python 3 compatible
      2019-10-03 eric Attempt to remove linker workaround on the buildbots: Attempt 2
      2019-10-03 eric Attempt to remove linker workaround on the buildbots.
      2019-10-03 ldionne [libc++] Add a per-target flag to include the generated config_site
      2019-10-03 ldionne [libc++] Add missing revision number in ABI changelog
      2019-10-03 maskray Fix libc++ pretty printer test for Python 3 after D67238 (take 2)
      2019-10-02 ldionne [libc++] Use functions instead of global variables to set libc++ build flags
      2019-10-02 ldionne [libc++] Use a function to set warning flags per target
      2019-10-02 ldionne [libc++] Revert to using PUBLIC instead of PRIVATE when linking system libs
      2019-10-02 ldionne [libc++] Use PRIVATE instead of PUBLIC when linking against system libs
      2019-10-02 maskray Fix libc++ pretty printer test for Python 3 after D67238
      2019-10-01 saugustine Determine endianness at a time when it doesn't inadvertantly clear gdb's wrap_buffer via gdb.execute.
      2019-10-01 ldionne [NFC] Fix typos in libc++ documentation
      2019-10-01 ldionne [libc++] Re-apply workaround for D63883
      2019-10-01 ldionne [libc++] Remove workaround for D63883
      2019-10-01 ldionne [libc++] Harden usage of static_assert against C++03
      2019-09-30 eric Refactor default constructor SFINAE in pair and tuple.
      2019-09-27 ldionne [libc++] Take 2: Implement LWG 3158
      2019-09-26 ldionne [libc++] Take 2: Implement LWG 2510
      2019-09-26 dave [libcxx] Do not implicitly #include assert.h
      2019-09-25 ldionne [libc++] Purge mentions of GCC 4 from the test suite
      2019-09-25 eric Add forward declaration of operator<< in <string_view> as required.
      2019-09-25 eric add tests that debug mode catches nullptr->string_view conversions in comparison operators
      (...)
      2019-06-12 ldionne [libcxx] XFAIL set/multiset CTAD tests on Apple Clang 10
      2019-06-12 ldionne [libcxx] XFAIL some CTAD tests on AppleClang 10
      2019-06-12 eric Apply [[nodebug]] to typedefs throughout the STL.
      2019-06-11 eric Move libc++ specific tests for std::function out of the std directory
      2019-06-11 eric Add documentation and tests for Clangs C++11 extensions in C++03.
      2019-06-11 ldionne [libcxx] Mark CTAD tests for set and multiset as unsupported on older Apple Clangs
      2019-06-11 mclow.lists Mark CTAD fail tests for set/multiset as XFAIL for older compilers that give different error messages
      2019-06-11 mclow.lists XFAIL a couple of tests on apple-clang-9.1, which is a compiler that I didn't know existed
      2019-06-11 eric Check in test that demonstrates ABI break for std::function.
      2019-06-11 ldionne [libc++] Implement deduction guides for <set>
      2019-06-11 ldionne [libcxx] Make std::tuple<> trivially constructible
      2019-06-11 ldionne [libcxx] Slightly improved policy for handling experimental features
      2019-06-11 mclow.lists Add a test for is_base_of and incomplete types. Because this trait uses a compiler intrinsic which was broken in many clangs, have lots of XFAILs.
      2019-06-11 mclow.lists XFAIL a couple of CTAD tests on clang-6; it gives different error messages than clang 7/8/9
      2019-06-10 mclow.lists Recommit r362649, which was reverted in r262680 because of bugs in std::to_chars (which have now been fixed). Speedup to_string and to_wstring for integers using stack buffer and SSO
      2019-06-10 mclow.lists Implement deduction guides for map/multimap. Reviewed as https://reviews.llvm.org/D58587. Thanks to Quuxplusone for the submission.
      2019-06-10 zy [libc++] Fix leading zeros in std::to_chars
      2019-06-08 eric update debugging docs to be less out of date
      2019-06-08 eric Substantially reduce instantiations and debug size of std::function
      2019-06-08 eric Fix some incorrect std::function tests
      2019-06-06 vlad Revert "Speedup to_string and to_wstring for integers using stack buffer and SSO."
      2019-06-05 ldionne [libcxx][test] Include test_workarounds.h where needed
      2019-06-05 mclow.lists Update issue statuses. Reviewed as https://reviews.llvm.org/D62932
      2019-06-05 mclow.lists Speedup to_string and to_wstring for integers using stack buffer and SSO. Reviewed as https://reviews.llvm.org/D59178  Thanks to ivafanas for all his work on this patch.
      2019-06-04 ldionne [libcxx] Add test to check min/max requirement to regular expression
      2019-06-04 mclow.lists No longer reject inputs when using a locale that has grouping information _and_ the input has no grouping characters at all. We continue to reject cases when the input has grouping characters in the wrong place. Fixes PR#28704
      2019-06-04 mclow.lists We had a _LIBCPP_ASSERT commented out because gcc 4.9 didn't like it. We (LLVM) now require GCC 5.1, so that's not a problem any more. Re-enable the assertion. Fixes PR#36863
      2019-06-02 phosek [libcxx] Use libtool when merging archives on Apple platforms
      2019-05-31 mclow.lists Add include for 'test_macros.h' to all the tests that were missing them. Thanks to Zoe for the (big, but simple) patch. NFC intended.
      2019-05-30 ldionne [libcxx] Add regex test cases from PR40904
      2019-05-30 jryans [Docs] Modernize references to macOS
      2019-05-30 phosek [runtimes] Use _LIBCPP_HAS_COMMENT_LIB_PRAGMA in all relevant files
      2019-05-30 phosek [libcxx][libcxxabi] Remove the unused CMake checks
      2019-05-30 phosek [runtimes] Use -Wunknown-pragmas for the pragma check
      2019-05-30 phosek [runtimes] Check if pragma comment(lib, ...) is supported first
      2019-05-30 phosek [runtimes] Support ELF dependent libraries feature
      2019-05-29 ldionne [NFC][libcxx] Remove trailing whitespace
      2019-05-29 mclow.lists Add additional constraints on midpoint(pointer, pointer). Fixes PR#42037.
      2019-05-29 eric Fix build breakage on 32-bit machines
      2019-05-29 eric Rework std::type_info definition to support systems without fully merged type info names.
      2019-05-28 mclow.lists Fix test that used raw string literals. Doesn't work in C++03
      2019-05-28 mclow.lists Fix an incorrect 'Throws' in the regex code. Add a test for the new behavior. Reviewed as https://reviews.llvm.org/D61828. Thanks to Mark for the catch and the fix.
      2019-05-24 eric fix test for older clang versions
      2019-05-24 eric fix destroying delete test with older apple compilers
      2019-05-24 eric Update C++2a status for destroying delete
      2019-05-23 eric P0722R3:  Implement library support for destroying delete
      2019-05-23 chris.bieneman [CMake] Copy C++ headers before configuring runtimes build
      2019-05-23 ldionne [libcxx][tests] Fix order checking in unordered_multiset tests.
      2019-05-22 phosek [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++
      2019-05-22 ldionne [libcxx][test] Fix order checking in some more unordered_multimap tests
      
      Created with:
        roll-dep src/buildtools/third_party/libc++/trunk
      
      BUG=996754
      R=thakis
      
      Change-Id: I6b4d224b3feca206161d642baae7be8da23592ef
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881953Reviewed-by: default avatarNico Weber <thakis@chromium.org>
      Commit-Queue: Nico Weber <thakis@chromium.org>
      Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709997}
      4f3e0042
    • Yue Li's avatar
      Fix setPlay logic for lottie · 8a92d917
      Yue Li authored
      SetPlay does not work if the animation is not loaded. Update it to set
      the autoplay attribite if the animation is not loaded yet.
      
      Bug: None
      Test: Manual Test
      Change-Id: I8132d11b5fd9ae77002f79cab7f0e12ef4e91c91
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879855Reviewed-by: default avatarMalay Keshav <malaykeshav@chromium.org>
      Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
      Commit-Queue: Yue Li <updowndota@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709996}
      8a92d917
    • Chromium WPT Sync's avatar
      Import wpt@436bf315615d923d756067bedbf5f69176582876 · 055a5ec1
      Chromium WPT Sync authored
      Using wpt-import in Chromium f1bdee58.
      With Chromium commits locally applied on WPT:
      1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
      
      
      Note to sheriffs: This CL imports external tests and adds
      expectations for those tests; if this CL is large and causes
      a few new failures, please fix the failures by adding new
      lines to TestExpectations rather than reverting. See:
      https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
      
      Directory owners for changes in this CL:
      foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
        external/wpt/tools
      
      NOAUTOREVERT=true
      TBR=raphael.kubo.da.costa
      
      No-Export: true
      Change-Id: Ic6847d750c6afb1700291b673f8ef9442d702c2d
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884092Reviewed-by: default avatarWPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
      Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#709995}
      055a5ec1
    • Nico Weber's avatar
      Remove OFFICIAL_BUILD-specific linux asan options. · 0a97ab1d
      Nico Weber authored
      According to the comments in
      https://chromium-review.googlesource.com/c/chromium/src/+/1882109
      
      Also reorder the options so they have the same order in all
      platforms, making it easier to see what's different across platforms.
      
      Bug: none
      Change-Id: Ibea9ef89a4fd78e31677f0e43036739ec6ad372c
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881636
      Commit-Queue: Nico Weber <thakis@chromium.org>
      Commit-Queue: Alexander Potapenko <glider@chromium.org>
      Reviewed-by: default avatarAlexander Potapenko <glider@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709994}
      0a97ab1d
    • Yun Liu's avatar
      Revert "[code coverage] Turn on native coverage on Android coverage CI builder" · d99bca53
      Yun Liu authored
      This reverts commit 3e7f8dd6.
      
      Reason for revert: Android apk and webview cause many linker issues with Clang coverage on. Bugs created: crbug/1018431, crbug/1018434, crbug/1018780
      
      Original change's description:
      > [code coverage] Turn on native coverage on Android coverage CI builder
      > 
      > Bug: 985574
      > Change-Id: I1d5f51adbe51d6022c0b74c71267b89da27958d2
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872770
      > Commit-Queue: Yun Liu <yliuyliu@google.com>
      > Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
      > Reviewed-by: John Budorick <jbudorick@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#709811}
      
      TBR=liaoyuke@chromium.org,jbudorick@chromium.org,yliuyliu@google.com
      
      Change-Id: I3dc4bcf4703a35288c32f03d15557f0c5bacd0ed
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 985574
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884264Reviewed-by: default avatarYun Liu <yliuyliu@google.com>
      Commit-Queue: Yun Liu <yliuyliu@google.com>
      Cr-Commit-Position: refs/heads/master@{#709993}
      d99bca53
    • Tom Anderson's avatar
      Export fontconfig symbols when using instrumented libraries · 582d48ca
      Tom Anderson authored
      This fixes an issue where Chrome would launch in msan with gLinux, but the first
      time the user types anything into the omnibox, Chrome would hang for several
      minutes. The hang was happening because the fontconfig caches were getting
      regenerated for an older version of fontconfig. See the detailed explanation
      added in BUILD.gn.
      
      BUG=1017974
      R=thakis
      
      Change-Id: I50f4c757a3fc66250f348129c03990eba9546a42
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880587
      Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
      Reviewed-by: default avatarNico Weber <thakis@chromium.org>
      Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709992}
      582d48ca
    • Jochen Eisinger's avatar
      Only deref android sms pairing state tracker if it's non-NULL · 609a2bfc
      Jochen Eisinger authored
      Bug: 1018860
      
      Change-Id: I75f867e6be9b303c7fcafcc5304788d754bb763b
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882314
      Commit-Queue: Jochen Eisinger <jochen@chromium.org>
      Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709991}
      609a2bfc
    • David Benjamin's avatar
      Add use counters for MouseEvent.screen[XY] · 021beee2
      David Benjamin authored
      These are equivalent to window.screen[XY], which were measured in
      https://chromium-review.googlesource.com/c/chromium/src/+/1384047.
      
      Bug: 915620, 1016935
      Change-Id: Iddfee602c9ffd4a360fa5bbca8a0366382c579d1
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874594
      Commit-Queue: David Benjamin <davidben@chromium.org>
      Auto-Submit: David Benjamin <davidben@chromium.org>
      Reviewed-by: default avatarYoav Weiss <yoavweiss@chromium.org>
      Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709990}
      021beee2
    • Adithya Srinivasan's avatar
      Portals: Fix touch input transfer tests · 3c4369d0
      Adithya Srinivasan authored
      Couple of issues dealt with by this CL:
      
      1) We should be starting the gesture from near the bottom of the page
         instead from the top (as it moves upwards)
      2) In TouchInputTransferAcrossReactivation, we might get some scrolling
         in the main page before the first activation. We should be checking
         to see if it has scrolled more than that amount after reactivation
      
      Bug: 1010675
      Change-Id: I6289549f1326a80896c8b78e6a66a724ac6dbeff
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880077Reviewed-by: default avatarKevin McNee <mcnee@chromium.org>
      Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709989}
      3c4369d0
    • v8-ci-autoroll-builder's avatar
      Update V8 to version 8.0.87. · 4026486b
      v8-ci-autoroll-builder authored
      Summary of changes available at:
      https://chromium.googlesource.com/v8/v8/+log/f9d7f08e..32c0b43e
      
      Please follow these instructions for assigning/CC'ing issues:
      https://v8.dev/docs/triage-issues
      
      Please close rolling in case of a roll revert:
      https://v8-roll.appspot.com/
      This only works with a Google account.
      
      CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
      CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
      CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
      CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
      CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel
      
      TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
      
      Change-Id: I8e3cb4789c75874e444377cda0a35eabf3fe0cda
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884090Reviewed-by: default avatarv8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
      Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#709988}
      4026486b
    • Etienne Bergeron's avatar
      Use ICU definition of brackets in itemize text · eea073a1
      Etienne Bergeron authored
      This CL is replacing the hardcoded list of parens with a call to the
      ICU API to get the codepoints attributes.
      
      Splitting a run on brackets has the side-effect to ensures each
      bracket (matching bracket) is rendered with the same font. This
      avoid visual mismatch. The code to split text runs on brackets
      was introduced to fix this:
        https://bugs.chromium.org/p/chromium/issues/detail?id=396776
      
      Unittests are added with some codepoints that were not included as
      brackets and should have been.
      
      Bug: 995789
      Change-Id: I268cc62604d755d61da2c87dd597aabfc57b7ef6
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881723Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
      Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
      Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709987}
      eea073a1
    • Joanmarie Diggs's avatar
      Implement support for ARIA code, strong, emphasis, and time roles · 954e4b97
      Joanmarie Diggs authored
      * Create ax::mojom::Role::kCode, kEmphasis, and kStrong
      * Map to accessibility APIs as defined in Core-AAM specification
      
      Because it is up to content authors and toolkits/frameworks to
      style these roles as they see fit, font and format information
      will be exposed based on authoring. We cannot assume (and thus
      should not automatically expose) bold for the strong role or
      italics for the emphasis role.
      
      Bug: 1017195
      Change-Id: I4fa6d300de27b01abd6c72742c4cf1ac90f63c01
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875520Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
      Reviewed-by: default avatarKevin Babbitt <kbabbitt@microsoft.com>
      Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
      Reviewed-by: default avatarAaron Leventhal <aleventhal@chromium.org>
      Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
      Cr-Commit-Position: refs/heads/master@{#709986}
      954e4b97
    • chromium-autoroll's avatar
      Roll src/third_party/perfetto c2493796361f..a78528cc1f2b (1 commits) · 5f1ca217
      chromium-autoroll authored
      https://android.googlesource.com/platform/external/perfetto.git/+log/c2493796361f..a78528cc1f2b
      
      git log c2493796361f..a78528cc1f2b --date=short --no-merges --format='%ad %ae %s'
      2019-10-28 eseckler@google.com Merge "processor: Fix chrome build & legacy arg export"
      
      Created with:
        gclient setdep -r src/third_party/perfetto@a78528cc1f2b
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/perfetto-chromium-autoroll
      Please CC perfetto-bugs@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      TBR=perfetto-bugs@google.com
      
      Bug: None
      Change-Id: I78531682ebb6642c42d9ee2fce45a130acabe430
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883781Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#709985}
      5f1ca217
    • Mohamed Abdelhalim's avatar
      Navigation: Reset commit timeout at ResetForCrossDocumentRestart. · 71ce57cd
      Mohamed Abdelhalim authored
      It was the case that if ResetForCrossDocumentRestart is called before
      committing, OnCommitTimeout was called which crashed when trying to get
      the current RenderFrameHost.
      
      The introduced test failed with the same stack trace in the related bug
      before resetting commit timeout.
      
      Bug: 1006677
      Change-Id: Ia1d08f792cbd9c3692533d69519cb6da7e21d102
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879913
      Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org>
      Reviewed-by: default avatarCamille Lamy <clamy@chromium.org>
      Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709984}
      71ce57cd
    • Anupam Snigdha's avatar
      Revert "Disable legacy hooking in the browser process" · ac5fadc5
      Anupam Snigdha authored
      This reverts commit f87359ae.
      
      Reason for revert: https://crbug.com/1017694
      
      Some legacy IMEs (ex: Yahoo Chinese IME) are broken with this change.
      
      Bug: 1017694
      Change-Id: I0dceabbd5ee712c74aab113e912a3e629f79785a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880597Reviewed-by: default avatarPatrick Monette <pmonette@chromium.org>
      Commit-Queue: Patrick Monette <pmonette@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709983}
      ac5fadc5
    • Roman Aleksandrov's avatar
      Lock Screen: Show auth error and info bubble on sides of the text field. · 6bb9fbc7
      Roman Aleksandrov authored
      Change behavior of auth error bubble and smart lock info bubble to make
      them appear on the right and left side.
      Make bubbles adjust to the height of virtual keyboard and tray.
      
      Bug: 888696
      Change-Id: I882832b892e762db69708a65f4f2dd6063d0ef59
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863093
      Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
      Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709982}
      6bb9fbc7
    • Yue Zhang's avatar
      Fix TabGridDialog back press misbehavior · 86af7333
      Yue Zhang authored
      http://crrev.com/c/1815988 makes the PopupWindow focusable so that we
      can focus on EditText within TabGridDialog. However, there seems to be
      some inconsistent behavior when clicking back press in a focused
      PopupWindow among different Android APIs. This CL fixes this issue and
      adds a regression test.
      
      Bug: 1013974
      Change-Id: I07575bb493d8627c6af2e7a64eb47acd08876ca4
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874461
      Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
      Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709981}
      86af7333
    • Koji Ishii's avatar
      Re-reland: Update disable-blink-features=LayoutNG · 60060a35
      Koji Ishii authored
      This is a re-reland of crrev.com/c/1882249 because the path
      names of some -expected.png were too long on non-default
      Windows bots. Making this type of errors to be predictable
      is filed as crbug.com/1018801.
      
      * 3 crashes in native-file-system.
      * Mostly image rebaselines where scrollbar buttons became
        grayed when the scroll position is at begin/end. Probably
        someone fixed this.
      * A few pixel differences in rendering fonts, for vertical
        flow and "AM" in the date picker.
      
      TBR=ikilpatrick@chromium.org
      
      Bug: 1018587, 1018731, 1018749
      Change-Id: Ib9bbcb4079b387c961ff01619218ecc56f9aca38
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884390Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
      Reviewed-by: default avatarAleks Totic <atotic@chromium.org>
      Commit-Queue: Koji Ishii <kojii@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709980}
      60060a35
    • Luis Sanchez Padilla's avatar
      Add a directional cut off alternative to the kalman predictor to · 989a4870
      Luis Sanchez Padilla authored
      prevent rubber banding.
      
      Rubber banding, or spring effect, often happens when recent point data
      evaluation generates a considerable deceleration producing velocity
      direction opposite to the current direction. This could happen because
      of noise in the input pipeline or a sudden stop by the input pointer.
      In order to mitigate this side effect, the current velocity vector is
      compared with the future velocity vector by computing the dot product
      between these two. If the result of the product is zero or less, it
      means that they have opposing directions and the prediction is cut off.
      
      Change-Id: I8a863475021f8531a7f2946325d458cad6d1138c
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860329Reviewed-by: default avatarElla Ge <eirage@chromium.org>
      Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
      Commit-Queue: Luis Sanchez Padilla <lusanpad@microsoft.com>
      Cr-Commit-Position: refs/heads/master@{#709979}
      989a4870
    • Wez's avatar
      [fuchsia] Enable shadow-call-stack for all targets. · f1bb41bd
      Wez authored
      Bug: fuchsia:27339, 821951
      Change-Id: If685fd9817f8dae8671634f3798a655ddb2ba392
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863774
      Auto-Submit: Wez <wez@chromium.org>
      Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
      Reviewed-by: default avatarKevin Marshall <kmarshall@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709978}
      f1bb41bd
    • Max Li's avatar
      Add API to EligibleHostDevicesProvider to retrieve active host devices · a65c7863
      Max Li authored
      Bug: 923594
      Change-Id: I1d2bfdb8b7067a7bf524e1e99cc90e2bda3429a6
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876735
      Commit-Queue: Max Li <themaxli@chromium.org>
      Reviewed-by: default avatarJosh Nohle <nohle@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709977}
      a65c7863
    • Evan Stade's avatar
      Remove NOTIFICATION_PROFILE_DESTROYED from sync_file_system_backend.cc · 0988704a
      Evan Stade authored
      Bug: 268984
      Change-Id: Ied766d3006009fbd5534eca799bf095bf48dbc28
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876083
      Commit-Queue: Evan Stade <estade@chromium.org>
      Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709976}
      0988704a
    • Peter Kotwicz's avatar
      Re-enable TrustedWebActivityTests · 06f433ae
      Peter Kotwicz authored
      This CL re-enables
      TrustedWebActivityTest#testStatusBarColorCertificateError()
      TrustedWebActivityTest#testToolbarVisibleCertificateError()
      
      - It modifies the tests to use different origins for "pages without a
      certificate error" and "pages with a certificate error". This is now
      necessary due to http://crrev.com/c/1872423
      - Uses host-resolver-rules command line flag in order to use multiple
      origins in tests. The command line flag has the side effect of causing
      "redirected-urls" to throw a certificate error when navigated to
      - It also fixes a bug with the testStatusBarColorCertificateError()
      test on Lollipop
      
      BUG=1016743,1016746
      
      Change-Id: I20bbfdd7828c243af991e62f9c7d9a173d326c59
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876872Reviewed-by: default avatarPeter Conn <peconn@chromium.org>
      Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709975}
      06f433ae
    • Robert Liao's avatar
      Remove View::GetAncestorWithClassName · d7eb78dc
      Robert Liao authored
      Upward ancestor traversal by class name is not a common pattern used in
      Views clients.
      
      BUG=
      
      Change-Id: If0aefc9084836526225441a4d8f15131b7c1f3fd
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881888
      Auto-Submit: Robert Liao <robliao@chromium.org>
      Reviewed-by: default avatarScott Violet <sky@chromium.org>
      Commit-Queue: Robert Liao <robliao@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709974}
      d7eb78dc
    • Clark DuVall's avatar
      Fix AllowSignedExchange crashing when closing incognito window · 3b2b88c5
      Clark DuVall authored
      The PrefetchURLLoader's lifetime is managed using
      mojo::MakeStrongBinding, which means it may live until after the
      BrowserContext is destroyed. Instead of keeping the browser context
      around to check if signed exchange is allowed, we check in the
      constructor and cache the value.
      
      Bug: 1016373
      Change-Id: Ia6722ed37a8213078be856b11b9dde70ef230e8d
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881379
      Commit-Queue: Clark DuVall <cduvall@chromium.org>
      Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#709973}
      3b2b88c5