GitLab

This is our first attempt, mostly to feel this out.  Performance and
correctness problems are both possible.  Please revert this if a benchmark even
smells funny.

That said, we've been working on this a while, are pretty confident it's good
stuff, and have had Skia's internal testing entirely switched over for a week.
Parts of Chromium that serialize and deserialize SkPictures are already
switched over.  This CL finishes things off by switching the default
recorded-from-scratch SkPicture to use SkRecord too.

BUG=408985,409110

Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c

Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg;tryserver.chromium.linux:linux_browser_asan

Review URL: https://codereview.chromium.org/504823003

Cr-Commit-Position: refs/heads/master@{#293258}

* "added" type is added
* "num_total_jobs" member is added
* and this is for displaying the total number of jobs in Chrome OS file manager

BUG=400636
TEST=
manually
1. Copy the local file to drive directory.
2. Observe the status of syncing status.

Review URL: https://codereview.chromium.org/507293002

Cr-Commit-Position: refs/heads/master@{#293257}

Layout changes trigger view changes which get sent to the plugin. With the
in process plugin (PDF), the plugin is notified synchronously of the view
change. It then might execute scripts synchronously in the plugin but
scripts are not meant to be executed during layout changes. This change
runs the scripts asynchronously. I tested print preview to ensure that it
still works correctly.

Note that once we remove in-process plugins this won't be an issue because
view changes happen asynchronously out of process (besides the fact that
synchronous script execution is limited to private plugins).

BUG=351636

Review URL: https://codereview.chromium.org/530363002

Cr-Commit-Position: refs/heads/master@{#293256}

BUG=110610
TBR=rpaquay@chromium.org

Review URL: https://codereview.chromium.org/536623003

Cr-Commit-Position: refs/heads/master@{#293255}

Revert of Removing X11 native_event uses for key events. (patchset #6 id:160001 of https://codereview.chromium.org/479873002/)

Reason for revert:
Causing check_licenses to fail on android_clang_dbg_recipe trybot:
The following files are whitelisted unnecessarily. You must remove the following files from the whitelist.
content/browser/renderer_host/web_input_event_aurax11.cc
The following files are whitelisted, but do not exist.
content/browser/renderer_host/web_input_event_aurax11.cc

Original issue's description:
> Removing uses of X11 native key events.
>
> BUG=380349
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822

TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,kpschoedel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=380349

Review URL: https://codereview.chromium.org/536313002

Cr-Commit-Position: refs/heads/master@{#293254}

Revert of Add LocationBar PageAction tests (patchset #4 id:80001 of https://codereview.chromium.org/512693003/)

Reason for revert:
Flaky test
see the following runs where the test fails even with 3 retries

http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9713
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9656
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9574
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9511
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9405
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9367
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9252
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9253
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9223
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9213

Original issue's description:
> Add LocationBar PageAction tests
>
> Page actions in the location bar have been somewhat loosely tested as a side-
> effect of the page actions api testing, but (near as I can tell), we never
> explicity test the ui for page actions.
>
> This is a problem because the extensions tests shouldn't care about the UI, and
> soon won't, since where the page actions are in the UI may change (i.e.,
> location bar vs toolbar).
>
> Fix this by adding a few basic UI tests for page actions in the location bar.
>
> BUG=408261
>
> Committed: https://chromium.googlesource.com/chromium/src/+/0abaca08e99fa6671758a96829b99aa941696e41

TBR=finnur@chromium.org,sky@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408261

Review URL: https://codereview.chromium.org/537813002

Cr-Commit-Position: refs/heads/master@{#293253}

This callback implies that the resources are gone (because LTH
was deleted). What ends up happening is that the resources get
deleted while LTH still tries to call GetBitmap() on them.

This still needs some working invalidation mechanism for Thumbnails,
which don't have a persistent Bitmap they return from GetBitmap().

BUG=406879
NOTRY=True
TBR=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/543543002

Cr-Commit-Position: refs/heads/master@{#293252}

Revert of Add test for ChromeVox keyboard commands. (patchset #7 id:120001 of https://codereview.chromium.org/490443002/)

Reason for revert:
Broke interactive_ui_tests on Linux ChromiumOS Ozone: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%282%29/builds/1626/steps/interactive_ui_tests

Failing tests:
ChromeVoxNavigateAndSelect_0
ChromeVoxPrefixKey_0
ChromeVoxPrefixKey_1
ChromeVoxShiftSearch_0
ChromeVoxShiftSearch_1

Original issue's description:
> Add test for ChromeVox keyboard commands.
>
> This is just a couple of quick sanity checks to prevent future regressions
> like the one in the linked bug. It tests both a Search+Shift shortcut and
> the corresponding Prefix Key shortcut.
>
> Adds support for sending the meta modifier key in
> aura/x11 tests.
>
> BUG=404470
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0

TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404470

Review URL: https://codereview.chromium.org/535283004

Cr-Commit-Position: refs/heads/master@{#293251}

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/536113002

Cr-Commit-Position: refs/heads/master@{#293250}

https://skia.googlesource.com/skia/+log/74364c97740eb48c86d6e7b42520c77130eb1486..0c88d8233ba3a8baa9b4dd6ef515def6b3749980

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/537723002

Cr-Commit-Position: refs/heads/master@{#293249}

TBR=zhaoqin@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/532883004

Cr-Commit-Position: refs/heads/master@{#293248}

BUG=82385,angle:736

https://chromium.googlesource.com/angle/angle/+log/a502c749b249df6460326c4e5354f0549cc698d8..ab56c6aeff8ea52a8927a947ec20d19eb4564fc9

Review URL: https://codereview.chromium.org/538533002

Cr-Commit-Position: refs/heads/master@{#293247}

Unify these two parts of out USB device support. The //device tree is
the cannonical location for hardware device APIs.

BUG=

Review URL: https://codereview.chromium.org/497363004

Cr-Commit-Position: refs/heads/master@{#293246}

This allows destination textures with GL_BGRA_EXT as internal format
to be used with CopyTexture.

BUG=371718

Review URL: https://codereview.chromium.org/539703002

Cr-Commit-Position: refs/heads/master@{#293245}

GPU raster was observed to cause pixel corruption on the Galaxy Note 2
(GT-N7100, Mali-400 MP, ES 2.0).  Remove it from the GPU raster
whitelist, as well as the international Galaxy S3 (GT-I9300) which also
uses Mali 400.

Also expand the Nexus 10 blacklist to all Mali-T604 devices.

NOTRY=true
BUG=409970

Review URL: https://codereview.chromium.org/537183003

Cr-Commit-Position: refs/heads/master@{#293244}

Cast was originally intended to tell vp8 to only reference buffers which have been ACKed.
However, that mode was buggy and disabled. This CL fixes it again. The three-buffer mode
lets the receiver drop frames and continue, which should be quite useful if we want lower
latency.

BUG=351596

Review URL: https://codereview.chromium.org/339743002

Cr-Commit-Position: refs/heads/master@{#293243}

Code cleanup:  Remove network_prediction_enabled_ from NetPrefObserver, and
enabled_ and set_enabled() from PrerenderManager.  Earlier CLs on this issue
update the Prerender mechanism and make these members/methods obsolete.

BUG=334602

Review URL: https://codereview.chromium.org/519583005

Cr-Commit-Position: refs/heads/master@{#293242}

https://chromium.googlesource.com/chromium/blink/+log/9d34a87dee82cbdcd5876669aa1cd1a430289e09..9a051c526402aedfa6bc73e6699838c777b679cf
TBR=tkent@chromium.org,arv@chromium.org

Review URL: https://codereview.chromium.org/539713002

Cr-Commit-Position: refs/heads/master@{#293241}

the history thread.

BUG=402104
TEST=None

Review URL: https://codereview.chromium.org/531493002

Cr-Commit-Position: refs/heads/master@{#293240}

BUG=402797
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/478773002

Cr-Commit-Position: refs/heads/master@{#293239}

This CL is the combination of https://codereview.chromium.org/493143004/ and
https://codereview.chromium.org/523723002/. They were reviewed separately to
make the review process easier.

Full a more detailed explanation of the refactor, see http://crbug.com/406656

Bugs fixed:
- Attempting to fullscreen HTML5 content with --enable-simplified-fullscreen
caused UI problems.
- Omnibox/toolbar did not slide in Canonical Fullscreen.
- Presentation Mode and Canonical Fullscreen tab strip layout is incorrect when
menubar is hidden.
- Canonical Fullscreen should ignore the mouse tracking area.

Refactor mostly consisted of:
- Deleted FullscreenModeController.
- External (outside of BWC) invocations of fullscreen mode are much simpler.
- Significant code reduction and logic simplification in BWC.

BUG=406656, 405561
TBR=rsesek

Review URL: https://codereview.chromium.org/533383002

Cr-Commit-Position: refs/heads/master@{#293238}

None of these are needed anymore since trials
can be marked as "starts_active" server-side.

BUG=none

Review URL: https://codereview.chromium.org/536033002

Cr-Commit-Position: refs/heads/master@{#293237}

This CL adds a new dependency on the protocol buffer compiler
from the android source tree, since this compiler supports
generating Java files using the nano runtime.

The initial version of this dependency is 2.2.0a, but checked
out as what the Android 4.4.4 Release 2.0.1 tag points to.

This CL adds a new protoc binary (for compiling protos) that supports
this, and also adds a Java library with the runtime.

To simplify use of this, it also updates build/protoc_java.gypi to
support generating nano protos by specifying an optional
proto_runtime argument. The argument defaults to 'lite' which does
the same thing as before this change, and setting it to 'nano'
generates the new style Java files.

The plan is to quickly deprecate the 'lite' runtime for Java, since
it is too big and uses too many methods.

TBR=darin@chromium.org,cjhopman@chromium.org
BUG=377891,410067

Review URL: https://codereview.chromium.org/532303003

Cr-Commit-Position: refs/heads/master@{#293236}

With this, CTObjectsExtractorTest and MultiLogCTVerifierTest pass on OpenSSL
builds.

BUG=408687

Review URL: https://codereview.chromium.org/519473002

Cr-Commit-Position: refs/heads/master@{#293235}

This is just a couple of quick sanity checks to prevent future regressions
like the one in the linked bug. It tests both a Search+Shift shortcut and
the corresponding Prefix Key shortcut.

Adds support for sending the meta modifier key in
aura/x11 tests.

BUG=404470

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547

Review URL: https://codereview.chromium.org/490443002

Cr-Commit-Position: refs/heads/master@{#293234}

Fixed bug in recording where it would not download credentials.

BUG=

Review URL: https://codereview.chromium.org/538603002

Cr-Commit-Position: refs/heads/master@{#293233}

This CL:
- Prevents HomeCardGestureManager from calling OnGestureProgressed() with
  |from_state| == |to_state|
  - This fixes the minimized home card's opacity being incorrectly set when
    dragging down from the minimized state
- Removes unnecessary |HomeCardGestureManager::last_state_|

BUG=409666
TEST=HomeCardGestureManagerTest.*

Review URL: https://codereview.chromium.org/529813002

Cr-Commit-Position: refs/heads/master@{#293232}

BUG=110610
TBR=mmenke@chromium.org,pkasting@chromium.org,rsleevi@chromium.org

Review URL: https://codereview.chromium.org/536053003

Cr-Commit-Position: refs/heads/master@{#293231}

This behavior is required by ObserverListThreadSafe and may leads to crashes if not followed

BUG=404767

Review URL: https://codereview.chromium.org/502003003

Cr-Commit-Position: refs/heads/master@{#293230}

This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them.

BUG=407376
TEST=this may crash for a few people

Review URL: https://codereview.chromium.org/537703003

Cr-Commit-Position: refs/heads/master@{#293229}

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/524983002

Cr-Commit-Position: refs/heads/master@{#293228}

When a user's cryptohome directory is created with a pre-hashed key,
the credentials provided need to be hashed in the same way whenever the
crypthome is to be unlocked/mounted. This CL updates the Login*() methods
in CryptohomeAuthenticator to retrieve key metadata and apply the correct
hashing algorithm to the given credentials. Follow-up CLs will update
the other CryptohomeAuthenticator methods to also work with pre-hashed
keys.

BUG=367847
TEST=Extended unit tests

Review URL: https://codereview.chromium.org/517653002

Cr-Commit-Position: refs/heads/master@{#293227}

Given that the metrics reporting pref is labelled in the UI as requiring
a restart to apply, this is a much simpler way of gating Domain
Reliability uploads on it.

We simply don't create the Service (so we don't collect data and upload
it) if the pref is false.

This will need to be revisited when we also start using the Monitor for
JavaScript hooks (e.g. the Navigation Error Logging API).

BUG=407170

Review URL: https://codereview.chromium.org/525303004

Cr-Commit-Position: refs/heads/master@{#293226}

BUG=163393
NOTRY=true

Review URL: https://codereview.chromium.org/542483002

Cr-Commit-Position: refs/heads/master@{#293225}

After sending an email to the native-client-discuss list, it was determined
that this feature for redirecting stdout and stderr to JavaScript isn't very
useful. This drops support for that feature; a follow up change to the NaCl
repository will remove support there (and the SRPC message).

BUG=406558

Review URL: https://codereview.chromium.org/513273003

Cr-Commit-Position: refs/heads/master@{#293224}

Restrict the number of cases where we force the compositor to do a synchronous paint to resizing and restore/maximize operations.

Forcing the compositor to do a synchronous paint in window size changed notifications sends over
a synchronous IPC to the GPU process which blocks the UI thread. We have been seeing cases where
Chrome seems to freeze while performing operations like typing in the omnibox, etc.

BUG=397633
R=sky,cpu

Review URL: https://codereview.chromium.org/528173002

Cr-Commit-Position: refs/heads/master@{#293223}

Currently there is not enough unit test cases available to cover
the functionality of Paste Popup menu behavior. This patch covers
essential unit test cases for the same.

BUG=

Review URL: https://codereview.chromium.org/534343002

Cr-Commit-Position: refs/heads/master@{#293222}

BUG=409938

Review URL: https://codereview.chromium.org/538543004

Cr-Commit-Position: refs/heads/master@{#293221}

- Initialize URL standard schemes on load.
- Use NULL-resistant string conversions.

BUG=410374

Review URL: https://codereview.chromium.org/536023003

Cr-Commit-Position: refs/heads/master@{#293220}

Test plan:

First: download chrome-mac.zip from https://download-chromium.appspot.com/?platform=Mac

Then:

$ unzip chrome-mac.zip
$ cd chrome-mac
$ find . -name "*.pak" | grep chrome
./Chromium.app/Contents/Versions/39.0.2136.0/Chromium Framework.framework/Resources/chrome_200_percent.pak
./Chromium.app/Contents/Versions/39.0.2136.0/Chromium Framework.framework/Resources/chrome_100_percent.pak

$ find . | grep content
0 # no results

Check with python:

$ cd ~/chromium/src/tools/grit
$ python
>>> from grit.format import data_pack
>>> pack = data_pack.ReadDataPack('
~/Download/chrome-mac/Chromium.app/Contents/Versions/39.0.2136.0/Chromium
Framework.framework/Resources/chrome_100_percent.pak')
>>> pack.resources[4700]
>>>'\x89PNG\r\n\x1a\n\x00\x00\x00\rIHDR\x00\x00\x00\x0e\x00\x00\x00\x10\x08\x06\x00\x00\x00&\x94N:\x00\x00\x01\x87IDAT(S\x8d\x90I/CQ\x18\x86\xbf\xb5_\x84\xa5\x84\x9f6XX\xb3\xb0\xb7"$j\xe8\xc05T\xe7\x95H\x8cM\xec\xc4XA\xd5\x90\xe2VU\x1a\xa5\x86xb8\xb4h\xaf\xd7\xf9\x0e\xb7Q\xb9\xa2o\xf2,\xce9\xcf\xb39\x14\x08\x04P\nDTF?\xe7\xf7\x07\xa0e?\xf0\x981\xe7)\xa3CQ\x14\xb0W\x14\xfb|~\x9c\xdf\xe98N\xe7LI\xde\xbc\xcb\x90\xc7n!\xf6z\xbd8\xb9\xd6\x119}\x93\x183\xcej\xea\xb5\x10\xf2\xd8\x97\xb1\xdb\xedA\xfcJ\xc7v\xe2\x15\xbf\xc7wG"\xb4\xd9lEpC.\x97[\x86f\xdb\x8ag\x11\x89k\xb8\xb8\xcb\xe1^\xcbK\xf8?\xb8!\xa7s\x0c\xf1K\x1d\x1b\xc7/\xa6\x84O2\xd8Ofqp\xf6E\xeaV\x0774:\xeaD,\x9dGH}.\tv\xb9\xa1\xe1\xe1\x11\xa8\xe2\xb0v\xa8\x95\x04\xbb\xa2!R\x94!\xa8\x17y\xacD\xb5\x02\xcb\xd1G\xccD\xa2\x08\xee\xc4\x8a\xee\x19\xe1rC48\xa8\xe0H\x84\x8b{\x0f\x12Oh\x1e\xb5\xe3\xe5\xa8\x9b\xac\x904\xcf5b6\xac\x1a\xef$\\n\x88\x1c\x8e\x01\x1c\x9e\xe7\xb1\xb0\xfb\x00\xdb\x92W\xc8\x95\x85\xc8\xa0~\xb2\n\x13\x9b\x11\x12\x0e\tW6d\xb7;d\xe8Z\r\x9aF\xdfP\xc3T5\xcd\x85\x13\x1c\x82\x1b\xb2Z\xedXO\xa4\xd18]\xf3gd\xd0\x12lB4\xf5\x0en\xa8\xbf\xdf\x8a\xb6\x85\xd6\x7f#\xe3\xaew\xad\x07\xbd\xd6>Pgg\x17\xda\xdb;\xcc\xa0\x1f\x14\xbdu[,\xf8\x04*e\x8e;5\xb6\x8b\x00\x00\x00\x00IEND\xaeB`\x82'

NOTE: 4700 is the ID of IDR_BROKENIMAGE defined in
out/Debug/gen/content/app/resources/grit/content_resources.h, which
shows content_resources_100_percent.pak gets included within
chrome_100_percent.pak

BUG=176960
TEST=see test plan above
R=tony@chromium.org

Review URL: https://codereview.chromium.org/521473002

Cr-Commit-Position: refs/heads/master@{#293219}