GitLab

We are introducing a new namespace "root". The "My Drive" root will be represented as
"/special/drive/root".

BUG=174233,218221
TEST=Open options UI


Review URL: https://chromiumcodereview.appspot.com/12790013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192572 0039d316-1c4b-4281-b951-d872f2087c98

New icons from sgabriel@.

BUG=180107
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/13685011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192571 0039d316-1c4b-4281-b951-d872f2087c98

This enables the update logic for /drive/root namespace.

BUG=174233
TESTS=unittests


Review URL: https://chromiumcodereview.appspot.com/13586012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=226014


Review URL: https://chromiumcodereview.appspot.com/13517002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192569 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175683,177443


Review URL: https://chromiumcodereview.appspot.com/13679005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192567 0039d316-1c4b-4281-b951-d872f2087c98

DevTools creates RenderView before browser populates systems settings into
WebContents preferences thus the renderer gets default subpixel antialising
setting.
The fix makes it sending ViewMsg_SetRendererPrefs to the renderer when
the preferences are finally obtained by the browser.

R=pfeldman@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13580007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192566 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192565 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13520009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192564 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/12422012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=222217
TEST=manual
R=nkostylev


Review URL: https://chromiumcodereview.appspot.com/13194004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192562 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation for porting TestKeyboard* tests to Drive.

BUG=224534
TEST=none


Review URL: https://chromiumcodereview.appspot.com/13706002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192559 0039d316-1c4b-4281-b951-d872f2087c98

This is a cleanup after:
https://codereview.chromium.org/12794003/

One test for backend force retry is enough, the other test
(CreateBackend_MissingFile) is converted to be backend implementation specific.

The CreateCacheViaPublicInterface() is called only once, but to eliminate it
there is a need to make the cache_thread_ protected. Also, I am sure the name is
not ideal, please suggest another.

The New Eviction allows not to be very strict about version comparison as stored
in the files on disk, this allows creating the BackendImpl with no flags and
then being able to pass the common integrity check.

BUG=173384


Review URL: https://chromiumcodereview.appspot.com/13517004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192558 0039d316-1c4b-4281-b951-d872f2087c98

SetAccessibleName to label text on SetText.
(this matches TextButtonBase::SetText behavior) 
Call SetText from LabelButton's constructor.

Use LabelButton in AccessibilityEventRouterViewsTest like: 
https://codereview.chromium.org/13584010 Patch Set 4. 

Note: This CL depends on https://codereview.chromium.org/13639003/

BUG=155363, 226814
TEST=LabelButtons have accessibility names. Tests pass. 
R=tfarina@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13689002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192557 0039d316-1c4b-4281-b951-d872f2087c98

Autogenerated with:
  python tools\swarm_client\isolate_test_cases.py -s out\Release\browser_tests.isolated --gtest_filter=PepperContentSettingsTest.PluginSpecialCases

This should turn browser_tests_swarm completely green on Windows.

TBR=csharp@chromium.org
NOTRY=true
BUG=


Review URL: https://chromiumcodereview.appspot.com/13601007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192556 0039d316-1c4b-4281-b951-d872f2087c98

chromeos: Fix FilePath handling incompatibility between FakeDriveFileSystem::GetEntryInfoByResourceId and GetEntryInfoByPath

ConvertResourceEntryToDriveEntryProto adds extensions like ".gdoc" to hosted documents.
GetEntryInfoByResourceId and GetEntryInfoByPath should handle paths in the same manner.

BUG=None
TEST=unit_tests --gtest_filter="FakeDriveFileSystemTest.GetEntryInfoByResourceId_PathCompatibleWithGetEntryInfoByPath"


Review URL: https://chromiumcodereview.appspot.com/13579005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192555 0039d316-1c4b-4281-b951-d872f2087c98

Create "/drive/root" at DriveResourceMetadata initialization.
"/drive/other" is also created but is empty for now.

BUG=174233
TEST=unittests. Open Files App and verify Google Drive is available.


Review URL: https://chromiumcodereview.appspot.com/13149003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192554 0039d316-1c4b-4281-b951-d872f2087c98

 -- another race in ICU memory allocation (issue 223352)
 -- suppress a test-only race in tracked_objects::ThreadData::ShutdownSingleThreadedCleanup (issue 102327)

BUG=223352,102327,226970
Review URL: https://codereview.chromium.org/13296008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192553 0039d316-1c4b-4281-b951-d872f2087c98

Updated the query stub to filter by search term and added a test for searching
in the history page.

R=dubroy@chromium.org
BUG=196568


Review URL: https://chromiumcodereview.appspot.com/13523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192552 0039d316-1c4b-4281-b951-d872f2087c98

Currently when creating a new managed user we open other tabs in addition to
the managed users settings one, which we don't want to do.

This makes sure that only that tab gets added to the list of URLs to open on
start-up by early-returning from that function.

R=ben@chromium.org
BUG=171370


Review URL: https://chromiumcodereview.appspot.com/13468005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192551 0039d316-1c4b-4281-b951-d872f2087c98

Previously, getFileList() was called directly from testFileDisplay().
This was bad, as it's not guaranteed that the file list is already rendered
by the time testFileDisplay() is called, hence the test was flaky.
We should use waitForFileListChange() instead.

Likewise, doKeyboardTest() and doKeyboardTestWithConfirmation() are fixed
in the same way.

BUG=224534

Review URL: https://chromiumcodereview.appspot.com/13450004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192550 0039d316-1c4b-4281-b951-d872f2087c98

Enable the new elevation for managed users which is tied to a specific WebContents. This replaces the old elevation which was tied to a profile.

BUG=222364
TEST=unit_tests,browser_tests


Review URL: https://chromiumcodereview.appspot.com/13119011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192549 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192546 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=japhet@chromium.org

Review URL: https://codereview.chromium.org/13423005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192545 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements five newly introduced methods on FakeDriveService.
The implementation of ContinueGetResourceList, the remaining method, needs
slightly more changes, so it will be done in another CL.
The new methods will be used for testing of replacing GetResourceList method.

BUG=160932
TEST=Ran unit_tests --gtest_filter=FakeDriveService*


Review URL: https://chromiumcodereview.appspot.com/13608006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192544 0039d316-1c4b-4281-b951-d872f2087c98

Starting with the 10.8 SDK and the iOS 6.0 SDK, enums are declared
strongly typed in C++11 mode, which the old forward-declares weren't
compatible with. This creates a new macro for forward-declaring these
enums in a way that will match the SDK and compilation mode.

BUG=226494

Review URL: https://chromiumcodereview.appspot.com/13455004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192543 0039d316-1c4b-4281-b951-d872f2087c98

Increased initial timer interval to ensure that we don't trigger error callback on certain "slow" Mac devices.

TBR=tommi
BUG=226327
TEST=Misc audio input demos in Chrome (WebRTC).

Review URL: https://codereview.chromium.org/13679007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175948
TEST=Open a .txt file in Google Drive directory from both Files.app and Ctrl-O


Review URL: https://chromiumcodereview.appspot.com/13401003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51204
TEST=GeolocationBrowserTest.NoLeakFromOffTheRecord

Review URL: https://chromiumcodereview.appspot.com/13548003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192540 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192539 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178313
TEST=(see instructions in bug)


Review URL: https://chromiumcodereview.appspot.com/13601005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192538 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a CHECK assertion that was triggered if an incognito split mode
extension with two background pages (each having an active web reqeust event
listener) was restarted. The reason for the bug was that the event listener
from the incognito background page would not be unregistered properly.

BUG=224094
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13572005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224923


Review URL: https://chromiumcodereview.appspot.com/13510002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192536 0039d316-1c4b-4281-b951-d872f2087c98

TBR=japhet@chromium.org
BUG=

Review URL: https://codereview.chromium.org/13679004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192535 0039d316-1c4b-4281-b951-d872f2087c98

We used to do so, and the resulting data doesn't make sense.

BUG=224262
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192526

Review URL: https://chromiumcodereview.appspot.com/13119014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192533 0039d316-1c4b-4281-b951-d872f2087c98

> Context menu on views must show on mouse down for non-WIN.
> This is mostly a copy of https://chromiumcodereview.appspot.com/12395010 which was reverted due to a regression (https://code.google.com/p/chromium/issues/detail?id=189100). I have attempted to fix that regression here.
> 
> BUG=189100,179381
> 
> Review URL: https://chromiumcodereview.appspot.com/12529012

TBR=varunjain@chromium.org
Review URL: https://codereview.chromium.org/13565004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192532 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192530 0039d316-1c4b-4281-b951-d872f2087c98

The eventual plan is to replace scoped_array<T> with scoped_ptr<T[]>.
All existing issues with these new restrictions have been fixed, so I'd
like to enforce them for scoped_array while the transition is still in
progress.

BUG=171118

Review URL: https://codereview.chromium.org/13673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192528 0039d316-1c4b-4281-b951-d872f2087c98

> Telemetry: Don't silently compare histograms from different processes.
> 
> We used to do so, and the resulting data doesn't make sense.
> 
> BUG=224262
> NOTRY=true
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/13119014

TBR=marja@chromium.org
Review URL: https://codereview.chromium.org/13408012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192527 0039d316-1c4b-4281-b951-d872f2087c98

We used to do so, and the resulting data doesn't make sense.

BUG=224262
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13119014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192526 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly a copy of https://chromiumcodereview.appspot.com/12395010 which was reverted due to a regression (https://code.google.com/p/chromium/issues/detail?id=189100). I have attempted to fix that regression here.

BUG=189100,179381

Review URL: https://chromiumcodereview.appspot.com/12529012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192525 0039d316-1c4b-4281-b951-d872f2087c98