GitLab

BUG=none

Review URL: https://codereview.chromium.org/11745003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/11783092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176109 0039d316-1c4b-4281-b951-d872f2087c98

There is no need to be using dup2() to set up an FD with a fixed
number; this risks overwriting an FD.  The point of
base::GlobalDescriptors is that it provides a level of indirection
that allows any FD number to be used.

Remove kNaClBrowserDescriptor.  Remove the browserdesc argument that
is not used for anything other than an assertion and so isn't needed.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2096
TEST=NaCl tests in browser_tests

Review URL: https://codereview.chromium.org/11819021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176106 0039d316-1c4b-4281-b951-d872f2087c98

In order to remove sleep-waiting from debug stub, we need to send events on
exceptions in NaCl program from Chrome process to debug stub. This requires
duplicating event handle from NaCl process to Chrome process.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2952
TEST= none


Review URL: https://chromiumcodereview.appspot.com/11819057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176105 0039d316-1c4b-4281-b951-d872f2087c98

Also
- removed the temp work-around in disabled_extensions_view.cc.
- pngcrushed the images in common/.

BUG=165808
TEST=Verify hotdog menu bubble does not go beyond browser window.

R=oshima@chromium.org,finnur@chromium.org
TBR=msw@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/11778074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176104 0039d316-1c4b-4281-b951-d872f2087c98

The setting is mapped directly onto WebKit's WebSettings.viewportEnabled

R=benm@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11759023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176103 0039d316-1c4b-4281-b951-d872f2087c98

Appears to break ChromeOS browser_tests.

> Re-introduce the partial magnifier
> 
> Major Changes:
> - Adding a selectbox at the right of screen magnifier setting on the setting page.
> - Adding 'screen_magnifier_type2' pref.
> - Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
> - Add IsMagnifierEnabled() to shell delegate.
> 
> BUG=166832
> TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
> 
> R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
> TBR=jhawkins@chromium.org
> # TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
> 
> Review URL: https://chromiumcodereview.appspot.com/11642014

TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11821053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176102 0039d316-1c4b-4281-b951-d872f2087c98

Active Setup is a Windows "Run-once-for-each-user-at-next-login" mechanism which we use to install per-user shortcuts on system-level installs.

It currently points to setup.exe --configure-user-settings --...

Windows' clever heuristics detect that this is an installer solely based on the process name and tries to elevate (this is mitigated on Vista since we set requestedExecutionLevel="asInvoker" in setup's manifest; on XP however this results in a blocking "Install Program as Other User" dialog at log in...).

BUG=166473
TEST=
On Windows XP:
0) Have User A (admin) and User B (non-admin, logged out)
1) Install system-level Chrome from User A
2) Log in to User B
3) See that the per-user Quick Launch shortcut has been installed (and that you weren't prompted by the "Install Program as Other User" dialog).

More Active Setup testing can be done as per the TEST block on https://codereview.chromium.org/11465025/.

Review URL: https://chromiumcodereview.appspot.com/11733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176101 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11823037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176099 0039d316-1c4b-4281-b951-d872f2087c98

the same way they have the ability to provide a custom view for page widgets.
All the widget views are created using WebContentsView, which can be
overriden by embedders with ContentBrowserClient::OverrideCreateWebContentsView
Contributed by rosca@adobe.com

BUG=155761

Review URL: https://chromiumcodereview.appspot.com/11773042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176092 0039d316-1c4b-4281-b951-d872f2087c98

Also, redirect the page to chrome://settings when only one monitor is
connected, so we can stop showing the dialog for now. In the future
we may decide to show the page for some reason.

BUG=169124
TEST=manually on parrot

Review URL: https://codereview.chromium.org/11818043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176089 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11833013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176088 0039d316-1c4b-4281-b951-d872f2087c98

Major Changes:
- Adding a selectbox at the right of screen magnifier setting on the setting page.
- Adding 'screen_magnifier_type2' pref.
- Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
- Add IsMagnifierEnabled() to shell delegate.

BUG=166832
TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.

R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
TBR=jhawkins@chromium.org
# TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/

Review URL: https://chromiumcodereview.appspot.com/11642014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176087 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces a new public InternalAccessDelegate interface
on AwContents.
The purpose of the new interface is to support adding new internal
access methods that are required by AwContents but not by
ContentViewCore. An added benefit is isolating the embedder from
one more org.chromium.content.* type.

BUG=None
TEST=compile
Java-only change.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11828045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176086 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11820038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176085 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11830033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=148878


Review URL: https://chromiumcodereview.appspot.com/11667024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176083 0039d316-1c4b-4281-b951-d872f2087c98

Quit() is deprecated and we should switch to QuitWhenIdle().

BUG=131220
R=darin@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11794032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176082 0039d316-1c4b-4281-b951-d872f2087c98

Error messages were black on almost black background. The color has been changed to white.

TEST=Invoke an error message by eg. opening a broken image file (eg. empty jpg file).
BUG=168041


Review URL: https://chromiumcodereview.appspot.com/11833026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176081 0039d316-1c4b-4281-b951-d872f2087c98

This test flaked with timeouts on Vista Tests.

TBR=tim
BUG=166261

Review URL: https://codereview.chromium.org/11818030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176080 0039d316-1c4b-4281-b951-d872f2087c98

First draft at moving the strong reference native side into a
weak reference and maintaining the strong reference on the
java side.

Android only change, android bots green.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11802002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176079 0039d316-1c4b-4281-b951-d872f2087c98

Also adds a complemetary DEPS file, in a subset of the gclient DEPS format, that specifies what files are needed for telemetry.

third_party/davclient is required to make interfacing with a WebDAV server simpler.

BUG=162301
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/11741030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176078 0039d316-1c4b-4281-b951-d872f2087c98

TBR=marshall@chromium.org,jsbell@chromium.org
BUG=150995,162829
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11778089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176077 0039d316-1c4b-4281-b951-d872f2087c98

> GTTF: Enable debugallocation by default.
>
> TBR=willchan
>
>BUG=30715
>
>Review URL: https://codereview.chromium.org/11794029


TBR=phajdan.jr@chromium.org
BUG=30715
TEST=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11829054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176076 0039d316-1c4b-4281-b951-d872f2087c98

> LTHI's bg animation timer should set the fake thread to impl.
> 
> The single thread proxy expects this to be true.
> 
> BUG=165399
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11532009
This is causing failures on mac:

http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%281%29&number=32119
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%281%29&number=5885

TBR=vollick@chromium.org
Review URL: https://codereview.chromium.org/11820049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169237

Review URL: https://codereview.chromium.org/11817041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176073 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168957

Review URL: https://codereview.chromium.org/11824061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169049

Review URL: https://codereview.chromium.org/11827050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=169239

Review URL: https://codereview.chromium.org/11824060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176070 0039d316-1c4b-4281-b951-d872f2087c98

TBR=svenpanne@chromium.org
BUG=34994
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11824059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111316
TEST=W3C SVG tests pass
R=marja@chromium.org
TBR=jam@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11828028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176068 0039d316-1c4b-4281-b951-d872f2087c98

Remove:
cc/copyfiles.py
webkit/compositor_bindings/copyfiles.py

These files were deleted in https://chromiumcodereview.appspot.com/11779006

TBR=torne@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11827048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176067 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds test cases for google_apis::GetAboutOperation.
Also, it naturally introduces the testing base code for the operations
communicating with a drive api server, so that it will be reused for unit tests
of other operation classes in drive_api_operations.{h,cc} later.

BUG=162155
TEST=Ran unit_tests


Review URL: https://chromiumcodereview.appspot.com/11824023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176066 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176065 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/11783080/
Review URL: https://codereview.chromium.org/11826040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176064 0039d316-1c4b-4281-b951-d872f2087c98

Pass TaskRunner to ResourceRequestBody::ResolveElementsAndCreateUploadDataStream and use it for file operations.

BUG=167524
TEST=net_unittests

Review URL: https://chromiumcodereview.appspot.com/11778016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176063 0039d316-1c4b-4281-b951-d872f2087c98

A Profile* can be passed to the constructor of DriveProtocolHandler and
the handler uses the given Profile* for processing the request.
This will help us adding unittests and introducting support for multiple profiles.
If the handler is constructed without Profile*,  it will use the profile from
ProfileManager::GetDefaultProfile().

BUG=167249
TEST=unittests. try opening a URL of 'drive://' (e.g. HTML file stored in Google Drive) on Chrome OS.


Review URL: https://chromiumcodereview.appspot.com/11785018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176062 0039d316-1c4b-4281-b951-d872f2087c98

The single thread proxy expects this to be true.

BUG=165399


Review URL: https://chromiumcodereview.appspot.com/11532009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176061 0039d316-1c4b-4281-b951-d872f2087c98

If the channel between a renderer and a plugin encounters an error, currently we display an infobar saying "<plugin_name> has crashed.".
This may cause confusion, because the plugin process may still be alive and no crash dump is generated in that case.

With this CL, we display a different prompt if the plugin process is still alive:
"<plugin_name> has encountered an error."

This CL only affects Windows.

TEST=None
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11820009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176060 0039d316-1c4b-4281-b951-d872f2087c98

../../testing/gtest/include/gtest/gtest-printers.h:169:42: error: ‘level’ may be used uninitialized in this function [-Werror=uninitialized]
../../chrome/browser/extensions/api/alarms/alarms_api_unittest.cc:280:32: note: ‘level’ was declared here

(introduced in http://crrev.com/176004)

TBR=jyasskin

Review URL: https://codereview.chromium.org/11823052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176059 0039d316-1c4b-4281-b951-d872f2087c98