GitLab

The Swiftshader component is 32-bit only and doesn't work there
(though it shouldn't really hurt to have it around).

Review-Url: https://codereview.chromium.org/2273703004
Cr-Commit-Position: refs/heads/master@{#414324}

BUG=639145
TEST=https://github.com/KhronosGroup/WebGL/pull/1982
R=kbr@chromium.org,tkent@chromium.org,haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2277603005
Cr-Commit-Position: refs/heads/master@{#414323}

BUG=314403

Review-Url: https://codereview.chromium.org/2278813002
Cr-Commit-Position: refs/heads/master@{#414322}

When there is no download item available, there should be a View telling
the user that the list is empty. Currently the download manger ui only
shows a blank screen if there are no items. This CL fixes this.

BUG=616324

Review-Url: https://codereview.chromium.org/2270233003
Cr-Commit-Position: refs/heads/master@{#414321}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/06af1137071d..956b570999cf

$ git log 06af11370..956b57099 --date=short --no-merges --format='%ad %ae %s'
2016-08-24 nednguyen [tracing] Fix implementation of TTI when new nav is detected
2016-08-24 benjhayden Migrate sampleMetric from ScalarNumeric to Histogram

BUG=630300

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2280473003
Cr-Commit-Position: refs/heads/master@{#414320}

BUG=638394

Review-Url: https://codereview.chromium.org/2274003002
Cr-Commit-Position: refs/heads/master@{#414319}

BUG=640734

Review-Url: https://codereview.chromium.org/2272863004
Cr-Commit-Position: refs/heads/master@{#414318}

When OfflinePageDownloadBridge is created, it will load all the
offline page items.
However, openItem() can get called before all page items are loaded.
This causes the native side unable to find the downloaded item.
As a result, nothing happens when user clicks offline page download
success notification.
This CL waits for all the page items to get loaded before calling
openItem().

BUG=640467

Review-Url: https://codereview.chromium.org/2272883004
Cr-Commit-Position: refs/heads/master@{#414317}

It's used in ConsoleView messages and UISourceCodeFrame messages.

BUG=none

Review-Url: https://codereview.chromium.org/2272193002
Cr-Commit-Position: refs/heads/master@{#414316}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

BUG=637812

Review-Url: https://codereview.chromium.org/2254173002
Cr-Commit-Position: refs/heads/master@{#414315}

MD History is not launching in M54, so we are disabling it until
after branch point.

BUG=425625

Review-Url: https://codereview.chromium.org/2271533005
Cr-Commit-Position: refs/heads/master@{#414314}

BUG=607425,517773

Review-Url: https://codereview.chromium.org/1925983002
Cr-Commit-Position: refs/heads/master@{#414313}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2254833003
Cr-Commit-Position: refs/heads/master@{#414312}

This reverts commit 693c002f.

This CL broke compilation of Chrome OS Debug:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/78413

BUG=
TBR=xiaoyinh@chromium.org
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2271223003
Cr-Commit-Position: refs/heads/master@{#414311}

Revert of Add POINTER_TYPE_ERASER to EventPointerType (patchset #5 id:80001 of https://codereview.chromium.org/2235933002/ )

Reason for revert:
Broke the build: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/45081/steps/compile/logs/stdio
../../ash/wm/stylus_metrics_recorder.cc:62:11: error: enumeration value 'POINTER_TYPE_ERASER' not handled in switch [-Werror,-Wswitch]

Original issue's description:
> Add POINTER_TYPE_ERASER to EventPointerType
>
> This pointer type can be used by graphics tablets, frequently the
> back-side of a stylus.
>
> BUG=636458
> TEST=Use rubber tool and watch generated mouse events.
>
> Committed: https://crrev.com/b90b789aea11dd97a7daa98bec8dd96d2f89f205
> Cr-Commit-Position: refs/heads/master@{#414146}

TBR=reveman@chromium.org,sadrul@chromium.org,spang@chromium.org,denniskempin@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636458

Review-Url: https://codereview.chromium.org/2278033003
Cr-Commit-Position: refs/heads/master@{#414310}

BUG=

Review-Url: https://codereview.chromium.org/2276183003
Cr-Commit-Position: refs/heads/master@{#414309}

This patch converts "editing/execCommand/4641880-2.html"
to use w3c test harness to simplify test script, and renames to
"indent_at_end_of_paragraph.html" to provide hint what this test script
verifies, for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2267363005
Cr-Commit-Position: refs/heads/master@{#414308}

As discussed in blink-dev@ (https://groups.google.com/a/chromium.org/d/topic/blink-dev/kk4VX0xRB7I/discussion)
and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion),
there is no reason we have to shut down the renderer gracefully.
It's just causing use-after-free bugs and wasting performance.
This CL removes a graceful shutdown sequence from TestingPlatformSupport.

BUG=639244

Review-Url: https://codereview.chromium.org/2279563003
Cr-Commit-Position: refs/heads/master@{#414307}

setSelectionRange(s, e) unexpectedly called the four-argument version of HTMLTextFormControlElement::setSelectionRange() with SelectionHasNoDirection.
So it set "none" direction without EditingBehavior check.

This CL renames the implementation function of web-exposed setSelectionRange() to
setSelectionRangeForBinding(), and makes its third argument optional so that
seSelectionRange(s, e) calls it.

On non-macOS platforms, two tests in textfieldselection-setSelectionRange.html
correctly fail.

BUG=640861

Review-Url: https://codereview.chromium.org/2274103002
Cr-Commit-Position: refs/heads/master@{#414306}

https://chromium.googlesource.com/skia.git/+log/168261287136..9d08cbc8c613

$ git log 168261287..9d08cbc8c --date=short --no-merges --format='%ad %ae %s'
2016-08-24 fmalita Experimental parsing expression grammar (PEG) template library
2016-08-24 bsalomon Update GrShape test to allow more flexible shape creation.
2016-08-24 mtklein GN: misc
2016-08-24 mtklein We can't infer the right type for voidp for old png_jmpbuf()
2016-08-24 halcanary SkPDF: set SK_SFNTLY_SUBSETTER uniformly

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bungeman@google.com

Review-Url: https://codereview.chromium.org/2277113002
Cr-Commit-Position: refs/heads/master@{#414305}

1. Number of “down” events generated by stylus/touch/mouse
2. Number of “down” events received by clamshell vs touchview

BUG=630070

Review-Url: https://codereview.chromium.org/2270173002
Cr-Commit-Position: refs/heads/master@{#414304}

We can remap modifier keys in Settings, but not Backspace or Escape;
this adds settings to remap those keys and handles them in EventRewriter.

BUG=608625
R=kpschoedel@chromium.org,stevenjb@chromium.org,sadrul@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2250473006
Cr-Commit-Position: refs/heads/master@{#414303}

A WorkerThreadableLoader::MainThreadLoaderHolder instance is created on the
main thread and its reference is sent to the worker thread. The current
implementation sends the reference after the loading starts (on the main
thread), but it's problematic because the loading may exit immediately and
hence it breaks WorkerThreadableLoader::WaitableEventWithTasks's assumption.

BUG=637980

Review-Url: https://codereview.chromium.org/2250203003
Cr-Commit-Position: refs/heads/master@{#414302}

This CL adds a check to isActiveAndVisible() so that
ScreenOrientationController::pageVisibilityChanged don't access frame()->host()
which is already null.

BUG=640719

Review-Url: https://codereview.chromium.org/2272043003
Cr-Commit-Position: refs/heads/master@{#414301}

BUG=591902
R=dpranke

Review-Url: https://codereview.chromium.org/2274743004
Cr-Commit-Position: refs/heads/master@{#414300}

ecosystem.atlassian.net:
Covered by atlassian.net

redbee.nl:
> We cannot support HTTPS on the following subdomains:
> • staging.schoolwijzer.redbee.nl - Customer staging environment, out of
> our control and just for testing purposes.

cerfrance.fr:
> We cannot support HTTPS on the following subdomains:
> • link.85.cerfrance.fr – use by a email marketing service (sarbacane)
> • link.cn.cerfrance.fr – use by a email marketing service (sarbacane)

spacecompute.com:
> I have no idea how this happened, since I never submitted the domain, but I
> would like to remove it because unfortunately it's breaking some services that
> integrate with google apps -- which it turns out do not play well with HTTPS
> requests.

ptsoft.de:
> We cannot support HTTPS on the following subdomains:
>
> • dm8000.ptsoft.de - Forwarding to internal server
> • config.ptsoft.de - Forwarding to internal server

everythingkitchens.com:
[15 subdomains] hosted on separate server than main domain

hilti.com, etc. (25 hilti.{eTLD} domains):
internal systems with same domain hilti.com do not all support https yet

souyidai.com:
> We cannot support HTTPS on the following subdomains:
> • mail.souyidai.com - cooperation with other company

nitho.me:
> I am afraid that it due to that blindly following online tutorial.

hovie.at:
> We cannot support HTTPS on the following subdomains:
>
> • andrew.hovie.at - I don't have to time to manage my own server
> anymore, so I switched to a hosting provider, wildcard certs are
> expensive, they do not support certs with multiple domains.
>
> Also, when I enabled preload, I did not actually know what I am doing,
> I was just following the recommendation from https://cipherli.st/.

constructdigital.net:
> We cannot support HTTPS on all sub-subdomains, since we don't have a wildcard
> SSL for them. Also, this domain is meant for development purpose and was
> configured as HSTS preload by mistake.

groovinads.com:
> We cannot support HTTPS on the following subdomains:
> • my.groovinads.com - Appnexus does not handshake over https, and it's killing us.
> • groovinads.com - same as above
> • *.groovinads.com

shamka.ru:
> We cannot support HTTPS on the following subdomains:
>
> • [water] - don’t have ssl cert.
> • [w] - not open 443 port
> • and many new subdomains

terravirtua.com:
> chalk it up to copy-pasting something without fully understanding what i was
> doing... i had added that after doing the ssl checker, following a
> recommendation about increasing the 'grade' it returned. i later removed it
> (the whole HSTS header) only to discover that everything continued to redirect
> to https... and finally realizing i was preloaded.

domainkauf.de:
> We support HTTPS in another way and so we have problems with the following
> subdomains:
> • mail.domainkauf.de HTTP Redirect to the main mailserver
> • imap /smtp / pop / pop3 / webmail with same reason

internl.net:
Uses uniquely generated domains per user with second-level subdomains, e.g. www.*.pa.internl.net; this can't be handled using wildcard certs.

rinobroer.nl:
No citable reason given.

sexton.uk.com:
> We cannot support HTTPS on the following subdomains:
>
> • mail.sexton.uk.com - costs for multiple SSL or SAN cert
> • webmail.sexton.uk.com - costs for multiple SSL or SAN cert

extracobanks.com:
> We cannot support HTTPS on the following subdomains:
>
> • Various internal subdomains - Although our external website,
> www.extracobanks.com, exclusively uses HTTPS, we also use extracobanks.com as
> our internal domain.  Having extracobanks.com on the HSTS preload list is
> causing problems for our employees connecting to internal sites, such as our
> internal CRM that uses a self-signed certificate.  Chrome and Firefox are
> giving "certificate authority invalid" errors when connecting to these
> internal subdomains.  We also have some non-HTTPS 3rd party vendor provided
> internal sites that cannot be changed to HTTPS that we cannot connect to at
> all.
>
> Our www.extracobanks.com site was built and is managed by a 3rd party
> Marketing firm.  I'm sure they added the HSTS header with the best intentions,
> but it is causing issues for us internally with our employees.

intramanager.co.uk/intramanager.dk:
> We cannot support HTTPS on the domain, since we changed our whole SSL setup
> and therefore do not support HTTPS on the intramanager.co.uk
> [/intramanager.dk] domain anymore.
>
> We have moved all activity to intramanager.com, where we have full HTTPS
> support.

thekelvinliu.com:
> I have a Tumblr blog at blog.thekelvinliu.com, which does not support https.

h-neef.de:
> We cannot support HTTPS on the whole Domain including subdomains, because we
> moved to a new IP Address and Need it for test purposes!

nathancheek.com:
> I never intended to be preloaded, nor to include subdomains, but I made the
> mistake of adding ‘preload’ and 'includeSubDomains’ to the HSTS header,
> without understanding what they entailed.

mercurystorm.co.za:
> I have moved from a Virtual Private Server to shared hosting, and can no
> longer use SSL certificates

klaxn.com:
> my client is not able to pay for a SSL certificate

postpi.com:
> self signed certificate

stupus.com:
> We cannot always support HTTPS on the all of our subdomains.
> ...
> I can no longer always support HTTPS on my domain because I change server
> distributions frequently.

upstox.com:
> We cannot support HTTPS on the following subdomain:
>
> help.upstox.com -> We are using this domain to point help.rksv.in with CNAME
> record and for rksv.in domain we don't have Wildcard SSL certificate so
> whenever we open help.upstox.com it goes to HTTPS in chrome.

TBR=palmer@chromium.org
BUG=527947

Review URL: https://codereview.chromium.org/2113813002 .

Cr-Commit-Position: refs/heads/master@{#414299}

This is a follow-up of Issue 2230713003.

BUG=629945, 640579

Review-Url: https://codereview.chromium.org/2273123003
Cr-Commit-Position: refs/heads/master@{#414298}

An external eglcontext may be current on android webview. GetCurrent() is better than eglGetCurrentContext() here.

BUG=

Review-Url: https://codereview.chromium.org/2276873002
Cr-Commit-Position: refs/heads/master@{#414297}

This adds a trace event that is logged every time the provisional
FirstMeaningfulPaint timestamp is updated.

Trace-based implementations can find FirstMeaningfulPaint for the page
load by looking for the last event in the trace.

BUG=638124
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2276573003
Cr-Commit-Position: refs/heads/master@{#414296}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d09641f4..b4f9789f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2274363002
Cr-Commit-Position: refs/heads/master@{#414295}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/355a52109ec78c1bda63274fadaa2f83462b604d Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/38954ea2aea645d40d933ec08fa9300978745851 Make syzygy recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/e10345ca9ae54bb82c86679d2e107dabb92a04bc Make v8 recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/1841f028ff591483facb7ada955e1e6eb942f343 Make dart recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/4fe7d03aee971b7daadc70b69dcf0f43eb1a59a5 Add stip@ to chromium.py OWNERS. (stip@chromium.org)
  https://crrev.com/32a901e0ee458a3b063f995ab461d38096ba80fd Make iOS recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/6ae64c302a5ae3bfc0df6d520b4945dfbd05c9ec Make android recipes explicitly set GIT_MODE (agable@chromium.org)
  https://crrev.com/6679485ce287924084b369b20fab59c1f6ef8122 Enable swarming for iOS try bots (smut@google.com)
depot_tools:
  https://crrev.com/f14eaff8148de420c63c87bd67678bf86837641a Remove --base_url from git cl and upload.py (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=598405,638750,640251

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2274173004
Cr-Commit-Position: refs/heads/master@{#414294}

BUG=

Review-Url: https://codereview.chromium.org/2275163002
Cr-Commit-Position: refs/heads/master@{#414293}

We set compositor view background to white while there are no
frames and onSwapBufferCompleted swap it back to null. On N
this creates a black flash on some cold starts where there is
still a frame that is drawn before the frame is actually completed.

BUG=640758

Review-Url: https://codereview.chromium.org/2271393003
Cr-Commit-Position: refs/heads/master@{#414292}

External Clear Key should be an external "Clear Key" key system which
behaves the same as "Clear Key" but is hosted externally (e.g. in a
separate process). It could support decrypt-and-decode by incorporating
codecs, or only support decrypt-only (same as default Clear Key
implementation in Chromium).

This will help us enable External Clear Key tests on multiple platforms,
e.g. on Android.

To do this, we need to move non-standard "Clear Key" features out of
the default External Clear Key test. This CL moves "renewal" test to a
new key system name: org.chromium.externalclearkey.renewal.

BUG=581893
TEST=This CL splits a curent test into two tests.

Review-Url: https://codereview.chromium.org/2267283002
Cr-Commit-Position: refs/heads/master@{#414291}

This is another step toward eliminating ash::Shelf.

* Move code that needs ShelfView into ShelfWidget to avoid exposing ShelfView
* Remove dead code (especially shelf_navigator.*)
* Make icon activation functions static

BUG=615502
TEST=ash_unittests, browser_tests

Review-Url: https://codereview.chromium.org/2274333002
Cr-Commit-Position: refs/heads/master@{#414290}

Makes the collapsing card position: absolute (instead of fixed).  Anchoring
it to the section makes it actually follow the section, so it always moves
toward the right position even if the containter's scroll/height/size changes.
Should reduce jarring jumps at the end of transitions.

Also moves the style changes into Web Animations instead of inline. This makes
the animations fire-and-forget. Transition clean up is largely automatic, there
are no styles to (forget to) remove (at the wrong time). If a transition is
buggy, we're still likely to end up in the right place.

This fixes several animation bugs (but likely introduces new ones).

BUG=589681, 621245, 622172
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2230123002
Cr-Commit-Position: refs/heads/master@{#414289}

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2268993003
Cr-Commit-Position: refs/heads/master@{#414288}

Cr-Commit-Position: refs/heads/master@{#414287}

There are several comments and FIXMEs about concern about NULL
unescaping.

The FIXMEs have been there since the commit for upstreaming
KURLGoogle.cpp which is
http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708.

But the commit
http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already
removed the special care for NULL character. The internal bug b/1350291
was just mentioning WebKit bug 20559.

We still have a warning comment about brettw@'s concern in KURL.h, so,
clean up the others.

As a bonus, this CL adds a test to check that the method decodes UTF-8.

R=brettw
BUG=none

Review-Url: https://codereview.chromium.org/2270373002
Cr-Commit-Position: refs/heads/master@{#414286}

Previously VideoRendererImpl waited for the VideoFrameStream::Reset() to
complete before invalidating its frame callback weak pointers, which
meant that it could receive frames that it didn't want between Flush()
and OnVideoFrameStreamResetDone(). For simplicity, now the weak pointers
are invalidated at the same time that Reset() is called, so it's
guaranteed that no frames will be received after Flush().

Also included in this change is reordering the deletion of the video
frame queue and resetting of the VideoFrameStream to save VDAs doing
wasted work.

BUG=640800

Review-Url: https://codereview.chromium.org/2273033003
Cr-Commit-Position: refs/heads/master@{#414285}