GitLab

Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination.

Wire this into all the existing callers.

Add a new child process watcher in chrome to be notified on child process crashes. This will confirm whether users with RESULT_CODE_INVALID_SANDBOX_STATE are crashing on background start (--no-startup-window) or not. This also adds required framework to paint a sad tab UI from this class in the future.

BUG=472324, 453541
TEST=Apply patch in http://pastebin.com/uEDxngBa and verify histogram ChildProcess.InvalidSandboxStateCrash.NoStartupWindow is recorded.

Review URL: https://codereview.chromium.org/1067733006

Cr-Commit-Position: refs/heads/master@{#327380}

Since base builds for both host and target so much ewt_manifest.
Without this gyp will fail when GYP_CROSSCOMPILE=1 and target_arch=arm:
gyp: Dependency 'S:\src\base\trace_event\etw_manifest\etw_manifest.gyp:etw_manifest#host' not found while trying to load target S:\src\base\base.gyp:base#host

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk
BUG=none

Review URL: https://codereview.chromium.org/1103943002

Cr-Commit-Position: refs/heads/master@{#327379}

This also makes the Note at the top of the files (to keep the GYP and
GN files in sync) a bit more noticeable.

BUG=

Review URL: https://codereview.chromium.org/1116463002

Cr-Commit-Position: refs/heads/master@{#327378}

The android implementation already uses the GOOD quality, rather than FAST.

This positively affects the quality of the thumbnails shown on the New Tab Page.

Description of GOOD, from code comments:
Bilinear upscale + N * 50% bilinear downscales.
This is still fast enough for most purposes and
Image quality is nearly as good as the BEST option.

BUG=481978

Review URL: https://codereview.chromium.org/1115433002

Cr-Commit-Position: refs/heads/master@{#327377}

BUG=460512

Review URL: https://codereview.chromium.org/1110263002

Cr-Commit-Position: refs/heads/master@{#327376}

WildcardLoginChecker and UserCloudPolicyManagerChromeOS now use this mechanism to fetch policy.

BUG=478432,470984,462036,480447
TEST=manual

Review URL: https://codereview.chromium.org/1108983002

Cr-Commit-Position: refs/heads/master@{#327375}

Fixes some

  [chromium-style] WeakPtrFactory members which refer to their outer class must
  be the last member in the outer class definition.

warnings and also makes the code more correct.

BUG=303818,467287

Review URL: https://codereview.chromium.org/1107353003

Cr-Commit-Position: refs/heads/master@{#327374}

BUG=482112

Review URL: https://codereview.chromium.org/1112693002

Cr-Commit-Position: refs/heads/master@{#327373}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3862020..a73239a

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1107363003

Cr-Commit-Position: refs/heads/master@{#327372}

The origin can be determined from the live ServiceWorkerRegistration,
use that instead of requiring the renderer to pass it.

Also, verify that the live registration is active to prevent
BackgroundSyncManager::Register from being called prematurely.

BUG=482012

Review URL: https://codereview.chromium.org/1110993003

Cr-Commit-Position: refs/heads/master@{#327371}

Build break: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/5072
Relevant CL: https://codereview.chromium.org/1112573003

BUG=NONE
TEST=Building components/html_viewer:tests passes.
R=sky@chromium.org
TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1108973004

Cr-Commit-Position: refs/heads/master@{#327370}

These will be added back once the cause of the crashes is fixed.

BUG=471599
R=adamk@chromium.org

Review URL: https://codereview.chromium.org/1114653002

Cr-Commit-Position: refs/heads/master@{#327369}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b9db944..a832422

TBR=pdr@chromium.org,caseq@chromium.org

Review URL: https://codereview.chromium.org/1109223002

Cr-Commit-Position: refs/heads/master@{#327368}

BrowserActionsBarRedesignBrowserTest.OverflowedBrowserActionPopupTest is
flaky on Mac bots. Disabling while investigating.

Review URL: https://codereview.chromium.org/1112603004

Cr-Commit-Position: refs/heads/master@{#327367}

Also fix initialization of weak_ptr_ which I had unintentionally broken in
https://codereview.chromium.org/1103713003

BUG=303818, 467287

Review URL: https://codereview.chromium.org/1111903002

Cr-Commit-Position: refs/heads/master@{#327366}

PermissionBubbleCocoa::CanAcceptRequestUpdate controls request
coalescing. This change allows requests to be added to an existing
permission bubble unless the user has moused over the bubble.

BUG=452931

Review URL: https://codereview.chromium.org/895363007

Cr-Commit-Position: refs/heads/master@{#327365}

BUG=481231
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1110243003

Cr-Commit-Position: refs/heads/master@{#327364}

MessageLoopProxy is deprecated.
This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045

Review URL: https://codereview.chromium.org/1103343003

Cr-Commit-Position: refs/heads/master@{#327363}

With the 'enter' rule, we can simplify the output of list-like roles. Namely, ChromeVox can generalize its treatment of saying, x role with y items for a variety of roles.

BUG=481583
TEST=chromevox_tests --gtest_filter=OutputE2ETest.*

Review URL: https://codereview.chromium.org/1109983003

Cr-Commit-Position: refs/heads/master@{#327362}

Exclude the mandoline target on android for now (no main).
Rename the test targets to avoid naming conflicts...
(android GN targets doesn't seem to respect output_name)
Update the namespace for mojo::util::FilePathToFileURL call.

See initial breakage at http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/384

The relevant CLs are:
  https://codereview.chromium.org/1109993002
  https://codereview.chromium.org/1091513005

BUG=466129
TEST=Building mojo and mandoline for android passes.
R=sky@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/1115463002

Cr-Commit-Position: refs/heads/master@{#327361}

With the removal using the DataReductionProxyService class to perform the secure proxy check, there is no longer a need to post tasks to the UI thread.

This effectively makes DataReductionProxyConfig an IO thread only class, and does not need to have pointers to task runners.

BUG=472290

Review URL: https://codereview.chromium.org/1052583005

Cr-Commit-Position: refs/heads/master@{#327360}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/50cb76b..3862020

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=humper@google.com

Review URL: https://codereview.chromium.org/1110153003

Cr-Commit-Position: refs/heads/master@{#327359}

Timing for creating chrome_apk/classes.dex:

No flag:
real    0m10.767s
user    0m16.480s
sys     0m0.444s

--num-threads=4
real    0m7.450s
user    0m11.837s
sys     0m0.606s

--num-threads=10 (or 20, or 80)
real    0m5.399s
user    0m9.266s
sys     0m0.420s

Timings performed on a z620 workstation.

BUG=

Review URL: https://codereview.chromium.org/1109193002

Cr-Commit-Position: refs/heads/master@{#327358}

Previously, the proxy pref would not be cleared during migration if the
proxy pref was set to a Data Reduction Proxy that didn't match a
currently configured DRP, e.g. if the pref was for
"proxy.googlezip.net", but the configured DRP is
"proxy-dev.googlezip.net".

This change causes Chrome to clear the proxy pref if it contains any
proxy with a host ending with ".googlezip.net".

BUG=476610

Review URL: https://codereview.chromium.org/1104413003

Cr-Commit-Position: refs/heads/master@{#327357}

Too many crashes and out of ideas for how to resolve this for right
now; this at least provides the chance that these users might unhang
themselves some time after the 2 minute hang timer.

BUG=422522, 468074, 478932
TEST=start w/ and w/o hang monitor according to channel, flags.

Review URL: https://codereview.chromium.org/1105083004

Cr-Commit-Position: refs/heads/master@{#327356}

Published to the web store now to get updated translations.
No other changes.

BUG=none
NOTRY=true
TBR=dtseng@chromium.org

Review URL: https://codereview.chromium.org/1109203003

Cr-Commit-Position: refs/heads/master@{#327355}

temporarily to measure its impact on battery.

Will be measuring its impact in the following dashboard.

https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-mac9&tests=power.top_25%2Fidle_wakeups_total&checked=idle_wakeups_total%2Cref

R=asvitkine@chromium.org
BUG=426203

Review URL: https://codereview.chromium.org/1102333004

Cr-Commit-Position: refs/heads/master@{#327354}

BUG=481955

Review URL: https://codereview.chromium.org/1114503003

Cr-Commit-Position: refs/heads/master@{#327353}

BUG=477690
R=skyostil@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/1112573003

Cr-Commit-Position: refs/heads/master@{#327352}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e68c882..b9db944

TBR=pdr@chromium.org,caseq@chromium.org

Review URL: https://codereview.chromium.org/1108823005

Cr-Commit-Position: refs/heads/master@{#327351}

BUG=456354

Review URL: https://codereview.chromium.org/1113463003

Cr-Commit-Position: refs/heads/master@{#327350}

BUG=480762

Review URL: https://codereview.chromium.org/1105743003

Cr-Commit-Position: refs/heads/master@{#327349}

We seem to have gathered enough data to find out debug further cause/reason for calling CloseHandle on already closed/invalid handle.
There are couple of theories which need to be investigated further like policy ownership of TargetProcess and thread watching for JOB_OBJECT_MSG_ACTIVE_PROCESS_ZERO.
CHECK seem to have introduced with CL https://codereview.chromium.org/1045513004

BUG=480639
R=cpu@chromium.org,grt@chromium.org

Review URL: https://codereview.chromium.org/1108953003

Cr-Commit-Position: refs/heads/master@{#327348}

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1112603003

Cr-Commit-Position: refs/heads/master@{#327347}

MessageLoopProxy is deprecated.
This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045

Review URL: https://codereview.chromium.org/1111673003

Cr-Commit-Position: refs/heads/master@{#327346}

This would make the widget container code independent of the
chrome APIs
available/used by the extension embedding the widget.

TEST=Verified installing file handlers and file system providers works
BUG=477106

Review URL: https://codereview.chromium.org/1091943002

Cr-Commit-Position: refs/heads/master@{#327345}

ERROR Dependency cycle:
  //gpu/command_buffer/service:service_sources ->
  //gpu/config:config_sources ->
  //gpu/command_buffer/service:service_sources

The problem was that gpu/command_buffer/service already include from
gpu/config, but gpu/config were also including from
gpu/command_buffer/service for gpu_switches.h, creating the above
dependency cycle.

By moving the required switch down to gpu/config, we broke this
dependency cycle.

With that 'gn check' passes for gpu/config with the following command
lines:

$ gn gen out-gn/Debug
$ gn check out-gn/Debug //gpu/config/*

gpu/command_buffer/service needs more work to pass 'gn check' though.

BUG=367595,376000
TEST=see above
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/1103403002

Cr-Commit-Position: refs/heads/master@{#327344}

GCD App needs to query devices for basic information.

BUG=brillo:839

Review URL: https://codereview.chromium.org/1106183006

Cr-Commit-Position: refs/heads/master@{#327343}

This histogram tracks the time-weighted memory use incurred by SDCH
dictionaries. This histogram is measured in units of byte-seconds per
second.

BUG=465873

Review URL: https://codereview.chromium.org/1051353003

Cr-Commit-Position: refs/heads/master@{#327342}

Now ScopedPtrHashMap expect the 2nd parameter is scoped_ptr<T>. For example, old usage
ScopedPtrHashMap<int, Value>
new usage
ScopedPtrHashMap<int, scoped_ptr<Value>>

With this change, ScopedPtrHashMap support scoped_ptr's custom deleter.

R=danakj@chromium.org, tzik@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1099383002

Cr-Commit-Position: refs/heads/master@{#327341}