- 26 Feb, 2019 40 commits
-
-
Daniel Nicoara authored
Move the zcr_stylus interface into its own files. This change only moves code around, no functional changes. Bug: 896710 Test: Build and run exo_unittests Change-Id: I42e70263a607f6a835199b9be46093b6e0b1af35 Reviewed-on: https://chromium-review.googlesource.com/c/1481719 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#635525}
-
Guido Urdaneta authored
Video constraints processing currently uses content mojo types. As part of the Onion Soup project, We plan to move MediaStream video interfaces to Blink. This requires moving video constraints processing, but the dependency on the content mojo type prevents the move to Blink, since only Blink bindings of Mojo types are allowed. This CL introduces an intermediate type for VideoInputDeviceCapabilities with the same fields as the Mojo type, and which can be easily replaced by the Blink mojo type once the dependent code is migrated to Blink. Bug: 921006 Change-Id: I418490f630a2dc13245f24d0c96edb41c2332571 Reviewed-on: https://chromium-review.googlesource.com/c/1448190 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#635524}
-
Michael van Ouwerkerk authored
When we use -1 it will crash. Bug: 924118 Change-Id: I04b0aedb7ff107364206b14d8cbe591b8fb4e8fd Reviewed-on: https://chromium-review.googlesource.com/c/1488930Reviewed-by:
Anna Malova <amalova@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635523}
-
Daniel Bratell authored
The two cookie managers in restricted_cookie_manager.cc and cookie_manager.cc need some shared functionality and rather than having a duplicate set of helper functions (of which one clashed in some jumbo builds and cause build breakage), move the shared helper functions to a new file cookie_managers_shared.cc. Bug: 729800 Change-Id: I1839bd04e96471569b1b8a53bf1921f182b8bff4 Reviewed-on: https://chromium-review.googlesource.com/c/1482974Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#635522}
-
Kevin Bailey authored
Add initial Welsh dictionary to spellcheck list. Bug: 692242 Change-Id: Ic9f0d030170ef62af2aa10ba422585659c7c7359 Reviewed-on: https://chromium-review.googlesource.com/c/1477341Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635521}
-
Clemens Arbesser authored
In an ongoing effort to integrate the PR into the autofill assistant, this CL creates an AA-specific subclass of PaymentRequestSection with customized text appearance and paddings. This is only a temporary low-effort measure for M-74. It does not change the appearance of the regular Chrome PR in any way. Collapsed before: https://screenshot.googleplex.com/WtXwMsTWGmu.png Collapsed after: https://screenshot.googleplex.com/Wd26Ge9k16Z.png Expanded contact, before: https://screenshot.googleplex.com/V2WC8UNtx1b.png Expanded contact, after: https://screenshot.googleplex.com/YGGX82yxJuv.png Expanded payment, before: https://screenshot.googleplex.com/1fGLNaprkfC.png Expanded payment, after: https://screenshot.googleplex.com/L7iVQzNoqda.png Bug: 806868 Change-Id: If30e46cac77c1d38096f6f5c2cc71d093c896631 Reviewed-on: https://chromium-review.googlesource.com/c/1488878Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
Move the zcr_alpha_compositing interface into its own files. This change only moves code around, no functional changes. Bug: 896710 Test: Build and run exo_unittests Change-Id: I6b576d9e686c8634dfa2a30c3718f9068628a9ea Reviewed-on: https://chromium-review.googlesource.com/c/1481733 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
-
Nico Weber authored
This seems to work after https://chromium-review.googlesource.com/c/chromium/src/+/1483332 Bug: 926235 Change-Id: I5a73ea6bf72a095be9222599b35b9544cfca3c73 Reviewed-on: https://chromium-review.googlesource.com/c/1486714 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635518}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7fb544c58018..9061ec504ae9 Created with: gclient setdep -r src-internal@9061ec504ae9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If3cbe4b8bb1ca92173a9bbbdb0b6656edd5f1760 Reviewed-on: https://chromium-review.googlesource.com/c/1489052Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635517}
-
Tibor Goldschwendt authored
Bug: 934381 Change-Id: Ia87d3743eb0634d6a16c476a40bfb07acceb26d9 Reviewed-on: https://chromium-review.googlesource.com/c/1480720 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#635516}
-
Elly Fong-Jones authored
This flag controls a feature that has been on by default for nearly a decade now. Bug: 935978 Change-Id: I506194c49389df0c4d59096f1b2c14d8ca6eee9f Reviewed-on: https://chromium-review.googlesource.com/c/1489131 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#635515}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a4b0cda0fc1b..9e170c9530bd git log a4b0cda0fc1b..9e170c9530bd --date=short --no-merges --format='%ad %ae %s' 2019-02-26 perezju@chromium.org [Telemetry] Disable flaky ActionRunnerTest.testScrollToElement on mac Created with: gclient setdep -r src/third_party/catapult@9e170c9530bd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:934649 TBR=sullivan@chromium.org Change-Id: I39e515b5dae3db52dd50bfde273dc4b14ebaab25 Reviewed-on: https://chromium-review.googlesource.com/c/1489055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635514}
-
Nico Weber authored
This is a reland of 5e12be67 dawn's build files are now fixed, so enable it for debug builds too. Original change's description: > Enable -Wextra-semi in mac release builds that have dcheck_always_on set. > > Bug: 926235 > Change-Id: I32c7a9f15f1f544caaceef28b0d34ebd643aa35d > Reviewed-on: https://chromium-review.googlesource.com/c/1486880 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635214} Bug: 926235,935704 Change-Id: I488db4451a0751d59bb8057194ddcab0b3ea8ebf Reviewed-on: https://chromium-review.googlesource.com/c/1488012 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#635513}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16ff21788126..38fb70186109 git log 16ff21788126..38fb70186109 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 lalitm@google.com trace_processor: handle binder transactions Created with: gclient setdep -r src/third_party/perfetto@38fb70186109 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I37859ae1c3f5c14886d83c285ff39f9852e52319 Reviewed-on: https://chromium-review.googlesource.com/c/1489054Reviewed-by:
-
Juan Antonio Navarro Perez authored
Before: https://chromium.googlesource.com/chromium/src/+/1b3ecdcb0ed69b5791d371a49fdef4aa95818f48/docs/speed/README.md After: https://chromium.googlesource.com/chromium/src/+/refs/changes/88/1488888/1/docs/speed/README.md Change-Id: I56bccdd951911ff40d22f705d05ff4cf9121d555 Reviewed-on: https://chromium-review.googlesource.com/c/1488888 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#635511}
-
Egor Pasko authored
This reverts commit 54c5c662. Reason for revert: http://crbug.com/935973, apk merging fails with: ApkMergeFailure: Files don't match expectations: unexpected files: set(['libcrashpad_handler_trampoline.so']) Original change's description: > android: Launch Crashpad with /system/bin/linker on Q > > This adds a small executable, libcrashpad_handler_trampoline.so, to > Monochrome, Trichrome, and SystemWebView. The trampoline loads the > remaining Crashpad handler code from the main native library, which > must export `CrashpadHandlerMain()`. > > All three packages will continue to use /system/bin/app_process to > launch Crashpad on P-. > > Note on static_initializers.gni: > > There aren't any real, new static initializers. The increased count is > due to the addition of the new object. Static initializers are counted > by measuring the size of each object's .init_array and dividing by the > object's pointer size. libcrashpad_handler_trampoline.so has two > invalid slots which are ignored by the loader: > > readelf -x .init_array libcrashpad_handler_trampoline.so > > Hex dump of section '.init_array': > 0x00001008 ffffffff 00000000 > > Bug: 928422 > Change-Id: Iba56cd6feda73ebc91f6758724d823e48b5c6e8f > Reviewed-on: https://chromium-review.googlesource.com/c/1454078 > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Joshua Peraza <jperaza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635269} TBR=torne@chromium.org,agrieve@chromium.org,jperaza@chromium.org,mark@chromium.org Change-Id: If4048a343ab12dd0b5af6747b2633de79db5ddd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 928422 Reviewed-on: https://chromium-review.googlesource.com/c/1489193Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#635510}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/346e10e8ae1a..8abc84294571 git log 346e10e8ae1a..8abc84294571 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 kjlubick@google.com [pathkit] fix perf Created with: gclient setdep -r src/third_party/skia@8abc84294571 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I1733e5a50887c2f582fb463d569372f0f80774ee Reviewed-on: https://chromium-review.googlesource.com/c/1489051Reviewed-by:
-
Maksim Ivanov authored
Add unit tests for the implementation that is triggered by the extensions API when an extension opens a message channel for sending UI messages to the diagnosticsd daemon. BUG=chromium:910561,b:123925995 TEST=new unit tests: DiagnosticsdMessagingTest Change-Id: If49bcc3c0b63135acf47337c263943854cabbc80 Reviewed-on: https://chromium-review.googlesource.com/c/1475187 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#635508}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b02792b9. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" 68d5240e "[ChromeDriver] Set key modifiers with mouse actions" 359fd7da "[PE] Fix rendering issue with effect escaping in pre-CompositeAfterPaint" 3685447d "[WPT] Move subresource_path from generator to referrer-policy-test-case.js" 4ea68472 "Creates an ICE transport object at DTLS transport initialization." 32a115f8 "[css-flexbox] ChildIntrinsicLogicalWidth needs to constrain by min/max" ec3bf6e6 "Fix class_white-space_[normal|pre-line]_wrapped.html wpt/webvtt tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I005ab3d20fa8d2476e834f1edf9235869c5156c0 Reviewed-on: https://chromium-review.googlesource.com/c/1488951Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635507}
-
Bo Liu authored
Change-Id: Ifef2a2d74500159096fe29763d64dca2647f18fd Reviewed-on: https://chromium-review.googlesource.com/c/1488023Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635506}
-
Henrique Ferreiro authored
Replace uses of OverscrollBehavior from third_party/blink/renderer/platform/overscroll_behavior.h with the original type from cc/input/overscroll_behavior.h. This is part of a series of CLs to remove platform/scroll. Bug: 922111 Change-Id: I9f1d9dc8d6937c8eaee36c5bb272d30f2fe5bd2a Reviewed-on: https://chromium-review.googlesource.com/c/1488918Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#635505}
-
Elly Fong-Jones authored
This is part 1 of https://chromium-review.googlesource.com/c/chromium/src/+/1488032 TBR=thakis@chromium.org Bug: 897809 Change-Id: Ifb3291b69bbebaf862f022d45b33a206f705313d Reviewed-on: https://chromium-review.googlesource.com/c/1489091Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635504}
-
Jérôme Lebel authored
Manage sync settings coordinator should listen to onPrimaryAccountCleared: notification. When the user is signed out, the Manage sync settings should be pop out, to come back to Google services settings. Bug: 914059 Change-Id: If08580a0dfe2cb2d94bad4e0276a5b3e3ef7c31c Reviewed-on: https://chromium-review.googlesource.com/c/1482952 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#635503}
-
Bo Liu authored
No DEPS file this time to prevent importing browser since there are actually two violations. Change-Id: Id62a279009965101ee4c417c10dd09e6c93b9e18 Reviewed-on: https://chromium-review.googlesource.com/c/1487141Reviewed-by:
-
Bo Liu authored
Mostly so that gn file can be modified without higher layer changes. Change-Id: I584f84b6356547fc8090c10cc9ab5d3facad2546 Reviewed-on: https://chromium-review.googlesource.com/c/1488016Reviewed-by:
-
Oleg Davydov authored
Add log message (on VLOG(2) level) for each extension which should be installed by policy, but appears not to be installed five minutes after policy update/login. We need this to investigate bug 917700, bug 904600 and other similar ones. Bug: 917700 Bug: 904600 Change-Id: I86a8e6b33c35b3ce83e06a30620e674faaee7f0c Reviewed-on: https://chromium-review.googlesource.com/c/1484095 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#635500}
-
Miyoung Shin authored
- unsigned short -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I070c42d5ce35c95b14759d86bf31c9167c5c29ec Reviewed-on: https://chromium-review.googlesource.com/c/1488404Reviewed-by:
-
Clemens Arbesser authored
This corresponds to the backend change cr/234129718. Bug: 806868 Change-Id: Id2ad7c8b60599ed0eef53018ec0a52fc1d367f29 Reviewed-on: https://chromium-review.googlesource.com/c/1477116 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Alex Clarke authored
Long delay canceled tasks can really pile up if we don't activly remove them. We already do that in the renderer but we need to bring this technology to other SequenceMangers. Bug: 863341 Change-Id: Ie16674043028090f94c184c02acbef6efcf3471b Reviewed-on: https://chromium-review.googlesource.com/c/1483076 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#635497}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/83af02a24a8e..a4b0cda0fc1b git log 83af02a24a8e..a4b0cda0fc1b --date=short --no-merges --format='%ad %ae %s' 2019-02-26 khokhlov@google.com Reland "Replace CustomizeBrowserOptions() with CustomizeOptions() step 1" Created with: gclient setdep -r src/third_party/catapult@a4b0cda0fc1b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:8888888801528 TBR=sullivan@chromium.org Change-Id: Ic00ae326d3c93c3ba97e25cd9c7e3eda30f23ef5 Reviewed-on: https://chromium-review.googlesource.com/c/1488414Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ebeca2a9eb81..16ff21788126 git log ebeca2a9eb81..16ff21788126 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 lalitm@google.com trace_processor: ui: remove cpu from window table and all throughout Created with: gclient setdep -r src/third_party/perfetto@16ff21788126 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id7d03ee64b477186ec7b77d0f0f4798cdb3c2c61 Reviewed-on: https://chromium-review.googlesource.com/c/1488506Reviewed-by:
-
Maksim Ivanov authored
Add pre-defined native messaging destination that allows whitelisted extensions to send messages to the diagnostics_processor daemon (via the diagnosticsd daemon) and receive the responses back. The extension should use either chrome.runtime.sendNativeMessage or chrome.runtime.connectNative with the 'com.google.wilco_dtc' application in order to use this message pipe. The hardcoded whitelist for accessing this message pipe is currently empty - it will have to be updated once we figure out extension IDs that we'll use. BUG=chromium:907932,b:123926112 TEST=manual Change-Id: I9083dd87346b490cb43ca8aabd2f7534245215e2 Reviewed-on: https://chromium-review.googlesource.com/c/1463442Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Kush Sinha authored
Chrome OS Account Manager's clients relied on |AccountTrackerService| to map |AccountManager::AccountKey| to other representations (namely raw email and canonical email). Due to the relation between one such client, |ChromeOSOAuth2TokenServiceDelegate|, and |AccountTrackerService|, it was required that |AccountTrackerService| should be able to store account mappings for which a refresh token was not yet known. This usage model is no longer supported. See the attached bug for context. Fix this by adding a |raw_email| field in Chrome OS Account Manager's Account proto definition. Future patches will change clients to read this value. Bug: 925827 Test: chromeos_unittests --gtest_filter="*AccountManager*Test*" Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Change-Id: I76ef741ec0a9ea38ae8757ff234c8be6dd7a3155 Reviewed-on: https://chromium-review.googlesource.com/c/1452003Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#635493}
-
Henrique Ferreiro authored
identity_get_auth_token_function.cc uses a mix of C++ and Mojo code. This CL ports GetAccessToken() to C++. Bug: 913853 Change-Id: I71ffbc6944dff0a886d57a4d8b10cb0fa334390b Reviewed-on: https://chromium-review.googlesource.com/c/1458300 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#635492}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/modules/webaudio have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of ProcessorCreationParams and SharedAudioBuffer classes, they make sense to use USING_FAST_MALLOC because they have been used as member variables with smart pointers. Bug: 919389 Change-Id: I415dc3360abcadff5d2b3ce25035d09d674c2720 Reviewed-on: https://chromium-review.googlesource.com/c/1488399Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3812fa949a49..e2da93130748 git log 3812fa949a49..e2da93130748 --date=short --no-merges --format='%ad %ae %s' 2019-02-26 kwiberg@webrtc.org Remove a leftover audio codec poison immutinty declaration 2019-02-26 asapersson@webrtc.org Add option to inject YuvConverter to SurfaceTextureHelper. 2019-02-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a55c7bb9..15651144 (635189:635345) 2019-02-26 kwiberg@webrtc.org Ban absl::StrSplit and absl::StrJoin 2019-02-25 thakis@chromium.org Fix -Wextra-semi warnings in webrtc fuzzers. 2019-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 81fda909..a55c7bb9 (635067:635189) 2019-02-25 amithi@webrtc.org Wiring up RIDs from the video engine to the RTP Sender. 2019-02-25 shampson@webrtc.org Fixing webrtc::IceTransportState. 2019-02-25 sakal@webrtc.org Revert "Remove VCMEncoderDataBase and put remaining code into VideoStreamEncoder" 2019-02-25 eladalon@webrtc.org Connect LossNotificationController to RtpRtcp 2019-02-25 srte@webrtc.org Avoids PostTask to repost a repeated task. 2019-02-25 mbonadei@webrtc.org Adding possibility to save an RTCEventLog of the call. 2019-02-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 95a23eca..81fda909 (634895:635067) 2019-02-25 srte@webrtc.org Reland "Adds resource path support for video files in scenario tests." 2019-02-25 sprang@webrtc.org Remove VCMEncoderDataBase and put remaining code into VideoStreamEncoder 2019-02-25 srte@webrtc.org Adds CoDel implementation to network simulation. 2019-02-25 srte@webrtc.org Stop using special RTT value for DelayBasedBwe. 2019-02-25 kuddai@google.com Delay bug during audio receiver stream recreation. 2019-02-25 mbonadei@webrtc.org Fix -Wextra-semi warnings. Created with: gclient setdep -r src/third_party/webrtc@e2da93130748 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:None,chromium:none,chromium:935572,chromium:None,chromium:933802,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0a2dcd1ba6947c1ca8f49070855c2b9f8c45530 Reviewed-on: https://chromium-review.googlesource.com/c/1488504Reviewed-by:
-
Nick Diego Yamane authored
This CL is intended to make the Wayland data device initialization more robust, removing the assumption that data device manager global object is advertised before the wl_seat. Additionally this patch does a minor code cleanup in WaylandDataDeviceManager, removing the WaylandConnection setter, injecting connection instance via its constructor instead, as it is already being done in other classes, such as WaylandDataSource, for example. Bug: 578890 Change-Id: Ia700c164f18b2778b08047bfcb5ccf382e69328f Reviewed-on: https://chromium-review.googlesource.com/c/1487853Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Nick Diego Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#635489}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/565a6950b6fe..7fb544c58018 Created with: gclient setdep -r src-internal@7fb544c58018 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I41aa1b6383e5b7472b80f1c51b45f0b6d22a2c10 Reviewed-on: https://chromium-review.googlesource.com/c/1488413Reviewed-by:
-
Yi Su authored
The limitation of displaying at most 2 rows of MostVisistedCells in NTP ContentSuggestionsCollectionView should be removed to support Dynamic Type. Bug: 893523 Change-Id: Ie22bc59b9149e154053bbf05e63e68ba0b850e99 Reviewed-on: https://chromium-review.googlesource.com/c/1482978 Auto-Submit: Yi Su <mrsuyi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Colin Blundell authored
In identity_apitest.cc, there is a test that verifies that when the primary account is cleared, the chrome.identity.onSignInChanged event is fired. This event is fired when a refresh token is added/removed for a given account. However, when DICE is enabled, clearing the primary account does not result in its refresh token being removed (and hence does not cause this event to fire). This CL updates this test to short-circuit out if DICE is enabled. Note that a different existing test already verifies that an event is fired when the refresh token of the primary account is removed. This CL is concretely necessary to unblock the elimination of FakeSigninManager. When FakeSigninManager is eliminated, this test (and others) will use a SigninManager instance that has been configured with the account consistency mode passed by SigninManagerFactory, rather than the account consistency mode being hardcoded to disabled. Once the test is using SigninManager, we will update it to check that the event is *not* fired if DICE is enabled. It's not yet possible to do that as the test is still using FakeSigninManager. Bug: 796544 Change-Id: I8ec51b1c960ea068cb984c1781e2cc84c72ce0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1488876Reviewed-by:
-
