GitLab

We do not scheduleVisualUpdate for setNeedsStyleRecalc when we have
pending stylesheets. If we setNeedsStyleRecalc while loading a stylesheet,
we won't necessarily trigger a BeginFrame when the stylesheet finishes
loading because subsequent setNeedsStyleRecalc call won't trigger those
either if the ascendants are already marked with childNeedsStyleRecalc
because we assume the visual update is already scheduled.

Schedule a BeginFrame from resumeTreeViewCommits to make sure deferred
visual updates are triggered.

BUG=384934

Review URL: https://codereview.chromium.org/1316403004

git-svn-id: svn://svn.chromium.org/blink/trunk@201933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just to fix the assertion failure.
The related code will be deprecated soon.

BUG=457415,523142

Review URL: https://codereview.chromium.org/1326093003

git-svn-id: svn://svn.chromium.org/blink/trunk@201932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This has moved to WebRemoteFrameClient.

BUG=none

Review URL: https://codereview.chromium.org/1309363005

git-svn-id: svn://svn.chromium.org/blink/trunk@201931 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add fallback fonts for more math and symbol unicode blocks on Windows to
allow better font fallback and handling of symbols that generally aren't
available in the commonly used fonts.

R=szager@chromium.org
BUG=237023, 237050, 526354
TEST=fast/text/unicode-fallback-font.html

Review URL: https://codereview.chromium.org/1314543011

git-svn-id: svn://svn.chromium.org/blink/trunk@201930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When building SVG image-backed WebGL textures, we're currently drawing
into a reusable buffer.  Since SVG images are not guaranteed to be
opaque, we should clear the buffer as needed.

Update the existing test to cover this logic (the updated version fails
at ToT but passes with the patch).

Also reactivate the imageForRender null-check (ineffective after
http://crrev.com/29203004), and change drawImageIntoBuffer() to take a
ref instead of a raw ptr.

TEST=fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html

BUG=500180
R=kbr@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1315233003

git-svn-id: svn://svn.chromium.org/blink/trunk@201929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This code only worked when we weren't using FCM mode, but now we always do for
tests. We also always run tests with asserts turned on, even for release builds
so this code clearly is never used since it contains a
RELEASE_ASSERT_NOT_REACHED().

Lets remove it!

I also removed the old baselines from tests that used this. These tests must all
be disabled on the platforms where these baselines would have been used since we
no longer were capable of producing this output without crashing on the
ASSERT_NOT_REACHED().

BUG=368518,521692

Review URL: https://codereview.chromium.org/1309243006

git-svn-id: svn://svn.chromium.org/blink/trunk@201928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Re-baseline expectations for video-to-canvas yuv tests.

BUG=449197

Review URL: https://codereview.chromium.org/1321163003

git-svn-id: svn://svn.chromium.org/blink/trunk@201927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A pair of user-timing timing tests imported from web-platform-tests
have a threshold that's too low for our Windows bots. I filed an
upstream bug[1] to try and improve the tests, but in lieu of that
we should skip them on Windows since they aren't giving us good
data.

[1] https://github.com/w3c/web-platform-tests/issues/2115

NOTRY=true
TBR=ojan@chromium.org
BUG=518992,518993

Review URL: https://codereview.chromium.org/1308393010

git-svn-id: svn://svn.chromium.org/blink/trunk@201926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This went untested before, but our pointercancel firing code for touch
scroll already takes care of it.

BUG=476576

Review URL: https://codereview.chromium.org/1316013007

git-svn-id: svn://svn.chromium.org/blink/trunk@201924 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The lowercase version comes from <cassert>, and shouldn't be used within Blink.

Review URL: https://codereview.chromium.org/1305353011

git-svn-id: svn://svn.chromium.org/blink/trunk@201923 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=529370
TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/1333523002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201922 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=490608

Review URL: https://codereview.chromium.org/1328183002

git-svn-id: svn://svn.chromium.org/blink/trunk@201921 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Resource for https://codereview.chromium.org/1316673007/, landed
separately so that patch can go through CQ (as it won't upload the .xml
because it's too large.)

TBR=dominicc@chromium.org
BUG=528078, 463958

Review URL: https://codereview.chromium.org/1328093005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201920 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=529345
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1330033003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201919 bbb929c8-8fbe-4397-9dbb-9b2b20218538

PresentationAvailability is listening to the page visibility but is using
the ExecutionContext to send messages to the controller. The ExecutionContext
might be destroyed before a page visibility change, for example, if the object
was created in a frame that has been removed from the frame tree.

BUG=526923,526116

Review URL: https://codereview.chromium.org/1322493006

git-svn-id: svn://svn.chromium.org/blink/trunk@201918 bbb929c8-8fbe-4397-9dbb-9b2b20218538

path().boundingRect() is exactly what objectBoundingBox() will return
for LayoutSVGPath, so the implementation from SVGGraphicElement can be
used.

Review URL: https://codereview.chromium.org/1315983012

git-svn-id: svn://svn.chromium.org/blink/trunk@201917 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Classes that keep a CancellableTaskFactory should create() these via the
provided factory method, which takes care of creating the task factory's
closure in a manner that doesn't cause an (Oilpan) leak.

Not using the factory method is convenient when testing, so accommodate
this by way of a protected CancellableTaskFactory<> constructor, and use
it in unit tests. The unit tests exercise functionality rather than direct
usage by Blink objects, so hiding the constructor is considered acceptable.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/1320023009

git-svn-id: svn://svn.chromium.org/blink/trunk@201916 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, resetting a bookmark in a file with BOM would not account for
the BOM length, meaning the parser would be off by 2 (UCS2) or 3 (UTF-8)
bytes. Additional information in the comments and in the referenced bug.

It's not an off-by-1 error, it's an off-by-O(1) error.

R=jochen@chromium.org
BUG=527930

Review URL: https://codereview.chromium.org/1315873003

git-svn-id: svn://svn.chromium.org/blink/trunk@201915 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of
|lastEditableVisiblePositionBeforePositionInRoot()| for introducing composed
tree version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568

Review URL: https://codereview.chromium.org/1306053017

git-svn-id: svn://svn.chromium.org/blink/trunk@201914 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=528262

Note: this cannot land until after the Skia DEPS roll has landed

Review URL: https://codereview.chromium.org/1323753003

git-svn-id: svn://svn.chromium.org/blink/trunk@201913 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |endOfParagraph()|
by templatizing original |endOfParagraph()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1326323002

git-svn-id: svn://svn.chromium.org/blink/trunk@201912 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |nextPositionOf()|
by templatizing original |nextPositionOf()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch also |honorEditingBoundaryAtOrAfter()| and
|skipToEndOfEditingBoundary()| used by |nextPositionOf()|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1315443011

git-svn-id: svn://svn.chromium.org/blink/trunk@201911 bbb929c8-8fbe-4397-9dbb-9b2b20218538

instance, prototype and interface.

There should be no behavioral change.

BUG=43394,516274

Review URL: https://codereview.chromium.org/1322533002

git-svn-id: svn://svn.chromium.org/blink/trunk@201910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Subtract border and padding when we're calculating the breadth of the
columns in LayoutGrid::computeUsedBreadthOfSpecifiedLength().

Added test to check the behavior for both columns and rows.

BUG=529203
TEST=fast/css-grid-layout/grid-percent-track-margin-border-padding.html

Review URL: https://codereview.chromium.org/1321723008

git-svn-id: svn://svn.chromium.org/blink/trunk@201909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We skip those access checks when dealing with Location, as V8Location has its own checks in place according to the Location's cross-origin policy (https://html.spec.whatwg.org/multipage/browsers.html#security-location).

BUG=455160

Review URL: https://codereview.chromium.org/1262353002

git-svn-id: svn://svn.chromium.org/blink/trunk@201908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,yosin
BUG=513568
NOTRY=true

Review URL: https://codereview.chromium.org/1303993005

git-svn-id: svn://svn.chromium.org/blink/trunk@201907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a partial revert of r201891

BUG=

Review URL: https://codereview.chromium.org/1315443010

git-svn-id: svn://svn.chromium.org/blink/trunk@201906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Suppress timeout on scrollstate-after-http-equiv-refresh-fragment-identifier.html (patchset #1 id:1 of https://codereview.chromium.org/1326193002/ )

Reason for revert:
The timeout was fixed by https://codereview.chromium.org/1304383004

Original issue's description:
> Suppress timeout on scrollstate-after-http-equiv-refresh-fragment-identifier.html
> 
> This patch suppresses a timeout on [1] likely due to [2]. See:
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fnavigation%2Fscrollstate-after-http-equiv-refresh-fragment-identifier.html&testType=layout-tests
> 
> [1] http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
> [2] https://src.chromium.org/viewvc/blink?view=rev&revision=201780
> 
> NOTRY=true
> BUG=528352
> TBR=alexclarke
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201810

TBR=alexclarke@google.com,pdr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=528352

Review URL: https://codereview.chromium.org/1324403002

git-svn-id: svn://svn.chromium.org/blink/trunk@201905 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |isFirstPositionAfterTable()|
by templatizing original |isFirstPositionAfterTable()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1309963003

git-svn-id: svn://svn.chromium.org/blink/trunk@201904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://codereview.chromium.org/393823003 added the loop for the purposes
of repeatedly polling the cross-thread-usable free page pool.
As we now take the first page & don't add that to the pool,
the loop looks redundant.

BUG=

Review URL: https://codereview.chromium.org/1319163003

git-svn-id: svn://svn.chromium.org/blink/trunk@201903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'll need to access DisplayItemList::newDisplayItems() to update
cacheable flag of BeginSubsequence display items for
https://codereview.chromium.org/1327563003/.

Update layout tests and make some cleanups.

Review URL: https://codereview.chromium.org/1323243011

git-svn-id: svn://svn.chromium.org/blink/trunk@201902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Fix function names.
- Use const references as possible.
- Use range-based |for|.

This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1305063008

git-svn-id: svn://svn.chromium.org/blink/trunk@201901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These methods are unused, and confusing. Let's remove them.

BUG=494880
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1321683009

git-svn-id: svn://svn.chromium.org/blink/trunk@201900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, remove FormDataList::setData and setBlob.  This simplifies the code.
This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1320463010

git-svn-id: svn://svn.chromium.org/blink/trunk@201898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

testharnessreport: Hide elements in tests by removing them from the document tree, instead of visibility:hidden.

This fixes the flakiness of web-platform-tests/webrtc/datachannel-
emptystring.html.

[1] made the test flaky because:
 - It added a chance to invoke onSendChannelOpen()
 - It prints some lines into <div id=msg>.
 - Text dump of visibility:hidden doesn't remove EOLs represented by
   <br>s.

This CL resolves this issue by removing elements completely by
body.textContent = ''.  Setting display:none instead of visibility:hidden
also works, but body.textContent = '' is much simpler.

[1] https://src.chromium.org/viewvc/blink?revision=201628&view=revision
BUG=528120

Review URL: https://codereview.chromium.org/1332523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of
|firstEditableVisiblePositionAfterPositionInRoot()| for introducing composed
tree version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311543006

git-svn-id: svn://svn.chromium.org/blink/trunk@201896 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per the spec
https://html.spec.whatwg.org/multipage/forms.html#input-type-attr-summary
input types date, time, month, week, datetime-local, file, image, reset etc
should ignore placeholder attribute and in-turn should not affect placeholder-shown state.
Adding testcases for the same.

BUG=451120

Review URL: https://codereview.chromium.org/1332543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201895 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebSearchableFormData.cpp created FormDataList instances.  However DOMFormData,
which is a subclass of FormDataList, is also acceptable, and we can remove
FormDataList factory.

This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1323023005

git-svn-id: svn://svn.chromium.org/blink/trunk@201894 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test flakes consistently on the bots:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fsources%2Fdebugger-breakpoints%2Fdebugger-reload-breakpoints-with-source-maps.html

TBR=yurys@chromium.org
BUG=529123

Review URL: https://codereview.chromium.org/1308663006

git-svn-id: svn://svn.chromium.org/blink/trunk@201893 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we run into an infinite loop when we hit the limit of the number
of mmapped regions OS can support. It is better to have a RELEASE_ASSERT
about it.

BUG=

Review URL: https://codereview.chromium.org/1320493006

git-svn-id: svn://svn.chromium.org/blink/trunk@201892 bbb929c8-8fbe-4397-9dbb-9b2b20218538