- 15 Mar, 2011 40 commits
-
-
zimmermann@webkit.org authored
Not reviewed. REGRESSION (r68976): Incorrect bidi rendering in SVG text https://bugs.webkit.org/show_bug.cgi?id=53980 Update Qt baseline, still waiting for gtk/leopard/win7/winxp. * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: * platform/qt/svg/text/text-align-02-b-expected.txt: * platform/qt/svg/text/text-align-04-b-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@81170 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by James Robinson. Valgrind error due to uninitialized PluginLayerChromium::m_textureId https://bugs.webkit.org/show_bug.cgi?id=56390 * platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::PluginLayerChromium): * platform/graphics/chromium/PluginLayerChromium.h: (WebCore::PluginLayerChromium::textureId): 2011-03-15 Alok priyadarshi <alokp@chromium.org> Reviewed by James Robinson. Valgrind error due to uninitialized PluginLayerChromium::m_textureId https://bugs.webkit.org/show_bug.cgi?id=56390 * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setBackingTextureId): (WebKit::WebPluginContainerImpl::platformLayer): git-svn-id: svn://svn.chromium.org/blink/trunk@81169 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
zimmermann@webkit.org authored
Reviewed by Dirk Schulze. REGRESSION (r68976): Incorrect bidi rendering in SVG text https://bugs.webkit.org/show_bug.cgi?id=53980 rework the test engine or SVG "text-intro" tests so we can turn them back on https://bugs.webkit.org/show_bug.cgi?id=6524 svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present https://bugs.webkit.org/show_bug.cgi?id=11662 svg/batik/text/textBiDi.svg failing https://bugs.webkit.org/show_bug.cgi?id=17392 SVG bidi examples at w3C I18N WG tutorials are not rendered correctly. https://bugs.webkit.org/show_bug.cgi?id=24374 Implement proper bidirectionality support for SVG text. The actual bidi support is working fine, the problem is that SVG demands to reorder x/y/dx/dy/rotate value lists, in order to main correspondance between the attributes and the potentially reordered text. Land a new suite of SVG & i18n tests, covering unicode-bidi/direction and text-anchor support with BiDi text (Arabic mixed with Latin) in LayoutTests/svg/W3C-I18N. Enable long-disabled SVG BiDi tests, and international fonts support in svg/W3C-SVG-1.1 by providing a SVGFont replacment, replacing the need for MS Office Fonts to be present. These tests have some value and we'd like to have them enabled again. * platform/mac/svg/W3C-I18N: Added. * platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.checksum: Added. * platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png: Added. * platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added. * platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.checksum: Added. * platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png: Added. * platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added. * platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.checksum: Added. * platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png: Added. * platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added. * platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.checksum: Added. * platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png: Added. * platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.png: Added. * platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Added. * platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Added. * platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Added. * platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added. * platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.checksum: Added. * platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png: Added. * platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added. * platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.checksum: Added. * platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.png: Added. * platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added. * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: * platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: * platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: * platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added. * platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added. * platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added. * platform/mac/svg/text/bidi-reorder-value-lists-expected.checksum: Added. * platform/mac/svg/text/bidi-reorder-value-lists-expected.png: Added. * platform/mac/svg/text/bidi-reorder-value-lists-expected.txt: Added. * platform/mac/svg/text/bidi-text-anchor-direction-expected.checksum: Added. * platform/mac/svg/text/bidi-text-anchor-direction-expected.png: Added. * platform/mac/svg/text/bidi-text-anchor-direction-expected.txt: Added. * platform/mac/svg/text/bidi-text-query-expected.checksum: Added. * platform/mac/svg/text/bidi-text-query-expected.png: Added. * platform/mac/svg/text/bidi-text-query-expected.txt: Added. * platform/mac/svg/text/bidi-tspans-expected.checksum: Added. * platform/mac/svg/text/bidi-tspans-expected.png: Added. * platform/mac/svg/text/bidi-tspans-expected.txt: Added. * platform/mac/svg/text/small-fonts-2-expected.txt: * platform/mac/svg/text/text-align-02-b-expected.txt: * platform/mac/svg/text/text-align-04-b-expected.txt: * svg/W3C-I18N: Added. * svg/W3C-I18N/NOTE: Added. * svg/W3C-I18N/g-dirLTR-ubNone.svg: Added. * svg/W3C-I18N/g-dirLTR-ubOverride.svg: Added. * svg/W3C-I18N/g-dirRTL-ubNone.svg: Added. * svg/W3C-I18N/g-dirRTL-ubOverride.svg: Added. * svg/W3C-I18N/resources: Added. * svg/W3C-I18N/resources/img1.png: Added. * svg/W3C-I18N/resources/img11.png: Added. * svg/W3C-I18N/resources/img12.png: Added. * svg/W3C-I18N/resources/img13.png: Added. * svg/W3C-I18N/resources/img14.png: Added. * svg/W3C-I18N/resources/img15.png: Added. * svg/W3C-I18N/resources/img16.png: Added. * svg/W3C-I18N/resources/img17.png: Added. * svg/W3C-I18N/resources/img18.png: Added. * svg/W3C-I18N/resources/img19.png: Added. * svg/W3C-I18N/resources/img2.png: Added. * svg/W3C-I18N/resources/img20.png: Added. * svg/W3C-I18N/resources/img21.png: Added. * svg/W3C-I18N/resources/img24.png: Added. * svg/W3C-I18N/resources/img25.png: Added. * svg/W3C-I18N/resources/img3.png: Added. * svg/W3C-I18N/resources/img4.png: Added. * svg/W3C-I18N/resources/img5.png: Added. * svg/W3C-I18N/resources/tanchor-left-right.png: Added. * svg/W3C-I18N/resources/tanchor-left.png: Added. * svg/W3C-I18N/resources/tanchor-right.png: Added. * svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg: Added. * svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg: Added. * svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg: Added. * svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg: Added. * svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg: Added. * svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg: Added. * svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg: Added. * svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg: Added. * svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg: Added. * svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg: Added. * svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg: Added. * svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg: Added. * svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg: Added. * svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg: Added. * svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg: Added. * svg/W3C-I18N/text-anchor-no-markup.svg: Added. * svg/W3C-I18N/text-dirLTR-ubNone.svg: Added. * svg/W3C-I18N/text-dirLTR-ubOverride.svg: Added. * svg/W3C-I18N/text-dirRTL-ubNone.svg: Added. * svg/W3C-I18N/text-dirRTL-ubOverride.svg: Added. * svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg: Added. * svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg: Added. * svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg: Added. * svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg: Added. * svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg: Added. * svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg: Added. * svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg: Added. * svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg: Added. * svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg: Added. * svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg: Added. * svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg: Added. * svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg: Added. * svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg: Added. * svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg: Added. * svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg: Added. * svg/W3C-I18N/tspan-direction-ltr.svg: Added. * svg/W3C-I18N/tspan-direction-rtl.svg: Added. * svg/W3C-SVG-1.1-SE/text-intro-02-b.svg: Added. * svg/W3C-SVG-1.1-SE/text-intro-05-t.svg: Added. * svg/W3C-SVG-1.1-SE/text-intro-09-b.svg: Added. * svg/W3C-SVG-1.1/resources/SVGExotic.svg: Added. * svg/W3C-SVG-1.1/text-align-08-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-align-08-b.svg-disabled. * svg/W3C-SVG-1.1/text-align-08-b.svg-disabled: Removed. * svg/W3C-SVG-1.1/text-fonts-03-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-fonts-03-t.svg-disabled. * svg/W3C-SVG-1.1/text-fonts-03-t.svg-disabled: Removed. * svg/W3C-SVG-1.1/text-intro-01-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled. * svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Removed. * svg/W3C-SVG-1.1/text-intro-02-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled. * svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Removed. * svg/W3C-SVG-1.1/text-intro-03-b.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled. * svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Removed. * svg/W3C-SVG-1.1/text-intro-04-t.svg: Copied from LayoutTests/svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled. * svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Removed. * svg/custom/glyph-transformation-with-hkern-expected.txt: * svg/text/bidi-reorder-value-lists.svg: Added. * svg/text/bidi-text-anchor-direction.svg: Added. * svg/text/bidi-text-query.svg: Added. * svg/text/bidi-tspans.svg: Added. 2011-03-14 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Dirk Schulze. REGRESSION (r68976): Incorrect bidi rendering in SVG text https://bugs.webkit.org/show_bug.cgi?id=53980 rework the test engine or SVG "text-intro" tests so we can turn them back on https://bugs.webkit.org/show_bug.cgi?id=6524 svg/W3C-SVG-1.1/text-intro-0*.svg fail when MS Office fonts are present https://bugs.webkit.org/show_bug.cgi?id=11662 svg/batik/text/textBiDi.svg failing https://bugs.webkit.org/show_bug.cgi?id=17392 SVG bidi examples at w3C I18N WG tutorials are not rendered correctly. https://bugs.webkit.org/show_bug.cgi?id=24374 Implement proper bidirectionality support for SVG text. BiDi didn't work properly until now, because the x/y/dx/dy/rotate value lists are stored in logical order (aka. in the order the characters appear in the markup), and when laying out bidi text, we associated the current character in visual order with the current x/y/dx/dy/rotate value in logical order, messing up RTL text layout. The BiDi algorithm itself, inherited by RenderBlockLineLayout, works just fine, the inline box tree is correct. Long story: Before the inline box tree is created, SVGTextLayoutAttributesBuilder builds a list of x/y/dx/dy/rotate/<text metrics> for each RenderSVGInlineText* object, called SVGTextLayoutAttributes. This happens in logical order, as specified in the markup. <text x="10 20" y="10">abcdef</text> creates a SVGTextLayoutAttributes object in the renderer associated with "abcdef" that contains (10, 20) for x, (10) for y, the dx/dy/rotate lists are empty, and the SVGTextMetrics list holds 6 width/height values for each of the glyphs (and some other infromation, see SVGTextMetrics class). The SVGTextLayoutAttributes object is _used by_ RenderBlockLineLayout when applying the BiDi algorithm as SVG demands that BiDi reordering does not happen across text chunks (a text chunk is defined by an absolute position, eg. x="10"). To summarize: SVGTextLayoutAttributes are stored in all RenderSVGInlineText renderers, caching the metrics of all characters, their position based on the DOM attributes x/y/dx/dy/rotate. Using that information it's possible to determine whether a position starts a new text chunk, and that's used by RenderBlockLineLayout to create the inline box tree, in _visual order_, as it will appear on screen. After the inline box tree is created, the SVGRootInlineBox traverses its children in visual order and feeds the found text boxes to SVGTextLayoutEngine, which lays out the text on a line or a path, according to SVG text layout rules. For each character of the passed in InlineTextBox, it determines the x/y/dx/dy/rotate value, and the position in the <text metrics> list of the renderer. The problem here is that the passed in text boxes are in visual order, the x/y/.. lists are all in logical order. Example: <text direction="rtl" unicde-bidi="bidi-override" x="10 20">abcdef</text>, reverse the text direction: the visual order now is: "fedcba", where 'f' should be associated with x="10" and 'e' with x="20". Fix that problem, by computing a list of text boxes in _logical_ order in advance and pass it to SVGTextLayoutEngine, before it starts processing the boxes in visual order, fed by SVGRootInlineBox. When laying oout text, we can now process text in visual order, but grab the x/y/.. coordinates from the renderer in logical order. Some more work was needed to truly fix Arabic. The SVGTextLayoutAttributesBuilder measured all characters isolated, which is not a problem with latin text, but results in wrong advances for Arabic text, as isolated forms, instead of shaped forms are measured. This broke text-anchor support, text queries on Arabic text etc. Fixed now, covered by dozens of new tests. Tests: svg/W3C-I18N/g-dirLTR-ubNone.svg svg/W3C-I18N/g-dirLTR-ubOverride.svg svg/W3C-I18N/g-dirRTL-ubNone.svg svg/W3C-I18N/g-dirRTL-ubOverride.svg svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg svg/W3C-I18N/text-anchor-no-markup.svg svg/W3C-I18N/text-dirLTR-ubNone.svg svg/W3C-I18N/text-dirLTR-ubOverride.svg svg/W3C-I18N/text-dirRTL-ubNone.svg svg/W3C-I18N/text-dirRTL-ubOverride.svg svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context.svg svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context.svg svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context.svg svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context.svg svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context.svg svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context.svg svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context.svg svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context.svg svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context.svg svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context.svg svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context.svg svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context.svg svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context.svg svg/W3C-I18N/tspan-direction-ltr.svg svg/W3C-I18N/tspan-direction-rtl.svg svg/W3C-SVG-1.1-SE/text-intro-02-b.svg svg/W3C-SVG-1.1-SE/text-intro-05-t.svg svg/W3C-SVG-1.1-SE/text-intro-09-b.svg svg/W3C-SVG-1.1/text-align-08-b.svg svg/W3C-SVG-1.1/text-fonts-03-t.svg svg/W3C-SVG-1.1/text-intro-01-t.svg svg/W3C-SVG-1.1/text-intro-02-b.svg svg/W3C-SVG-1.1/text-intro-03-b.svg svg/W3C-SVG-1.1/text-intro-04-t.svg svg/text/bidi-reorder-value-lists.svg svg/text/bidi-text-anchor-direction.svg svg/text/bidi-text-query.svg svg/text/bidi-tspans.svg * rendering/RenderBlockLineLayout.cpp: Remove hack that forced LTR support when unicode-bidi="normal" and handling SVG text. (WebCore::RenderBlock::determineStartPosition): * rendering/svg/SVGInlineTextBox.cpp: s/fragment.positionListOffset/fragment.characterOffset/ (WebCore::SVGInlineTextBox::offsetForPositionInFragment): (WebCore::SVGInlineTextBox::constructTextRun): (WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates): * rendering/svg/SVGRenderTreeAsText.cpp: Ditto. (WebCore::writeSVGInlineTextBox): * rendering/svg/SVGRootInlineBox.cpp: Add new buildTextBoxListInLogicalOrder(), collecting all text boxes recursively in logical order (aka. as specified in markup). This is needed as we have to process x/y/dx/dy/rotate value lists of text/tspan/.. elements in logical order, not in visual order as the characters are presented on screen. (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): (WebCore::SVGRootInlineBox::buildTextBoxListInLogicalOrder): (WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes): * rendering/svg/SVGRootInlineBox.h: * rendering/svg/SVGTextChunk.cpp: Cleanup code, minimize SVGTextChunks memory consumption. (WebCore::SVGTextChunk::SVGTextChunk): A text chunk now know whether its base progress direction is left-to-right or right-to-left. (WebCore::SVGTextChunk::calculateLength): (WebCore::SVGTextChunk::calculateTextAnchorShift): Make text-anchor direction aware. text-anchor="start/end" meaning depends on the context (ltr vs. rtl). * rendering/svg/SVGTextChunk.h: Adapt code, merging three members into a bitfield. (WebCore::SVGTextChunk::isVerticalText): (WebCore::SVGTextChunk::hasDesiredTextLength): (WebCore::SVGTextChunk::hasTextAnchor): (WebCore::SVGTextChunk::hasLengthAdjustSpacing): (WebCore::SVGTextChunk::hasLengthAdjustSpacingAndGlyphs): * rendering/svg/SVGTextChunkBuilder.cpp: Adapt to SVGTextChunk code changes. (WebCore::SVGTextChunkBuilder::addTextChunk): (WebCore::SVGTextChunkBuilder::processTextChunk): * rendering/svg/SVGTextFragment.h: Add metricsListOffset, needed only while laying out text. (WebCore::SVGTextFragment::SVGTextFragment): Rename positionListOffset to characterOffset, as it describes an offset in the textRenderer->characters() array. * rendering/svg/SVGTextLayoutAttributesBuilder.cpp (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Fix measuring Arabic text in LTR/RTL modes. Assure that each SVGTextMetrics object that we cache, refers to the _rendered_ character. For Arabic text that means, that we're measuring the shaped width of the glyph, not the glyph in its isolated form. Without that fix reordering boxes containing Arabic is wrong. * rendering/svg/SVGTextLayoutEngine.cpp: SVGTextLayoutEngine is fed with text boxes to be laid out in _visual_ order, left-to-right, after the BiDi algorithm has been applied by RenderBlockLineLayout to create the inline box tree. The coordinates lists x/y/dx/dy/rotate have to be processed in _logical_ order. SVGRootInlineBox now passes a list of text boxes in logical order to SVGTextLayoutEngine, to assure it grabs the coordinates from the correct InlineTextBox. See examples at the top of the ChangeLog. (WebCore::SVGTextLayoutEngine::SVGTextLayoutEngine): (WebCore::SVGTextLayoutEngine::recordTextFragment): No need to measure text here anymore, SVGTextLayoutAttributesBuilder now provides exact advances for each glyph. The width of a SVGTextFragment is always equal to the sum of each glyph advance. (This was not the case for Arabic until now.) (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices): (WebCore::SVGTextLayoutEngine::nextLogicalBoxAndOffset): Computes the next logical box and the offset to the next coordinate value in its position list. (WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath): * rendering/svg/SVGTextLayoutEngine.h: Add CharacterRange helper struct. (WebCore::SVGTextLayoutEngine::CharacterRange::CharacterRange): * rendering/svg/SVGTextMetrics.cpp: Remove unused measureAllCharactersIndividually() method. (WebCore::constructTextRun): Pass direction and unicode-bidi="override" values to the TextRun, otherwhise LTR is always asumed. * rendering/svg/SVGTextMetrics.h: (WebCore::SVGTextMetrics::setWidth): Add private setter, only SVGTextLayoutAttributesBuilder is allowed to modify the metrics (to fix up glyph widths for Arabic). * rendering/svg/SVGTextQuery.cpp: s/fragment.positionListOffset/fragment.characterOffset/ (WebCore::SVGTextQuery::subStringLengthCallback): (WebCore::SVGTextQuery::startPositionOfCharacterCallback): (WebCore::SVGTextQuery::endPositionOfCharacterCallback): (WebCore::calculateGlyphBoundaries): git-svn-id: svn://svn.chromium.org/blink/trunk@81168 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
sergio@webkit.org authored
Reviewed by Xan Lopez. [GTK] Fix make distcheck for 1.3.13 release https://bugs.webkit.org/show_bug.cgi?id=56371 No new tests as this is a build fix. * GNUmakefile.am: added a couple of missing files. git-svn-id: svn://svn.chromium.org/blink/trunk@81166 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
leviw@chromium.org authored
Reviewed by Ryosuke Niwa. Get rid of firstDeepEditingPositionForNode and lastDeepEditingPositionForNode https://bugs.webkit.org/show_bug.cgi?id=52642 Replacing calls to first/lastDeepEditingPositionForNode with calls to their analogous functions that create new positions. Also fixing various parts of editing code that incorrectly handled the new positions now being created. No new tests as this is refactoring/cleanup. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRange): * dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent): (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::atFirstEditingPositionForNode): (WebCore::Position::atLastEditingPositionForNode): (WebCore::Position::upstream): (WebCore::Position::isCandidate): (WebCore::Position::getInlineBoxAndOffset): * dom/Position.h: (WebCore::operator==): * dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): * editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary): * editing/DeleteSelectionCommand.cpp: (WebCore::isTableCellEmpty): (WebCore::DeleteSelectionCommand::removeNode): * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): * editing/InsertListCommand.cpp: (WebCore::InsertListCommand::unlistifyParagraph): * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): * editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed): * editing/VisibleSelection.cpp: (WebCore::VisibleSelection::selectionFromContentsOfNode): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): * editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::enclosingEmptyListItem): * editing/htmlediting.h: * editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::startOfEditableContent): (WebCore::endOfEditableContent): * rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint): git-svn-id: svn://svn.chromium.org/blink/trunk@81165 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
brettw@chromium.org authored
Reviewed by Adam Barth Make WebConsoleMessage properly respect the log level. https://bugs.webkit.org/show_bug.cgi?id=56386 * public/WebConsoleMessage.h: (WebKit::WebConsoleMessage::WebConsoleMessage): git-svn-id: svn://svn.chromium.org/blink/trunk@81164 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
bdakin@apple.com authored
* platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::cancelAnimations): git-svn-id: svn://svn.chromium.org/blink/trunk@81163 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Reviewed by Dave Levin. Fix FontCache problems on Linux. Make sure not to mutate the platform data passed in to SimpleFontData's constructor. Change this code to match Mac and to set the new m_hasVerticalGlyphs boolean instead of mutating orientation. * platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit): git-svn-id: svn://svn.chromium.org/blink/trunk@81162 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
Reviewed by Dan Bernstein. Disable ShadowBlur shadow drawing in accelerated contexts https://bugs.webkit.org/show_bug.cgi?id=56392 When drawing into a graphics context that is accelerated, don't use ShadowBlur, because it may be slower. * platform/graphics/GraphicsContext.h: * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillRectWithRoundedHole): (WebCore::GraphicsContext::setIsCALayerContext): (WebCore::GraphicsContext::isCALayerContext): (WebCore::GraphicsContext::setIsAcceleratedContext): (WebCore::GraphicsContext::isAcceleratedContext): * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): * platform/graphics/mac/WebLayer.mm: (drawLayerContents): git-svn-id: svn://svn.chromium.org/blink/trunk@81161 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
andersca@apple.com authored
* DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject): git-svn-id: svn://svn.chromium.org/blink/trunk@81160 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/9075624bdakin@apple.com authored
Reviewed by Simon Fraser. Tell the ScrollAnimator to cancelAnimations() since we are navigating to a new page. * loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Scroll animations should be suspended if the FrameLoadState is anything but complete. * page/FrameView.cpp: (WebCore::FrameView::shouldSuspendScrollAnimations): * page/FrameView.h: * platform/ScrollableArea.h: (WebCore::ScrollableArea::shouldSuspendScrollAnimations): * rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::shouldSuspendScrollAnimations): * rendering/RenderDataGrid.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldSuspendScrollAnimations): * rendering/RenderLayer.h: * rendering/RenderListBox.cpp: (WebCore::RenderListBox::shouldSuspendScrollAnimations): * rendering/RenderListBox.h: New virtual function cancelAnimations() is only needed on the Mac, so the base class is empty. * platform/ScrollAnimator.h: (WebCore::ScrollAnimator::cancelAnimations): ScrollAnimatorMac needs to keep track of whether the page has been scrolled since it started loading. If so, we will override optimizations that wait for the FrameLoadState to be complete before animating scrollbars. * platform/mac/ScrollAnimatorMac.h: (WebCore::ScrollAnimatorMac::haveScrolledSincePageLoad): If the scrollbar animations should be suspended, we start a timer to make sure that we do flash the scrollbars. Animating the scrollbars is expensive, so this is both a performance optimization and a UI enhancement since the scrollbar won't jump around nearly as much on a page load. * platform/mac/ScrollAnimatorMac.mm: (-[ScrollbarPainterDelegate cancelAnimations]): (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): (-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]): (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): (WebCore::ScrollAnimatorMac::scroll): (WebCore::ScrollAnimatorMac::handleWheelEvent): (WebCore::ScrollAnimatorMac::cancelAnimations): (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorMac::beginScrollGesture): (WebCore::ScrollAnimatorMac::startScrollbarPaintTimer): (WebCore::ScrollAnimatorMac::scrollbarPaintTimerIsActive): (WebCore::ScrollAnimatorMac::stopScrollbarPaintTimer): (WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired): New WebCoreSystemInterface function to force the scrollbars to flash * WebCore.exp.in: * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: Source/WebKit/mac: WebKit part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6% Reviewed by Simon Fraser. New WebKitystemInterface function to force the scrollbars to flash * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Source/WebKit2: WebKit2 part of <rdar://problem/9075624> Overlay scrollbars slow down PLT by 6% Reviewed by Simon Fraser. New WebKitystemInterface function to force the scrollbars to flash * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): git-svn-id: svn://svn.chromium.org/blink/trunk@81159 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
dglazkov@chromium.org authored
Reviewed by Adam Barth. Remove stale comment at RenderStyle::diff. https://bugs.webkit.org/show_bug.cgi?id=56387 * rendering/style/RenderStyle.cpp: Removed comment. git-svn-id: svn://svn.chromium.org/blink/trunk@81158 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
andersca@apple.com authored
Reviewed by Sam Weinig. Make sure that NP_Shutdown is always the last NPP function called https://bugs.webkit.org/show_bug.cgi?id=56391 <rdar://problem/8989902> Make sure to always increment the load count whenever a web process connection is opened to a plug-in process, and decrement it when the last web process connection goes away. * PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::createWebProcessConnection): (WebKit::PluginProcess::startShutdownTimerIfNecessary): * Shared/Plugins/Netscape/NetscapePluginModule.cpp: * Shared/Plugins/Netscape/NetscapePluginModule.h: * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): (WebKit::NetscapePlugin::~NetscapePlugin): 2011-03-15 Anders Carlsson <andersca@apple.com> Reviewed by Sam Weinig. Make sure that NP_Shutdown is always the last NPP function called https://bugs.webkit.org/show_bug.cgi?id=56391 <rdar://problem/8989902> Add test. * plugins/npruntime/np-deallocate-called-before-np-shutdown-expected.txt: Added. * plugins/npruntime/np-deallocate-called-before-np-shutdown.html: Added. 2011-03-15 Anders Carlsson <andersca@apple.com> Reviewed by Sam Weinig. Make sure that NP_Shutdown is always the last NPP function called https://bugs.webkit.org/show_bug.cgi?id=56391 Add a test that times out if an NP_Deallocate object is called after NP_Shutdown. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::PluginTest): (PluginTest::NP_Shutdown): (PluginTest::registerNPShutdownFunction): * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added. (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown): (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject): (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty): (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty): (NPDeallocateCalledBeforeNPShutdown::NPP_New): (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue): (NPDeallocateCalledBeforeNPShutdown::shutdown): * DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_Shutdown): * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: * GNUmakefile.am: git-svn-id: svn://svn.chromium.org/blink/trunk@81157 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
http://webkit.org/b/56381ddkilzer@apple.com authored
Reviewed by Simon Fraser. Typedef-ing Objective-C classes as void* for pure C++ makes it easier for bugs to creep in because compilers can't do any type checking for void pointers. * platform/graphics/GraphicsContext3D.h: Changed typedef declarations for CALayer and WebGLLayer from void* to structs. (WebCore::GraphicsContext3D::platformLayer): Changed static_cast<CALayer*> to reinterpret_cast<CALayer*> now that CALayer and WebGLLayer are not void pointers. * platform/graphics/GraphicsLayer.h: Changed typedef declaration for PlatformLayer from void* to struct CALayer. * platform/graphics/ca/PlatformCAAnimation.h: Changed typedef declaration for CAPropertyAnimation from void* to a struct. Extracted typdef for PlatformAnimationRef. git-svn-id: svn://svn.chromium.org/blink/trunk@81156 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Tony Chang. Autofilled form elements are assigned fixed background color but not text color https://bugs.webkit.org/show_bug.cgi?id=48382 * fast/forms/input-autofilled-expected.txt: Added. * fast/forms/input-autofilled.html: Added. * platform/win/fast/forms/input-autofilled-expected.txt: Added. 2011-03-15 Ilya Sherman <isherman@chromium.org> Reviewed by Tony Chang. Autofilled form elements are assigned fixed background color but not text color https://bugs.webkit.org/show_bug.cgi?id=48382 Test: fast/forms/input-autofilled.html * css/html.css: (input:-webkit-autofill): Added foreground color: #000000 * css/wml.css: (input:-webkit-autofill): Added foreground color: #000000 2011-03-15 Ilya Sherman <isherman@chromium.org> Reviewed by Tony Chang. Autofilled form elements are assigned fixed background color but not text color https://bugs.webkit.org/show_bug.cgi?id=48382 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setAutofilled): Added. * WebCoreSupport/DumpRenderTreeSupportGtk.h: 2011-03-15 Ilya Sherman <isherman@chromium.org> Reviewed by Tony Chang. Autofilled form elements are assigned fixed background color but not text color https://bugs.webkit.org/show_bug.cgi?id=48382 * DOM/WebDOMOperations.mm: (-[DOMHTMLInputElement _setAutofilled:]): Added (wrapper). * DOM/WebDOMOperationsPrivate.h: 2011-03-15 Ilya Sherman <isherman@chromium.org> Reviewed by Tony Chang. Autofilled form elements are assigned fixed background color but not text color https://bugs.webkit.org/show_bug.cgi?id=48382 * DumpRenderTree/LayoutTestController.cpp: (setAutofilledCallback): Added. (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: * DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setAutofilled): Added. * DumpRenderTree/chromium/LayoutTestController.h: * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAutofilled): Added. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setAutofilled): Added. (LayoutTestController::setValueForUser): Style tweak. * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setAutofilled): Added (stub). * DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setAutofilled): Added (stub). git-svn-id: svn://svn.chromium.org/blink/trunk@81155 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
barraclough@apple.com authored
Reviewed by Sam Weinig. * dfg/DFGAliasTracker.h: (JSC::DFG::AliasTracker::recordPutByVal): - recordPutByVal is called for both PutByVal & PutByValAlias. git-svn-id: svn://svn.chromium.org/blink/trunk@81154 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
barraclough@apple.com authored
Rubber stamped by Sam Weinig. * bytecompiler/BytecodeGenerator.cpp: * bytecompiler/BytecodeGenerator.h: - delete uncalled code missed when reparsing was removed. git-svn-id: svn://svn.chromium.org/blink/trunk@81153 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
tony@chromium.org authored
Revert r81147 and r81149, broke the chromium win build. * WebKit.gyp: * scripts/generate_devtools_grd.py: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@81152 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
Fix a leak in WebStorageTrackerClient::dispatchDidModifyOrigin Fixes <http://webkit.org/b/56385> SecurityOrigin leaks seen in WebStorageTrackerClient::dispatchDidModifyOrigin Reviewed by Antti Koivisto. * Storage/WebStorageTrackerClient.mm: (WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread): Adopt the reference passed to us by dispatchDidModifyOrigin. (WebStorageTrackerClient::dispatchDidModifyOrigin): Added a comment and removed an unnecessary cast. git-svn-id: svn://svn.chromium.org/blink/trunk@81150 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
tony@chromium.org authored
Fix chromium build using python 2.5 (with statement). * scripts/generate_devtools_grd.py: git-svn-id: svn://svn.chromium.org/blink/trunk@81149 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
tony@chromium.org authored
Reviewed by Adam Barth. [chromium] add a build target to create a grd file with devtool resources https://bugs.webkit.org/show_bug.cgi?id=56335 This is the webkit side of the fix for http://code.google.com/p/chromium/issues/detail?id=35793 * WebKit.gyp: * scripts/generate_devtools_grd.py: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@81147 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
* platform/mac-wk2/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@81146 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Eric Carlson. HTMLMediaElement::mediaPlayerPlaybackStateChanged should not change the "public" state of the element if it's an internal pause for example. https://bugs.webkit.org/show_bug.cgi?id=56374 In case of an internal pause, the callback from the mediaplayer should be ignored to avoid reflecting the change into the DOM. No new tests: Verified manually. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged): git-svn-id: svn://svn.chromium.org/blink/trunk@81145 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by David Levin. AssociatedURLLoader does not support Cross Origin Requests https://bugs.webkit.org/show_bug.cgi?id=53925 No new tests. No new functionality exposed. * public/WebURLLoader.h: (WebKit::WebURLLoaderOptions::WebURLLoaderOptions): * src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::clearClient): (WebKit::AssociatedURLLoader::ClientAdapter::create): (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::willSendRequest): (WebKit::AssociatedURLLoader::ClientAdapter::didSendData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveResponse): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveCachedMetadata): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): (WebKit::AssociatedURLLoader::ClientAdapter::didFail): (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading): * src/AssociatedURLLoader.h: git-svn-id: svn://svn.chromium.org/blink/trunk@81144 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by James Robinson. Remove unnecessary function WebPlugin::getBackingTextureId https://bugs.webkit.org/show_bug.cgi?id=56122 It will be tested by Pepper2D and Pepper3D layout/smoke tests on the Chromium side. * public/WebPlugin.h: * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::platformLayer): git-svn-id: svn://svn.chromium.org/blink/trunk@81143 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mitz@apple.com authored
* TestWebKitAPI/Configurations/InjectedBundle.xcconfig: git-svn-id: svn://svn.chromium.org/blink/trunk@81142 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mnaganov@chromium.org authored
Unreviewed. Update chromium deps to pick up the latest V8. * DEPS: git-svn-id: svn://svn.chromium.org/blink/trunk@81141 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mitz@apple.com authored
* WebKitTestRunner/Configurations/InjectedBundle.xcconfig: * WebKitTestRunner/mac/TestControllerMac.mm: * WebKitTestRunner/mac/TestInvocationMac.mm: * WebKitTestRunner/mac/main.mm: git-svn-id: svn://svn.chromium.org/blink/trunk@81140 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kbalazs@webkit.org authored
Reviewed by Adam Barth. REGRESSION(80977): breaks Qt ARMv7 Linux Release bot https://bugs.webkit.org/show_bug.cgi?id=56349 * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig on platforms where we use it. Copied from DumpRenderTree.pro. git-svn-id: svn://svn.chromium.org/blink/trunk@81139 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mitz@apple.com authored
* DumpRenderTree/cf/WebArchiveDumpSupport.cpp: * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: git-svn-id: svn://svn.chromium.org/blink/trunk@81138 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
Reviewed by Adam Barth. [GTK] [WebKit2] The UIProcess never changes the mouse cursor https://bugs.webkit.org/show_bug.cgi?id=56333 Add an implementation for WebView::addCursor for WebKit2 GTK+. This allows the cursor to change as the user mouses around the page. There is currently no test infrastructure to track cursor changes. * UIProcess/gtk/WebView.cpp: (WebKit::WebView::setCursor): Ported implementation from WebKit1. git-svn-id: svn://svn.chromium.org/blink/trunk@81137 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
podivilov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: re-implement xhr breakpoints. https://bugs.webkit.org/show_bug.cgi?id=56252 * inspector/debugger/xhr-breakpoints-expected.txt: Added. * inspector/debugger/xhr-breakpoints.html: Added. * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: 2011-03-12 Pavel Podivilov <podivilov@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: re-implement xhr breakpoints. https://bugs.webkit.org/show_bug.cgi?id=56252 - restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints - store xhr breakpoints in a separate setting - move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane Test: inspector/debugger/xhr-breakpoints.html * inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clear): * inspector/InspectorBrowserDebuggerAgent.h: * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.setXHRBreakpoint): (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId): * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing): (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked): (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight): (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints): (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged): * inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._debuggerPaused): (WebInspector.ScriptsPanel.prototype._clearInterface): * inspector/front-end/Settings.js: (WebInspector.Settings): * inspector/front-end/inspector.js: (WebInspector.resetFocusElement): (WebInspector.set attached): git-svn-id: svn://svn.chromium.org/blink/trunk@81136 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
kevino@webkit.org authored
Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export info into the headers rather than in export symbol definition files, but disable it on all platforms initially so we can deal with port build issues one port at a time. https://bugs.webkit.org/show_bug.cgi?id=27551 git-svn-id: svn://svn.chromium.org/blink/trunk@81135 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
loislo@chromium.org authored
Unreviewed build fix. Chromium: shared lib linux build are failing. Two exclude rules for LocalizedNumberNone and TextEncodingDetectorNone were added to the wrong library. It was webcore_remaining instead of webcore_platform. * WebCore.gyp/WebCore.gyp: git-svn-id: svn://svn.chromium.org/blink/trunk@81134 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: expanding/collapsing object shouldn't affect outer console.group expansion state https://bugs.webkit.org/show_bug.cgi?id=56373 * inspector/front-end/Section.js: (WebInspector.Section): (WebInspector.Section.prototype.toggleExpanded): (WebInspector.Section.prototype.handleClick): stop click even propagation if it was handled by this section. git-svn-id: svn://svn.chromium.org/blink/trunk@81133 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: crash upon "//html//@id" search in elements panel. https://bugs.webkit.org/show_bug.cgi?id=56334 * inspector/elements/elements-panel-search-expected.txt: * inspector/elements/elements-panel-search.html: 2011-03-15 Pavel Feldman <pfeldman@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: crash upon "//html//@id" search in elements panel. https://bugs.webkit.org/show_bug.cgi?id=56334 * inspector/InspectorDOMAgent.cpp: * inspector/front-end/ElementsTreeOutline.js: git-svn-id: svn://svn.chromium.org/blink/trunk@81132 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
caseq@chromium.org authored
Unreviewed. Swap two calls to setMonitoringXHREnabled to get rid of side effects on other tests. * inspector/protocol/console-agent-expected.txt: * inspector/protocol/console-agent.html: git-svn-id: svn://svn.chromium.org/blink/trunk@81131 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
caseq@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: further extension API cleanup (removed inspectedPage, add experimental prefix) https://bugs.webkit.org/show_bug.cgi?id=56327 * inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI): * inspector/front-end/ExtensionAPISchema.json: git-svn-id: svn://svn.chromium.org/blink/trunk@81130 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: when console.groupEnd calls twice https://bugs.webkit.org/show_bug.cgi?id=56114 * inspector/console/console-nested-group-expected.txt: Added. * inspector/console/console-nested-group.html: Added. 2011-03-15 Yury Semikhatsky <yurys@chromium.org> Reviewed by Pavel Feldman. Web Inspector: when console.groupEnd calls twice https://bugs.webkit.org/show_bug.cgi?id=56114 Test: inspector/console/console-nested-group.html * inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::type): * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::addConsoleMessage): do not coalesce adjacent EndGroup messages. git-svn-id: svn://svn.chromium.org/blink/trunk@81129 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Adam Barth. Initializing several member variables that were not initialized in their constructors. These values were all read prior to initialization as reported by Valgrind. No new tests: No feature additions/removals. * accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink): * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): * xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult): git-svn-id: svn://svn.chromium.org/blink/trunk@81128 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
