GitLab

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4e5e7f1..15e603d

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/882393002

Cr-Commit-Position: refs/heads/master@{#313699}

Cr-Commit-Position: refs/heads/master@{#313698}

Revert of Don't refcount tracking id -> slot id mapping. (patchset #6 id:120001 of https://codereview.chromium.org/785753002/)

Reason for revert:
Reverting due to memory failures.

http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/5041/steps/memory%20test%3A%20content/logs/stdio

{
UNINITIALIZED READ
name=<insert_a_suppression_name_here>
content.dll!content::TouchEventQueue::TouchMoveSlopSuppressor::FilterEvent
content.dll!content::TouchEventQueue::FilterBeforeForwarding
content.dll!content::TouchEventQueue::TryForwardNextEventToRenderer
content.dll!content::TouchEventQueue::ProcessTouchAck
content.dll!content::InputRouterImpl::ProcessInputEventAck
content.dll!content::InputRouterImpl::OnInputEventAck
content.dll!InputHostMsg_HandleInputEvent_ACK::Dispatch<>
content.dll!content::InputRouterImpl::OnMessageReceived
content.dll!content::RenderWidgetHostImpl::OnMessageReceived
*!content::RenderWidgetHostViewAuraTest_TouchEventState_Test::TestBody
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/40143/steps/memory%20test%3A%20content/logs/stdio

UninitCondition
Conditional jump or move depends on uninitialised value(s)
  content::TouchEventQueue::TouchMoveSlopSuppressor::FilterEvent(blink::WebTouchEvent const&) (content/browser/renderer_host/input/touch_event_queue.cc:240)
  content::TouchEventQueue::FilterBeforeForwarding(blink::WebTouchEvent const&) (content/browser/renderer_host/input/touch_event_queue.cc:715)
  content::TouchEventQueue::TryForwardNextEventToRenderer() (content/browser/renderer_host/input/touch_event_queue.cc:445)
  content::TouchEventQueue::ProcessTouchAck(content::InputEventAckState, ui::LatencyInfo const&) (content/browser/renderer_host/input/touch_event_queue.cc:436)
  content::InputRouterImpl::ProcessTouchAck(content::InputEventAckState, ui::LatencyInfo const&) (content/browser/renderer_host/input/input_router_impl.cc:666)
  content::InputRouterImpl::ProcessInputEventAck(blink::WebInputEvent::Type, content::InputEventAckState, ui::LatencyInfo const&, content::InputRouterImpl::AckSource) (content/browser/renderer_host/input/input_router_impl.cc:576)
  content::InputRouterImpl::OnInputEventAck(InputHostMsg_HandleInputEvent_ACK_Params const&) (content/browser/renderer_host/input/input_router_impl.cc:483)
  _Z20DispatchToMethodImplIN7content15InputRouterImplEMS1_FvRK40InputHostMsg_HandleInputEvent_ACK_ParamsEJS2_EJLm0EEEvPT_T0_RK5TupleIJDpT1_EE13IndexSequenceIJXspT2_EEE (base/tuple.h:246)
Suppression (error hash=#675E7177BFE2BE12#):
  For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
   <insert_a_suppression_name_here>
   Memcheck:Uninitialized
   fun:_ZN7content15TouchEventQueue23TouchMoveSlopSuppressor11FilterEventERKN5blink13WebTouchEventE
   fun:_ZN7content15TouchEventQueue22FilterBeforeForwardingERKN5blink13WebTouchEventE
   fun:_ZN7content15TouchEventQueue29TryForwardNextEventToRendererEv
   fun:_ZN7content15TouchEventQueue15ProcessTouchAckENS_18InputEventAckStateERKN2ui11LatencyInfoE
   fun:_ZN7content15InputRouterImpl15ProcessTouchAckENS_18InputEventAckStateERKN2ui11LatencyInfoE
   fun:_ZN7content15InputRouterImpl20ProcessInputEventAckEN5blink13WebInputEvent4TypeENS_18InputEventAckStateERKN2ui11LatencyInfoENS0_9AckSourceE
   fun:_ZN7content15InputRouterImpl15OnInputEventAckERK40InputHostMsg_HandleInputEvent_ACK_Params
   fun:_Z20DispatchToMethodImplIN7content15InputRouterImplEMS1_FvRK40InputHostMsg_HandleInputEvent_ACK_ParamsEJS2_EJLm0EEEvPT_T0_RK5TupleIJDpT1_EE13IndexSequenceIJXspT2_EEE
}

I haven't been able to reproduce this consistently locally, which is making it tricky to pin down. Once I have (or I've determined this patch isn't what's causing the failures), I'll reland.

Original issue's description:
> Don't refcount tracking id -> slot id mapping.
>
> Previously we tried to refcount the tracking id to slot id mapping.
> This broke in some circumstances where the number of press events was
> not equal to the number of release events.
>
> This patch switches to marking some touch events such that they don't
> modify the mapping, simplifying logic, and fixing a nasty bug.
>
> BUG=439051
> TEST=EventsXTest.TouchEventNotRemovingFromNativeMapping
>
> Committed: https://crrev.com/47a823b565a4051e58d83a857738c0fb8417d9ac
> Cr-Commit-Position: refs/heads/master@{#313520}

TBR=sadrul@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=439051

Review URL: https://codereview.chromium.org/869433007

Cr-Commit-Position: refs/heads/master@{#313697}

Without it the overhead of serialized ios simulator run is too big.

BUG=426870
R=sky@chromium.org, smut@google.com

Review URL: https://codereview.chromium.org/886463003

Cr-Commit-Position: refs/heads/master@{#313696}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/af451c1..4e5e7f1

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/888553002

Cr-Commit-Position: refs/heads/master@{#313695}

navigate function of navigator object is not getting called.

Changes done so that navigate function of navigator will get called
with proper url and newTab as true value.

BUG=453307

Review URL: https://codereview.chromium.org/886773003

Cr-Commit-Position: refs/heads/master@{#313694}

R=digit@chromium.org

Review URL: https://codereview.chromium.org/882373002

Cr-Commit-Position: refs/heads/master@{#313693}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/01a83c9..af451c1

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/886773002

Cr-Commit-Position: refs/heads/master@{#313692}

Our main goal is to understand how often is the situation when no security storage is available on Linux and plain text (actually SQL lite db) is used for password storage.

BUG=355223

Review URL: https://codereview.chromium.org/880943002

Cr-Commit-Position: refs/heads/master@{#313691}

BUG=357038

Review URL: https://codereview.chromium.org/881653005

Cr-Commit-Position: refs/heads/master@{#313690}

BUG=450589
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/890473003

Cr-Commit-Position: refs/heads/master@{#313689}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/61cdebe..01a83c9

TBR=rjwright@chromium.org,junov@chromium.org

Review URL: https://codereview.chromium.org/871403006

Cr-Commit-Position: refs/heads/master@{#313688}

BUG=451148

Review URL: https://codereview.chromium.org/880303003

Cr-Commit-Position: refs/heads/master@{#313687}

This reverts commit b138032e.

This seems to make RenderTextTest.TextDoesntClip to fail on Chrome OS Asan /Lsan.

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6266

BUG=448948
TBR=xdai1@chromium.org

Review URL: https://codereview.chromium.org/889533002

Cr-Commit-Position: refs/heads/master@{#313686}

BUG=451374

Review URL: https://codereview.chromium.org/866713003

Cr-Commit-Position: refs/heads/master@{#313685}

BUG=452847

Review URL: https://codereview.chromium.org/877333002

Cr-Commit-Position: refs/heads/master@{#313684}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/882313002

Cr-Commit-Position: refs/heads/master@{#313683}

Flaky on Mac, see bug.

BUG=453256
TBR=rouslan@chromium.org

Review URL: https://codereview.chromium.org/889483003

Cr-Commit-Position: refs/heads/master@{#313682}

DeviceStatusCollector used to report multiple CPU usage measurements, but only a
single free-RAM measurement. This CL changes the reporting code to report
multiple free-RAM measurements.

BUG=430908

Review URL: https://codereview.chromium.org/884063003

Cr-Commit-Position: refs/heads/master@{#313681}

The CL removes:

* fileManagerPrivate.visitDesktop
* ImageSet

BUG=450129
TEST=None
R=kinaba@chromium.org
TBR=benwells@chromium.org, isherman@chromium.org

Review URL: https://codereview.chromium.org/819953005

Cr-Commit-Position: refs/heads/master@{#313680}

Drop references to reference frames before requesting new surfaces to
ensure we don't hold onto them while the Accelerator is changing resolution,
risking reusing a stale buffer.

BUG=chrome-os-partner:35539
TEST=Hangouts, vdatest

Review URL: https://codereview.chromium.org/880773009

Cr-Commit-Position: refs/heads/master@{#313679}

Cr-Commit-Position: refs/heads/master@{#313678}

Note that accessibility_event_recorder_win a test helper, this
doesn't add logging to Chrome.

BUG=440579
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/873313009

Cr-Commit-Position: refs/heads/master@{#313677}

The term 'gdata' is no longer relevant, since we stiched from
WAPI (GDATA based API) to Drive API.

BUG=357038
TEST=everything builds as before

Review URL: https://codereview.chromium.org/881403003

Cr-Commit-Position: refs/heads/master@{#313676}

Quotes to command now adding only if "su -c" parameter is present.

R=jbudorick@chromium.org
BUG=452237

Review URL: https://codereview.chromium.org/880853002

Cr-Commit-Position: refs/heads/master@{#313675}

BUG=413528

Review URL: https://codereview.chromium.org/890493002

Cr-Commit-Position: refs/heads/master@{#313674}

Currently seeing a crash when two iframes from the same origin request the
same permission. The issue arises because they have the same ID and therefore
the same entry in the hash map, which makes the request_ptr destruct. This CL
cancels the second (redundant) permission request.

BUG=433877

Review URL: https://codereview.chromium.org/799783002

Cr-Commit-Position: refs/heads/master@{#313673}

This helps with debugging a TabbedPane views hierarchy as you can print
the proper class names of Tabs and TabStrips inside.

Review URL: https://codereview.chromium.org/889453004

Cr-Commit-Position: refs/heads/master@{#313672}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5e88f46..61cdebe

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/890453003

Cr-Commit-Position: refs/heads/master@{#313671}

BUG=450908

Review URL: https://codereview.chromium.org/861343005

Cr-Commit-Position: refs/heads/master@{#313670}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/34bc400..5e88f46

TBR=leviw@chromium.org,rjwright@chromium.org

Review URL: https://codereview.chromium.org/886513003

Cr-Commit-Position: refs/heads/master@{#313669}

The infobar container became non-scrollable because InfoBarContainer now
ignores all touch events in InfoBarContainer.onTouch(). These touch
events need to be swallowed to prevent them from reaching the webpage,
but they should be swallowed in ContentWrapperView, not in
InfoBarContainer, so that InfoBarContainer (which extends ScrollView)
can be scrolled.

The offending CL: https://codereview.chromium.org/824763002

BUG=453103

Review URL: https://codereview.chromium.org/872113003

Cr-Commit-Position: refs/heads/master@{#313668}

BUG=450050

Review URL: https://codereview.chromium.org/828063007

Cr-Commit-Position: refs/heads/master@{#313667}

BUG=451934

Review URL: https://codereview.chromium.org/879913005

Cr-Commit-Position: refs/heads/master@{#313666}

Previously, calling postMessage from an isolated world would use that
world's context for calling the proxy frame's postMessage(). This
resulted in "Illegal invocation" errors. This CL avoids this problem by
using the main world script context when calling postMessage on the
proxy frame.

BUG=453184

Review URL: https://codereview.chromium.org/861073004

Cr-Commit-Position: refs/heads/master@{#313665}

Since I removed the IRT's calls to NaClSrpcModuleInit() and
NaClPluginLowLevelInitializationComplete(), the IRT no longer depends
on SRPC.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864
TEST=build

Review URL: https://codereview.chromium.org/878623004

Cr-Commit-Position: refs/heads/master@{#313664}

In addition to the extensions also parse GL/GLES version
information from the headers (hence add a few fresh headers).

Instead of brute-forcing binding in somewhat unclear order
make all dynamic bindings very specifically conditional to
the GL version or extension, given the precise name.
If a function is not available, then leave function pointer
set to NULL so it will generate a crash (report).
(Previously it might have ended up as 0
or with whatever valid or not valid pointer GetProcAddr()
returned - i.e. GetProcAddr returning something does not
imply the functionality is there.)

The version also includes whether it is GLES or not which
means we won't look up functions on GLES anymore that are
specific to desktop or vice versa.

Update gpu_unittests so that they are very specific to what
extensions they need (otherwise they might end up calling
the _NotBound fallback).

Also make WGL/GLX/EGL/MESA bindings all happen rightaway since
they don't depend on a context.

BUG=438742,325668

Review URL: https://codereview.chromium.org/871763002

Cr-Commit-Position: refs/heads/master@{#313663}

Makes sure that a WebView as RenderProcessHostObserver is removed from RenderProcessHost's observer list when RenderProcessHost exits.

BUG=290701

Review URL: https://codereview.chromium.org/878383002

Cr-Commit-Position: refs/heads/master@{#313662}

The line is specified for the hidden redu button does not affect layout of other
buttons, but it removes the button from the layout even if the button is
visible, and it causes overlapping of the buttons.  Actually we can remove the
line because hidden items are specified display: none; in Gallery.

BUG=450186
TEST=None

Review URL: https://codereview.chromium.org/866893004

Cr-Commit-Position: refs/heads/master@{#313661}

Show the keyboard switcher icon on the right edge of the navigation bar
when two or more IMEs are enabled and a physical keyboard is connected.

BUG=452543

Review URL: https://codereview.chromium.org/879403003

Cr-Commit-Position: refs/heads/master@{#313660}