- 06 Oct, 2020 40 commits
-
-
Jan Krcal authored
This is a reland of b8368dd1 Original change's description: > [Profile creation] Show sync confirmation and finish the flow > > This CL proceeds with the happy path of the signed-in profile creation > flow: > 1) After a successful sign-in, the current WebUI for sync confirmation > gets displayed; > 2) After choosing whether to sync, the flow is finished by opening a > browser window for the new profile. > > Error handling and restyling the confirmation page is left for follow-up > CLs. > > Bug: 1126913 > Change-Id: I17b43fe4ec0c0e0f2f9725b1df8e8e59d2c35f3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421592 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811140} Bug: 1126913 Change-Id: I4b3b6d974214c4be16f207111007887b433b04dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437373 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#814160}
-
Hitoshi Yoshida authored
SanitierConfig is a construction options for Sanitizer. Its members are defined to have non-null types in spec[1], and this CL makes its Blink implementation to follow the spec. [1] https://wicg.github.io/sanitizer-api/#sanitizer-api Bug: 839389, 116418 Change-Id: I86302fe6f36894bf102d23844bb9353ba5bdb1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444770Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#814159}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I924615894dbd75baf38ad389b160834d5868ac7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446209Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814158}
-
Viktor Semeniuk authored
This change shows proper string when user is signed out and there are no weak passwords. Bug: 1135155 Change-Id: I46da38d75f48bc230058cf9f6f36b3effd0cd45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448373 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814157}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I475d54b703c2cea4ca5f6a816a200511571901e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445933Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814156}
-
Anastasiia N authored
Update width of management status label in settings, so it can fit the default "Primary account" text. Screenshots: http://screen/3QzuPjQMPCUpr8e, http://screen/9FRoEbupQUdSZ8e, http://screen/9vrUQp9LczfghoW Bug: 1099332 Change-Id: I22a92c993bc7ed960da0cf85b8455559794cb450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442016 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#814155}
-
Gabriel Marin authored
Updated the microarchitecture based unit tests for default commands to check that the first two commands are sampling CPU cycles. BUG=b:170056137 Change-Id: I6a1a91e4f1b35cb0c3e6ef77dc6aa8a297f831ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450841Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#814154}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/326e14f34bb5..db2c2dd9b9a2 2020-10-06 enrico.galli@intel.com Add support for depthBias, depthBiasSlope, and depthBiasClamp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: If65aac1dcb0371a906ce334920b630071fc0ec7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814153}
-
Callum May authored
Edge has been receiving reports of null pointer crashes similar to the linked bug. We believe they are caused by AuthenticatorCommon::IsUserVerifyingPlatformAuthenticatorAvailable passing in a null delegate since ContentBrowserClient::GetWebAuthenticationRequestDelegate may return a nullptr if the embedder can't service the request. To fix this we can check the pointer before calling the delegate Bug: 1110081 Change-Id: I007a8815fb23e86e025e2ccafb2bcc74d40aebfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423049 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#814152}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Idd7a25c5d7b92eb7595bdc00b4482f8344de231a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451906Reviewed-by:
-
Paula Vidas authored
The class is moved to a helper file so it can be reused in tests for sync invalidations. Bug: 1135167 Change-Id: I30cbc76cd5ed032666c5827b007c94128a65ebb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450269 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#814150}
-
Aya ElAttar authored
- Changed ClipboardNonBacked::ReadImage to run ReadImageCallback with empty SKBitmap as a crash happens when it returns without running the callback. Bug: 1133717 Test: New unit test added. Change-Id: I6a7264b8b0d0c56e78852ed1822883cdd9c4efc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440656 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814149}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d0b4e1976ca1..9929780af36a 2020-10-06 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ib134880d8033303df6322748be8a16e60e2e9fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451899Reviewed-by:
-
Monica Basta authored
The code assumes if no browser exists for the profile where the signin is happening then the sign in error is related to the user manager. The previous assumption is not valid if the user decides to close the profile while the user manager or another profile is open. This CL compares the profile path with |UserManager::GetSigninProfilePath| and only in case of equality uses |UserManagerProfileDialog::DisplayErrorMessage| to show the sign in error. Bug: 1132175 Change-Id: Icccdc44d3927d8750bea9957120d7fef6677c4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435309 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Monica Basta <msalama@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814147}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/32decd42e68a..f79f298cc9cb 2020-10-06 sigurds@chromium.org Fix CSS priority for generated dark-mode themes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135123 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7a720b9d513b66ed48d67eeeef26cdf3fac4134a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451907Reviewed-by:
-
Mikel Astiz authored
The metric has collected sufficient data and the team considers it sufficient to rely on Sync.PostedClientToServerMessageLatency. Change-Id: I5e53d623c058999a6bc5c7adb7b623141abe92f4 Fixed: 1105063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445151 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814145}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601899131-c43b6187adc90e2cb7e0fb0be3a8513091bf4fd9.profdata to chrome-win32-master-1601942192-fa539b08a521491a2633981acf18458f1a2ef415.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie4653559492a162b60d116d3be8f0a22ee3abbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451750Reviewed-by:
-
Nohemi Fernandez authored
This reverts commit 4f68ef3f. Reason for revert: Failing bot MAC Asan 64 tests https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/65394 Original change's description: > Desktop PWAs: Browser tests wait for registry > > The browser test helper methods in web_app_browsertest_util.cc > that install PWAs (InstallWebApp, InstallWebAppFromManifest, > PendingAppManagerInstall) now wait for on_registry_ready(). > > Bug: 1119807 > Change-Id: I60c16e04b75603a8d0979fd09e9f6746335cd788 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450133 > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Auto-Submit: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814065} TBR=dmurph@chromium.org,ericwilligers@chromium.org,alancutter@chromium.org,loyso@chromium.org Change-Id: I23471abd515c34d6262def80bc83613420f90622 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119807,1135469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450319 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#814143}
-
Nohemi Fernandez authored
This reverts commit 430b7621. Reason for revert: Failing builder https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel Original change's description: > [LayoutNG] Don't truncate margins after spanners. > > A column spanner forcefully breaks a column, so any leading margins on > content right after the spanner shouldn't be discarded. > > Bug: 829028 > Change-Id: I767466677d72be2760306ddd531e847f52cfa8ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445482 > Reviewed-by: Alison Maher <almaher@microsoft.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813892} TBR=ikilpatrick@chromium.org,mstensho@chromium.org,almaher@microsoft.com Change-Id: I535ec21071aacd85f22968286e0f920fd2870324 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450062Reviewed-by:
-
Alexander Bolodurin authored
Split fileManagerPrivate.getThumbnail() into getDriveThumbnail() and getPdfThumbnail() to allow implementation-specific arguments: PDF thumbnailer supports size arguments, Drive thumbnailer only supports crop and, in future, others that may have their own (and different) argument needs. For getPdfThumbnail(), pass through size arguments from the image loader request to the PDF thumbnailer and pull up default values from C++ to the image loader JS code, to make them usable in other thumbnailers that take explicit dimension arguments. Bug: 1049966 Change-Id: Ia17a32028a7fb510c1755c9fa0283f9a37978331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434013 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814141}
-
Boris Sazonov authored
PrimaryAccountManager.IsAuthenticated was only checking sync account and wasn't fitting into the new consent-aware API for the primary account. This CL introduces HasPrimaryAccount(ConsentLevel) and replaces existing calls to IsAuthenticated with HasPrimaryAccount(kSync). Subsequent CLs will replace HasUnconsentedPrimaryAccount with HasPrimaryAccount(kNotRequired) and so on. Bug: 1046746 Change-Id: I2118ecbfc2295b9c437de304fd8617e1d13665aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440621 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Koji Ishii authored
TBR=ikilpatrick@chromium.org NOTRY=True Bug: 1134724 Change-Id: I8b3bf9d6e9c204854d16a082ff3a2c7987a36755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452090Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814139}
-
Patrick Brosset authored
When initiator objects are created for parser and script type requests a line number is passed, so that clients can possibly link http requests to locations in source files. For some reasons, only the line number is passed and not the column. This means that for minified files (where all content is on one line) it is impossible to link to the exact location. Furthermore, clients like DevTools which know how to re-format minified files won't be able to link to the right line once a file is re-formatted. The column number is already available in the TextPosition object that is set in FetchInitiatorInfo, so in this change, we just return it to the client too. Corresponding frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2444236/ Bug: 1134064 Change-Id: I297924c3a22176309bd0fe4b613f7f1a42163ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442367Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814138}
-
Kenichi Ishibashi authored
This CL removes AppCacheResponseReader dependency from ServiceWorkerResourceWriter by re-implementing resource writing logic. See [1] for the reasoning of the rewrite. [1] https://docs.google.com/document/d/1UhdZnaeEP8GywZR0Gik6wF6jKmNY3je6aDhPfJ05YhU/edit?usp=sharing This CL should not have behavior changes, and existing tests like ServiceWorkerResourceStorageTest cover this change. Bug: 1117369 Change-Id: I2fe4075ddff1c185768e0dd245e49f1ac5c26962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430687 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814137}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/da61c40e99c3..08142700a841 2020-10-06 ianelliott@google.com Work-around test runner & DebugAnnotator 2020-10-06 jmadill@chromium.org Test Runner: More docs. 2020-10-06 cclao@google.com Vulkan: Defer the depthStencil buffer layout change to endRenderPass 2020-10-06 ianelliott@google.com Plumb EntryPoint & Context to DebugAnnotator/EVENT() 2020-10-06 cclao@google.com Vulkan: Add plumbing to render pass when ImageHelper gets deleted If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I5459486104af4c641a700789b2e449d91fdb139f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451893Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fa5ff7d234b8..00dc0bcb4d54 2020-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 500704812409 to 77e3d0ae97b6 (22 revisions) 2020-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b3c1e71eb1cb to afe6ca45b6da (4 revisions) 2020-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2cd17d78 to 4259b6b6 (463 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Test: Test: Test: Temple Run on multiple systemsTest: Test: angle_perftests --gtest_filter="*Trace*" Change-Id: Ie7a8889ac3d4d4390b9ef9d9b334824a79ca6387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451692Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601942192-5610f8208d2a00c81b789319176c3ce4858b86b7.profdata to chrome-linux-master-1601963930-28f0c2d12f0ac8a2122590ec137db80f0d74ffd6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I19c0bcfbccf4170d2f7bcbb699eeeb19beb57858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451898Reviewed-by:
-
Yuki Shiino authored
Adds a unittest for the change of https://crrev.com/c/2418513 . Also removes unnecessary "#if defined" guards. All test cases in allocator_shim_unittest.cc depend on USE_ALLOCATOR_SHIM, so the entire contents of the file should be guarded with it. Currently it's done at: https://source.chromium.org/chromium/chromium/src/+/master:base/BUILD.gn;drc=625ee4c0eea632fed7825725d54843ef3cd6ca2c;l=3352 Bug: 1111332 Change-Id: I2204d88b676365b317e27f21baa0fb5ba8df213c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449869 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#814133}
-
Fredrik Söderqvist authored
This is largely a revert of the code-change from a77da2a9, since that workaround should no longer be required now that the visual rect no longer has bounds of clip-path, mask and filter baked in. Also replace the check of LayoutObjectCanHaveResources() with a DCHECK since this is guaranteed by the callers. Bug: 1028061, 1028063 Change-Id: I3cd7eef130468ca1bb2e6473535fac815a7bda1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450151Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#814132}
-
Gyuyoung Kim authored
This CL replaces all uses of EditingBehaviorType with mojom::EditingBehavior to reduce unnecessary type conversion. Bug: 1097943 Change-Id: I013e40a725d7b12f1f9d88a37f068e4163d1d399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#814131}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f76601902650..32decd42e68a 2020-10-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0ddbb9dc49f4002b274f65f39e88a5e80b7d7144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451645Reviewed-by:
-
Morten Stenshorne authored
Suspecting crrev.com/2333083 , but didn't check. TBR=ikilpatrick@chromium.org Change-Id: Idf7a1156bccdf78adf6743ae4e7d703a9198cb5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450059Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#814129}
-
Fredrik Söderqvist authored
Rather than letting the container of the LayoutObject manage the SVGResources, have it manage it itself via InsertedIntoTree() and WillBeRemovedFromTree() overrides. This allows limiting the checks in the called methods a bit since we know what LayoutObjects it's being called on. Bug: 1028063 Change-Id: I54b28336649c6c200dcf4c220fd869fe66770119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450050Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ibbe33355abdb999f7afb612bb3ab6c8b9b93178c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451812Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814127}
-
Colin Blundell authored
This CL splits out the ContentSubresourceFilterThrottleManager test implementation of SubresourceFilterClient from the test fixture class. This is necessary for an upcoming change which will have the ThrottleManager own the client instance as part of simplifying the embedder-side responsibilities in advance of WebLayer bringup. It is also IMO more readable in any case. Bug: 1116095 Change-Id: I85fc42e393ecfa9cdaaa2148ee08f74f2324d00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443010 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#814126}
-
Marc Treib authored
The verifier profile doesn't always exist; notably it doesn't when running against external servers (aka E2E_TEST, aka KitchenSync). This fixes a test crash when running in that mode. Bug: 1135195 Change-Id: I163583c74e2139cd50f9d658657832d57550a3ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450290 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814125}
-
Gauthier Ambard authored
This CL fixes which URL is used to set the document URL. The previous implementation was using the WebView URL. Some times this is not the same as the URL of the navigation. For example on the following workflow: 1. Start a navigation to about://newtab 2. Once the navigation1 reach DidStartNavigation, start a navigation to another page (e.g. http://example.com). 3. The URL of WebView is updated to http://example.com 4. The provisional navigation to http://example is starting 5. The navigaation1 (to about://newtab) is committed. At step 5, the documentURL should be the URL of the committed navigation (i.e. about://newtab), but the URL of the WebView is http://example.com. Fixed: 1127025 Change-Id: Icc271b87c1877bf005ee4454c863126aacb81127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418856 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#814124}
-
Sigurd Schneider authored
Follow-up to https://crrev.com/c/2450031, unlocks https://crrev.com/c/2450032 Bug: chromium:1135143 Change-Id: I792677962aa6de9ffcf20e7f4e6fe9300fbe0b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450149Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#814123}
-
James Cook authored
Move the ChromeOS.* prefixed metrics into their own file/directory. Most of these metrics are not general Chrome browser metrics, and this will let us have a separate OWNERS file once we train up some reviewers. Bug: none Change-Id: If42613c021c44e0e0639ec68db6f012416046c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446519 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 988a0b63. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/CSS2/text NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Ied524cd5922082cd36afb646f732ab9c96ce2eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451534Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814121}
-
