- 23 Oct, 2018 40 commits
-
-
Alexander Alekseev authored
Do not show HID detection screen for devices that have virtual keyboard and pointing device. Bug: 890142 Change-Id: I0fa128664166a566fead192174253d1e6fef878a Reviewed-on: https://chromium-review.googlesource.com/c/1297399Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#602147}
-
Bill Orr authored
The idea here is that we have potentially multiple "runtimes" backing a single VRDisplay for WebVR so we don't need GVR for magic window sessions. However, that means we have to aggregate multiple display info changes coming from multiple runtimes and decide which display info the aggregate device reports. This flag is used as part of that logic - mostly we take the presenting display info. This was a simple copy-paste error that causes us to treat immersive sessions as non-immersive for these updates. BUG=897401 Change-Id: If4685282e8756875b85b808aa61aca1e9622cb16 Reviewed-on: https://chromium-review.googlesource.com/c/1295317 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#602146}
-
Alexandre Frechette authored
Bug: 883456 Change-Id: I48aab1bb09fe5527cc6ad07a9c3ccadc87224055 Reviewed-on: https://chromium-review.googlesource.com/c/1291784 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#602145}
-
siyua authored
And also remove card index since we are not using index for checkbox status update. Bug: 897998 Change-Id: I60513831b0392c469d62dfd45a15719670662272 Reviewed-on: https://chromium-review.googlesource.com/c/1287434Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#602144}
-
Kevin Strohbehn authored
Bug: 897892 Change-Id: I0f1412fba8ee32d998f7166a90c1d4ee7d78b70b Reviewed-on: https://chromium-review.googlesource.com/c/1292891 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602143}
-
dpapad authored
Because of Polymer 2's different observer dependencies semantics the default setting was erroneously toggled when the user enter the subpage. Bug: 897236 Change-Id: I83b8959734e85d39e35f0acd187062326143b876 Reviewed-on: https://chromium-review.googlesource.com/c/1297231Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602142}
-
dpapad authored
Wrapping <style is="custom-style"> with <custom-style> per Polymer 2 migration guide. Bug: 897221 Change-Id: If7fe3c858b631ad11604feb7f1eb144b1488ccfb Reviewed-on: https://chromium-review.googlesource.com/c/1297253Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602141}
-
Mohamed Heikal authored
Add a new function to build_utils to make it easier to filter output from CheckOutput if you just have a regular expression matching silenceable lines. Change-Id: I41f1c94fbe47405aae980a00df137439825a7f05 Reviewed-on: https://chromium-review.googlesource.com/c/1284751 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#602140}
-
Xianzhu Wang authored
Whether a test produces pixel results should be decided by the test itself. Controlling that outside of the test is unnecessary. Removing it can greatly simplify our code. This is a preparation to replace the ImageFirst feature with a better solution (https://chromium-review.googlesource.com/c/chromium/src/+/1277654). TBR=mkwst@chromium.org # For simple passive changes Bug: 703899 Change-Id: Ia04b622e24f88cf2408f20e5e6888d933e34dac5 Reviewed-on: https://chromium-review.googlesource.com/c/1277820 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#602139}
-
Justin Cohen authored
While ios/chrome will soon be dropping iOS10, ios-web will need to continue to support the old versions SDK. Bug: 894099 Change-Id: I9743fc39eccf7493ee4df8f09bd9313ee05e84ad Reviewed-on: https://chromium-review.googlesource.com/c/1296678 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#602138}
-
Xida Chen authored
Right now the CSSPaintDefinition::Paint takes a FloatSize which is the container size without subpixel snapping. So when we create the paint worklet input, we should use the same FloatSize. Bug: 884698 Change-Id: Ifcabb84cdb8db041a8ebd28112d4943c4c7adcb0 Reviewed-on: https://chromium-review.googlesource.com/c/1291783Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602137}
-
Morten Stenshorne authored
Got fixed a long time ago by something, and got picked up by https://chromium-review.googlesource.com/844269 , which fixed the NG-specific expectations file. TBR=kojii@chromium.org Change-Id: Ib973a02cc91d2699b9c9b6fdd927ff24f997da42 Reviewed-on: https://chromium-review.googlesource.com/c/1296607Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#602136}
-
Esmael El-Moslimany authored
When |ticks.length == 1| or the public |disabled| property is true, the slider is effectively disabled. Bug: 895831 Change-Id: Iea13afaec1b784a433fd9f7fa8fe9d7a98a531b9 Reviewed-on: https://chromium-review.googlesource.com/c/1284090 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602135}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4624f363d41a..8f7440e30ca2 git log 4624f363d41a..8f7440e30ca2 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 treehugger-gerrit@google.com Merge "perfetto: Commit memory in chunks in TraceBuffer" Created with: gclient setdep -r src/third_party/perfetto@8f7440e30ca2 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I100a4101a3ec8b0adb966df381d9f88d4798b0d1 Reviewed-on: https://chromium-review.googlesource.com/c/1297272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602134}
-
Josh Gao authored
Having multiple objects simultaneously own a file descriptor inhibits error-checking that prevents unintentional double closes where we don't immediately release an fd from the previous owner after handing over ownership. Release the fd before passing ownership instead. Bug: 897897 Change-Id: Iecc5fa434d2e676fef44b9d27313337efd02c9e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297411Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Josh Gao <jmgao@google.com> Cr-Commit-Position: refs/heads/master@{#602133}
-
Xiaohui Chen authored
Bug: None Test: locally build Change-Id: If7f936051ecc056969e10328fed1ffe257cce226 Reviewed-on: https://chromium-review.googlesource.com/c/1297351Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#602132}
-
Xiaohan Wang authored
This CL converts MediaSourceTest to use GetMimeTypeForFile() to get the mime type for test files to remove duplicate code. Bug: 897767 Test: No functionality change Change-Id: I5953cf8ae4e466d6fbb9c5d0ea021077a6f27f7f Reviewed-on: https://chromium-review.googlesource.com/c/1296998Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602131}
-
erikchen authored
Previously, the implementation only worked on Win8.1+, and had no fallback for DiscardVirtualMemory failures [which are known to occur on some Win10 versions]. This CL switches the logic to be the same as PartitionAlloc -- it uses DiscardVirtualMemory with a fallback to VirtualAlloc(MEM_RESET), which works on all OSes. Change-Id: Icb3fcf8de12820496c613af5ab4ce2a5386aabef Reviewed-on: https://chromium-review.googlesource.com/c/1291389Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#602130}
-
Yunlian Jiang authored
glibc 2.27 changed the implementation of the "raise" system call to block all signals and call getpid/gettid, and then finally call raise. This implementation breaks our test, so we use 'kill' instead. BUG=chromium:896903 TEST=sandbox_linux_unittests passes on host with glibc 2.23 and glibc 2.27. Change-Id: I4a037989cddb29d7dff2741f3abd03947feef8b2 Reviewed-on: https://chromium-review.googlesource.com/c/1294845Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Yunlian Jiang <yunlian@chromium.org> Cr-Commit-Position: refs/heads/master@{#602129}
-
Philip Rogers authored
This patch is a followup to https://crrev.com/601428 and stops clearing the paint controller in SPV2 mode. This prevents flashing on all pages when running with SPV2+BGPT and will unblock making BGPT experimental (all SPV2 layout tests fail without this change): https://chromium-review.googlesource.com/c/chromium/src/+/1294204 Bug: 836902 Change-Id: I80bea03bc3d06c5fe6761734babdf6517813e7bb Reviewed-on: https://chromium-review.googlesource.com/c/1297060Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602128}
-
Vasilii Sukhanov authored
It's fully launched. Bug: 854562 Change-Id: Iae62096ced27a37cd29e18db405842f13fa6ff71 Reviewed-on: https://chromium-review.googlesource.com/c/1288973 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#602127}
-
Jordan Demeulenaere authored
Bug: 806868 Change-Id: I4f2d9729549a2a6502336c98d3450967d39181b3 Reviewed-on: https://chromium-review.googlesource.com/c/1288539 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#602126}
-
Becca Hughes authored
Move audio focus media internals to helper class. Move logic from content::AudioFocusObserver (which we want to remove) to this helper class. BUG=875004 Change-Id: I7c80f6b680bd23e71193438c32b68e55ea05b58e Reviewed-on: https://chromium-review.googlesource.com/c/1286904Reviewed-by:
-
Bret Sepulveda authored
TBR=dgozman@chromium.org,chenwilliam@chromium.org Bug: 849670 Change-Id: Ida277f1d6dcfa07502ee3e97227a7fd4a891de38 Reviewed-on: https://chromium-review.googlesource.com/c/1297232Reviewed-by:
-
Antonio Gomes authored
BUG=890770 Change-Id: I74bc630b9bf7616400808227f8536c7dec2f48da Reviewed-on: https://chromium-review.googlesource.com/c/1296871 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#602123}
-
Dan Harrington authored
As requested by dcheng@. In some places, this can avoid extra conversions / constructions. Change-Id: Ibe8e330e604386706d0683ccc8bee9d78f9d9f59 Reviewed-on: https://chromium-review.googlesource.com/c/1289998 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#602122}
-
Xiaocheng Hu authored
The test has an Android-specific baseline, which was missed out in crrev.com/c/1278210, causing bot failures. This patch fixes it. NoTry: True Tbr: tkent@chromium.org Bug: 887148, 896310 Change-Id: I1448139afce05792e72f659dd528bf6b90e3d993 Reviewed-on: https://chromium-review.googlesource.com/c/1297406Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#602121}
-
Scott Violet authored
Forgot to remove before landing. BUG=891489 TEST=none TBR=xiyuan@chromium.org Change-Id: Icc5df4d872a9fe5a08a275bf3a15bc0b7f9b8781 Reviewed-on: https://chromium-review.googlesource.com/c/1297056Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#602120}
-
vmpstr authored
We're careful not to update the image loader when it is inserted into but nothing has changed. However, if we're inserted into a subtree such that the base element is now different, we do need to schedule a new run since the final URL may be different. R=fs@opera.com, chrishtr@chromium.org Bug: 897545 Change-Id: Id84894049c52e8f28a7ae581c3a626da5550207f Reviewed-on: https://chromium-review.googlesource.com/c/1296506 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602119}
-
Jon Mann authored
This ensures connection to the Android Messages backend is not taken if another device is active and the user closes the tab or PWA. When the service worker connects with the backend it needs to send a START_STREAMING message if the device wasn't previously connected in order to start receiving messages. If this message is sent when a different device is conencted, the other device will lose the connection. Closing the active tab or PWA is not an action which should take the connection from another device so in this case we don't want to send the start message. This new 'resume_streaming_connection' informs the service worker that it should connect and not send the START_STREAMING message. Bug: 896383 Change-Id: Ie0e27461d29679c7c969bfd45c39e1dfb39da515 Reviewed-on: https://chromium-review.googlesource.com/c/1287264Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#602118}
-
David Benjamin authored
Test: 1. Go to chrome://settings/certificates 2. Press IMPORT 3. Select a PKCS#12 file, e.g. net/data/ssl/certificates/client.p12 from Chromium (password is "12345") 4. FIX #1: Password dialog should focus the input field. 5. Type the password and import. 6. Expand the entry for the newly-imported certificate. Hit the "..." button and select "Export". 7. Pick some file to export it to. 8. FIX #2: Password dialog should focus the first input field. Bug: 897264 Change-Id: Ia9377d9c776e486c6745cc32e3228193c1a265b6 Reviewed-on: https://chromium-review.googlesource.com/c/1292603Reviewed-by:
-
Michael Spang authored
Logging in with a USB drive connected is enough to hit this NOTREACHED(). DiskMountManager re-fires "mounting" notifications inside RefreshAfterEnumerateMountEntries. Bug: 716635 Test: log in with dcheck_always_on=true build Change-Id: I70c3b7e8064c7465a78c53e6574b20c38b74c168 Reviewed-on: https://chromium-review.googlesource.com/c/1297234Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602116}
-
Daniele Castagna authored
GLRenderer::GetBackdropTexture used to bind the same texture twice in a row, this patch removes an unnecessary glBindTexture. Additionally, the caller of GLRenderer::GetBackdropTexture would check the texture name was not 0. This is not necessary since we assume the texture name is valid in GetBackdropTexture. Change-Id: I4668d2ecebbc840cb2cae45baa45182c780e9898 Reviewed-on: https://chromium-review.googlesource.com/c/1296679Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#602115}
-
Scott Graham authored
This is to unblock the v8 roll, which consumes //build separately from Chromium. TBRing for DEPS include_rules change, because it's a straight move, not a new addition. TBR: jochen@chromium.org Bug: 898088 Change-Id: Ic93764169680fc4e0680cc28db327a04a59750c8 Reviewed-on: https://chromium-review.googlesource.com/c/1297078 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#602114}
-
Sarath Singapati authored
XRSession's selectstart event is fired on pointerdown event now. Bug: 887904 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib37fb8c46d9afd832b89499b14fa7baa741de727 Reviewed-on: https://chromium-review.googlesource.com/c/1244636 Commit-Queue: Sarath Singapati <sarath.singapati@huawei.com> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#602113}
-
CJ DiMeglio authored
We had incorrectly obmitted an update to the opacity when we first start sending frames. This CL adds that necessary call, and also neatens up the logic to update opacity and rotation, making the effect of these calls clearer. Bug: 893056 Change-Id: I1b6edb4292f1a3a25aa22b61e82c20381d395eb7 Reviewed-on: https://chromium-review.googlesource.com/c/1275525 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602112}
-
Fredrik Hubinette authored
Note that this refactoring is not entirely without side effects. In some cases we will do a better job of reading the color space from the container. For VP9, we will no longer be using the resolution to guess color spaces. media: :ColorSpace is deprecated. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6ebd5b6f9a5fc579274032e17f84c53f1c63f6ad Reviewed-on: https://chromium-review.googlesource.com/c/1277838 Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#602111}
-
Shakti Sahu authored
Fixed the received_bytes field for offline pages to OfflineItem conversion. Also added all the missing fields to the conversion unit tests. Bug: 897841 Change-Id: I823a84bc36a9d07c2f955f756c91412d22fa59ae Reviewed-on: https://chromium-review.googlesource.com/c/1294404 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602110}
-
Christopher Cameron authored
This fixes the bug where we see two titlebars for PWA windows, and fixes a longstanding TODO to add needed parameters to the CreateWindowParams structure. Update the mojo struct CreateWindowParams to include parameters used by the various NativeWidgetMac::CreateNSWindow overrides. Include in these parameters a WindowClass parameter to indicate the subclass of NativeWidgetMacNSWindow to use. Add the overrideable method NativeWidgetMac::PopulateCreateWindowParams to populate the CreateWindowParams structure. Add plumbing in BrowserWindowFrame to call back into the browser process to get the overridden titlebar height. Add similar plumbing to BrowserNativeWidgetWindow to implement _handleFocusToolbarHotKey. With this in place, BrowserWindowFrame et al no longer have any dependencies on browser-process classes. Move BrowserWindowFrame and NativeWidgetMacFramelessNSWindow from //chrome/browser/ui/views/ over to //ui/views_bridge_mac. Bug: 897866 Change-Id: I04d9dd57d2bb98f98899349f2810198103e286b8 Reviewed-on: https://chromium-review.googlesource.com/c/1295251Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#602109}
-
Aaron Krajeski authored
Bug: 894043 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id777b3e30ce6f9d84b2935630559c62a251d07af Reviewed-on: https://chromium-review.googlesource.com/c/1289749 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
