- 04 Dec, 2019 40 commits
-
-
siyua authored
Bug: 991037 Change-Id: Ib05576915206cc2b88a9e3b92d7c5392a480d6e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951004 Commit-Queue: Siyu An <siyua@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#721675}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 979876c1. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." 83e4a43b "Refactor VRPose to fit better with WebXr concepts" a93be69b "Update reversing-an-animation test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I3fad8ae994c6c62e95427d2965e8a5d9f56c3f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950886Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721674}
-
Avi Drissman authored
The included script installs Keystone, and then registers Chrome with it. Bug: 1022416 Change-Id: I887b54e0872b0a065cd1ffe17463c06daf460594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930144Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#721673}
-
Archana Simha authored
TBR=dbeam@chromium.org,tmartino@chromium.org Bug: 1019296 Change-Id: I3dd7dbf5d1dfdb67b883118b7c4e181cc8bd8795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947560 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721672}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1759c2d96833..77e5e0540b54 git log 1759c2d96833..77e5e0540b54 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 hjd@google.com Merge "Reland: Add statsd logging to perfetto_cmd" Created with: gclient setdep -r src/third_party/perfetto@77e5e0540b54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4b65a784878775d9c361f82d7158bb0f02736a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721671}
-
Brian Ho authored
This CL sets the Dawn GN arg to enable compilation of libdawn [1] in Chrome OS Chromium builds. This CL does *not* modify the enable-unsafe-webgpu GPU switch [2], so there should be no changes in functionality for end users yet. The main reason for this change is to re-enable the Dawn e2e and unit tests in Chrome OS which were disabled due to a recent change that requires use_dawn to be set to actually compile the tests [3]. Furthermore, we will need this flag in the near future anyways when WebGPU support is fully implemented in CrOS. Adding this flag on the Chrome OS side breaks none of the trybots on the CQ [4], so the main concern is that adding the new library will bloat the Chrome binary. I did a quick check, and it seems like Dawn (and all of its own third-party dependencies) adds less than 1% to the build size. ~/chromium/src$ du -h out_atlas/Release/chrome 262M out_atlas/Release/chrome <Update GN args> ~/chromium/src$ du -h out_atlas/Release/chrome 264M out_atlas/Release/chrome [1] https://cs.chromium.org/chromium/src/third_party/dawn/ [2] https://cs.chromium.org/chromium/src/chrome/browser/about_flags.cc?l=4230&rcl=3938e6ad2290409589b5595dd13e0661bb2cf276 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1917380 [4] https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1918345 Bug: 996470 Change-Id: Ia4ccd28817e7665c6725a719b574ad15dad613f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935234Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#721670}
-
Takumi Fujimoto authored
This reverts commit 4f7bdf97. Reason for revert: Suspected to be the cause of test failures on the "Linux Tests (dbg)(1)" bot: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/85058 Original change's description: > Friendly Privacy Setting Initial Redesign: Reland > > Changes between original submission and reland: > > 1.) Privacy-page subpages are now in lazy_load.html > 2.) Fixed bug that erroneously showed "privacy" in the settings menu of "Guest" mode settings. > 3.) Fixed bug where going to chrome://settings/clearBrowsingData didn't work unless the advanced section was expanded when the flag for this change was disabled. > 4.) Reordered a few settings rows to match the most current mocks. > > > Revert "Friendly Privacy Setting Initial Redesign" > > > This reverts commit 544412a4. > > > Reason for revert: Performance and functional regressions > > https://bugs.chromium.org/p/chromium/issues/detail?id=1024034#c5 > > > Original change's description: > >> Friendly Privacy Setting Initial Redesign > >> > >> This CL does 3 things: > >> 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag. > >> 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on. > >> 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag. > >> > >> Bug: 1014143 > >> Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088 > >> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094 > >> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> > >> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > >> Cr-Commit-Position: refs/heads/master@{#714287} > > Change-Id: If3fa33801604491b8648672ff53d37a818f2cd08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929443 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Sean Harrison <harrisonsean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721579} TBR=dbeam@chromium.org,dpapad@chromium.org,msramek@chromium.org,harrisonsean@chromium.org Change-Id: I50b7bd6b35a1ac769b38c73bdc4b69dd51fa4d6b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951728Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#721669}
-
jonross authored
We would like to enable SkiaRenderer by default on Linux. Due to Skia not guaranteeing pixel-perfect reprodcution, the blink layout tests require the use of --fuzzy-diff. While this was added as a --linux-args to the main test configs, unfortunately test_suite_exceptions just bases over the args. So this adds it to all linux exceptions. This also creates a new exception for linux-trusty-rel as apparently that mixin does not apply --linux-args TEST=blink_layout_tests webkit_layout_tests Bug: 967716 Change-Id: I6a97a74effeb5153dce8f21a3da15fc764fada64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951132Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#721668}
-
Jordan Bayles authored
Currently, the MediaRouter BUILD.gn does not declare any dependencies on the UI browser.h file, causing build failures on some bots. This patch adds a dependency on //components/signin/public/base:signin_buildflags to fix the Open Screen build bots, as ui/browser.h ultimately depends on this generated header. Change-Id: Iafed8a6a3717b9ee2b8df6fb41f385a4a0acc4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951543Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#721667}
-
Anatoliy Potapchuk authored
We should enforce network connection for the first installation of the app and give the ability to configure the network before running the app. Bug: 1015383,1006230 Change-Id: Ic4c10d8032cbd62eada8f85ed343efd92994d594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904075Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#721666}
-
Michael Ludwig authored
This fixes a regression introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1947358 because that CL inadvertently conflated having an empty filter bounds and not cropping the backdrop at all. This fixes it by dropping the backdrop filter if the backdrop filter bounds are empty (i.e. all filtered content would have been cropped out anyways). CalculateRPDQParams() is updated to check the backdrop filter bounds for emptiness. By dropping early, the rest of the draw code may be able to avoid calling saveLayer() that normally is required for a backdrop filter. Essentially we have three backdrop filter modes: 1. Backdrop filter with no bounds to crop against 2. Backdrop filter with non-empty bounds to crop against 3. No backdrop filter, or backdrop filter with empty bounds (visually the same, and now effectively the same in CalculateRPDQParams). Change-Id: Idcdffb35fa7912fd51ce2cc673a6ce7e2d39371e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948061 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#721665}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a06f9d0787ca..6344c2937997 git log a06f9d0787ca..6344c2937997 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 reed@google.com some cleanups for halfplanes 2019-12-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-04 egdaniel@google.com Remove unneeded abandon/release check in GrGpuResource message processing. 2019-12-04 bsalomon@google.com Remove SkSize& SkSize::operator=(const SkISize&) Created with: gclient setdep -r src/third_party/skia@6344c2937997 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Id364b943406450d2210371ef337df9a852a6849c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951330Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721664}
-
Brian Sheedy authored
This is a reland of ca140dc0 No changes from the original CL, as it was reverted due to a FindIt false positive. Original change's description: > Replace uses of LogSymbolizedUnsymbolizedMinidumps > > Replaces all uses of LogSymbolizedUnsymbolizedMinidumps with > CollectDebugData, which is functionally identical but the name is more > descriptive of what it actually does. > > TBR=crouleau@chromium.org > > Bug: 1025034 > Change-Id: I1cbb2702efec1e608622ca0878399f5406a2775d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937854 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720640} Bug: 1025034 Change-Id: Ia522c0c172b42eb274989d170c578fbe68a6ba4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947387 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#721663}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b92f8d81cac4..75a7e95c6f5c Created with: gclient setdep -r src-internal@75a7e95c6f5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6bb3eab039a89b3dce1ef0ba2da77dbbc1187c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951325Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721662}
-
Toni Barzic authored
The page switcher button radius should be 4 dip instead of 5. BUG=None Change-Id: Ibfd1a7fd97190b78003a36b1ebca1a56939f7619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949364Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#721661}
-
sczs authored
- Adds infobarAccepted flag that is YES whenever a user has tapped on a Translate action. - Adds displayShowOriginalBanner flag that is YES whenever a translation has taken place, this will display a Show Original banner once the initial Banner/Modal has been dismissed. - alwaysTranslateSourceLanguage now uses performInfobarAction to translate. Bug: 1014959 Change-Id: I337f6d3172a4f32524940635d9f65944c3daeedf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949853Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#721660}
-
Weiliang Chen authored
Both Ozone's and Android's OverlayCandidateValidator implementation goes through a list of strategies. This is different from the Mac and Windows implementation, which instead answers simple true or false question. This CL adds a OverlayCandidateValidatorStrategy class as a base class to be shared by Ozone and Android. This is moving towards separating out different platforms' validator implementations so they can be moved into OverlayProcess. The final goal is for OverlayProcessor to have different subclass implementation for each platform. This is CL 3/? of overlay processor refactor. R=rjkroege TBR=kylechar@chromium.org Bug: 963597 Change-Id: I58e17a1bcff7045963ff6026e859310f37972f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756474 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#721659}
-
Aaron Leventhal authored
Bug: None Change-Id: I51d0b37d763008690f1e4de94c7abd348d8966e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951547 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#721658}
-
Wez authored
This reverts commit 25b01730. Reason for revert: No evidence of sequence issues, but some other reports suggest another cause, so will replace these checks with validation of the new hypothesis. Original change's description: > [stability] Temporarily make some sequence DCHECKs into CHECKs. > > Modify HistoryService and CancelableTaskTracker to track and check their > home sequence/thread in Release builds, to get visibility into potential > threading issues. > > Bug: 1009795 > Change-Id: Id85a818111e8d2540a4bc4e333c88d7461a93a04 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918222 > Commit-Queue: Wez <wez@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715523} TBR=ajwong@chromium.org,falken@chromium.org,sky@chromium.org,wez@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1009795 Change-Id: I59d08819f2868cfb7220bd9ed7c3d398bfef430a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949864Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#721657}
-
Andrew Xu authored
The following functions are moved out of Layout(): (1) Update the available space of ScrollableShelfView. (2) Update the layout strategy. (3) Update the tappable icon indices. (4) Translate the shelf view. (5) Create the scroll animation to ensure the correct UI. It helps to fix the issue that calling Layout() multiple times may break the existing scroll animation. Change-Id: Ie2e3b18a93216004cb82bf1dfe0b373eab66ca35 Bug: 1012772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930469Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#721656}
-
Brandon Wylie authored
Bug: 1027709 Change-Id: I886efef0539a57ce4f38064d550a389340da3df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949731Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#721655}
-
Xiaohan Wang authored
This CL adds a path to pass the information of whether Media Foundation Renderer is needed from the CdmContext to CreateRenderer() in WebMediaPlayerImpl which can instruct the RendererFactorySelector to choose the right RendererFactory. Bug: 1018372 Test: Added a new test. Change-Id: I527909c433f72c76b83e6238ecdab60ab7b5d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910682 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#721654}
-
Ahmed Mehfooz authored
The message center redesign kUnifiedMessageCenterRefactor feature is disabled by default, and is only enabled on the devices that has hotseat feature enabled (i.e., on Krane and on Dogfood devices). Bug: 976952, 958020 Change-Id: I172f310831a0ef64dfecccc210850464b2a5c80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951283 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721653}
-
David Bokan authored
The state is unused except in deferred_scroll_end_state_ where its existence is used as a signal to call ScrollEnd at the end of an animation. Removed state as an input to ScrollEnd and turned the deferred state into a bit. Bug: 1029781 Change-Id: Ia0d4261f5d0d21c08f01650eb436c091112e0912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948515 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#721652}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/006a15542867..5f3456e3314b git log 006a15542867..5f3456e3314b --date=short --first-parent --format='%ad %ae %s' 2019-12-04 thomasanderson@chromium.org Expose GL_ARB_sync for GL Created with: gclient setdep -r src/third_party/angle@5f3456e3314b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1028799 Tbr: geofflang@google.com Change-Id: I902a32975bf941a98852354117420d34844e5996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721651}
-
Xiyuan Xia authored
Pass display transform hint via CompostiorFrameMetaData instead of via DisplayPrivate. This ensures proper display transform used for a frame in viz::Display::DrawAndSwap. Bug: 1026744 Change-Id: I1645c177b948946fab5549a3b48000ee9e2f576e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930216Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721650}
-
Taylor Bergquist authored
Bug: 989131 Change-Id: If8e698c9f95fe20ffc99b434f5a6e1e690a60141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949681Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#721649}
-
Devlin Cronin authored
ShowToolbarActionPopup() is called from the ExtensionActionAPI to trigger a popup from a couple different call sites. Move the method to ExtensionsContainer, and implement it on ExtensionsToolbarContainer. Bug: 984654, 985834 Change-Id: I37033f132f01546e0b26f3f84cf7a8c15d922ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927214Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#721648}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/38f725fb445a..024cbe1befe1 git log 38f725fb445a..024cbe1befe1 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 tsepez@chromium.org Add unit tests for FPDF_BSTR. 2019-12-04 tsepez@chromium.org Test FPDF_SetSandboxPolicy() public API. 2019-12-04 tsepez@chromium.org Test CJX_Event::emit() and reset() 2019-12-04 thestig@chromium.org Fix nits in CFX_XMLParser::DoSyntaxParse(). 2019-12-04 tsepez@chromium.org Remove some DOXY-style punctuation from fpdf_formfill.h. 2019-12-04 thestig@chromium.org Remove an unused struct in AGG code. 2019-12-04 thestig@chromium.org Stop manually setting -Wshadow. Created with: gclient setdep -r src/third_party/pdfium@024cbe1befe1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I6372ad4b00533a5c71dbc5d084c518217fe9dd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951153Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721647}
-
John Budorick authored
Starting with sdcard size as well as screen dimensions and density. Also adds a marshmallow tablet AVD configuration. Bug: 922145 Change-Id: I72d083599e920307f5db1eeb7e6fd708105878bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918275 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#721646}
-
dalyk authored
Bug: 985589 Change-Id: I6a7e3a66041ae5b0a6e42a27d3123412ac382113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943475Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#721645}
-
danakj authored
Long running tasks make for slow tests make for overloaded bots make for slow commit queue! R=gab@chromium.org Change-Id: I003e70a98477084d6a948553c78f3d48376d2480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949028 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#721644}
-
Xiaoqian Dai authored
Bug: 1027353, 997885 Change-Id: I23a421baf0b684c5c1cccf9c8c6183e137b6cd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951183 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#721643}
-
Steven Bennetts authored
Includes some modernizing of the use of base::Value in the code. Bug: 1005404 Change-Id: Ibbaad2585637ab265bd7fc214d3d940fe2e79171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949365 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#721642}
-
Tricia Crichton authored
Several places where UnexpectedAlertOpen status is returned do not include the alert text in the status object. This cl adds the text where missing. Bug: chromedriver:3184 Change-Id: I3087ed77d73c326ca93c77667c2a9eaa7c460134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950862 Commit-Queue: Tricia Crichton <triciac@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721641}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=kbr@chromium.org Bug: 1023677 Change-Id: I3f94fcf12837e64582ff2b834e201f88f017df11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927011 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#721640}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4eacc1612b6..6f790e4528b7 git log c4eacc1612b6..6f790e4528b7 --date=short --first-parent --format='%ad %ae %s' 2019-12-04 brgoddar@microsoft.com Memory: Deselect Nodes when Filtered Out 2019-12-04 sigurds@chromium.org Fix: Initialize member 2019-12-04 liviurau@chromium.org [test] Port the virtual test suites from Chrome Created with: gclient setdep -r src/third_party/devtools-frontend/src@6f790e4528b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1018670,chromium:1030462 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7621b81724d2cc0bca879355a4b7eb679b2defce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#721639}
-
Kamila authored
This cl sets a specific width for the promo, and modifies the promo label, according to the UX requirements. Before-after screenshots attached on the bug below. Bug: 986737 Change-Id: I59f8c183e95eac4ba67501c775a71e553ad5c559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950903Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@google.com> Cr-Commit-Position: refs/heads/master@{#721638}
-
Johannes Kron authored
Change return type of GpuVideoAcceleratorFactories::IsDecoderConfigSupported() from bool to a tristate enum class Supported to be able to distinguish between supported (kTrue/kFalse) and not yet initialized (kMaybe). Bug: chromium:1029737 Change-Id: I2a70947f2bf37398aba5a9b9dc2db3080265163a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945175Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/master@{#721637}
-
Aran Gilman authored
Bug: 1027612 Change-Id: I924bde8462b459fad436ebcc1cc8afe645cb4276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931109 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#721636}
-