GitLab

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/823663003

Cr-Commit-Position: refs/heads/master@{#309499}

Fix data reduction proxy browser tests to check that
dataReductionUpdateDailyLengths is reset after date lengths are updated.

BUG=384394

Review URL: https://codereview.chromium.org/823703002

Cr-Commit-Position: refs/heads/master@{#309498}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/823713002

Cr-Commit-Position: refs/heads/master@{#309497}

Covers content/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/803813003

Cr-Commit-Position: refs/heads/master@{#309496}

This patch prepares sync codebase for supporting datatypes with
implicit permanent forlders by introducing an empty/unset
syncable ID.
There was a notion of Null ID before but it was equivalent
to the root ID which caused some confusion in the code - a Null
ID would sometimes be used where a "root" would be appropriate
and vice versa.
See the following code fragment for an example:
// TODO(sync): We could use null here, but to ease conversion we use "r".
// fix this, this is madness :)
inline bool IsNull() const {
  return IsRoot();
}

This change will be followed by one or two separate changes
that will actually remove dependencies on PARENT_ID and
SERVER_PARENT_ID and use a different way to organize nodes
in the directory based on node's datatype rather than parent ID.

This change impacts the following:
1) The default ID value in EntryKernel ID fields and elsewhere is
Null ID and not Root ID as it used to be.
2) This means that some tests that depended on Root ID being
set implicitly
in PARENT_ID and SERVER_PARENT_ID now need to set these IDs explicitly.
3) Node's GetPredecessorId, GetSuccessorId, and GetFirstChildId
methods now return a null ID rather than a root ID when there
is no predecessor, successor, or children.
4) Small changed throughout the code to make sure that
null IDs and root IDs are used accordingly (now that they
are no longer equivalent).
5) Changed some validation methods to accept Null IDs
to avoid large changes in the test code.

BUG=438313

Review URL: https://codereview.chromium.org/805633004

Cr-Commit-Position: refs/heads/master@{#309495}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/825523002

Cr-Commit-Position: refs/heads/master@{#309494}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/818113002

Cr-Commit-Position: refs/heads/master@{#309493}

The CMA code is not linked in for Android builds.

R=erickung@chromium.org
TBR=lcwu@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/821793002

Cr-Commit-Position: refs/heads/master@{#309492}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6e7a766..55af1ae

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/824803002

Cr-Commit-Position: refs/heads/master@{#309491}

Covers courgette/, dbus/, device/, extensions/, gin/, google_apis/, and gpu/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/819193002

Cr-Commit-Position: refs/heads/master@{#309490}

This is based on Nat's patch: https://codereview.chromium.org/441873007/

Move timeline and importers to use telemetry.timeline.TraceData

This (admittedly massive) patch actually gives us an ubertrace object: the
TraceData. The key way to understand this CL is to read timeline/trace_data.py file,
then read importer.py. The rest is cosmetic fallout from the signature changes.

A TraceData contains the data from many tracers, and is always serializable. A
TimelineModel is constructed from a single TraceData. Internally, a
TraceData is an in memory version of json of the following form:
  { traceEvents: ...
    inspectorTimelineEvnets: ...
    tabIds: ...
  }

Since a TraceData has all the tracer data, the model and importer system was
updated so that instead of there being 1 importer per value, the importers
instead indicate which part of the TraceData they can handle, if any.

BUG=356763

Review URL: https://codereview.chromium.org/805463002

Cr-Commit-Position: refs/heads/master@{#309489}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463#

Review URL: https://codereview.chromium.org/825503002

Cr-Commit-Position: refs/heads/master@{#309488}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/795043004

Cr-Commit-Position: refs/heads/master@{#309487}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/823733002

Cr-Commit-Position: refs/heads/master@{#309486}

Covers chrome/browser/* from f on.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/816403003

Cr-Commit-Position: refs/heads/master@{#309485}

This CL makes Widget::RunShellDrag() and DesktopDragDropClientWin not crash if
the browser window is deleted during a drag-drop operation. An extension can
delete the browser window during the drag-drop operation.

BUG=440534
TEST=BookmarkBarViewTest22.*
R=pkasting
TBR=sky (The files in ui/views/widget are identical to the original CL)

Review URL: https://codereview.chromium.org/819793002

Cr-Commit-Position: refs/heads/master@{#309484}

Review URL: https://codereview.chromium.org/818033005

Cr-Commit-Position: refs/heads/master@{#309483}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/822833002

Cr-Commit-Position: refs/heads/master@{#309482}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/818093003

Cr-Commit-Position: refs/heads/master@{#309481}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/817403002

Cr-Commit-Position: refs/heads/master@{#309480}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/819943002

Cr-Commit-Position: refs/heads/master@{#309479}

This regressed in r308886 because the unit test changed from having no
activation policy to having a "Regular" activation policy.

With a regular activation policy, calls to [NSApp hide/show*:] are
asynchronous, so the run loop needs to be flushed afterwards.

Also adds an extra check for [NSWindow makeKeyAndOrderFront:]. It
doesn't need a runloop flush for the visibility change, but it should
have coverage anyway.

BUG=378134

Review URL: https://codereview.chromium.org/809903009

Cr-Commit-Position: refs/heads/master@{#309478}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/817393002

Cr-Commit-Position: refs/heads/master@{#309477}

Covers chrome/app* and chrome/browser/* through e.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/819133004

Cr-Commit-Position: refs/heads/master@{#309476}

Covers cloud_print/ and components/.

BUG=422426
TEST=none
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/818103002

Cr-Commit-Position: refs/heads/master@{#309475}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

Several formatting edits by clang-format were manually reverted, due to
mangling of some of the more complicate IPC macros.

BUG=417463

Review URL: https://codereview.chromium.org/792343004

Cr-Commit-Position: refs/heads/master@{#309474}

* Moves various classes upstream.
* Changes ActivityDelegate to use the DocumentUtils to access
  the task's baseIntent instead of calling getTaskInfo() directly.
* Findbugs file changed for fields that are only read downstream.

Submitting with NOTRY as true to get around findbugs submission issues.

BUG=443773
NOTRY=true

Review URL: https://codereview.chromium.org/821063002

Cr-Commit-Position: refs/heads/master@{#309473}

We added a flag in Blink to decide if Ctrl-wheel-scroll should scroll or zoom, and now we use this flag in chromium code.

This patch is part of a series:

patch #1: https://codereview.chromium.org/759073002
patch #2: This CL
patch #3: https://codereview.chromium.org/768443002

BUG=397027, 378755

Review URL: https://codereview.chromium.org/739013008

Cr-Commit-Position: refs/heads/master@{#309472}

Adds cast_media_load_dererrer to prevent unwanted media from being
played in web_contents that are not currently visible.

R=gunsch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/824733002

Cr-Commit-Position: refs/heads/master@{#309471}

BUG=444655
TEST=TrayKeyboardLockTest.HiddenOnCreation, TrayKeyboardLockTest.HidesOnA11yEnabled, TrayKeyboardLockTest.PerformActionOnDefaultView

Review URL: https://codereview.chromium.org/818083002

Cr-Commit-Position: refs/heads/master@{#309470}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0edb76a..6e7a766

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/790243004

Cr-Commit-Position: refs/heads/master@{#309469}

LayerSorterMainTest.LayerSorterRubik, and possibly other cc_perftests are failing in
LayerTreeHostCommon::CalculateDrawProperties, the difference in width and height of
visible_content_rect() and visible_rect_from_property_trees() is 2, and the tolerance
is 1.  CHECK(!failed) is hit.

Until the issue is resolved, set verify_property_trees to false

BUG=444219

Review URL: https://codereview.chromium.org/802343007

Cr-Commit-Position: refs/heads/master@{#309468}

PrintingMessageFilter does not know if ProfileIOData is destroyed. Instead of
ProfileIOData filter can create onw BooleanPrefMember.

BUG=428829

Review URL: https://codereview.chromium.org/816143002

Cr-Commit-Position: refs/heads/master@{#309467}

Pepper drops its global lock and reacquires it during synchronous IPCs, so these can turn into deadlocks.

BUG=418651

Review URL: https://codereview.chromium.org/796543007

Cr-Commit-Position: refs/heads/master@{#309466}

This was recently introduced by https://codereview.chromium.org/465853004/

BUG=444629

Review URL: https://codereview.chromium.org/821743003

Cr-Commit-Position: refs/heads/master@{#309465}

BUG=442514

Review URL: https://codereview.chromium.org/794683005

Cr-Commit-Position: refs/heads/master@{#309464}

BUG=444471

Review URL: https://codereview.chromium.org/812753004

Cr-Commit-Position: refs/heads/master@{#309463}

Make the overflow menu for the extensions toolbar on mac work with drag-and-
drop across multiple menu rows.
Also adjust the visibility criteria for the overflow menu in the wrench menu model.

TBR=sky@chromium.org (small wrench menu model change)

BUG=429810

Review URL: https://codereview.chromium.org/820713008

Cr-Commit-Position: refs/heads/master@{#309462}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dd080bd..0edb76a

TBR=haraken@chromium.org,gavinp@chromium.org

Review URL: https://codereview.chromium.org/817363002

Cr-Commit-Position: refs/heads/master@{#309461}

This fixes a few cases in which ChromeVox gets stuck when entering or exiting an iframe:
- during continuous reading, multiple inter frame messages get sent
- on some iframes, even though there's a valid src, ChromeVox isn't injected; this results in the outer ChromeVox continuously messaging into an iframe with out ChromeVox running. This occurs typically with dymaically loaded iframes.

TEST=manual; create a page with an iframe src='http://www.google.com'; previously, ChromeVox gets stuck trying to enter the iframe. Now, it should skip it. On MacRumors.com, attempt to enter one of the iframes containing YouTube content; perform continuous read immediately before the content. Should no longer get stuck.

Review URL: https://codereview.chromium.org/816343004

Cr-Commit-Position: refs/heads/master@{#309460}