- 04 Mar, 2020 7 commits
-
-
Michael Sun authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/a4d130010ec6..2302d21944c8 $ git log a4d130010..2302d2194 --date=short --no-merges --format='%ad %ae %s' 2020-02-20 kevinptt runtime_probe: Modify probing type of wireless 2020-02-29 michaelfsun system_api: Add CRAS media player D-Bus constants 2020-02-26 juwa vm_tools: add extensions to Application message Created with: roll-dep src/third_party/cros_system_api Bug: b:147365563 Change-Id: Ieee9f156c4a834b8f71ce2bd34cd8713c1a670cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081187Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#746597}
-
Eric Willigers authored
CreateAppIdLaunchParamsWithEventFlags is used by system web apps. We move the function from extensions to app service, eliminating a dependence of web apps on extensions/ code. Change-Id: Ie406bdd4aa0e69752d5ad671925310a11da29e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082669Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#746596}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f096a8f4. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I5302bf94f97bafb0111ec63d2647f041b25f86ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084833Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746595}
-
Robert Sesek authored
It has launched and landed, so the sandbox should be unconditionally enabled. Bug: 915910 Change-Id: I89d2dcd3788e0570bce7c632349706ad6c73810f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085112Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#746594}
-
zhaoyangli authored
A recent change made |get_launch_command| return an empty dict, which caused a none-empty check failure later. This change set some default fields in the dict as what was happening before. Bug: 1054989 Change-Id: Ib2cfeac297705eb4e20c40b923c30d20976b6852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083761 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746593}
-
John Abd-El-Malek authored
Fix Android crash in ChromeContentBrowserClient::CreateURLLoaderThrottles when a RenderFrameHost is shutting down. At that point It won't have a WebContents. Bug: 1056801 Change-Id: I1453f7484123157d8086b8b9964eb66f4d4ec1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085846Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#746592}
-
dalyk authored
Most tests involving the dropdown or custom input field have been moved to the new secure_dns_interactive_test.js as they involve testing for focus. This cl also re-enables CrSettingsSecureDnsTest.All, which was disabled when the flakiness was observed. Bug: 1040145,1057504 Change-Id: I7813849295ddf6a3ddc283a9cdd9416db64b8f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083760Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#746591}
-
- 03 Mar, 2020 33 commits
-
-
Frank Tang authored
Track misc features launched in 2019 to understand the impact. Also measure the v8BreakIterator usage of 'word' and 'line' to lobby the need for 'line' in the replacement standard Intl.Segmenter. Depending on https://chromium-review.googlesource.com/c/v8/v8/+/2067512 Bug: v8:10251 Change-Id: Ied744dc947986b4cdbec3f70c3eb6299cd58599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078903Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746590}
-
Ovidio Henriquez authored
This change adds an entry for Web Bluetooth permissions to Site Settings if the WebBluetoothNewPermissionsBackend flag is enabled. Bug: 601523, 563724 Change-Id: I0860e56132242c3ca59f0ee79e0b11337fd6d041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082322Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Yulun Wu authored
Adds a switch to override minimal interval between showing user contextual nudges. Bug: 1055918 Change-Id: I71ae9c6ab5662336d6828f9af64cc98aad14c099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079537Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746588}
-
Nektarios Paisios authored
The use of ComPtr::GetAddressOf is banned see http://crbug.com/914910 Either the "&" operator or the ReleaseAndGetAddressOf method should be used. Also, the "CopyTo" method could be replaced with the "As" method which is easier to type and call. Bug: 914910 R=dmazzoni@chromium.org, kbabbitt@microsoft.com Change-Id: Ida82e35ecc16953b99e576fc62834b6c894e87ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083664 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#746587}
-
wutao authored
Remove unused code related to kEnableTextQueriesWithClientDiscourseContext. Bug: b/145218971 Test: manual Change-Id: Iceb7a5be8f0d95939542637fd17ebf2ac1648569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080819Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#746586}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1058139 Change-Id: I5c57ce99769e9ae77022199c25ea1c7b47250bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085838 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#746585}
-
Wenbin Zhang authored
Updating the owners of tracing_perftests. After synced with primiano@, setting the owners to eseckler@chromium.org and oysteine@chromium.org. Bug: chromium:1049256 Change-Id: I6c2269369e7ec5d9114e15fc915bd1b439841da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085832 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#746584}
-
Yusuf Sengul authored
Bug: 1038368 Change-Id: Ibc07bae9b5a3763ea88a6d070c5e159178a03a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086012 Auto-Submit: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#746583}
-
Gang Wu authored
Update recursivelyDeleteFile and batchDeleteFiles in FileUtils, so both of functions can take a filter function to check if the file can be deleted. Change-Id: I7f2cdc1182a8ad4111297d0529b1fdc8b31b462b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062914Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746582}
-
Ehimare Okoyomon authored
Add support and UI to disable incognito ntp toggle if that setting is managed. EnforcedByPolicy: https://screenshot.googleplex.com/BoEVngjYMsn.png EnforcedBySettings: https://screenshot.googleplex.com/21UPKQSmc31.png Bug: 1040091 Change-Id: Ie1f269af20a82025d4ec3d6f92e9c5e8b061f3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062445 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#746581}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/67cabcd71f8a..e1318818e6ab git log 67cabcd71f8a..e1318818e6ab --date=short --first-parent --format='%ad %ae %s' 2020-03-03 ehmaldonado@google.com gclient: Don't warn on Python 3 when GCLIENT_PY3=1 is set. Created with: gclient setdep -r src/third_party/depot_tools@e1318818e6ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ie8fe5aaa04b085461b16cb46065cc9b70eaf8908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085716Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746580}
-
John Palmer authored
Change-Id: I6419cab6c355a4021f9accb537e34d221f24abcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082735Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746579}
-
Hazem Ashmawy authored
Flags set via flags UI are not applied to ":webview_apk" processes. That's why simply checking CommandLine for flags only isn't sufficient in the devUi at the moment. Until this is fixed, we will connect to DeveloperMode ContentProvider to retrieve the overridden value of the crash uploads flag to show/hide crash consent error accordingly. Bug: 1051019 Test: Enable/Disable crash upload flag via commandline and the UI and check the error Test: Enable/Disable usage & diagnostics settings and check the error Change-Id: I3a0d31c0b17dc7fe302965132055deb90ae8ca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080381 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746578}
-
Daniel Rubery authored
The CSD model shows a warning without |callback| or |callback_thread| set, so when committed interstitials are enabled, we crash here in BaseUIManager::DisplayBlockingPage. This CL fixes that crash. Bug: 1058094 Change-Id: Id1dccced4fd4469ecf7f6f6bbc95d283550c98c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082323 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#746577}
-
Anand K. Mistry authored
Bug: 634140 Change-Id: I38b8ad3ec7c01c2dedbb65281d7d4541bd553688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078371 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#746576}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for fingerprint subpage and setup pin subpage from settings_strings.grdp to os_settings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I89540f7f26bdcf79503a26346a28842ed45befe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057115 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746575}
-
Josh Simmons authored
Bug: 1040661 Change-Id: Ib9406209e2a8c5c3b753e4cd29b3faf20573f870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082320Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#746574}
-
Darwin Huang authored
Mechanical find/replace from "Trace(blink::Visitor* to Trace(Visitor*" Refactoring change only. No functional changes intended. Bug: 1051193 Change-Id: I60c4e11fb0d50be25c5dcc8a0d5ab854c0ff34c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084723 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746573}
-
Nina Satragno authored
This is a reland of 60d219b6 Temporarily bring back `adjusted_timeout` to make compiling internal android source happy. This will be followed up by a patch updating internal code and later the final removal of `adjusted_timeout`. Original change's description: > [webauthn] Don't adjust timeout when testing > > Move the timeout adjustment from blink to the browser and avoid > adjusting it if we detect a discovery factory override is in place. > > This change makes authenticator browser tests and WPTs 3X faster. > > Fixed: 976428 > Change-Id: Iaea88f356a6d090c14474151b29c04e912c471b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079043 > Commit-Queue: Nina Satragno <nsatragno@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/master@{#746432} Change-Id: If79cd8e5e7add21bd20bc375628cee5f4c3b6e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084725Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#746572}
-
Markus Handell authored
https://chromium-review.googlesource.com/c/chromium/src/+/2033253 unfortunately did away with pause time compensation. This CL adds it back. Bug: 1057810 Change-Id: Iee553ca2e671739fa4ba794878ed09e5bf6954fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085251Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#746571}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b9b24d1b0b80..83af90cf49de git log b9b24d1b0b80..83af90cf49de --date=short --first-parent --format='%ad %ae %s' 2020-03-03 primiano@google.com Merge "Add duplicate frames counter metric" Created with: gclient setdep -r src/third_party/perfetto@83af90cf49de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I05fe962a287bef5ae88eba2e22caae8ac780339a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085711Reviewed-by:
-
Jeremie Boulic authored
The main sections on the storage management page have been added. This change adds a "System" row so that the sizes of the storage items of the storage page (My files, browsing data, apps etc...) add up to the amount of "In use" space displayed at the top of the page. This change creates a SystemSizeCalculator class that keeps track of all calculated sizes. The "System" storage size is displayed as - "Calculating..." while the size of any other item is still being calculated. - "Unknown" if the calculation of any other row fails. - The difference between "In use" and the sum of the other storage items otherwise. If the calculation of a row fails, the corresponding size in the calculation of "System" will be 0. In other words, when the calculation of a row fails, its size is reflected in the System section. Test: unit_tests --gtest_filter="*StorageHandlerTest.SystemSize" browser_tests --gtest_filter="*OSSettingsDevicePageTest.StorageTest" Bug: 733192 Change-Id: Id3b82b10a2b94ed32daba085f8dce719d8272fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060445 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#746569}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f8b286781636..90019cea5ec9 git log f8b286781636..90019cea5ec9 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 ancheng.qiao@arm.com Vulkan: Add depth to mipmap generation Created with: gclient setdep -r src/third_party/angle@90019cea5ec9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Icccf3465737d081611d5b10353440104d8eb897c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083749Reviewed-by:
-
Jeremie Boulic authored
On the storage management page, to have the numbers match up to the size that was advertised when the user bought the device, we round the total size to the next power of 2. The total size that was displayed on the storage page was the size of the stateful partition, by far the largest of the 12 partitions present on a ChromeOS device. The vast majority of users doesn't want to worry about these details. We want to numbers on the storage page to add up to the disk size advertized by the manufacturer, a rounded power of 2. unit_tests --gtest_filter="*StorageHandlerTest*" Test: Bug: 1056507, 1013452 Change-Id: Ie8185730183572f5f61fd8646bb9a1fe0f318d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074821 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Sam Sebree authored
This change uses the -internal-light-dark-color css property to set correct dark mode styling on the select native control. Bug: 929098 Change-Id: I029859c64119e139ec228e8476a1501ad256b48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084057Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#746566}
-
Jae Hoon Kim authored
ARCVM remains in rootfs. BUG=chromium:1058105 TEST=Build chrome Change-Id: I0a4f37c393a1231120f191920135c4c0e84b00e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085704Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#746565}
-
Ovidio Henriquez authored
This change generates the migration guide HTML file using native_client_sdk/src/doc/Makefile. The Sphinx document generator has changed greatly since these documents were last generated, so the latest version of Sphinx does not work because SmartyPantsHTMLTranslator is no longer available. Change-Id: Id98b77972784d161f10f6a3a0231ede740d24ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078802Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#746564}
-
Koji Ishii authored
This reverts commit fbbcb327. Reason for revert: Regressed crbug.com/1057576 Original change's description: > Fix outline when linebox has non-zero inline offset > > When computing outline rects in an inline formatting context, > the coordinate system needs to be relative to the root of the > inline formatting context, because the algorithm needs to > call |LayoutObject| functions, which uses the coordinate > system for inline |LayoutObject|s. > > This patch fixes not to accumulate line box offset. For the > inline direction, this is usually zero and is not visible, > but non-zero `padding-left` can expose this difference. > > Bug: 1048070 > Change-Id: I30dfabcca621136b6d78892a1856c1336c7438eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038296 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Aleks Totic <atotic@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738646} TBR=wangxianzhu@chromium.org,cbiesinger@chromium.org,kojii@chromium.org,atotic@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048070, 1057576 Change-Id: I183b2c0e5ba65e8dd97418e222331ec566d2adbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084775Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#746563}
-
Jeffrey Cohen authored
TBR=ellyjones@google.com Bug: 1058157 Change-Id: I66d30be3bbfbfd2cb1b4754812b31e46840bbede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085599 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746562}
-
Anastasia Helfinstein authored
This is a step towards incorporating Rose and Sophie's code for text navigation and selection from last summer into the new navigation paradigm. Bug: 982004 Change-Id: I4fc4b41b6a151992348e8558eb51cde5172667de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076552 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746561}
-
Hazem Ashmawy authored
Check if crash collection is enabled or not in Activity#onResume so if the user enabled crash collection then returns to the activity the error message would resolve. Fixed: 1054142 Test: enabling/disabling usage and diagnostics settings and return back to crash activity Change-Id: I2fce207e4db3912b467492e2f2935c80009b866c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080490 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Yi Xu authored
In the current implementation, we always retain the content from the previous surface. However, if the full canvas needs to be repainted in this frame, the old content would over written. So there is no need to retain the content from the previous frame. The performance improvement is measure by "Blink.Canvas.IsFullRepaint". Bug: 1054666 Change-Id: Iae766225e741439c729d75f57e30418d05fe8577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063733Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#746559}
-
Jeffrey Cohen authored
TBR=mlamouri@chromium.org Bug: 1058087 Change-Id: Idf5dbbdd63937afbccf76bd626fa27575da724c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084729Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746558}
-
