- 13 Jun, 2018 40 commits
-
-
Hajime Hoshi authored
This CL is just a pure refactoring. RelatedEvent was removed at https://codereview.chromium.org/2905763003. Change-Id: Ib0c4a31944075a9361618ec556544a97bbb95cc0 Reviewed-on: https://chromium-review.googlesource.com/1096732Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#566771}
-
Yoshifumi Inoue authored
This patch makes file local funciton |NonInlineBlockFlow()| in "ax_node_object.cc" to use |IsAtomicInlineLevel()| to make this funciton to work both legacy layout and LayoutNG. Note: |IsAtomicInlineLevel()| is a bitfiled in |LayoutObject|. It is set by |LayoutBlock::StyleWillChange()| when compute style has "display:inline-block". Therefore, in legacy layout, when |IsAtomicInlineLevel()| is true for |LayoutBlockFlow|, |!InlineBoxWrapper() == !IsAtomicInlineLevel()|. In LayoutNG, |IsAtomicInlineLevel()| is used for computing physical fragment box type in |BoxTypeFromLayoutObject()|. |BoxTypeFromLayoutObject()| returns |NGBoxyType::kAtomicInline| for |IsAtomicInlineLevel()|. Bug: 591099 Change-Id: Ieafd8a414662df7e0d4f48f1b15657a602265559 Reviewed-on: https://chromium-review.googlesource.com/1092224Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566770}
-
Yoichi Osato authored
This patch imports the paint logic from InlineTextBoxPainter, converts DOM offset to inline offset and paint markers with NGPhysicalTextFragment. Here is copied functions from InlinTextBoxPainter to NGTextFragmentPainter: PaintSingleMarkerBackgroundRun PaintStyleableMarkerUnderline PaintDocumentMarkers This patch fixes: paint/markers/active-suggestion-marker-basic.html paint/markers/composition-marker-basic.html Bug: 850448 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6126bcc3880fe8ba9bd0ebd6262bae4cd7b762be Reviewed-on: https://chromium-review.googlesource.com/1090601 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Jun Mukai authored
This CL looks up the policy blob data for the offline demo mode from the filesystem and goes through the enrollment flow. Bug: 827290 Change-Id: Id23959bb710a08db2ad64cf838b15a3b21457cef Reviewed-on: https://chromium-review.googlesource.com/1048166 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#566768}
-
Yutaka Hirano authored
Bug: 851858 Change-Id: I332467c9ac043408e8a44c41047ef511131e96eb Reviewed-on: https://chromium-review.googlesource.com/1098635 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#566767}
-
Richard authored
We do not have 'handle' concept now, this CL just renames class ServiceWorkerHandle to ServiceWorkerObjectHost as it implements mojom:: ServiceWorkerObjectHost. Change-Id: I004c45bdf739cc32e0a89c9c4221d352457d9d2f Reviewed-on: https://chromium-review.googlesource.com/1090574 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#566766}
-
Colin Blundell authored
This CL follows the motivations of https://chromium-review.googlesource.com/c/chromium/src/+/1095108 to make the same change for the SetInvalidRefreshTokenForAccount() and RemoveRefreshTokenForAccount() APIs as that CL made for the SetRefreshTokenForAccount() API. Bug: 798699 Change-Id: If3701f0d42fd0129ed324dc8b9f7ac7402c1cb3d Reviewed-on: https://chromium-review.googlesource.com/1097087Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#566765}
-
Daniel Cheng authored
Bug: none Change-Id: Id43c913c699283df72696c8f97b7b869befeebd1 Reviewed-on: https://chromium-review.googlesource.com/1093265Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#566764}
-
Christopher Lam authored
This CL fixes an issue where the overlay didn't hide the toolbar properly so it could still be tabbed to, and a corresponding problem where overlay buttons could be tabbed to when not visible. Bug: 851835, 851864 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1562211745c2373ee64a85936953137f2541ae48 Reviewed-on: https://chromium-review.googlesource.com/1098420 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#566763}
-
Yutaka Hirano authored
Bug: 736308 Change-Id: I3e0f76acc7269d54ed86999d7938384f9c2171e1 Reviewed-on: https://chromium-review.googlesource.com/1095118 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#566762}
-
Noel Gordon authored
With more speed, add more coverage: run open Quick View case in Tablet mode, and in Guest mode (so easy). Add a Quick View open test case for an ephemeral volume (USB here). Tablet (aka fully immersive) mode is not supported in Mash: add a Mash bot exclusion for the Tablet mode case. Bug: 851888 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I893f35838731b3264268b027a00a86c339bf5b3f Reviewed-on: https://chromium-review.googlesource.com/1098432 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#566761}
-
Hiroki Nakagawa authored
This is a cleanup CL and doesn't change behavior except LAPIs support (see below). Before this CL, ModuleScriptFetcher is an implementation of module script fetch for <script type='module'> on Documents, and WorkletModuleScriptFetcher is a subclass of ModuleScriptFetcher that implements the custom fetch hook for Worklets. This override reduces code duplication, but also makes it difficult to read code. After this CL, ModuleScriptFetcher becomes just an interface. DocumentModuleScriptFetcher implements it for Documents, and WorkletModuleScriptFetcher implements it for Worklets. This separation makes it easier to read code and to add a new variant of ModuleScriptFetcher for Workers, there're some duplicate code among DocumentModuleScriptFetcher and WorkletModuleScriptFetcher though. Note that this CL tentatively drops LAPIs support for worklets. This is safe because it has been flagged feature and not ready for worklets so far. We'll re-add the support after refactoring around ModuleScriptFetcher. Change-Id: I60fa46ebd86e046da811f018219cdd02411529a8 Bug: 842553 Reviewed-on: https://chromium-review.googlesource.com/1096919 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#566760}
-
Rohit Rao authored
When switching between incognito and non-incognito BVCs, it is possible for all of the toolbar's buttons to be temporarily hidden. We believe that this results in the stack view having zero width, which seems to permanently break autolayout on iOS 10. Adding an optional width constraint seems to work around this issue. BUG=851954 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6995f2b3f5fa3b0f2eafb09e3970001fd16720f6 Reviewed-on: https://chromium-review.googlesource.com/1097207Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#566759}
-
Nicholas Verne authored
Also adds a browsertest for CrostiniUninstallerView. Bug: 849438 Change-Id: I13ff94ec9324be0c01757f3094d76403c1d3b30f Reviewed-on: https://chromium-review.googlesource.com/1092397 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#566758}
-
Nicholas Verne authored
This relands commit 9ec0dfc9. In viz_browser_tests and mash_browser_tests it is possible for RunLoop::RunUntilIdle to return in a test while there are still pending tasks (on another task runner). We delay the test's continuation until the appropriate condition on FakeConciergeClient is satisfied. Bug: 851253 Change-Id: Iab1ade58607efae9ca7666666e0f77210d5973c1 Reviewed-on: https://chromium-review.googlesource.com/1096587Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
Dominic Battre authored
This CL disables password requirements fetching from gstatic unless the user syncs browsing history without a custom passphrase. NOTRY=true Bug: 846694 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If500c349d4fcbc94c3fe8b6c74aec1f9a2403420 Reviewed-on: https://chromium-review.googlesource.com/1097411 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#566756}
-
DongJun Kim authored
Chromium build with GCC, it had -Wmisleading-indentation warning in ax_menu_list_popup.cc after commit [1]. It looks unintended and we adds missing braces from previous patch-set. Also this patch includes clean-up as removing redundant function calls. [1] https://chromium-review.googlesource.com/c/chromium/src/+/769674 Bug: 849614 Change-Id: I45051847e116bc055dd8ba954bd9a0730d7188df Reviewed-on: https://chromium-review.googlesource.com/1090698 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
-
Yuki Shiino authored
As a preparation to move ExceptionState into platform/, moves ExceptionMessages into platform/. This should be the last dependency of ExceptionState to core/. NOPRESUBMIT=true Bug: 849607 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3d66e9ee6cce7ff2df138e2ab975b7fad3f733d3 Reviewed-on: https://chromium-review.googlesource.com/1097236 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#566754}
-
Dominic Battre authored
This CL introduces two features that are purely meant as kill switches until the feature have proven stable: - PasswordGenerationRequirements controlls whether Chrome attempts to generate passwords that meet the requirements of a website. If enabled, Chrome will use the requirements from Autofill server responses to generate passwords. - PasswordGenerationRequirementsDomainOverrides builds on top of that. If set an extra request will be sent to gstatic.com to fetch requirements for the main frame domain for which the password will be generated. These are separated into different features for to allow for disabling only the second part in case it should turn out to create problems (not expected). On top of that, three field trial parameters are defined: - PasswordGenerationRequirements/version - PasswordGenerationRequirements/prefix_length - PasswordGenerationRequirements/timeout The first two parameters control the file name that will be downloaded from gstatic. These are meant to stay in Chrome unless we decide to kill the service. They are used to scale the service: If few overrides are necessary, they all fit into one file that can be downloaded on demand. If more overrides become necessary, we may want to split that into multiple files. The prefix_length indicates the hash prefix lengh used for sharding data into files. The version parameter allows two things: 1) gradual rollouts to a new version while measuring that nothing breaks. 2) ensuring an atomic switch to a new prefix_length (e.g. version 1 might have a prefix length of 0, version 2 might have a prefix length of 4 -> the version parameter ensures that files are fetched from a directory that contains prefixes of the corresponding length). The purpose of the timeout parameter is to see whether a 5 second timeout works. We may remove that parameter if it turns out to be non-necessary. But we may also increase it from the server if necessary. Bug: 846694 Change-Id: I451b45b04eecfac609cb2400bb5281839578c628 Reviewed-on: https://chromium-review.googlesource.com/1097317 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Alexandre Courbot authored
DMA-BUF support in VideoFrame was suffering from several issues: * The number of DMA-BUF FDs provided to back a frame was assumed to be equal to the number of planes of the format of the frame. This is not always correct, since several planes can be backed by the same buffer, * FDs were always duplicated when creating a new VideoFrame - there was no option to make it take ownership of the passed FDs. * The class' public interface was taking FDs as ints instead of the more secure ScopedFD. This patch fixes these issues by doing the following: * Make VideoFrame::WrapExternalDmabufs() take a vector of ScopedFDs instead of a vector of integers, make it take ownership of the passed FDs, and make it accept a smaller number of FDs than there are planes in the frame's format, * Turn VideoFrame::DmabufFd() into VideoFrame::DmabufFds(), which returns all the FDs associated to a frame. * Introduce the media::DuplicateFDs() function which can be used by callers to explicitly duplicate a vector of FDs (a rather common thing to do). * Update users of VideoFrame::WrapExternalDmabufs() (concentrated in media/gpu/v4l2) to make use of this updated interface. BUG=850375 BUG=b:73752373 TEST=Tested VDA unittest and video playback on Hana (decoder + IP), and VEA unittest and resulting video playback on pit (IP + encoder). Change-Id: I9318fb3be82e3ff50c13c17dfd5faf8f4b5fd419 Reviewed-on: https://chromium-review.googlesource.com/1090416 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#566752}
-
Yutaka Hirano authored
This CL adds redirect logic to CORSURLLoader. There are some TODOs and I'll address them later. Bug: 736308 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8db4eccb6c5bb453882f6a469d4185487848773a Reviewed-on: https://chromium-review.googlesource.com/1088715Reviewed-by:
-
Balazs Engedy authored
This allows AuthenticatorImpl to first create the delegate and ask it if the WebContents has focus, and only then triggering the request dialog (which may steal the focus), so as to avoid race conditions around focus checking at request start. The CL also fixes fake FidoDiscoveries to use weak pointers so as to support being immediately destroyed after the discovery is started. Bug: 849323, 851593 Change-Id: Iae4ac25dc39b527e5481836e4522a6f4da7e31ba Reviewed-on: https://chromium-review.googlesource.com/1095619 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#566750}
-
Yuki Shiino authored
This reverts commit 377243e0. Reason for revert: SitePerProcessTextInputManagerTest.TrackTextSelectionForAllFrames is failing on Mac-10.12. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13719 Findit has 93% confident with this CL, and nothing else looks suspiciou so far (although this one doesn't look suspicious to me, neither). https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/13719 Let me give it a try to revert this one to see whether the revert fixes the issue or not. Please land this again, if this is irrelevant at all. Original change's description: > Move main scrolling coordinator update after PrePaint > > The main scrolling coordinator update, ScrollingCoordinator:: > UpdateAfterCompositingChangeIfNeeded, does not depend on the PrePaint > phase and can be moved after PrePaint. This change will make it easier > to compare the new PaintTouchActionRects update > (ScrollingCoordinator::UpdateTouchActionRects) to the current update > (ScrollingCoordinator::UpdateAfterCompositingChangeIfNeeded). > > This patch also renames UpdateAfterCompositingChangeIfNeeded to > UpdateAfterPrePaint and adds a comment describing what it does. > > Bug: 851513 > Change-Id: Idbcd515708a33d6955deb513808874b38d731c4f > Reviewed-on: https://chromium-review.googlesource.com/1096297 > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566542} TBR=flackr@chromium.org,pdr@chromium.org,xidachen@chromium.org Change-Id: Ic1839d7e51752fd2b5f974b958dadd2b98f2569c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851513 Reviewed-on: https://chromium-review.googlesource.com/1098815Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#566749}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/efd99cc92817..7deacf4833dc git log efd99cc92817..7deacf4833dc --date=short --no-merges --format='%ad %ae %s' 2018-06-12 jvanverth@google.com More shadow tessellation cleanup. Created with: gclient setdep -r src/third_party/skia@7deacf4833dc The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I29227ed013756bbe4960422ebbe8b2b95a876828 Reviewed-on: https://chromium-review.googlesource.com/1098239Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566748}
-
Yutaka Hirano authored
ErrorParameter holds a reference to a stale object. Let's stop doing that. Bug: 851419 Change-Id: I0c91acce7afaceeecdb368f5592417d4a39d8174 Reviewed-on: https://chromium-review.googlesource.com/1098646Reviewed-by:
-
Darren Shen authored
This is used to hide ongoing work to update the virtual keyboard UI. Bug: 851847 Change-Id: I13001c8812a68341cd9a330958dc4b42dda9abfd Reviewed-on: https://chromium-review.googlesource.com/1096799 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#566746}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f7f40e7..a0f86882 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic6a276cf133342b130fe2fc865baae96d81181f3 Reviewed-on: https://chromium-review.googlesource.com/1098615Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#566745}
-
Cathy Li authored
This will later be used to fetch resources for the UI. Bug: 852075 Change-Id: I58fa78a458c9cd329d55d7b4042c15b7f721aa97 Reviewed-on: https://chromium-review.googlesource.com/1095691Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#566744}
-
Findit authored
This reverts commit bf746c55. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 566724 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JmNzQ2YzU1YWRmNDlkMmYyMmNjMzA4MTg1YTE2ZDEyYzRlMTViMDQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/72596 Sample Failed Step: not_site_per_process_browser_tests Original change's description: > paint timing: Use presentation-time instead of swap-time. > > The presentation-time from gpu gives a more correct view of what the > user experiences, rather than the swap-time in the renderer process. > So switch to using the presentation-time to measure the various > paint-time metrics. > > The various paint-time metrics in telemetry tests (loading benchmark) > will go up after this change, but it is expected, and it is not a > regression. Results on various platforms with this change: > > Win 7: https://pinpoint-dot-chromeperf.appspot.com/job/14d09714240000 > Win 10: https://pinpoint-dot-chromeperf.appspot.com/job/149921e4240000 > Mac low-end: https://pinpoint-dot-chromeperf.appspot.com/job/12eeeba5240000 > Android one: https://pinpoint-dot-chromeperf.appspot.com/job/16ab13e9240000 > Android N5x: https://pinpoint-dot-chromeperf.appspot.com/job/12d45da5240000 > > BUG=811961 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I70a86eb85e84670942fe3fe6341926b5bc6255b9 > Reviewed-on: https://chromium-review.googlesource.com/1050693 > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Brian Anderson <brianderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566724} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=811961 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia66f54dd90c3010d1103c7ddc657e2765f67a1e3 Reviewed-on: https://chromium-review.googlesource.com/1098775 Cr-Commit-Position: refs/heads/master@{#566743}
-
Koji Ishii authored
This patch forces legacy fallback for -webkit-box and -webkit-inline-box. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I15c35df5e71c03a2df6b466e2ba2197f48d5e588 Reviewed-on: https://chromium-review.googlesource.com/1089591 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#566742}
-
Keishi Hattori authored
Add new IncrementalV8FollowupGC. It is a incremental marking enabled version of PreciseGC. Bug: 757440 Change-Id: I1b480eac30936a8ad9b56a88b2191b0d417a61e7 Reviewed-on: https://chromium-review.googlesource.com/1096798 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Darren Shen authored
There are some keyboard settings that enable the virtual keyboard (e.g. SetTouchKeyboardEnabled, SetAccessibilityKeyboardEnabled). When changing these settings, the code must also Enable/Disable KeyboardController. This is done every time in the real code so that we maintain an invariant that KeyboardController is enabled iff one of those settings is on. In KeyboardControllerUnittest however, we Enable KeyboardController in SetUp, but we don't update the corresponding settings there. Instead we instantiate some helper classes that turns on those settings in each test case. This is weird, as we'll always need to instantiate that class to maintain the invariant, so we might as well do it in SetUp. We get rid of the scoped helper classes and just turn on the setting in SetUp. Bug: 849995 Change-Id: I7d7b1bd751cb8894ff2d7a2554b6ae1f8db77bf9 Reviewed-on: https://chromium-review.googlesource.com/1098647Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#566740}
-
Wez authored
Update RTCPeerConnectionHandler to check explicitly that the configured |task_runner_| is the sequence that is is invoked on, rather than using a separate ThreadChecker. Bug: 851378 Change-Id: Ib0e4a7f12e12c1e3b92a435244808d177f86cbf2 Reviewed-on: https://chromium-review.googlesource.com/1096277Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#566739}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/11376cfc6fe9..c27a6612dbae git log 11376cfc6fe9..c27a6612dbae --date=short --no-merges --format='%ad %ae %s' 2018-06-13 ahassani@chromium.org paygen: Remove au-generator.zip Created with: gclient setdep -r src/third_party/chromite@c27a6612dbae The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:808495 TBR=chrome-os-gardeners@chromium.org Change-Id: I5cd621b2dcccf248570fdd215ec497a277003059 Reviewed-on: https://chromium-review.googlesource.com/1098238Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566738}
-
Hajime Hoshi authored
Now we're trying not to depend on event's target when dispatch an event asyncly in EventQueueImpl since event target is set also when actual dispatching, and setting the target before dispatching should be redundant. In the current situation, there is no consistent rule whether event target is set before dispatching or not. However, there is no other way to inform what is the target for the given event at EventQueueImpl::EnqueueEvent. In the usecase of EventQueue in ContentSecurityPolicy, there is no need to cancel events actively. Then, just posting tasks for events and dispatching them or canceling them when execution context is not present are enough. Instead of EventQueueImpl, this CL introduces EventTarget:: EnqueueAsyncEvent. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I33e67390762cba233ce31634238d4fd477b8d8da Reviewed-on: https://chromium-review.googlesource.com/1090591 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
edchin authored
This CL refactors duplicate logic into a helper method. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I83dcd77667a25821d8bac524be16647517bb83c4 Reviewed-on: https://chromium-review.googlesource.com/1094476 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#566736}
-
Hajime Hoshi authored
This CL is a pure refactoring. There is no usage of IPCTaskRunner from non-main threads. Change-Id: I74063e7f8cdd4562262eebfea4f9d12d594bae8d Reviewed-on: https://chromium-review.googlesource.com/1096934Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#566735}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9614a313b836..241d0c16c0d3 git log 9614a313b836..241d0c16c0d3 --date=short --no-merges --format='%ad %ae %s' 2018-06-13 qingsi@google.com Remove ContinualGatheringPolicy::GATHER_CONTINUALLY_AND_RECOVER. 2018-06-13 shampson@webrtc.org Updated PeerConnection integration test to fix race condition. 2018-06-13 buildbot@webrtc.org Roll chromium_revision ef538e31..9df92afb (566490:566630) 2018-06-12 qingsi@google.com Refactor the regathering of candidates in P2PTransportChannel. 2018-06-12 zhihuang@webrtc.org Add a flag to actively reset the SRTP parameters 2018-06-12 danilchap@webrtc.org Reland "Use absl::optional instead or rtc::Optional" 2018-06-12 buildbot@webrtc.org Roll chromium_revision ffaf1e2b..ef538e31 (565764:566490) 2018-06-12 orphis@webrtc.org Add HeaderExtensions to RtpParameters 2018-06-12 alexnarest@webrtc.org Enable send side audio TWCC only if WebRTC-Audio-ForceNoTWCC is not enabled. 2018-06-12 mbonadei@webrtc.org Explicitly setting use_lld=false on MSVC bots. 2018-06-12 peterhanspers@webrtc.org Metal renderer does not handle i420 frames correctly. 2018-06-12 andersc@webrtc.org Make rtc_software_fallback_wrappers target visible. 2018-06-12 phensman@webrtc.org Release ADM after passing it to PCF in AppRTC 2018-06-12 kwiberg@webrtc.org LogMessage::UpdateMinLogSeverity: Don't ignore all but the last stream 2018-06-12 philipel@webrtc.org Don't update internal state of the FrameBuffer2 when an undecodable frame is inserted. 2018-06-12 jonasolsson@webrtc.org Remove stringstreams from p2p/ 2018-06-12 jonasolsson@webrtc.org remove unused UNSHIPPED trace macros 2018-06-12 sakal@webrtc.org Delay the creation of the platform thread in TestAudioDeviceModule. Created with: gclient setdep -r src/third_party/webrtc@241d0c16c0d3 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:835958,chromium:None,chromium:None,chromium:844313,chromium:b/79961243 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b4bcb1330e3b4206e7a0d20aa3bb776e04949b2 Reviewed-on: https://chromium-review.googlesource.com/1098237Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566734}
-
edchin authored
A crash will occur when an scrolled offscreen cell is updated. This is because UICollectionView's |-cellForItemAtIndexPath:| returns nil if the cell is offscreen. This CL adds a unittest that fails without the fix, which is also in this CL. The fix is to skip cell configuration if the cell is nil. Bug: 851352 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iccdb53e3a67b58f225a09ce32ac70f48d42431ef Reviewed-on: https://chromium-review.googlesource.com/1094210Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
Joel Hockey authored
* Add Quick View test for downloads and crostini. * Update waitForElement to support searching elements within nested shadow roots. Bug: 845830 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b8f2ebd29eddfb3aa453aa5db0cd75aadec0650 Reviewed-on: https://chromium-review.googlesource.com/1090517 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
