- 01 Oct, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 49993008. With Chromium commits locally applied on WPT: 92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25734 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: msisov@igalia.com: external/wpt/webvtt timvolodine@chromium.org, reillyg@chromium.org: external/wpt/orientation-event NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I21f8093510ab47bb9505f3e3058b47ff94fb63ab Reviewed-on: https://chromium-review.googlesource.com/1255153 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#595607}
-
Andrey Kosyakov authored
The default for 3rd-party cookies in content shell has been changes from "deny" to "allow" by https://chromium-review.googlesource.com/1196547 However, we still reset it to "deny" when resetting the TestRunner between tests, which causes inconsistent behavior for tests that depend on default value. Bug: 890000 Change-Id: If85535e617eb884e5fdd64c928d558f9fa84bb29 Reviewed-on: https://chromium-review.googlesource.com/1250165Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#595606}
-
Justin DeWitt authored
* If no catalog is present, requests one from the network and displays default images. When request finishes, updates the category images. * Updates category images right away if not requesting from the network. * Fixes the query in GetCatalogTask so that if there is no "current" catalog, it will use the "downloading" catalog instead. Bug: 867488 Change-Id: Ic307f77a4b3ae2ededa711f619059b1aed562012 Reviewed-on: https://chromium-review.googlesource.com/1252908 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#595605}
-
Scott Violet authored
The client area insets of a top-level need to be propagated to the ClientSurfaceEmbedder. BUG=869501 TEST=covered by tests Change-Id: Id5aca98e46d596e8e43c7ea71150f59a0db638da Reviewed-on: https://chromium-review.googlesource.com/1252145 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595604}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d46dfc57..6d7c52f8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I27de39197801350ac95f29ef306811de43cfe3b4 Reviewed-on: https://chromium-review.googlesource.com/1254381Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595603}
-
Pedro Amaral authored
This reverts commit a55d47e1. Reason for revert: The breakage that caused this revert was only present on the M70 branch and never happened on master. It was due to this CL referring to a drawable that was renamed in M71. This CL uses the new name so it broke the M70 build when it was cherry picked. Original change's description: > Revert "Horizontal tab switcher use tab toggle" > > This reverts commit 61bed816. > > Reason for revert: Broke [Build Non-Channel Targets] build step > > Original change's description: > > Horizontal tab switcher use tab toggle > > > > Replace the HTS Incognito Button with a toggle. > > > > Bug: 851166 > > Change-Id: I5c431abb508930ee1a9a24792f2299ea08d944cf > > Reviewed-on: https://chromium-review.googlesource.com/1246453 > > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > > Commit-Queue: Pedro Amaral <amaralp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#594780} > > TBR=yusufo@chromium.org,amaralp@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 851166 > Bug: 890673 > Change-Id: I3631d88c29bd950beea9280e97e0ff50ed332bc8 > Reviewed-on: https://chromium-review.googlesource.com/1253741 > Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> > Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595411} TBR=yusufo@chromium.org,tobiasjs@chromium.org,amaralp@chromium.org Change-Id: Iaee562d9f3c393480028749e265550b84cad4ae1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851166, 890673 Reviewed-on: https://chromium-review.googlesource.com/1256104Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595602}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac93684421fa..69f64b270397 git log ac93684421fa..69f64b270397 --date=short --no-merges --format='%ad %ae %s' 2018-10-01 oysteine@google.com Allow bindId for separate begin/end slices as well 2018-10-01 simonhatch@chromium.org Dashboard - Create histograms per bot for alert statistics 2018-10-01 cbruni@chromium.org [pinpoint] Redirect to raw results.html on job completion 2018-10-01 pasko@chromium.org Avoid running Android background jobs Created with: gclient setdep -r src/third_party/catapult@69f64b270397 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890025,chromium:876233,chromium:890424,chromium:881384 TBR=sullivan@chromium.org Change-Id: I3fa5e360f1c7c98152f5078c58d9d41e34b66ebc Reviewed-on: https://chromium-review.googlesource.com/1254685Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595601}
-
Tom Anderson authored
BUG=737995,881371 TBR=pkasting Change-Id: Ifd8b41626747ae8e52fd7db67e86af5d87b9994f Reviewed-on: https://chromium-review.googlesource.com/1255594Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595600}
-
Vladimir Levin authored
This patch adds code to skip subtree walk if it was forced for a reason that is blocked for isolation. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I80b0010bbda722d03a07e4293d13e494b5da53e1 Reviewed-on: https://chromium-review.googlesource.com/1252941 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595599}
-
Ryan Sturm authored
When a preview is client blacklisted, this should be reported to the Data reduction proxy pageload metrics pingback. However, the boolean for this is not properly copied before content moves the navigation data cross thread. This is resulting in never reporting the client blacklist blocking the optimization. Another bool (offline_preview_used) is also not copied, but it is only used on the IO thread currently, so there is not functional bug. Bug: 890983 Change-Id: I6fafaa91d875b590ee5c5c725bc6f487e63395c4 Reviewed-on: https://chromium-review.googlesource.com/1255889Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#595598}
-
Achuith Bhandarkar authored
* Get rid of #define OS_CHROMEOS * Stop using GetActiveUserProfile. * Separators between functions * Remove ctors and DISALLOW_COPY_AND_ASSIGN for conciseness. * Consistency in declarations. * Consistency in use of DVLOG * Match order of functions in header and cc. * Remove kOnlyAvailableOnChromeOSError BUG=None TEST=browser tests, vm_sanity Change-Id: I0b6900886642479a84c70387c69042c51b9ad5ea Reviewed-on: https://chromium-review.googlesource.com/1251261Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#595597}
-
Sahel Sharify authored
This cl converts middleClickAutoscroll.js and the middle click autoscroll layout tests that are using it to use gpu benchmarking. Bug: 875945 Change-Id: Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6 Reviewed-on: https://chromium-review.googlesource.com/1251901Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595596}
-
Brian White authored
Try to narrow down where the ranges are getting corrupted by verifying the internal checksum in places. Bug: 836238 Change-Id: I05493e86d74c820c6dfe2dbe30759c04cdfb3f28 Reviewed-on: https://chromium-review.googlesource.com/1255322Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#595595}
-
Min Qin authored
SystemNetworkContextManager already takes a PrefService in its ctor. As a memeber variable of SystemNetworkContextManager, ProxyConfigMonitor should do the same. This CL also fixes an issue that ProxyServiceFactory is using BrowserThread::UI to create the system proxy service. It is possible that BrowserThread is not created if ServiceManager is started alone. Switching to use base::ThreadTaskRunnerHandle::Get() instead. BUG=866028 Change-Id: I6a33310e94a6050ca0bd22bdd716660aea790b58 Reviewed-on: https://chromium-review.googlesource.com/1255144Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595594}
-
David Trainor authored
Two files were redundantly listed in base/BUILD.gn which caused a compile error. NOTRY=true No-trying because this is blocking junit test compilation and has (should have) no effect on the mac builder. Change-Id: I98da40cfa877a3665a03cf4f879dd228574392ec Reviewed-on: https://chromium-review.googlesource.com/1255049 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#595593}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8dfa5c869e08..1b448050d611 Created with: gclient setdep -r src-internal@1b448050d611 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9f0de92dc70411b48d98df5b7345b27d7c25ceef Reviewed-on: https://chromium-review.googlesource.com/1255562Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595592}
-
Shimi Zhang authored
There is no need to keep this function since printing/units.h has such conversion already. R=thestig Bug: None Change-Id: Ib6164b40d5f8a6b812b7ebc2f81942403eb3926a Reviewed-on: https://chromium-review.googlesource.com/1255604Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#595591}
-
Tsuyoshi Horo authored
Bug: 890199 Change-Id: Idd9d01735d1a922692de63fc7b99e1154b13e7e9 Reviewed-on: https://chromium-review.googlesource.com/1250764Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595590}
-
Joshua Bell authored
As a follow on to https://crrev.com/c/1248328, wrap conversions between base::Time and the particular format used for persistence in the quota database (int64_t) in methods, instead of inlining the conversion steps at every point. Bug: 889242 Change-Id: I8d5b7b6a6e7bf9ccf507cd8c3ad750dae9e30206 Reviewed-on: https://chromium-review.googlesource.com/1254744 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#595589}
-
Weidong Guo authored
Changes: Make app list respect work area instead of display bounds. Bug: 889334 Change-Id: I861b2d652ce432dbccb16f36b90aae6cc90e328b Reviewed-on: https://chromium-review.googlesource.com/1255583 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#595588}
-
Eric Stevenson authored
This CL introduces the badging api. The badging API will eventually allow developers to set and clear badges for installed PWAs. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Fw764MVF5nI Explainer: https://github.com/WICG/badging/blob/master/explainer.md Bug: 719176 Change-Id: I68aa5a9310469bd3a38b1029f2141be335121b06 Reviewed-on: https://chromium-review.googlesource.com/1166603Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#595587}
-
Raymond Toy authored
It is valid to set the buffer attribute more than once. As resolved in https://github.com/WebAudio/web-audio-api/issues/1762, setting the buffer more than once is allowed. This is a revert (mostly) of https://chromium-review.googlesource.com/c/chromium/src/+/1077713 Bug: 882211 Test: the-convolvernode-interface/convolver-setBuffer-already-has-value.html Change-Id: Ie7f170883e6a6b2bfa7f14d89c74b72eebde3dac Reviewed-on: https://chromium-review.googlesource.com/1249275Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595586}
-
gogerald authored
src/chrome/test:browser_tests will be added later on Desktop since it is not available on Android (crbug.com/611756). Bug: 806868 Change-Id: I1f0896057d3a3608ff72e1205c4c4f372ea56c71 Reviewed-on: https://chromium-review.googlesource.com/1239440Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#595585}
-
Kristi Park authored
Before: https://screenshot.googleplex.com/VTEZEnvP8Ac.png After: https://screenshot.googleplex.com/QpJWqkymMe8.png Bug: 879502 Change-Id: I4a37757b19297c3507b55d8506446dd1f58ecbc5 Reviewed-on: https://chromium-review.googlesource.com/1252854 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595584}
-
Yue Cen authored
Bug: 881083 Change-Id: Ia8aa5753b1170983b0081c7de85c4b197743f7a6 Reviewed-on: https://chromium-review.googlesource.com/1253066 Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595583}
-
David Roger authored
This CL clears all Chrome authentication tokens when the user clears their cookie, except in one edge case: when the user is clearing both their cookie and their synced data at the same time, the token for the Sync account is not deleted, because it would prevent the data to be correctly deleted on the Sync server. The UI of the "Clear Browsing Data" dialog will be updated in a followup CL, to surface this behavior change to the user. Bug: 889137 Change-Id: I495a57b52a39832c30474973b4619de646a79bc3 Reviewed-on: https://chromium-review.googlesource.com/1250966Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595582}
-
Mihai Sardarescu authored
When DICE is disabled or DICE fix auth error is enabled, the token service should only manage the token of the primary account. This means that token service should clear all tokens from DB in these modes to avoid leaving tokens on disk when the user changes from DICE disabled to DICE enabled modes. The change in crypauth service is needed as to avoid an assumption that pref changes can only happen after primary account was set. This is not the case in browser tests. Bug: 890758 Change-Id: I63a8ae3ac0f00271c0031cd090d1cf9dad50905c Reviewed-on: https://chromium-review.googlesource.com/1254210Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595581}
-
Robert Ogden authored
If the user has IPH_DemoMode set in their about:flags, the previews IPH may appear even if the page is not a preview. This CL puts in a small check to ensure this can't happen. Bug: 886949 Change-Id: Ib0af8adcdefef0dba7dd8441d1a0d0189ea2581b Reviewed-on: https://chromium-review.googlesource.com/1255422Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#595580}
-
Tommy Steimel authored
This CL updates the styling for the volume slider for larger videos. Bug: 890092 Change-Id: I1b410b7318f10247457c46cadbbb081801e19acf Reviewed-on: https://chromium-review.googlesource.com/1250206Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#595579}
-
Tatiana Buldina authored
Bug: chromedriver:2600 Change-Id: I2d4ebdcfac43b27f2d443c82583a288d2570207b Reviewed-on: https://chromium-review.googlesource.com/1255623Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#595578}
-
chrome://omniboxmanuk authored
[chrome://omnibox]: create BrowseryProxy class to encapsulate communication with OmniboxPageHandler. BrowseryProxy is responsible for sending requests to and receiving responses from the omnibox page handler c++ code. In this cl, all communication with the c++ code are migrated to this class, but it is not yet fully isolated with the remaining js code; e.g. it directly reads inputs from the HTML DOM when making a request. This will be addressed in a separate CL to isolate js <-> HTML communication. Change-Id: I5aaa363a6614c8120c05cc4923c032a0d79a6157 Reviewed-on: https://chromium-review.googlesource.com/1252324 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#595577}
-
Chris Harrelson authored
[PE] Don't consider "unclipped_descendants" from being conditioned on having a composted scrolling ancestor. Also, scrollers which NeedCompositedScrolling count as a composited scrolling ancestor, not just ones with direct reasons. This fixes cases such as a fixed-position element under a scroller with an in-flow sibling, on high-DPI screens: <div style="overflow: scroll"> : This is composited due to high-DPI <div style="position: fixed; background: white"></div> : This is composited due to high-DPI <div style="position: relative; top: 500px"></div> : This is not composited because it is not overlapping the fixed position element unless scroll is applied. Once scrolled, it will not be visible because it is overlapped by the positon: fixed element. </div> There is already a code pattern to handle composited promotion for this flavor of case. However, the fixed position element does not have a non-root composited scroller above it. This is why the code was wrong before this patch. Bug: 889492 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I650408cb3bc7c2b7fac932f7e968863bcdcd41d5 Reviewed-on: https://chromium-review.googlesource.com/1253063 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595576}
-
Peter Kotwicz authored
The goal of this "CL set" (1-3) is to: - Force people to update template_shell_apk_version when code which is compiled into WebApk.apk is updated - Don't require additional reviewers for updating template_shell_apk_version. This CL: - Moves template_shell_apk_version into into a new file in a directory where it is the only file. - Adds an OWNERS file to allow anyone to update template_shell_apk_version. - Renames template_shell_apk_version and expected_shell_apk_version so that the GN variable names are more intuitive BUG=884444 Change-Id: Ic7a15506511f2bbffe2beea04d51e1a6e6d1aed5 Reviewed-on: https://chromium-review.googlesource.com/1243669 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595575}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/prefs. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=pam@chromium.org Bug: 874080 Change-Id: I7ca5bf1e7d05dafa3ba1b2d96ff5d6af1278df17 Reviewed-on: https://chromium-review.googlesource.com/1191137Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
Pam Greene (Please send IM for reviews) <pam@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#595574}
-
Fabrice de Gans-Riberi authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5d532182b97b6d849ac6ba9ccec45ed032da5927 Reviewed-on: https://chromium-review.googlesource.com/1255046Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595573}
-
Dmitry Titov authored
This will be used in Explore Sites to track breadth of web usage. It'll be called from ExplreSitesService, on a schedule, approximately once a week. Bug: 867488 Change-Id: If535dfead7f11dbaf501472dc42eaa882cbd94c4 Reviewed-on: https://chromium-review.googlesource.com/1248128Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#595572}
-
Weilun Shi authored
Change the height limit for truncateTitleText function to 24 according to the largest minimum font size in the setting. Screencast: https://screencast.googleplex.com/cast/NTY0Mzc2NjE5OTIyMjI3MnxlNDZjMjRlZi0yMA Bug: 881288 Change-Id: I1f9a6e60269acbe1756f22911410f85b29249e03 Reviewed-on: https://chromium-review.googlesource.com/1255602 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#595571}
-
Joshua Bell authored
Bug: 714018 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2cb2aba8e1f8460f0dedc25fdeba1df702e845fb Reviewed-on: https://chromium-review.googlesource.com/1244369Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#595570}
-
Alex Clarke authored
Bug: 863341, 872372 Change-Id: I19405b9061b3dc677d1f06e16564eb9aed133f79 Reviewed-on: https://chromium-review.googlesource.com/1251546 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#595569}
-
Xiaohan Wang authored
This was added accidentally in the original CDM, not initialized, and not used. Then in a late CL it's used assuming it's initialized, which was wrong. This CL removes |weak_this_| from MojoCdmService to fix the issue. Bug: 432998 Change-Id: Ifcda68e79c7ca5f2203cad9e77765b7f8c3d1971 Reviewed-on: https://chromium-review.googlesource.com/1255464Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595568}
-