- 12 Mar, 2020 40 commits
-
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: I2bc245d1a50e7ef3ef66467f4b849461e13bf40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100310Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#749691}
-
Fabian Sommer authored
This concerns the height of the dialog, the handling of multiline titles and descriptions, and the space between back button and lock icon. Fixed: 1059858 Change-Id: I182c2329417feb4d2a50e183115e5a8cb7211fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089684 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#749690}
-
John Abd-El-Malek authored
This regressed in r745404. Bug: 1060744 Change-Id: I983224321214f6ce43490c4de1f0788f3e3160e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099363 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#749689}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/421684f9438d..0338b7ae194a git log 421684f9438d..0338b7ae194a --date=short --first-parent --format='%ad %ae %s' 2020-03-12 brandon1.jones@intel.com Residency 3: Track Resource Heap Usages Created with: gclient setdep -r src/third_party/dawn@0338b7ae194a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibd8625019bb64cbadb5a20460864ad922cacb031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749688}
-
Robert Ogden authored
This field is no longer used since DRP removed non-core proxies, so let's clean it up. Bug: 945364 Change-Id: Ica6ba2dbaffcca3db1fd366edf725784b63e89c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096100 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#749687}
-
Juanmi Huertas authored
Removing usage of the fallback method of CreateProvider to the actual Creation of a SharedImageProvider and if that fails, a BitmapProvider. Bug: 1035589, 1021287 Change-Id: Iacc44c19ccb8cc9931923bf4cc51bf8b00d71b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095342 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#749686}
-
Emre Kanlikilicer authored
Bug: 1054268: GCPW startup sentinel file is updated 3 times per process (LogonUI) Change-Id: I3156fe8c51c4d3b2baed16b532dfd5002068fa0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066079Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Emre Kanlikilicer <emreknlk@google.com> Cr-Commit-Position: refs/heads/master@{#749685}
-
Peter Kasting authored
Bug: none Change-Id: I2d63751b0b5a000c3ea16155eba77cbfa28a99d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100015 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#749684}
-
Mustaq Ahmed authored
Change-Id: Ie75d61d71fef780c84c25b70c4fddab395ea4ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088229Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#749683}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/559b7c953589..3181426885c3 git log 559b7c953589..3181426885c3 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 petermarshall@chromium.org [test] Add an e2e test for console let re-declaration Created with: gclient setdep -r src/third_party/devtools-frontend/src@3181426885c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I39e2dcd89a1bb3e9fbfa21890f08f042ab14cddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749682}
-
Justin Miron authored
This change renames OnDomStorageAccess to OnStorageAccess from MetricsWebContentObserver->PageLoadMetricsObserver. It adds a new parameter access_type denoting what storage medium is being accessed. This change is a precursor change to new metrics measuring third party storage usage. OnStorageAccess is currently used for LocalStorage and SessionStorage but will be expanded to cover other types of storage in future changes. BUG=1059915 Change-Id: I8fe5e6ed8d934723b1d31b6459bd77c4b8baf700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094213Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#749681}
-
Juanmi Huertas authored
Refactoring a test to better test individual type of canvas resource and replacing instances of AcceleratedResourceUsage for SharedImage and Bitmap resource providers. Bug: 1035589, 1021287 Change-Id: I8731cc59aed59a3f56eaeff49845cb9e8f6a0da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095369 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#749680}
-
Richard Knoll authored
These seem to cause flakiness so disable them until we find the cause for that. This feature is behind a flag so disabling the test seems fine for now. Bug: 1060869 Change-Id: I49d9841c1122660355b4b57018dbcd09f2b829e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100808Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#749679}
-
Sebastien Marchand authored
Bug: 1056189 Change-Id: I8929621e4ecef829fa83d13e4973d4cefda8574e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100108 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#749678}
-
Aaron Leventhal authored
Image <map> already disallows children via CanHaveChildren(). Bug: None Change-Id: I156f1f33e5864eb5459ccaf252d5afb34cb1329a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100488Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749677}
-
Fabian Sommer authored
ChallengeResponseAuthKeysLoader now waits until force-installed login screen extensions are installed before requesting a certificate from these extensions, avoiding an incorrect error message. In order to know which extensions to wait for, stored ChallengeResponseKeys now contain the id of the extension that signed them. ChallengeResponseAuthKeysLoader will only wait for 5 seconds, then the error is displayed anyway (e.g. if the extensions failed to load). Bug: 1052404 Change-Id: I8a24b87cb63f4d899d36a3b0ab30237a6d82f691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078584Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#749676}
-
Peter Wen authored
Found by errorprone. I'm surprised that they were not caught earlier. Tbr: Comment changes. Bug: None Change-Id: Ia26be03885df3a416978686ad6581be9cd1ec376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100708Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749675}
-
Daniel Vogelheim authored
These tests have a very high flakiness because they bump against the timeout limit, and they are also run on other bots. So we can just save the effort and drop them from MSAN. Bug: 1060138, 856601 Change-Id: I7861f65721747334bbc925d48dd4669aedebb5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096736 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#749674}
-
Nohemi Fernandez authored
Adds logging for first run and sign-in flows. Bug: 971989 Change-Id: Ieec769b0db013959396be3ee533eb84f206cb9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087403 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749673}
-
Theresa authored
This reverts commit a8ed939a. Reason for revert: Moving to different directory Original change's description: > Move //chrome/android/public/ to //chrome/browser/android/ > > Change 1 of 2. The next CL will update downstream dependencies. > > Note that this will break the downstream build temporarily. Since there > are JNI files generated, unless the package is updated we cannot keep > a temporary mirrored build target as was done in > https://chromium-review.googlesource.com/c/chromium/src/+/2095444 > > BUG=1052382 > > Change-Id: Ib4d2e6f8143a7c0c6ead75d7701fea69a21db3a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095760 > Commit-Queue: Theresa <twellington@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749666} TBR=dtrainor@chromium.org,twellington@chromium.org Change-Id: Ieb5026e18ccbc629be00c6a10762253908a98ae2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100709Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#749672}
-
Nohemi Fernandez authored
Streamlines the existing OWNERS files and adds fernandex@ to sign-in. Bug: 1060993 Change-Id: I20e91d74fc6d6013904aa5d9faea502b1ee66985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098629 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749671}
-
Andrew Grieve authored
Plus resource_sizes.py tweaks: * Fixes failed sanity check for TrichromeWebView.apk * Teaches it that TrichromeLibrary is a shared apk Plus converts milestone_apk_sizes.py to python3 Bug: 1056320 Change-Id: I7691e9ccd7498dab180e104428ed7fe909c18fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099765Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#749670}
-
Andrew Grieve authored
The robolectric_processor annotation processor need extra data files for it to operation, which GOMA has no way to know to make available. Easiest fix is to just disable GOMA for the three targets that use the annotation processor. Bug: 726475 Change-Id: Idb9c6d6edd9f199a3430499d4835051a4db9ca2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098762 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749669}
-
Daniel Nicoara authored
Bug: None Test: Compiled Change-Id: I70c10e9c03f937c0e383df55a75014020214d92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100707 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#749668}
-
David Van Cleve authored
Currently, runtime_enabled_features.json5, the central registry of Blink runtime-enabled features, has a relatively large OWNERS alias (to API owners and Blink core owners). Adding a new runtime-enabled feature associated with an embedder-side base::Feature often involves adding boilerplate to WebRuntimeFeatures and //content/child/runtime_features.cc. Unfortunately, these files are in far-removed directories with few common owners. This CL expands those files' per-file owners to include renderer/core's owners, just as blink/renderer/platform/OWNERS currently does for runtime_enabled_features.json5. For the case of content/child/runtime_features.cc, the change also adds all top-level Blink owners. This should reduce the number of approvals needed to land a new runtime-enabled feature. It might also improve the quality of scrutiny these changes get: the comments accompanying these OWNERS aliases (copied from the comment next to runtime_enabled_features.json5's OWNERS alias) require that the reviewers have context about the functionality being affected by the runtime-enabled feature; currently, it might be hard to find owners for public/platform, renderer/platform, and //content/child who have context on one's specific feature. Change-Id: If420895d0256347ca2831e835ef970f766420ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092905Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749667}
-
Theresa Wellington authored
Change 1 of 2. The next CL will update downstream dependencies. Note that this will break the downstream build temporarily. Since there are JNI files generated, unless the package is updated we cannot keep a temporary mirrored build target as was done in https://chromium-review.googlesource.com/c/chromium/src/+/2095444 BUG=1052382 Change-Id: Ib4d2e6f8143a7c0c6ead75d7701fea69a21db3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095760 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#749666}
-
Aaron Leventhal authored
TBR=aboxhall@chromium.org NOTRY=true Bug: None Change-Id: I43b293e9ef1247458bd6f500ace250b285a7a934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099568Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749665}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: I5c32614984a2398d83001d5b4e48c7689f7991d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087585 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749664}
-
Ulan Degenbaev authored
This changes the reporting in performance.measureMemory to reveal only the URL at the frame creation time for cross-origin iframes and thus prevents URL information leak if the iframe navigates after loading. This is done by saving the first cross-origin URL loaded in LocalFrame in LocalFrame::DidAttachDocument and using that URL for reporting. The patch also adds a new test for redirecting iframe and fixes the existing tests to wait until child iframes are loaded. Bug: 1049093 Change-Id: I0162efb82061f036450586dea0b191cacdce23f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098722 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#749663}
-
Rouslan Solomakhin authored
Patch #10: Set minimal UI fields of the payment app and rename PaymentApp.java methods to the new terminology of "minimal UI". Before this patch, the abstract class PaymentApp.java had methods isReadyForMicrotransaction(), setMicrotransactionMode(boolean), accountBalance(), while the concrete class ServiceWorkerPaymentApp.java overrode these methods with demo-only stubs. After this patch, the abstract class PaymentApp.java has stub methods isReadyForMinimalUI(), setIsReadyForMinimalUI(boolean), disableShowingOwnUI(), setAccountBalance(String), accountBalance(), which are overridden by the concrete class ServiceWorkerPaymentApp.java. Bug: 1005076 Change-Id: Id5d5dd131b7e12e982639106f9a963d362e4f408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087907 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#749662}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e5def0b4eb6..95001d898186 Created with: gclient setdep -r src-internal@95001d898186 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I67aa24b09d8adfefbdfcffcba8afccb1cdd96b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100567Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749661}
-
Ewann authored
If the URL scheme corresponds to Chrome on iOS, the icon shouldn't be set. Bug: 1038919 Change-Id: I3f23fd8a23a3c10accb139d341d75d952e6faae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096555 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#749660}
-
Andrey Zaytsev authored
Moved TestPasswordsPrivateDelegate into a separate file so it can be later used by safety check passwords unit tests Bug: 1015841 Change-Id: Id1662ec772f20eb8e33a98eb35b7b94be4fac422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096588 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749659}
-
Tien Mai authored
Change-Id: I2832ea85e93e9ec6439f23327f191c31ca5dfd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095879Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#749658}
-
Mark Cogan authored
Changes the URL loading notifier keyed service into a browser agent. This removes the notifier service as a direct dependency on the URL loading service; instead the loading service fetches the notifier when it is assigned a Browser. Bug: 1046375 Change-Id: I302858f854d310749660922c994ae8b9238a24b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093441 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749657}
-
Jason Lin authored
Bug: 1019034 Change-Id: Iaaf06362ba428414a4bc59414c355f34cc258992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089541Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#749656}
-
Aaron Leventhal authored
If this line is removed, tests fail because pseudo elements no longer have static text children. The comment originally associated with it was incorrect. NOTRY=true TBR=aboxhall@chromium.org Bug: None Change-Id: I7bb1e9c3af01d02c2199c769f70e40755cd2876f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100728Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#749655}
-
Rouslan Solomakhin authored
Patch #9: Pass minimal UI response from C++ to Java and report the error message, if any. Before this patch, Java received only the "can make payment" boolean from C++. After this patch, Java receives the following fields: 1) Optional error message <--- reported. 2) Can make payment. 3) Ready for minimal UI. 4) Account balance. Bug: 1005076 Change-Id: I4d30a5685416f0cadfc9e39db5557b92e7ff9aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088291 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#749654}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9841983ed0df..559b7c953589 git log 9841983ed0df..559b7c953589 --date=short --first-parent --format='%ad %ae %s' 2020-03-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@559b7c953589 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic91cb4c37a417f9bdf1d58ca47503c2d1bed01ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749653}
-
Ben Joyce authored
Bug: 1052460 Change-Id: Iae243b05cdbdacc4997059bbc3a9ee555365cc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099323 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#749652}
-