- 06 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3fee63a19d6..8b665312ca15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0cad7d7744c26698270c300eb2473208b8d48f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824783}
-
Kenichi Ishibashi authored
This CL moves MakeSelfOwneReceiver() for resource reader/writer from ServiceWorkerStorageControlImpl to ServiceWorkerStorage. This move allows us to call LazyInitialize() if the internal storage hasn't been initialized yet. This behavior simplifies service worker storage service recovery steps because it would eliminate a need for force initialization after restart. As a side effect we need to update helper functions in service_worker_storage_unittest.cc Bug: 1133143 Change-Id: I43057adfbbc91d94dd5aedc22c684cb862ab26d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519345Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824782}
-
Sigurd Schneider authored
This CL allows the WorkerDevToolsAgentHost to get to the DedicatedWorkerHost of the associated dedicated worker, which was previously not possible. This is accomplished by re-using the dedicated worker token as devtools token, and by adding a lookup mechanism on the DedicatedWorkerServiceImpl which allows looking up the DedicatedWorkerHost based on said token. The CL then uses this mechanism to allow look-up of the COEP status on dedicated workers. Bug: chromium:1051466, chromium:1145158 Change-Id: Id038006e6437d3c622ca74979ac1ab4493bcd240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494861Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#824781}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8b665312ca15..0891c367b8b2 2020-11-06 chinglinyu@google.com Merge "traced: provide options to set socket permissions." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I06d7478c34a985fac544646a8bcc1ab59169da48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522599Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604620781-6e005798045dacc8d1de821cf745cddceb8035b4.profdata to chrome-mac-master-1604642156-6de658d746d924ba0793cdd79cc80ba08c1ee69e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I45082c033d3775c4995ef0fb7ca5351913264713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522688Reviewed-by:
-
Simon Zünd authored
Trust Token Redemption can be short-circuited if a valid Signed-Redemption-Record (SRR) already exists. In this case, the network service aborts the request with a special error code. In DevTools, this is repoted as a failed request, even though it was technically a successful request served from cache. This CL handles this case better and emits a loadingFinisehd event instead of a loadingFailed event. R=caseq@chromium.org, sigurds@chromium.org Bug: chromium:1141652 Change-Id: Ie0408b7557928722ddb1964c1ad5d8bdf73aa831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516225Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
WrapExternalGpuMemoryBuffer() doesn't fill sizes and offsets of planes. This CL fills them on Linux and ChromeOS based on NativePixmapHandle acquired by the given GpuMemoryBuffer. Bug: b:172456191 Test: local playback appr.tc/?vsc=vp8&vrc=vp8 on atlas Test: video.DecodeAccelVD.* on atlas, cyan, hatch Test: Play videos on YouTube atlas Change-Id: Ie150d330e2e1df49deeafdac1f21b7669ebb790c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518311Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#824777}
-
yiyix authored
Add new attribute textRendering to canvas context 2d. Developers can now choose between auto, optimizeSpeed, optimizeLegibility and geometricPrecision for textRendering. Bug: 1144620 Change-Id: I2420967849b1080b667cf6803a8edecc06327297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511910Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#824776}
-
Asami Doi authored
The CL introduces new states to the CheckOfflineCapability feature. 1) The feature (CheckOfflineCapability) is disabled. 2) The feature is enabled (warn-only). 3) The feature is enabled (enforce). Currently, warn-only mode just records the metrics and it doesn't affect the result. It will show a warning message in another CL. Bug: 965802 Change-Id: I4a7c4b748c674004696f9587f4c988dfc2116d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508100Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824775}
-
Moe Ahmadi authored
NTP can show 10 custom links and 8 MV tiles. MV tiles appear as though they are custom links until they are modified and actually freeze into custom links. Thus, 9 MV tiles are requested from the MostVisitedSites making up to 10 custom links including the "Add shortcut" button. Given that the 9th MV tile is need only if custom links are enabled and is ignored otherwise, this CL changes the number of requested MV tiles to 8 and allows MostVisitedSites itself to decide when to return an additional tile. This CL does not change the user experience. It only facilitates integration of the Repeatable Queries into MostVisitedSites. Bug: 1145050 Change-Id: Ib784019e99abf98ee6a2a6373c5f1eeb834b9615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516383Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824774}
-
Yuki Shiino authored
Makes blink_type_info more friendly to use of forward declarations so that complete type definitions are not required. Bug: 839389 Change-Id: Ie6ec1bd350cd6bd60e569cc24717055871d5d44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521871 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#824773}
-
Bartek Nowierski authored
The code wasn't accurate to begin with as it doesn't decommit enough. Line 318 does it correctly, thus superseding the code being removed. Name local variables more accurately, while at it. Change-Id: I44c6aae01bf263704354c4c331064f084873e2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519430 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#824772}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/67117aa5b601..abc1b79a1564 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040645 Tbr: peria@google.com Change-Id: Ia0648530749b77e7aee75216750631dc8d3509f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522683Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824771}
-
Robin Lewis authored
Login enforcement for policies is done only when cloud policies is enabled. This cl is the same as one reviewed in https://chromium-review.googlesource.com/c/chromium/src/+/2503810 but which was reverted due to time out issues on win-asan build. This cl refactors the tests to decrease the number of scenarios being tested. Bug: 1142903 Change-Id: I97508f69ebefb15d1129f775743c27a5dac1a3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518267Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Commit-Queue: Robin Lewis <wrlewis@google.com> Cr-Commit-Position: refs/heads/master@{#824770}
-
Ramin Halavati authored
WindowAppleScript initialization with profile sometimes crashes and this can be due to unavailability of browser creation at that time. Code added to prevent crash and facilitate further investigation. Bug: 1144992 Change-Id: I4835f443cca7e29c7f66334b06ca0f878702ea4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516359Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#824769}
-
Jérémie Boulic authored
Dependencies for //ui/file_manager/file_manager/common/js/util_unittest.m.js common/js: - util_unittest.m.js - async_util.js - metrics.js - metrics_base.js background/js: - entry_location_impl.js - mock_volume_manager.js - volume_info_impl.js - volume_info_list_impl.js - volume_manager_factory.js - volume_manager_impl.js - volume_manager_util.js Test: browser_tests --gtest_filter=FileManagerJsTest.UtilTest Bug: 1133186 Change-Id: I907c936c00efdfea888166ba09f61b31845eacd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522812Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#824768}
-
Tarun Bansal authored
This CL moves the logic to disable lite videos on seek behind experiment parameter, and also disables that by default. The param can be enabled again once we are reasonably confident that it's not too aggressive and we can run an experiment to verify that. Change-Id: I950b6d42750f11156ba0f0afad5989ac19832a7b Bug: 1145646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519719 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#824767}
-
Hitoshi Yoshida authored
On backward/forward navigations, BFCache does not load the destination page again and onload event is not triggered. Instead, onpageshow event is triggered on the first load and b/f navigation. This CL updates 3 tests under history/ to replace onload to onpageshow to work with BFCache. Bug: 1132180 Change-Id: I9146aecc4a020efe72dd8de24a1d33576395ab96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517188Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#824766}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8532ef05056c..9d6ec8fb24e8 2020-11-05 nigi@chromium.org Enable 2 tests in FPDFEditEmbedderTest for Skia/SkiaPaths. 2020-11-05 tsepez@chromium.org Remove use of CFXJSE_Value in CFXJSE_Engine::m_mapObjectToValue. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I75bdeb9a4c7cdb5f504657aea5468429311fac3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522601Reviewed-by:
-
Yuki Shiino authored
This is a follow-up of https://crrev.com/c/2521971 . Change-Id: I53d5bbaa1de43cbb17cf80d9aa39f7108addaaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521554Reviewed-by:
-
Alex Moshchuk authored
This CL adds logic to not honor opt-in origin isolation (typically specified via the Origin-Isolation header) if the environment has a site isolation memory threshold in effect, and the device is below that threshold. Memory thresholds are used on Android, where the default threshold is currently 1900MB (overridable via field trials), and where full site isolation is disabled by default. They aren't used on desktop, so this change does not apply to desktop platforms. An exception is made to still honor opt-in origin isolation if full site isolation is in effect, such as if the user manually turned it on via chrome://flags or if this was done via enterprise policy. Similarly, if the user manually turns off site isolation via --disable-site-isolation-trials (or the equivalent chrome://flags entry), that also disables opt-in origin isolation, including on desktop platforms. Bug: 1145860 Change-Id: Ibc5b2f6100ea9f6e2e46e25cefb52ba51ac697f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520086Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#824763}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for: - LayoutBR - LayoutCounter - LayoutText - LayoutTextCombine - LayoutTextFragment - LayoutNGText This CL has no behavior changes. Bug: 891908 Change-Id: I495349f1efffa3f9a2b6d53ae117a2f95fe606ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521986Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#824762}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/59917fa054ac..0f76c73eff05 2020-11-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I403a2d29524cfce105afc5928e06556faa68fdcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522598Reviewed-by:
-
Lijin Shen authored
Add distance change between the current motion event and the last motion event. Bug: 1142475 Change-Id: I365fb9d37c2138ac42ce46a8cafe6b8adf554bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518995 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#824760}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e3fee63a19d6..8b665312ca15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1d2eafdd8b12899e726f0aed0bdd63ad0076dcff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521700Reviewed-by:
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/7LsYDFYkkFrBUZ9 Bug: 889763 Change-Id: I918cae68beb3614f1c32374028320424897c597d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517189 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824758}
-
Alex Danilo authored
Bug: 1002410 Tests: browser_tests --gtest_filter="*saveFileDialogDefaultFilterKeyNavigation" Change-Id: I040f3cda4d4f211cafbab10d46a4506f2b7a10f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521974 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d30f01144708..3dfaeeb00271 2020-11-06 syoussefi@chromium.org Vulkan: Don't flush deferred clears on READ framebuffer sync 2020-11-06 jmadill@chromium.org Fix trigger.py using deprecated parameters. 2020-11-06 jdarpinian@chromium.org Allow choosing EAGL or CGL at runtime 2020-11-06 jmadill@chromium.org GL: Add support for GL_OES/EXT_texture_buffer 2020-11-06 syoussefi@chromium.org Vulkan: Store image updates per level If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I8dd0dfe603210079f98e9097b00375d90519e6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521699Reviewed-by:
-
Drew Davenport authored
This could be called in mesa on some SoCs to set the affinity of the gallium thread from the main thread. BUG=b:170305550 TEST=gpu process does not crash Change-Id: I51aec065750ccbbe71c086ddd2492bc25933d3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514066Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#824755}
-
Leo Lai authored
BUG=b:158955123 TEST=unit_tests. TEST=gn check. Change-Id: I6f1d854228897fb586b7da5c508d72127d82943a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519542 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#824754}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/073820cb20af..67117aa5b601 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1133499 Tbr: peria@google.com Change-Id: Ibf643d6ab42146b5f91662983309de65ff1a13e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522680Reviewed-by:
-
Yuki Shiino authored
Removes migration_adapter.idl because the new IDL interface's implementation landed. Bug: 839389 Change-Id: I4d5096428459fbb902bbe97b70328194356b3fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521971Reviewed-by:
-
Dominic Mazzoni authored
This patch has no functional difference, it is just a refactor. AX-Relnotes: N/A Bug: 1068668 Change-Id: Ibf1d3dd111d1a1c239aa79141905d36752805db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520076Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
-
Joel Hockey authored
I just noticed another flake in https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42616. 1/ The in-progress map is changed to store a globally unique identifier so that multiple deletes across volumes cannot collide. 2/ The in-progress map was being cleared after the *.trashinfo files was written, but before the file is moved. This is now changed so that we only clear the map once the file is moved. Bug: 953310 Change-Id: I49c9c75878288f2f1a0be4447c1885a07c873bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521981 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#824750}
-
David Bienvenu authored
This reverts commit 00952e6e. Reason for revert: <crbug.com/1141059> Original change's description: > Stop removing WS_THICKFRAME style on full screen. > > Also, change IsFullScreenWindowMode to not require the absence of > WS_THICKFRAME when deciding if a window is full screen. > > This issue this fixes involves the glass_browser_frame_view when > maximizing after going full screen - an extra 8 pixel bar gets drawn > above a maximized window, and if there's another monitor > above the one with chrome maximized, the bar gets drawn on > the other monitor. > > Windows doc > https://docs.microsoft.com/en-us/windows/win32/winmsg/window-styles > claims that some styles can't be changed after the window is > created, but also says that if you change frame styles, you > need to call SetWindowPos with SWP_FRAMECHANGED, which we are doing. > > Not removing the WS_THICKFRAME style doesn't seem to have any visible > effect on full screen windows. > > Bug: 1014720 > Change-Id: Ibfbd480c603fd7c3aca74081201e99e59fbbbecc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972258 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791237} TBR=pkasting@chromium.org,thakis@chromium.org,davidbienvenu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1014720 Change-Id: I4a35fccff45ba0994157939fe5fa95107ecb0334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522875Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824749}
-
Leo Lai authored
After using attestation client, we don't really need cryptohome and its async caller, but they are still passed to the constructor. BUG=b:158955123 TEST=unit_tests, browser_tests, chromeos_unittests. Change-Id: I984694d0ec985da3c9d21273bba9555f0aa89633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519639 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Adam Rice authored
In 2017 the HTML standard changed to no longer check the bad port list synchronously in the WebSocket constructor, instead relying on the lower-level check in Fetch to cause an asynchronous failure. Safari is now implementing this (https://github.com/web-platform-tests/wpt/pull/26392#issuecomment-722593477), so update our implementation to match. BUG=705534 Change-Id: I29c35fa2307a1215d5f382f86ca97bbfd17aba2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521874Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#824747}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604588329-6f5ba33f1a6962e1b0406a8222a4664471a1f39d.profdata to chrome-win32-master-1604609790-b9d65003227996f3e38071970a83664b74f65abb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2ef00d93f088ceca9b10eb87d28c4a42a3155653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522591Reviewed-by:
-
Nicholas Hollingum authored
Tasks are deleted on completion (even before crrev.com/c/2507234), this caused a UAF when a member-object of the AwaitBorealisStartup task was transitively deleted but its callee. The chosen solution is to post completion as a separate task rather than call it from the current completing BorealisTask, we do this is a mutually-exclusive way so that the deletion of the task is exclusively-after its completion. Bug: b/172605172 Change-Id: Iaf23e9ead37196988b24753cef451da318c48436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521876Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#824745}
-
Daniel Cheng authored
Change-Id: I4a0d6a554cbce5eecb25f6720f22d41919588a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521355Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#824744}
-
