- 16 Oct, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium d1c80a64. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I5d8180308c7bf43416d51e0e2bf042910475cc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864874Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706491}
-
sczs authored
- Creates InfobarSaveCardCoordinator and implements stop and infobarWasDismissed which is common between all InfobarCoordinators. - Creates kInfobarTypeSaveCard and expands infobar_metrics_recorder to handle this case. (The Histogram suffix is being updated on https://crrev.com/c/1862867) Bug: 1014652 Change-Id: I86e70ce67f01e63622d83834094fb4bd4fded68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862863Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#706490}
-
Christian Fremerey authored
Bug: None Change-Id: Id480b5ff4951b72408bf26765bff53fb4e447901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811279Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706489}
-
Annie Sullivan authored
We need to re-enable to check if bug 839470 is fixed, and bug 953371 is marked fixed. Bug: 839470,953371 Change-Id: I9c1c06b731c7d9049ed88cf758796dd31a35f9ee TBR: crouleau@chromium.org NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864380Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Auto-Submit: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706488}
-
Matt Menke authored
There's a method in net/ which does the exact same check: net::HttpUtil::IsSafeHeader(). We shouldn't duplicate logic. Bug: None Change-Id: I70a68db14c4cdb1962e0980594485e8a41be1308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862864Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#706487}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/692ad2ff20be..a737564bd5b5 git log 692ad2ff20be..a737564bd5b5 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 jclinton@chromium.org cbuildbot: Always use `--groups all` when repo init Created with: gclient setdep -r src/third_party/chromite@a737564bd5b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I61e1a1e796610f0a38f8dc345afc79c6f238cc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865196Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706486}
-
Robert Liao authored
BUG=1014283 Change-Id: Ieb4762c3c6b59cba40a55d60c980d76c0330180f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860979Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706485}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bedeb781e8ca..a14555a7928f git log bedeb781e8ca..a14555a7928f --date=short --no-merges --format='%ad %ae %s' 2019-10-16 jmadill@chromium.org Vulkan: Refactor RenderTargetVk ImageViews. 2019-10-16 tobine@google.com Revert "Vulkan: Define VK_USE_PLATFORM_XLIB_KHR" Created with: gclient setdep -r src/third_party/angle@a14555a7928f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:1011068 Change-Id: I94b146ac594828006ecc7fc0d1df910f0e4cd6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864373Reviewed-by:
-
Andrew Grieve authored
Rather than whatever version of java is available in PATH. For desugar and errorprone, some java warnings started to show up from this: "WARNING: An illegal reflective access operation has occurred" I've just silenced them with a stderr filter, and figure they will go away next time we roll these deps. I've checked the effect on d8 & r8 for this: * On my local machine, they run much faster. * On the trybot, they ran a bit slower. Bug: 693079 Change-Id: I4001bbcb5bdcc2a9afa062c35633dc397b0ef9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857702 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706483}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad531032..fedca194 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id2be91e07431d38b508fc198e601865d2ad07ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864875Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706482}
-
Mark Cogan authored
This is the first CL of several breaking crrev.com/c/1860025 into smaller chunks. This updates most of the SettingsNavigationController class inits to take a Browser instead of a BrowserState. One of the inits (the import data one) is called from AuthenticationFlowPerformer, which doesn't yet have a Browser, so it's initialized with a BrowserState instead. Because of this, SettingsNavigationController itself is initialized with a BrowserState. There's also some cleanup of these init names. Prior to this change, none of the class methods (for example: "newAccountsController:delegate:") properly identified the first parameter. Some of the method signatures were also impossible for clang-format to wrap to 80 characters. So: - The return type of all of these methods is now 'instancetype'. - The 'new' prefix is dropped from all of them, matching current style. - Methods that had 'WithBrowserState:' now have 'ForBrowser:', aside from -importDataControllerForBrowserState:delegate:importDataDelegate: fromEmail:toEmail:isSignedIn:. - Methods that didn't have a keyword for the BrowserState parameter also now have "ForBrowser:". - "syncEncryptionPassphrase" is shortened to "syncPassphrase", since "Encryption" doesn't add any useful information. The full method name is now +syncPassphraseControllerForBrowser:delegate:. - "autofillProfille" is corrected to "autofillProfile" (one "l" in "profile", The full method name is now +autofillProfileControllerForBrowser:delegate: - "settingsMainController" is reordered to "mainSettings". The full method name is now +mainSettingsControllerForBrowser:delegate: BrowserInterface didn't have a 'browser' property, which it clearly needed. This CL adds one. Change-Id: I6b0a8c8583dc69485a0f65ac1d069de7b417d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862915 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#706481}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48014ea23a48..79f2a7ff7c3b Created with: gclient setdep -r src-internal@79f2a7ff7c3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I00e877980c0f4e0a3eaa0a5e970fc96c1a55353e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706480}
-
Rodney Ding authored
- Consolidate baseFeature checks together and use enums to denote 3 common use patterns Design docs: https://docs.google.com/document/d/1d6_NBVPXh7B2XMk3H9b_qIxeuSXq6MblVSJldN7bTBY/edit?usp=sharing Bug: 832393 Change-Id: If3b4e4d80c61ab810014550c6aedf873768d1fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826862 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#706479}
-
Alexander Rezepkin authored
Before this patch, the maximum number of suggestions within Hunspell was 15, although Chrome uses only 5 suggestions. See: https://cs.chromium.org/chromium/src/components/spellcheck/common/spellcheck_common.h?l=22&rcl=a88c5fe6e641bdc9cb84b64ddb90ead67e0d0bcc So when a misspelled word has more than 5 suggestions, Hunspell does a useless job and searches for suggestions that will never be used. This patch reduces from 15 to 5 the maximum number of searched suggestions within Hunspell. Bug: NONE Change-Id: I68054cfc161ec509c99a620de2b0e5252576853c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863298 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706478}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9097eeb5359b..520ed2286b88 git log 9097eeb5359b..520ed2286b88 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 srisser@google.com Fix how we calculate potential overflows with PBOs Created with: gclient setdep -r src/third_party/swiftshader@520ed2286b88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:140881221 Change-Id: Ib7a9f1f683bdffb975ddc61d69baa81957e98f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865191Reviewed-by:
-
Sebastien Marchand authored
Change-Id: I17ccf902883095ba5e2f7356672e6c3d3b5dfd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864612 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#706476}
-
dpapad authored
registerMessageCallback is not encouraged, when a TestBrowserProxy already exists. Note that registerMessageCallback is fairly old infrastructure, and couples our tests to test_api.js which is unwanted. Bug: None Change-Id: I97c480fbb44547e3dbb6dad32d96d96174051559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863074Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#706475}
-
Paul Lewis authored
If a user right clicks on an element in the console and chooses to reveal it in the elements panel, and the element is not in the document, the operation fails but it is not communicated to the user. This patch adds a warning if the node appears to be detached from the document; it is done through checking the parentNode property, which is the most suitable means in lieu of having the isConnected property available in the Node object. Bug: 967156 Change-Id: I58228facb54e9afc87215d68176f473121121db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681891 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#706474}
-
Thomas Tangl authored
Bug: 995720 Change-Id: Ib8863788082efb13f38831813e86dff5289d810b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865247 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#706473}
-
Peter Boström authored
This reverts commit 5bb16cdd. Reason for revert: Relanding without CreateInkDropMask removal. Original change's description: > Revert "Add HighlightPathGenerator to TabCloseButton" > > This reverts commit b25e7445. > > Reason for revert: The ink drop path here was not the same as the highlight path; in particular, the ink drop path is manually mirrored, while the highlight path is auto-mirrored. Reverting since this results in the wrong appearance in RTL. > > Original change's description: > > Add HighlightPathGenerator to TabCloseButton > > > > Replaces OnBoundsChanged override which resulted in a lot of path > > generation (per-tab + frame) while opening new tabs or resizing the > > window. > > > > Also removes a ::GetInkDropMask() override which just generated the same > > path. > > > > Bug: chromium:1007546 > > Change-Id: I0131f9a589c1525e2c0eacd61c9fcd9f6ac05948 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861016 > > Auto-Submit: Peter Boström <pbos@chromium.org> > > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#705972} > > TBR=ellyjones@chromium.org,pbos@chromium.org > > Change-Id: Ic7bd1312d452c828877669db89af45ac59160455 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1007546 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864393 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706348} TBR=ellyjones@chromium.org,pkasting@chromium.org,pbos@chromium.org Change-Id: I219552ebc8ec2dfe0504f5d1234d01fdc7e1232d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1007546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864376 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706472}
-
Jinsong Fan authored
In code path of ShowNonLocatedContextMenu, if can show the context menu at the selection, here always use the first rect of the selection range to compute the position for hittest. So if there is a lot of selected text in the contenteditable box, the begin of the selection is likely to be invisible, and the value of the first rect will be negative and invalid. The CL uses one of corner point or center of the selection rect fully between the handles. Bug: 1002344 Change-Id: Iba5110cad4d8d7d2dd36ece2454c415d7dcdd419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792426Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#706471}
-
Juan Antonio Navarro Perez authored
This new class makes it easier to write tests for LegacyPageTest implementations, and is compatible with the add hoc measurements that they normally write. Depends on catapult CL: https://chromium-review.googlesource.com/c/catapult/+/1862517 Bug: 999484 Change-Id: I13c64fdf7cb7181ac34306a124868d408bc99742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863292Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#706470}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2f6e525099a0..64444bc865d2 git log 2f6e525099a0..64444bc865d2 --date=short --no-merges --format='%ad %ae %s' 2019-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fbf280c2..08af4873 (706299:706400) 2019-10-16 saza@webrtc.org Remove the noise_suppression() pointer to submodule interface 2019-10-16 perkj@webrtc.org Removed unused RTCP methods SendFeedbackPacket and SendNetworkStateEstimate 2019-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bdc89d87..fbf280c2 (706176:706299) Created with: gclient setdep -r src/third_party/webrtc@64444bc865d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: I461324d0657be3dbd9cd31c4534fa85323a173ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865108Reviewed-by:
-
Peter Boström authored
Apparently use_titlecase was only used for IDS_TOOLTIP_NEW_TAB and IDS_TOOLTIP_SAVE_CREDIT_CARD. This removes titlecasing for those two. It's very possible that there are titlecase tooltips that don't have TOOLTIP in their IDS_name but auditing TOOLTIP strings in grd/grdp files seemed like the only tractable thing. Bug: chromium:999574 Change-Id: Ica864612ab85a2708bd93d213d2782f5ae3eee1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860880 Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706468}
-
Evan Stade authored
OnProfileMarkedForPermanentDeletion should move from ProfileManagerObserver to ProfileObserver, which would also fix this bug. However, changing the order of members is the quickest and most cherry-pick-able way to avoid the crash. Bug: 1005244 Change-Id: If2db68c846dd418cd02864b57b9b543687fa1e03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863518 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
-
Mohamed Abdelhalim authored
To clear the in-memory cache, the test was relying on a cross-process navigation. This is not enough, because the old page can be kept in the back-forward cache. This patch disables the back-forward cache for the old page. Bug: 999849 Change-Id: I7f2587d0bc25a349c74c8a68599e74db4eb8e318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863296 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706466}
-
Lily Chen authored
This adds analogues of the Cookie.SameSiteAttributeValue and Cookie.SameSiteNoneIsSecure histograms in //net to the Android WebView CookieManager API, to collect SameSite metrics specifically from the AW CookieManager Java API. Bug: 986319 Change-Id: Ifd9822a2c560cb30844652cbd1ceccfafc0bf2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860529Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#706465}
-
François Beaufort authored
This CL declares a NFC intent filter so that Android can directly start WebAPK activity if in the scope of the WebAPK. Change-Id: Ia9c716bc37f4534d6cf6cd387e53a6152d9d0f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863190Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#706464}
-
Olga Gerchikov authored
This change removes opacity, transform and filters members of cc:AnimationEvent that are not used anymore. Bug: 1013715 Change-Id: Ide6889a26ae39ac86d904fd5e2135350af3f0b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863731Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706463}
-
Nektarios Paisios authored
Similar to what Safari exposes, we expose three new parameterized attributes on Mac, which will be used for dumping text markers, text marker ranges and their anchor nodes. A followup patch will wire these attributes through to dump tree tests as follows: The @MAC-ALLOW directive will be extended to take parameterized attributes and an argument for each one. For example, if we want to dump the current selection, we could write: @MAC-ALLOW:AXTextMarkerRangeDebugDescription(AXSelectedTextMarkerRange) R=dmazzoni@chromium.org Change-Id: Ife020ad4ebc5d7d0002126a53d7d150555d31d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857049 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706462}
-
Aaron Krajeski authored
This function was being overridden twice, but was never called anywhere. Bug: 1005911 Change-Id: Ia17aaf20ed47ccad80571438578d0b62911cc7f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856918Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#706461}
-
Sammie Quon authored
Overview now has a clipping animation which will clip out the frame, so we can dont have to change how paint works for overview. Caption buttons on the regular browser still need a repaint on overview state changed. Test: manual Bug: 1014520 Change-Id: Ie2b1d2a28e11f50e52c1ebe50f0ce6a8a2f85412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863756Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#706460}
-
behdad authored
TBR=sadrul@chromium.org Bug: chromium:1011969 Change-Id: Ida53ba86a2d673a834ff3afb501e66d49b42c7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863359 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
-
Li, Hao authored
Overrides Dawn's Vulkan validation layers path to reuse the one in ANGLE. TBR=dpranke@chromium.org BUG=dawn:150 Change-Id: Ibf4e513db2c2cb1a89613f1e3ab679f56bcf1c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864394Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#706458}
-
Nektarios Paisios authored
This patch adds tests that exercise the use of extra Mac nodes in AXTableInfo and OneshotAccessibilityTreeSearch. Extra Mac nodes are fake nodes that are added in the accessibility tree on Mac, representing the table header and columns. R=dmazzoni@chromium.org Bug: 1006842 Change-Id: Ia1d648be0cc52e949c5177d5d7df2bc2cb7d6d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854682 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic, only docs. This fixes several mistakes in the java_cpp_strings docs: * Do not need GENERATED_JAVA_PACKAGE * {NATIVE_STRINGS}, not {NATIVE_SWITCHES} * Do not need "This file is autogenerated..." boilerplate in the template * Consistent package name between template and generated file * Consistent class name between template and generated file * Change {YEAR} to $YEAR, as this must not be left templated, but should be filled in by the author This also adds some more opinionated changes: * Mark the class as "public final" not "public abstract" and mark the constructor private, as this is a more robust way to mark the class as non-instantiable * Include the boilerplate "This following string constants..." [sic] message in the generated file, as that's what the script inserts. * Use more realistic file names (foo_switches.cc and FooSwitches.java). * Add javadoc for the template file, as a suggestion for others to document the generated class. Bug: 1011991 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ia1aa96cf50842bf226f35440fd2cafe8a186f8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863866Reviewed-by:Ian Vollick <vollick@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706456}
-
delima02 authored
Bug: 139488757 Change-Id: If51b977f7b9b3bc50a83a6328cebfdb6e0138aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808715 Commit-Queue: Juan Pablo De Lima <jpdelima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Zachary Kuznia <zork@chromium.org> Auto-Submit: Juan Pablo De Lima <jpdelima@chromium.org> Cr-Commit-Position: refs/heads/master@{#706455}
-
Andreas Haas authored
It seems to me that the additional step of first creating a DataHandle was used to handle the case where allocation fails. However, this is also possible by creating an ArrayBufferContents directly. Bug: chromium:1008840 Change-Id: If2dde91b411157721dacc8257f9ab2a08bf48048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865159Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#706454}
-
Parastoo Geranmayeh authored
This reverts commit 83b71438. Reason for revert: SitePerProcessSSLBrowserTest.UnloadHandlersArePowerful* failing on Android. Please see bug. Bug: 1014956 Original change's description: > Adjust tests for upcoming cross-site cookie requirements > > They will need to be marked explicitly and secure, so adjust some tests to > be over SSL and mark those cookies appropriately > > Bug: 1006816 > Change-Id: I6da53ea64a7c03530335913fadb9099992e8ca33 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863389 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Maksim Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706108} TBR=avi@chromium.org,morlovich@chromium.org Change-Id: I982bc1590171f92883000c8315d3be77f7b35b9f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865249Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706453}
-
Mikel Astiz authored
The newly introduced mechanism around PendingLocalNigoriCommit allows implementing NigoriSyncBridgeImpl::SetEncryptionPassphrase(), responsible for setting up a custom passphrase, in a way that: a) Success is only reported when the sync server acks the commit. b) Conflict-resolution becomes simple. c) Logic is factored out from NigoriSyncBridgeImpl. There is a risk that the round trip to the sync server introduces noticeable UX latency when setting up a custom passphrase. However, manual tests suggests that it's actually not noticeable. Bug: 922900 Change-Id: I76f6644ed313d05aca8fe1d7cdf1d3205c7282cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856968 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#706452}
-
