- 23 May, 2019 40 commits
-
-
Friedrich Horschig authored
This class adds the Address controller that collects data for the manual fallback sheet on Android. It does work similar to https://crrev.com/c/1599927, and the existing PasswordAccessoryController. All three classes should be fairly similar in behavior. The interface leans on the draft implementation of the bridge which currently pulls data and might need changing to pushing data - I am open for suggestions. Bug: 962548 Change-Id: Id4c593a7af9eda815be16a85354bcfe241bc731f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614200 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#662658}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8224a58b4749..344ecaa6755d git log 8224a58b4749..344ecaa6755d --date=short --no-merges --format='%ad %ae %s' 2019-05-23 geofflang@chromium.org D3D: Return Incomplete when failing to load a program binary. Created with: gclient setdep -r src/third_party/angle@344ecaa6755d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:962439 TBR=ynovikov@google.com Change-Id: Ibef7986f7032cc5eb3c5c484dee3c294d7228eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662657}
-
Becky Zhou authored
Bug: 958554 Change-Id: I7d8d78ed5b971d7d37630c93e320641b913d8e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623537Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#662656}
-
arthursonzogni authored
This reverts commit ef860d19. Not everything is reverted, all the previously updated tests stays the same. Reason for revert: https://crbug.com/965410 Successive navigations to about:blank triggered from the same script execution used to be collapsed into one. By using the default code path without PerNavigationMojoInterface, all of them commit successfully. I am reverting this patch to preserve the old behavior and will be able to reland it later. Original message description: ============================= https://chromium-review.googlesource.com/c/chromium/src/+/1543258 Make renderer-initiated navigation to about:blank to use the default path. We used to believe renderer initiated navigation from a document to about:blank needed to happen sometimes "synchronously". This isn't the case, a PostTask is currently used. The only real requirement is when committing the initial empty document. This CL makes those navigation to use the default path instead. This requires a few tests to be updated: 1) The initiator and a few other properties needs to be properly set. There are DCHECK in BeginNavigationInternal to enforce renderer initiated navigation always have a defined initiator. 2) runtime-console-log-handle-navigate.js: In console-log-navigate, console.log can use the 'getter' of the object several times (up to 2) to print the object. It triggers several about:blank navigations. Since they are now going to the browser process, they are committed later compared to the script execution. The test became less reliable. The test was using dp.Runtime.onceExecutionContextCreated to wait for new documents to commit, but waiting was started potentially after the event occured. The new test is now creating the Promise before triggering the action that will later resolve it. The action is either creating the iframe or making use of the logXXX() function. This is now fully reliable. Bug: 936696, 965410 Change-Id: Ib4e514f9e1c8f70b8329f961b23f381302840e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626417Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#662655}
-
Eric Robinson authored
Right now looking up the base histograms without any suffixes (Activated/Unactivated) doesn't work properly on uma.googleplex. It indicates that the histograms are obsolete and a suffix should be used. John indicated he thought this was due to the extraneous "base" in a couple histograms. This change removes those. Change-Id: I3552ce44af355b549539f9e6da1dfbda56100e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626570Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662654}
-
Daniel Murphy authored
The IndexedDBOriginState map is iterated on context destruction, and each state is ForceClose()'ed. However, calling this: * Requires that a handle is held, so ForceClose doesn't operate on a destructed state, and * Can cause the OriginState to destruct itself. To avoid this, all of the RemoveOriginState callbacks are bound with a specific weak factory that can be invalidated in order to call ForceClose on all of the OriginState, which are then manually deleted. TBR: pwnall@chromium.org Bug: 966366,966267 Change-Id: I2ba2b9e6e10d34172ce38a934cafb0e9e341c05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627268Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#662653}
-
Etienne Bergeron authored
This CL is adding sanity check around system settings that can be altered by the users. The tests rely on these settings to be at the default value to work properly. Bug: 963868 Change-Id: I77021e86964500dea62263f57f6a25cf3c0055cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625266 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#662652}
-
Lukasz Anforowicz authored
This CL extends CORB to also cover CSV, PDF and other types handled by MimeHandlerView. This protection is only turned on when the kMimeHandlerViewInCrossProcessFrame feature is enabled, because otherwise the resource body may need to go through a cross-origin renderer process (see https://crbug.com/929300). Manually tested by launching $ out/rel/chrome --user-data-dir=$HOME/.corb-for-pdf \ --enable-features=MimeHandlerViewInCrossProcessFrame \ http://anforowicz.github.io/xsdb-demo/index.html and verifying that DevTools console shows CORB warning for <img src="https://www.w3.org/.../dummy.pdf"> Bug: 802836 Change-Id: Ia13a693d76f50aca52d6241af317d75c07e20b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606589Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#662651}
-
Henrique Nakashima authored
Now that the task may run in Reduced Mode, there is not necessarily a Profile anymore. Bug: 933358 Change-Id: I58d3d69e724ca058b676cc4ff0b2b7ef24c7792e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625392Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#662650}
-
Alexandre Frechette authored
Bug: 957657 Change-Id: I3e03e000c3c377fbf1417bf8a9a63e52d71af965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613789 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#662649}
-
Jordan Demeulenaere authored
This CL fixes the padding bottom of the onboarding that was broken in http://crrev/c/1624194. Change-Id: Id1a01a7495975b0abc7fe852c8221b5516128750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627359 Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#662648}
-
Mihai Sardarescu authored
This CL adds a temporary solution to present the advanced sign-in settings when the user taps on settings on the sign-in promo screen. This is a temporary solution as the plan is to move the ownership of the SigninPromoViewController to the SigninInteractionCoordinator (see crbug.com/965992). However it is preferred to only make this change after the unified consent feature is launched as it is fairly complex to do if we want to also support pre-unified consent flows. Bug: 963412 Change-Id: Iee3216254e2b42dbaed39503af58851980a7c9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625110 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#662647}
-
Clark DuVall authored
This was previously only being reported for Win/Mac, but would be very useful to have on Android as well. Bug: 965732 Change-Id: I351e00b20339469d5a3fd6bcafa0d2a3423c2f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625206Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#662646}
-
Vladimir Levin authored
This patch avoids layout of children for display locked elements. This is important for performance, and is one of the objectives of display locking. R=cbiesinger@chromium.org, chrishtr@chromium.org, ikilpatrick@chromium.org Bug: 963063 Change-Id: I7e36f5d916ae62bf8a5ca244dd0527022ee27a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603764Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662645}
-
sczs authored
The RepostFormCoordinator checks if baseViewController is already presenting another ViewController. If it is it won't present and retry later on. Because of this, if an InfobarBanner is being presented the RepostForm won't be presented, even if BVC is willing to dismiss the InfobarBanner. Since RepostForm has a retry mechanism we think its not safe to simply remove the presentedViewController check. There might be other reasons why that was added. In order to fix this, this CL dismisses any banner before trying to present the RepostForm. Bug: 911864 Change-Id: Ieaa6c574c619c1d1d3ada7ab49f953ea4656caba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623453 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662644}
-
Henrik Boström authored
This unblocks a third_party/webrtc roll which adds new metrics. Making this test pass again is blocked on https://chromium-review.googlesource.com/c/chromium/src/+/1621912 but that CL is blocked on the roll. To get out of this situation, the test is temporarily allowed to both pass and fail. TBR=guidou@chromium.org NOTRY=True Bug: webrtc:10453 Change-Id: I5d2986d642efa92bb93a9e008956655e03967fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627039Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Auto-Submit: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#662643}
-
Yao Xiao authored
blink LGTMs: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/tXKnmZD3P9o/x5YFru_YBQAJ Bug: 929911 Change-Id: I0d5ebe43b8c4bca13393035dd3b356ab602ea5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625781Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#662642}
-
Ehsan Karamad authored
Currently, a MimeHandlerView is created as long as there is a plugin for it. This behavior undermines issues such as <webview> permissions API. This CL will avoid creating MimeHandlerView if the plugin is not allowed. This change will also make the test WebViewPluginTest.TestLoadPluginInternalResource pass with the flag MimeHandlerViewInCrossProcessFrame. Note that when the plugin is not allowed, no (frame-based) MimeHandlerView will be created and the code will follow the ordinary CreatePlugin code path. Bug: 963694 Change-Id: I91b88956480139ffdb0df06077d099746b713751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622890Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#662641}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/436ba6c4a0..27c30ec671 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/436ba6c4a0..27c30ec671 Bug: None Change-Id: Iafc0aabd56d9f5506774a37427718f616bdff7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626859Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#662640}
-
Elly Fong-Jones authored
DesktopMediaPickerDialogViews (DMPDV) sizes itself based on the preferred size of its root view, which ultimately depends via TabbedPane on the preferred sizes of DesktopMediaListView (DLMV) or DesktopMediaTabList (DMTL). DMLV computes its preferred size based on the number of sources in its list. DMTL did not compute its preferred size at all, but used FillLayout, which meant its actual preferred size was the maximum preferred size of any of its children. As it happened, its only child is a ScrollView, which always has a preferred size of (0,0) when not bounded via ClipHeightTo(). That meant that if the DMPDV *only* contained a DMTL, its preferred size was not large enough to actually show any of the DMTL, leading to the linked bug. The fix uses a couple of empirical layout constants :) specifically, I chose minimum and maximum numbers of rows to show in the DMTL such that it looks okay with both 1 tab and 100 tabs. Testing this change is fiddly: 1) Make an official build, OR: a) Make an unofficial build b) Load //chrome/browser/resources/hangouts_service as an unpacked extension (using developer mode in chrome://extensions), ignoring the JS error you get 2) Go to https://meet.google.com and start a new meeting 3) In the bottom-right, Present > Chrome Tab This will create a DMPDV that only has a DMTL, no DMLVs. Bug: 965408 Change-Id: I1de28690c579dc2a09fd232d7a3927dee8a70c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626010 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#662639}
-
Kim Paulhamus authored
Subsequent requests while a request is on-going get canceled with a PENDING_REQUEST error on both desktop and Android, except that on Android the callback for the legitimate request was getting overriden by the subsequent request, leading to a crash. Bug: 958542 Change-Id: Ie6d5b096abddb66aa4933a5331c689357791c3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624606Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#662638}
-
Jordan Demeulenaere authored
This CL introduces the notion of validation for the CounterInput of the FormAction. This allows to express multiple different validation rules depending on the counters values. Change-Id: I2a6c0cb684be3f7c8e98340b8682cac6d0f7531a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621918 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#662637}
-
Peter K. Lee authored
This adds a new delegate method to ActivityServicePresentation protocol so ActivityServiceController can ask "presentation" delegate to show a Context Menu with a title and an array of menu items as options. For example, -showActivityServiceContextMenu:items: can be called like this: [delegate showActivityServiceContextMenu:@"Fruits?" items:@[ [[ContextMenuItem alloc] initWithTitle:@"Apples" action:^{}], [[ContextMenuItem alloc] initWithTitle:@"Oranges" action:^{}] ]]; Change-Id: I7aa28d2616b36be0b43a331e771b950ea3c92f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618046 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#662636}
-
Samuel Huang authored
This CL creates the Devtools DFM upstream, hidden behind a new flag |dfmify_devtools| (default = false). The currently empty DFM is created by following the instructions in docs/android_dynamic_feature_modules.md and also add an empty DevtoolsUi class. Details: * DevtoolsUi is needed so dexsplitter.py and apkbuilder.py can have a valid DEX param for the Devtools DVM. * DevtoolsUi uses @UsedByReflection so it won't be optimized away by ProGuard / R8. Bug: 927131 Change-Id: Iefbe39f5825f8c1579f8b9c1a94d7196b1f44734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613558 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#662635}
-
Stephen McGruer authored
This CL adds some documentation for PaintWorkletPaintDispatcher, and also changes up the |painter_map_| to allow direct lookup using the worklet id. Bug: None Change-Id: I4f60ddce561b9fbc415f12f7f0bfcdd7a2c173d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625462Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#662634}
-
vasilii authored
The element is already stored in the votes uploader. Bug: 936011 Change-Id: I655ea64547ced1deaad9c510494e0f444e9e7fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627371Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#662633}
-
Kevin Ellis authored
Bug: 958359 Change-Id: I7ab0dea91227a45fcbaf9f27ac668f1d1ce8bc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604490 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662632}
-
Marc Treib authored
That's what it means, so now the name matches reality. Bug: 953641 Change-Id: Ib376da99f3da59ec44fc9edca8f6ffc13c6691b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627372 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#662631}
-
rnasri authored
Pass the rects detected by the jank tracker into the heads up display layer. Use the method push_properties_to to hand the rects off to the heads up diplay layer impl. Finally, add the layout shift rects to the list of debug rects. Bug: 961846 Change-Id: Ifab3c19a7769bbe32645f6bfee98e22b32cab843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625020Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Rasha Nasri <rnasri@google.com> Cr-Commit-Position: refs/heads/master@{#662630}
-
Becky Zhou authored
Add a wrapper for AlertDialog.Builder to work around an issue with AppCompatDelegate not taking account of the night mode of the owner Activity when creating an AppCompatDialog. Bug: 966101 Change-Id: Ie175897f6e0058ce0ba060e47997408a620af715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626009Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#662629}
-
Clemens Arbesser authored
This CL refactors clicks in web_controller such that the caller can specify one of a number of click-types (click, tap, JS-click). Also, this CL adds three stress-tests which fail for tap, but succeed in JS-click. The intent is to let scripters override the type of click to perform in order to increase reliability. Bug: b/133129236 Change-Id: Ied8a1145186e1277c5b0cd70bb433b723a9a7395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621919 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662628}
-
Mikel Astiz authored
One DCHECK is simply wrong (the Nigori sync entity is a folder) and the bridge was lacking a call to ModelReadyToSync(). Bug: 922900 Change-Id: I529592e90aaae2ef12ca2fdde08984c0ddf835e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620627 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#662627}
-
Harald Alvestrand authored
This doesn't diagnose the bug referenced, but verifies that the error doesn't occur on these codepaths. Bug: 959128 Change-Id: I6f7543d7010b097d93a2614ecf8b94ada78762dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626410 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#662626}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from //third_party/blink/renderer/core/dom. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBg> Bug: 939691 Change-Id: I9ed956ee209084aab6dd88167d82093d85059745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624807Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#662625}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/550868a2b2b4..acd66b4946f1 git log 550868a2b2b4..acd66b4946f1 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 egdaniel@google.com Remove viewport from GrGLRenderTarget. Created with: gclient setdep -r src/third_party/skia@acd66b4946f1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Change-Id: Ida5f4e305f01529b35def614ce7b34c20f458fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625804Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662624}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a021ed986342..93571e89c9f4 git log a021ed986342..93571e89c9f4 --date=short --no-merges --format='%ad %ae %s' 2019-05-23 perezju@chromium.org Reland "Telemetry changes to remove fallback code for old Chrome versions" Created with: gclient setdep -r src/third_party/catapult@93571e89c9f4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:962883 TBR=eyaich@google.com Change-Id: I4e899d0facf03f5c6d7ac4355bc3da4c9f1728e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662623}
-
Albert Chaulk authored
We need to implement a couple WebContentsDelegate functions in order to enable fullscreen behaviours Bug: b/128926264 Test: desktop cast_shell build w/ embedded video page Change-Id: I7c5e95fb4f59b3369b35f770dcccff647bf7f899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585104Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#662622}
-
Peter K. Lee authored
This is simpler than -viewWillTransitionToSize:withTransitionCoordinator: because all the logic is in one place, ContentSuggestionsHeaderView. Bug: 965964 Change-Id: Id990d4b91e07282f7ff985f529c5ad27856f0199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626302Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#662621}
-
Olivier Yiptong authored
This change adds a writable stream output to the `FileSystemFileHandle`. This follows some [discussion](https://github.com/WICG/native-file-system/issues/19#issuecomment-490579093) on github. While this writable stream does not yet feature stream-like behavior, it carries over some of the interface from `NativeFileSystemWriter`, namely `truncate` and `write`. Bug: 955189 Change-Id: I8b8c9ff1ef36adfb30501251563699c6c7973889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623534Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#662620}
-
Mason Freed authored
This test, which currently fails, tests that rounded-corner clips do not create a Backdrop Root. Bug: 964417 Change-Id: I1849962b408ecc451cc2934668488046bc4f89ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626456 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#662619}
-