GitLab

BUG=642361

Review-Url: https://codereview.chromium.org/2291163002
Cr-Commit-Position: refs/heads/master@{#415608}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/8b4eaefc8859cf67683a5fa2e558b27e7c48dbfd Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/3a98a0a38287c090976ffd2f0cd47d12ba21b2d3 Add dart/packages recipe, and builders using it. (whesse@google.com)
depot_tools:
  https://crrev.com/6d3c290164360907fe08784093e36314069e689f It's time to bring subprocess42 to depot_tools. (tandrii@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=635641

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2294243002
Cr-Commit-Position: refs/heads/master@{#415607}

Move the implementation of GURL::DomainIs into a shared function in url_util/,
to be used both by GURL and url::Origin.

The reason for this refactoring is to reap significant performance gains in
scenarios where previously url::Origins had to be converted to GURLs for
DomainIs checks. This involved string copying, allocations, and parsing the
entire URL once again.

BUG=517560

Review-Url: https://codereview.chromium.org/2287483002
Cr-Commit-Position: refs/heads/master@{#415606}

BUG=603176

Review-Url: https://codereview.chromium.org/2292233002
Cr-Commit-Position: refs/heads/master@{#415605}

- Use symbols consistent with operator<< for PositionAnchorType.
- Add offset only if OffsetInAnchor
  The output of PositionTemplate::showTreeForThis() is changed:

  BODY
  *       #text ...
  offset, offset:9

  to

  BODY
  *       #text ...
  offsetInAnchor[9]

- printPosition() uses toAnchorTypeAndOffsetString().
  The output of printPosition for OffsetInAnchor is changed:

  #text "..."@9

  to

  #text "..."@offsetInAnchor[9]

This CL doesn't affect production.

Review-Url: https://codereview.chromium.org/2296863003
Cr-Commit-Position: refs/heads/master@{#415604}

BUG=527059
TBR=mef, droger

Review-Url: https://codereview.chromium.org/2291033003
Cr-Commit-Position: refs/heads/master@{#415603}

They are unused after https://codereview.chromium.org/2253853002/ and thus this
CL removes them from MemoryCache::TypeStatistic and WebCache::ResourceTypeStat.

This CL also fixes compile errors when MEMORY_CACHE_STATS is enabled.

BUG=603791

Review-Url: https://codereview.chromium.org/2254593003
Cr-Commit-Position: refs/heads/master@{#415602}

https://chromium.googlesource.com/chromium/src/+/0f93d7965

BUG=637811
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/2298713002 .

Cr-Commit-Position: refs/heads/master@{#415601}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2251263003
Cr-Commit-Position: refs/heads/master@{#415600}

BUG=640319
TBR=fgorski@chromium.org

Review-Url: https://codereview.chromium.org/2300563002
Cr-Commit-Position: refs/heads/master@{#415599}

Neither the corpus nor the dictionary are helpful for the fuzzer at the
moment.

R=mmoroz@chromium.org

Review-Url: https://codereview.chromium.org/2298153002
Cr-Commit-Position: refs/heads/master@{#415598}

When a suggestion is dismissed from the NewTabPage using the 'Remove'
context menu item, the content that it refers to cannot be looked up
from the corresponding ViewHolder, as onBindViewHolder may be called
while the context menu is still open (which would result in the wrong
suggestion being dismissed).
Instead, store the referenced suggestion in the listener for the
context menu items. This requires some additional refactorings.

When the 'Remove' item is clicked for a suggestion that has been
removed for other reasons (section became unavailable, suggestion was
invalidated) in the meantime, ignore the call. When it is clicked for
a suggestion that as moved out of the visible view, skip the
animation and just dismiss it from the underlying data model directly.

BUG=641313

Review-Url: https://codereview.chromium.org/2285833002
Cr-Commit-Position: refs/heads/master@{#415597}

TBR=dpapad@chromium.org
BUG=642574,625332

Review-Url: https://codereview.chromium.org/2298113002
Cr-Commit-Position: refs/heads/master@{#415596}

BUG=642482
TBR=stanisc@chromium.org,nick@chromium.org:

Review-Url: https://codereview.chromium.org/2301493002
Cr-Commit-Position: refs/heads/master@{#415595}

BUG=570121

Review-Url: https://codereview.chromium.org/2285663002
Cr-Commit-Position: refs/heads/master@{#415594}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257793002
Cr-Commit-Position: refs/heads/master@{#415593}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2253053003
Cr-Commit-Position: refs/heads/master@{#415592}

ErrorResponse can be null when an error happens locally.
Also, this logging is unnecessary as ObjectProxy::CallMethod is already
doing that.

BUG=642241

Review-Url: https://codereview.chromium.org/2291453006
Cr-Commit-Position: refs/heads/master@{#415591}

Disabling the Microsoft software synthesizer due to security reasons.
See http://crbug.com/499279 for details.

R=toyoshim@chromium.org

Review-Url: https://codereview.chromium.org/2298103002
Cr-Commit-Position: refs/heads/master@{#415590}

BUG=642050

Review-Url: https://codereview.chromium.org/2289193003
Cr-Commit-Position: refs/heads/master@{#415589}

Revert this CL and its successors. A new approach will be progressed under 637811.

BUG=637811,627305,623026,465096,468699

Review-Url: https://codereview.chromium.org/2296883002
Cr-Commit-Position: refs/heads/master@{#415588}

https://pdfium.googlesource.com/pdfium.git/+log/2fdacfb09551..7e7ef3dd60a8

$ git log 2fdacfb09..7e7ef3dd6 --date=short --no-merges --format='%ad %ae %s'
2016-08-30 thestig Update .gitignore to properly ignore base/

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2290243003
Cr-Commit-Position: refs/heads/master@{#415587}

This patch converts "editing/execCommand/find-after-replace.html" to use w3c
test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2300553002
Cr-Commit-Position: refs/heads/master@{#415586}

This patch converts "editing/deleting/paragraph-in-preserveNewline.html" to use
w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2297103002
Cr-Commit-Position: refs/heads/master@{#415585}

This patch converts "editing/deleting/delete-at-paragraph-boundaries-009.html"
to use w3c test harness to simplify test script and consolidates into
"delete_at_paragraph_boundaries.html", since there are similar test cases,
for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2297553002
Cr-Commit-Position: refs/heads/master@{#415584}

This patch converts "editing/deleting/skip-virama-001.html" to use w3c test
harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2299513002
Cr-Commit-Position: refs/heads/master@{#415583}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8b4e1a30..b1336315

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2296113002
Cr-Commit-Position: refs/heads/master@{#415582}

CSSImageValue::m_isCachePending is true iff CSSImageValue::m_cachedImage
is null. This CL removes this redundant member for code health.

BUG=n/a
TEST=n/a

Review-Url: https://codereview.chromium.org/2296083003
Cr-Commit-Position: refs/heads/master@{#415581}

Use LOG(INFO) instead.

Review-Url: https://codereview.chromium.org/2294853004
Cr-Commit-Position: refs/heads/master@{#415580}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/854d164..e5dcf5c

$ git log 854d164..e5dcf5c --date=short --no-merges --format=%ad %ae %s
2016-08-30 perkj@webrtc.org Do not build task_queue.cc and include from webrtc_overrides in Chrome. This is step 2 of the plan below.
2016-08-30 honghaiz@webrtc.org Add a switch to redetermine role when ICE restarts.
2016-08-30 hbos@webrtc.org Making hbos and hta OWNERS of webrtc/api/rtcstats*.
2016-08-30 kjellander@webrtc.org MB: Flip iOS bots to GN by default
2016-08-30 hbos@webrtc.org RTCStatsCollector and RTCPeerConnectionStats added.

Override webrtc task_queue.cc and task_queue.h.
This is step 3 of the plan below.

The modified plan
1. First land unmodified task_queue.h into webrtc_override in Chrome
2. Modify build files in the webrtc repo to include the task_queue.h and task_queue.cc from webrtc_overrides. This will breaks webrtc Chrome FYI.
3. Combine a roll of webrtc to Chrome and this cl  into one  cl.
The combined cl will roll in build files from  2 and  add task_queue.cc in webrtc_overrides and build task_queue_unittest.cc as part of content_unittests to test task_queue.cc in webrtc_overrides.
4... Start using task queues in webrtc........

TBR=tommi@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=webrtc:5687

Review-Url: https://codereview.chromium.org/2295723004
Cr-Commit-Position: refs/heads/master@{#415579}

https://chromium.googlesource.com/chromium/src/+/94405829a

BUG=262679
TBR=glebl@chromium.org

Review URL: https://codereview.chromium.org/2295073002 .

Cr-Commit-Position: refs/heads/master@{#415578}

This adds grid/flex layout support for <fieldset> by
introducing an anonymous inner block that is used to
layout fieldset's underlying blocks without interfering
with the special paint flow used to render <legend>
element.

This is the updated version of http://crrev.com/2150003005 that passes failed ClusterFuzz tests.

W3C/CSS WG discussion:
https://github.com/w3c/csswg-drafts/issues/321

Testing:
- All affected tests' results were verified to make sure
that there are no differences in pixel test results between
old and new version of LayoutFieldSet.
- 2 more tests were added
(fieldset-display-{flex|grid}.html)
- verified interoperability of fieldset(display: flex)
with Firefox(one of 2 browsers that support fieldset's flex
layout)

BUG=262679,375693
TEST=fast/forms/fieldset/fieldset-display-flex.html;
fast/forms/fieldset/fieldset-display-grid.html

Committed: https://crrev.com/c6d69f896f406c9a7801b29cb8c02a88e5b01770
Cr-Commit-Position: refs/heads/master@{#409303}

patch from issue 2150003005 at patchset 290001 (http://crrev.com/2150003005#ps290001)

Review-Url: https://codereview.chromium.org/2215133005
Cr-Commit-Position: refs/heads/master@{#415577}

https://pdfium.googlesource.com/pdfium.git/+log/c65e11ee1bef..2fdacfb09551

$ git log c65e11ee1..2fdacfb09 --date=short --no-merges --format='%ad %ae %s'
2016-08-30 thestig Fix ASAN build after rolling DEPS for build/

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2298653002
Cr-Commit-Position: refs/heads/master@{#415576}

Review-Url: https://codereview.chromium.org/2272703005
Cr-Commit-Position: refs/heads/master@{#415575}

Use a FakeSigningService in the DeviceCloudPolicyInitializer in order
to be able to unit test re-enrollment for locked devices when
registering with a certificate.

BUG=624187,641447
TEST=unit_tests

Review-Url: https://codereview.chromium.org/2287343004
Cr-Commit-Position: refs/heads/master@{#415574}

Cr-Commit-Position: refs/heads/master@{#415573}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2252293003
Cr-Commit-Position: refs/heads/master@{#415572}

https://pdfium.googlesource.com/pdfium.git/+log/77be04971c13..c65e11ee1bef

$ git log 77be04971..c65e11ee1 --date=short --no-merges --format='%ad %ae %s'
2016-08-30 thestig Roll DEPS for build to b73bafdd.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2297123002
Cr-Commit-Position: refs/heads/master@{#415571}

Remove this user button for supervised user is changed to back bold font style not by design. This CL restores the red button style for both removing non-owner user and supervised user.

BUG=641137
TEST=device test. Screenshots are in crbug.com/641137.

Review-Url: https://codereview.chromium.org/2293683002
Cr-Commit-Position: refs/heads/master@{#415570}

Now the feature is approved to roll out into Stable channel,
let me flip the feature flag to be enabled by default.

This is a required process to launch the feature through the field study,
and should be done before the feature is rolled out to 100%.

BUG=591245

Review-Url: https://codereview.chromium.org/2296603002
Cr-Commit-Position: refs/heads/master@{#415569}