- 02 Jun, 2020 40 commits
-
-
Brandon Wylie authored
Bug: 1083917 Change-Id: Iea521ba0dc2d525fe266cb0246ef6f0c72a759de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222821 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774226}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5ced794731b..aa9d99ff6b53 2020-06-02 egdaniel@google.com Add support for vk image sharing mode and handle queues xfers correctly. 2020-06-02 bsalomon@google.com Add threshold for partitioning blur draws 2020-06-02 scroggo@google.com Remove transform_scanline from SkWebpEncoder 2020-06-02 herb@google.com Make path data private 2020-06-02 cwallez@chromium.org Rolling 2 dependencies 2020-06-02 jvanverth@google.com Bind D3D constants. 2020-06-02 brianosman@google.com Rewrite SkVertices serialization to use SkReadBuffer/SkWriteBuffer 2020-06-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 48102b2b3655 to 77e5316a515d (11 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084458,chromium:1086532 Tbr: tdenniston@google.com Test: Test: Test: angle_perftest --gtest_filter=VulkanBarriersPerfBenchmark.Run/vulkan_buffer_copy Change-Id: I6b60f9c8e1fa0a6b6e137ac745644024baa110de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774225}
-
Ilia Samsonov authored
The purpose of this cl is to reduce the output snippet. This is most prevalent when tests fails on exit, and executed in large batches. Bug: 1086276 Change-Id: I73072f072e12597cdb5dfe53f6153ffaf9cf09d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226089Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#774224}
-
kylechar authored
This CL implements code needed for WrappedSkImage to handle shared memory GpuMemoryBuffers. This enables using WrappedSkImage in more places with both SkiaRenderer/Dawn and SkiaRenderer/Vulkan. There are issues with using WrappedSkImage for SkiaRenderer/GL so the logic there is still just for OOP-R. Bug: 1082819 Change-Id: I13a7526f8319f183bf215548aa70ce2cb9faa22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210789 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774223}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 181 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-11-29. TBR=chromium-metrics-reviews@google.com Change-Id: Ifc51ba2db775d597230fbc7208facb37b5c71cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226111Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774222}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/72f885bd4df9..4391bc111097 2020-06-02 mathias@chromium.org Recognize CSS variables as valid properties 2020-06-02 patrick.brosset@microsoft.com DevTools: E2E test covering going from perf to sources 2020-06-02 tvanderlippe@chromium.org Remove logic for downloading a content_shell from npm_test.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071296,chromium:1079076,chromium:1087379 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I718047984ad85e636ac14772e3becc551267558b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226875Reviewed-by:
-
Ricardo Quesada authored
The linux-explicit-sync Wayland interface allows to exchange two different kind of fences: release and acquire. The release fence comes from DrmDevice, but only when drm-atomic is available. Similar, when drm-atomic is present, the Acquire fence can be used in DrmAtomic. And technically, the Acquire-fence can be waited-on outside DrmDevice, but practice shows that when this happens and if drm-atomic is not present, some flickers migtht appear. So, this CL disables the Wayland linux-explicit-sync interface when drm-atomic is not present. This CL should only land *AFTER* these two CLs from ARC are uprevved: * ARC-P: http://ag/11624164 * ARC-R: http://ag/11661407 Tested on ARC Pi and ARC Rvc with the CLs mentioned above. Bug: chromium:1083569 Test: Manually disabled linux-explicit-sync on Chrome side. Change-Id: Iff78eebc5567f96cc9d775d9fce3f851104b04f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223090Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Auto-Submit: Ricardo Quesada <ricardoq@chromium.org> Cr-Commit-Position: refs/heads/master@{#774220}
-
Timothy Gu authored
r453744 and r474224 added six use counters to the getters and setters of <embed> and <object>, but none of them keep track of how many such property accesses actually returns a non-null value. This CL adds such a use counter, mending that gap. Bug: 695895 Change-Id: Idef2b4e3c22f7c97611bb67a9399e3555233efed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226910Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Auto-Submit: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774219}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8d3c80a2bf5115957815a5268248175dd926d401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226306Reviewed-by:
-
Xi Han authored
Bug: 1086608 Change-Id: Id46f9775c0de498d2b6b15754da281444e3ce06a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216277Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#774217}
-
Reilly Grant authored
Linux considers both actual terminals (like the system console) and serial ports to be TTYs. The previous implementation used a series of heuristics to guess whether a new device in the "tty" subsystem was a serial port or not. This information however is available precisely from the kernel. This change parses /proc/tty/drivers and checks if a TTY device matches the major and minor numbers for a known serial port driver. This allows a number of heuristics to be removed. Bug: 1046475 Change-Id: Icc6b8d8bb56270c9762b5ab91a59c63df1e30379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225491 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#774216}
-
Jongmok Kim authored
Change-Id: I5469cbb89167f1d1dfd5a83bb15f12e58ae1d454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226316Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#774215}
-
Matt Menard authored
This is a reland of 2aef8221 DCHECK use in EnterpriseActivityStorageTest caused linux-chromeos-rel to fail, but not in TryJobs. Original change's description: > Ensure activity is not overwritten when there are multiple users on the same day. > > Since activity is stored from midnight onward for all users (regardless of what time of day the usage interval actually occurred) and the IntervalMap removes overlapping intervals, it would nondeterministically remove usage intervals that occur on the same day with different users. This instead culls usage beyond 24 hours in a day. Since all time is stored UTC this is appropriate in all cases without losing usage due to time changes. > Add unit tests to EnterpriseActivityStorage and ActivityStorage. > Refactor to isolate functionality of each method of the storage classes for better reuse. > Change |user_email| to |activity_id| so the class can be used by classes that need to key preferences but not by an email. > > Bug: 1058453 > Change-Id: I8e5bd7b552d00bddd478c3a275313ccc7ed214a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153748 > Commit-Queue: Matt Menard <mattme@google.com> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773574} Bug: 1058453 Change-Id: I0df21c560e0693b998739b58b5d210125d188967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225817Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#774214}
-
Katie D authored
AX-Relnotes: Adds feature flag for cursor color to chrome://flags. Bug: 1085442 Change-Id: Ie06092e3edb92c93d6b0791349c705aa049f7f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220386 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774213}
-
Songtao Xia authored
This CL fixes an issue where hinge is shifted when a user changes screen setting. For example in Windows, when a user increases "the size of text, apps and other items" in display setting. The hinge is displaced. Cause: Tools::Draw function takes a windows to view port scale. Hinge copied the logic from HighlightQuad. It draws a quad, whose calculation applies the scale. It really shouldn't as the hinge's geometric parameters by px is measured not in the device world. Like the the width and height of the device, they are measured in the windows/chrome client world. Fix: create the quad using a scale of 1. Before image (annotated with the window-viewport scale and emulation scale factor): https://imgur.com/XCLBdRL Hinge is shifted by window-viewport scale:1.5. After image: 1) Same situation as above: https://imgur.com/XUBdYvb 2) manually chosen emulation scale with scrolling and zooming: https: //imgur.com/e2dTaIX Change-Id: Id1237748d2f41ef5aecd8374c4457e3205d6a91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202121Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Commit-Queue: Songtao Xia <soxia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774212}
-
Samuel Tang authored
Manifest parser can now parse protocol_handlers This feature allows the blink parser to parse protocol_handlers defined in its app manifest. It is checked in behind the flag ParseUrlProtocolHandler. The current CL does not include semantic validation of the scheme. We will include it in a subsequent CL to keep CLs small and scoped. This feature is part of a Chrome experiment, see the feature page: https://chromestatus.com/features/5151703944921088 The URLProtocolHandler explainer can be found here: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/URLProtocolHandler/explainer.md The main bug link is: https://bugs.chromium.org/p/chromium/issues/detail?id=1019239 The blinkdev proposal is here: https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/x4Ev_l9Oj2U Bug: 1019239 Change-Id: I85a99064485f12e7c224bdaf491ad413e451229c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211200Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Samuel Tang <samtan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774211}
-
Domenic Denicola authored
Bug: 1067389, 1042415 Change-Id: I5edc60736200bf8335ff1ff9422d53d8fea52569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199909Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#774210}
-
Fabian Sommer authored
For component policies that fail to validate against their schema, an error message is now displayed in about:policy. Components will still not see the invalid policy values. Fixed: 974676 Change-Id: I2a8fa750df69721617a2043344364700acbccb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054944 Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#774209}
-
Ionel Popescu authored
Having an outline for the selected option is causing issues since there is no way for a developer to remove the outline for <option>'s in a popup. This CL removes the outline since background color is good enough to indicate the current selection. Bug: 1087250 Change-Id: Id50d4ae891884ea10b4628b41c368dd97c8f0f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225480Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774208}
-
Nate Chapin authored
* Guarantee that DocumentInit::content_security_policy_ is non-null and is the final CSP for the Document * Now that CSP is finalized in DocumentInit, sandbox_flags_ can be, too. Move a MHTML sandbox flags special case to DocumentLoader to make that cleaner. * Add a DocumentInit::ForTest() method, which serves two purposes: 1. Initialize content_security_policy_ for the unit test case 2. DocumentInit can now require that every user will call exactly one of ForTest, WithDocumentLoader, or WithExecutionContext and assert that invariant. Change-Id: Iafd9d15882a48ce55b2a73841fbf6eafb2f72d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222639 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#774207}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 3 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-11-29. TBR=chromium-metrics-reviews@google.com Change-Id: Ib1fdb6f8d36cc0f2a07f67977360b0acf9f6b6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226775Reviewed-by:
-
Alex Ilin authored
This CL adds a new set of tests for the reauth dialog. These tests check interactions with a Gaia Reauth endpoint that is imitated through an EmbeddedTestServer. The main "embedded/xreauth/chrome" endpoint operates in two modes: - In the default mode, the endpoint redirects to the "challenge" URL whose response can be controlled within the test by a ControllableHttpResponse. - If the "?done" query is present, the endpoint returns the HTTP_NO_CONTENT response that signifies a successful reauth. The CL also extracts common test code into test suite functions to reduce the code duplication and make the tests code more readable. Bug: 1045515 Change-Id: I89d4aac57ef25168def1341fb63b1a7498dcfa0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225396 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#774205}
-
Joshua Peraza authored
Bug: 1082190 Change-Id: If7e19d39beb4def965c0cfebe87aabaefdc8faaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225274Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#774204}
-
Jordan Bayles authored
This patch effectively reenables the SessionDuration histogram for media remoting, by updating the expiration date to 1 year from now. I also added myself as an owner. Bug: 1053021, b/157478542 Change-Id: I2904ca1703b4414a1170c59f5fb522481486b507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223144Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#774203}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/11dd7183c4d2..2fbd57b6362a 2020-06-02 capn@google.com Regres: Test changes from external contributors if reviewed by Googler If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I2a90affd3cf2d9ef0d504dbaca413e88ce8f5fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226869Reviewed-by:
-
Toby Huang authored
The browser test UserCloudPolicyManagerChildTest.PolicyForChildUser is flaky due to invalid OAuth tokens from FakeGaiaMixin. This CL fixes the root cause and re-enables the test. Bug: 1052604 Change-Id: Idaaed998e050e4b090513fabb7f8244330d55d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226337Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774201}
-
Henrique Nakashima authored
This moves it together with the rest of the glue code. Bug: 1072748 Change-Id: I89b310995af73243a59402a2e55ee9c82c7b8231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225358Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Sammie Quon authored
These are used for perf tests, and there are no plans to remove those anytime soon. Test: none Change-Id: Iaf826786e4a0dbdef766581002bc2f97fe62b863 Fixed: 1088584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225577Reviewed-by:
-
sczs authored
Creates a Discover provider for the Feed. Bug: 1085419 Change-Id: Ie057304dffefa3b3dba6b53cd9092da9ed559305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212441 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#774198}
-
Etienne Pierre-doray authored
Still useful for ongoing experiment: crbug.com/1026785 Bug: 1089879 Change-Id: I6e3dbb99b038fd0ddf90d8d82beaf78529eec603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224647Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#774197}
-
Mohamed Amir Yosef authored
Instead of using a hardcode value for the icon size, this CL incorporates the line height of the small body text. Default in Harmony specs is 20. So this CL doesn't introduce any UI change in the default settings. Bug: 1044038 Change-Id: If2bd0f50ab93c85c07b77271f7614510426f0101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219902Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#774196}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 216407de. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I660ebcfaade8bdd4891e15d92a1b35ea44725b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774195}
-
Vincent Boisselle authored
There are corner cases where the stream object could be used when null which causes a null dereferencing exception crash. Bug: 1088440 Change-Id: I9281fa6d2cbf3216eebe1ea5c5ccbad8607463ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225838Reviewed-by:
Vincent Boisselle <vincb@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#774194}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/d7beb6099c3a..6dfe58d86e80 $ git log d7beb6099..6dfe58d86 --date=short --no-merges --format='%ad %ae %s' 2020-06-01 fayang Deprecate gfe2_reloadable_flag_quic_deprecate_draining_streams. 2020-05-29 dschinazi Fully support draft-28 transport parameters 2020-05-29 fayang Fix quicsession::willingandabletowrite to check connection level flow control for send control stream and qpack streams. protected by gfe2_reloadable_flag_quic_fix_willing_and_able_to_write. 2020-05-29 fayang Internal QUICHE change 2020-05-29 dschinazi Introduce ParsedQuicVersion static constructors 2020-05-29 wub Fix the bug where loss parameters are chosen but not applied in loss algorithms. protected by existing --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src update flags Change-Id: I087108b0feac89fbaabdca3949b66911f066c4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225266 Commit-Queue: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#774193}
-
Bartek Nowierski authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: "For pointers (address values), use nullptr, as this provides type-safety." Furthermore, NULL/0 won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for more details. !! is used in situations where the pointer is assigned to or returned as bool, otherwise CheckedPtr's more costly implicit T* cast operator would kick in. !! isn't needed in boolean expressions. Examples here: https://chromium-review.googlesource.com/c/chromium/src/+/2226003 Bug: 1080832 Change-Id: I8ebc83be2e96bf1598dd25ef5ca07c98134ccffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226318 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
Autocomplete system provides the correct transition type to use when the user navigates to a match. This is ui::PAGE_TRANSITION_TYPED for URL matches and ui::PAGE_TRANSITION_GENERATED for other types which do not look like a URL. This allows for URL navigations from the NTP realbox to be correctly recorded in the history backend and for the most visited tiles to be updated accordingly. Bug: 1090004 Change-Id: I1af862bfe8b926ccc729dc340fe8384e5759101b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224020Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#774191}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8abb5a5b05e8..70b11675ddaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fdoray@google.com,tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fdoray@google.com,tnagel@google.com Change-Id: Ib643a84a69c87d522a84baf20431f4d22fa7ca1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226614Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774190}
-
Nina Satragno authored
When sending getPinUvAuthTokenUsingUvWithPermissions, the permissions list is required [1]. Since we are only using UVToken for make credential and get assertion, and sometimes making a credential involves getting assertions, request those two permissions with every UVToken request. [1] https://drafts.fidoalliance.org/fido-2/stable-links-to-latest/fido-client-to-authenticator-protocol.html#permissions-list Fixed: 1086558 Change-Id: I572850efafb02ab9d292465379d385751adac101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220258 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#774189}
-
Paul Jensen authored
Bug: 1089566, 1088509 Change-Id: I8574ae101c5d59f4a083e74ebfce4e92db2a71df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225842 Auto-Submit: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#774188}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1e6a2f8f4a6ae67035c21da5a3a7aa351f2b3f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226633Reviewed-by:
-
