- 09 Dec, 2020 40 commits
-
-
Ken Rockot authored
Content hasn't actually used Service Manager-based services in ages, and these names are only relevant to those things. They're still used by //chromecast, but in extremely limited capacity. This moves a few constant definitions into //chromecast C++ code and wipes out service_names.mojom. Most of the CL is deletion of stale includes of the generated header. Bug: 977637 Change-Id: Ica638ae5bd2b1238a998ce76faa943ce85775b5d Tbr: boliu@chromium.org Tbr: blundell@chromium.org Tbr: caseq@chromium.org Tbr: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568681 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#835309}
-
danakj authored
The mojom was changed to BitmapN32 in a9162d6d, so the browser will only receive the correct bitmap format now. No need to rely on checks in the receiver code. R=avi@chromium.org Bug: 1144462 Change-Id: I72fd8cac96b3154a894d77ef80b8a19588231878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580322 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835308}
-
rbpotter authored
Bug: 1065895 Change-Id: I87c383d9b8091b41aa2aeda237d49e9a6db3caa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581029Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#835307}
-
Shannon Chen authored
Point scanning performs a vertical range scan before a vertical line scan. The vetical line should scan within the range. Currently, the point scan performs the following step: 1. Horizontal Range Scan 2. Horizontal Line Scan 3. Vertical Range Scan 4. Vertical Line Scan Signed-off-by:
Shannon Chen <shannc@chromium.org> Bug: 1061537 Change-Id: If29f7bbf7f1e3c29c8872523bf48214dcc9f6bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580139Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Shannon Chen <shannc@google.com> Cr-Commit-Position: refs/heads/master@{#835306}
-
Robert Sesek authored
CoreFoundation was only needed for a __builtin_available check to support Mac OS X 10.10, support for which has now been removed. Bug: 1153883 Change-Id: I02fff5146387c56db4b1d3f061fc2e37f82b9100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579952 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835305}
-
Mario Sanchez Prada authored
This migrates these legacy IPC messages to the media.mojom.MediaPlayer mojo interface, now implemented by HTMLMediaElement inside of Blink, and updates its callers in the browser process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: Ia4c873402179fb3eb918a3bc077b19842026ce21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543025 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
edchin authored
Removes kPointerSupport flag which was launched M84. Bug: 1076995 Change-Id: I8f5eb06d4942ded876723aeb30abfa521f978d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580136 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#835303}
-
Thiemo Nagel authored
This reverts commit fe104bae. Reason for revert: I believe I've wrongly reverted this CL. My apologies. (In the meantime, I've bisected the failing test to be https://chromium-review.googlesource.com/c/chromium/src/+/2580046) Original change's description: > Revert "[Tab Groups] Only create a tab group if it is the second link." > > This reverts commit 022f0128. > > Reason for revert: It looks like this is breaking TabStripTabListTest.All in https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 > > First occurrence: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93505 > > Original change's description: > > [Tab Groups] Only create a tab group if it is the second link. > > > > This is merely a heuristic for whether or not to create a tab group > > based on the opener of the tab next to the current one. > > > > Bug: 1128703 > > Change-Id: Iae0ae8db78be0bbe9be2fdacd143c70e1a0d49bc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567818 > > Commit-Queue: Charlene Yan <cyan@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: Connie Wan <connily@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#834915} > > TBR=ellyjones@chromium.org,cyan@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,connily@chromium.org > > Change-Id: Ib7fae0f0d2bfce4eddd9966923b50b3690e0fe24 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1128703 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580530 > Reviewed-by: Thiemo Nagel <tnagel@chromium.org> > Commit-Queue: Thiemo Nagel <tnagel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835150} TBR=ellyjones@chromium.org,tnagel@chromium.org,cyan@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,connily@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1128703 Change-Id: I7d3346cdf4fa0deba24d56134a542f13b5fc985e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582020Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835302}
-
Jan Wilken Dörrie authored
This change replaces Blacklist with Blocklist in FormFetcher and renames related APIs. TBR=vasilii Bug: 1147799 Change-Id: I4f90ac165ed3c877e45433f4408b06a88d5e9f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580886 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#835301}
-
Clemens Arbesser authored
Bug: b/175132318 Change-Id: I1b4116420dcd441b6ef089ed7f3c56a8f97048d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582338Reviewed-by:
Lukasz Suder <lsuder@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#835300}
-
Eric Seckler authored
Connection failures such as SMB mapping failures and exhaustion of concurrently registered producer limits were causing ReportBadMessage() even though they are more likely caused by tracing service internal errors. Instead, drop the producer connection and report a UMA stat in these cases. Bug: 1154344 Change-Id: Ia1163a55a65f627f8114596ac892b9d0f1d58a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582058 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#835299}
-
Yutaka Hirano authored
Bug: 1156550 Change-Id: I683f7e82c19db65aaaab49746ab5d7880ef96321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581658 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#835298}
-
Alice Wang authored
This CL moves SigninScrollView to signin.ui target. Bug: 1157052 Change-Id: I944621ee3242273ed6fb8b6aac028fee2b4d606d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581838Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#835297}
-
yilkal authored
This cl provides a PostMessageAPI interface that can be used to fetch the EDU account that is being added to the family link user's profile. The email is needed as part of the consent logging that is required in the online flow. Bug: 1156497 Change-Id: I8e1bc0bb067f57e4d298ff160cb11954fdc9a346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579717Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#835296}
-
Wenyu Fu authored
Store decision if ToS is skipped by policy in shared preference, and add a singleton helper class to check and refresh the policy value if necessary. Change-Id: Ia62622b76207c5ebe7ab226ef3d6f8b18602f488 Bug: 1108582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570077Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835295}
-
Yulun Wu authored
We will be using primary colors for inactive search box placeholder text and secondary colors for active search box placeholder text. Bug: 1156231 Change-Id: I1285bb3f6630e103bfd1cf192e9065d248614b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581023Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835294}
-
Reilly Grant authored
This change fixes error handling for the getSignals() method. It was assumed that the Mojo reply value could be null on error but this was not allowed by serial.mojom. This meant that if a call to GetControlSignals() failed it would trigger a Mojo connection failure rather than only reporting the (potentially recoverable) error. Tests exercising this case on both the renderer and browser process sides have been added. Bug: 1156864 Change-Id: Ife5c953d5f6748c0290fae2f2d53c5415c1faba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580747 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#835293}
-
edchin authored
Bug: 1133889 Change-Id: I671beba1defc45dfeebddc59ea5975202dcfa6d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581337Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835292}
-
Sylvain Defresne authored
The gn variable ios_use_goma_rbe is ignored since the CL https://crrev.com/c/2555117 landed, so stop overriding it on the bots (it is now always enabled which is what the bots want). Bug: none Change-Id: I76e2c9180da9396fd206efb8592990f231841115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558437 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#835291}
-
ckitagawa authored
This addresses two shortcomings of PlayerCompositorDelegate for the Long Screenshots use case: 1. An in-memory PaintPreviewProto is provided from Java rather than one from disk. 2. Compositing should occur to a single SkPicture using the MainFrame mode of the compositor rather than the SeparateFrame mode. This CL also makes the MainFrame mode return the dimensions of the SkPicture so that Long Screenshot can leverage this information. Change-Id: If0b2d666f7459b94f4501c23808c504826a0112a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578076Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#835290}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/83448c4da727..627f4a6b8dc3 2020-12-09 lalitm@google.com tp: minor refactoring of track event code for readability If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I347eac7fdaacc0a70dc000f4261f86c042caaff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582180Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835289}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8670c9887529..15b4892925ba 2020-12-09 johnstiles@google.com Simplify constant single-value SkSL constructors. 2020-12-09 johnstiles@google.com Parenthesize intrinsic comparisons properly in Metal. 2020-12-09 bsalomon@google.com Rewrite restore_scissor_on_fbo_change 2020-12-09 johnstiles@google.com Fix SPIR-V compilation of binary expressions of boolN type. 2020-12-09 borenet@google.com [infra] Roll infra DEPS, update CIPD packages 2020-12-09 johnstiles@google.com Add newline to end of Metal's Globals struct definition. 2020-12-09 brianosman@google.com Remove fInputColor usage in unit-test FPs 2020-12-09 brianosman@google.com Remove modulation by input color in convolution FPs 2020-12-09 johnstiles@google.com Add $genHType version of inversesqrt. 2020-12-09 brianosman@google.com Increase Metal timeout to 1 second If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1152831 Tbr: jmbetancourt@google.com Change-Id: I1713a7837e204474e058e087cfbd14d2b86e5238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582141Reviewed-by:
-
Jan Wilken Dörrie authored
This is a mechanical change replacing #includes of base/stl_util.h with base/containers/contains.h for usages of base::Contains. TBR=dcheng Bug: 970209 Change-Id: I50db76f2fd192708ab718f8ce72a765f9c38aed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579969 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#835287}
-
Jan Wilken Dörrie authored
This is a mechanical change replacing #includes of base/stl_util.h with base/containers/contains.h for usages of base::Contains. TBR=dcheng Bug: 970209 Change-Id: Iba94204e7cfd1266a3577fdc0854f1c0891c75b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580880 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Stephan Hartmann authored
Following code in flat_tree.h triggers an ICE in GCC 9 and onwards: container_type body_; NO_UNIQUE_ADDRESS key_compare comp_; testcase.ii:58:77: internal compiler error: in output_constructor_regular_field, at varasm.c:5249 58 | void Get() { static auto kSchemas = MakeFixedFlatMap<int, int>({{"", ""}}); } Swapping the declaration does not change behavior, but it doesn't trigger the ICE anymore. Bug: 1156268 Change-Id: I865812bf24daf14bf53473726c40b4566e002cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574860 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835285}
-
cfredric authored
There's currently no plan for any *other* kind of First-Party set, so calling this "preloaded" is unnecessary. Change-Id: I7e08751a5717f87ecd5c2425451940091e861ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580361 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#835284}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/67f7197d74bc..53c2ae23b73c 2020-12-09 tvanderlippe@chromium.org Add tests for javascript_metadata 2020-12-09 bmeurer@chromium.org Hide "Add breakpoint" menu item for non-breakable lines. 2020-12-09 tvanderlippe@chromium.org Add tests for HTMLFormatter 2020-12-09 pfaffe@chromium.org [Wasm debug] Add a new plugin method to retrieve breakable lines If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1009443,chromium:1024752,chromium:1136484,chromium:1142275,chromium:1156075 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I88cdffda2e503887aa0501a065db96c5ff48e0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582181Reviewed-by:
-
David Bokan authored
In wheel handling, we assume that if a wheel event is set to non-blocking it must not be the first in the sequence so the previous event disposition should be available in mouse_wheel_result_. In https://crbug.com/1069760 that was found not to be the case. The fix there was to revert to the previous behavior which checked for whether that was true (the underlying cause wasn't found) but a DCHECK was left in. This trips up builds that have DCHECKs enabled as in https://crbug.com/1156940. Bug: 1156940,1069760 Change-Id: Ia65b5a0c28c4214492ec0cd9072ff8e5467bfdd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580054Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835282}
-
Mario Sanchez Prada authored
This CL adds the minimal plumbing required to allow browser -> renderer mojo messages replacing MediaPlayerDelegateMsg_* legacy IPC messages from //c/common/media/media_player_delegate_messages.h, and migrate MediaPlayerDelegateMsg_{SeekForward, SeekBackward} as a first step. This CL also makes MediaWebContentsObserver, MediaSessionController and MediaSessionControllerManager classes take a WebContentsImpl in their constructor, since we will need to access WebContentsImpl's methods from MediaSessionController to do this migration and the instance passed on creation is a WebContentsImpl anyway (see the constructor of WebContentsImpl, where the MediaWebContentsObserver object gets created from). This will be also be useful for future migrations of remaining MediaPlayerDelegate[Host]Msg_* messages. Additional plumbing to migrate MediaPlayerDelegateHostMsg_* messages will be still required, and will be added in follow-up CLs, as well as migrations for more MediaPlayerDelegateMsg_* messages, following an iterative process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: Ia3287731acd1aea9f63061d01b01cfa23d5ce49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520838Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Bug: 1153249 Change-Id: Ia6ef721da2839d67a99ad67c41fe7c2a11a555c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581302 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#835280}
-
Peng Huang authored
Bug: 1157074 Change-Id: I6fad512dcb8a262d67fc5160c2af89b0a8dfeefe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581938 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835279}
-
Wei Li authored
Use a variable instead of a static function to represent the default focus behavior in platform style files. Bug: 1001103 Change-Id: Icf92ea6b83037ba3b285ba0c5eccb7bc16f1f460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579653Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#835278}
-
Xiaocheng Hu authored
Bug: 1155018 Change-Id: Ia2c76552745a9b1499f7339f00aacb6c34203e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578376Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835277}
-
Jesse McKenna authored
This change makes the following cleanup changes: * replace NULL with nullptr * remove namespace specifier for web_app::internals when inside that namespace * replace for loops with range-based for loops * add braces around a multi-line conditional statement Change-Id: I93876e058cf95882b0faa1e4dc8dece891975a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576501Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#835276}
-
Sigurdur Asgeirsson authored
It seems there's a possibility for a single frame client to be an un-committed controlee of two service worker version_ids at the same time. Presumably this happens rarely during e.g. version updates or some such. Bug: 1143281 Change-Id: I9250b24945e7eed0251a7dee2eef3f473c74c917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581939Reviewed-by:
Patrick Monette <pmonette@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835275}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0e323e7bff96..8732c0efd3ab 2020-12-09 cwallez@chromium.org roll_dep.py: Fix outstanding references to subprocess If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156908 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I4f9d5c4a1f060b3aa1e00154c7a9d05e655b5109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582182Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b5c844554e30..83448c4da727 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie862f61fd8379a0f54ce18ecfc6f2c5ad41d47e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582259Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c1463884785..f87c8f0d0c37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC anthonyvd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1107904,chromium:1157050 Tbr: anthonyvd@google.com Change-Id: If47fb880ff4be02935f668e860a5c186bb546e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582138Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835272}
-
vidorteg authored
Localization V2 migration on mobile_throttling had some changes on the legacy functions it exposes, changing the webtests to match the API Also, disabling the test so I can check in the front_end changes and then I'll follow up with a reenable. Associated frontend changes: 2572862: [Loc] Migrate mobile throttling setting panel to Localization V2 https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2572862 Bug: 1136655 Change-Id: I62165c3ae95075c68bd835b1a7e41b9f7f224781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580134 Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#835271}
-
Mitsuru Oshima authored
BUG=chromium:1088371 Change-Id: Id22b8b928fe21b72b61ee4ad1b6d44d6bde72f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578480 Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#835270}
-
