GitLab

Syntax error corrected in network traffic annotations of:
chrome/browser/extensions/install_signer.cc
extensions/browser/updater/extension_downloader.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2900953002
Cr-Commit-Position: refs/heads/master@{#473964}

When a secondary UI dialog is opened, the omnibox icon it's anchored to
need to set its state as active. When the dialog is dismissed, the icon is
set to inactive.

BubbleAnchorHelper provides functions to retrieve the omnibox icons
and sets the active state.

BUG=715863

Review-Url: https://codereview.chromium.org/2882533003
Cr-Commit-Position: refs/heads/master@{#473963}

SupportsWeakPtr's weak pointers are invalidated only after derived class
members are destroyed which may lead to use-after-destroy issues.

This CL removes SupportsWeakPtr from GLES2Decoder and adds a WeakPtrFactory
instance to each of its subclasses.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2898953002
Cr-Commit-Position: refs/heads/master@{#473962}

The rectangle highlight was mostly faded out, with an occasional pulse
to fade in.  The spec calls for the opposite.  Switching the animation.

BUG=724996

Review-Url: https://codereview.chromium.org/2902573002
Cr-Commit-Position: refs/heads/master@{#473961}

The automation API specifies the hit test coordinates should be
integers which is fine since there's no reason for sub-pixel
precision.

However, it crashes if you pass it a non-integer, which is not good!
It should just convert to an integer.

BUG=725159
TBR=aboxhall

Review-Url: https://codereview.chromium.org/2900803003
Cr-Commit-Position: refs/heads/master@{#473960}

Requiring quoted URLs was cargo-culted from the HPKP implementation. The HPKP
spec does not actually say that report-uris must be quoted -- it's simply that
all the examples quote them. So it's possibly a bug that Chrome's HPKP implementation
requires quoted report-uris. The Expect-CT spec doesn't say anything about quoting
report-uris nor do I see a reason that it should, so Chrome's implementation shouldn't
require them.

BUG=679012

Review-Url: https://codereview.chromium.org/2895373002
Cr-Commit-Position: refs/heads/master@{#473959}

Review-Url: https://codereview.chromium.org/2894203002
Cr-Commit-Position: refs/heads/master@{#473958}

* Adds an OS upgrade check to the BackgroundTaskScheduler
* Adds OS version tracking to BackgroundTaskSchedulerPrefs
* Ensures GCMNetworkManager based upgrades only happen on supported OSs
* Calls OS version check from DeferredStartupHandler

BUG=710630
R=nyquist@chromium.org

Review-Url: https://codereview.chromium.org/2819703002
Cr-Commit-Position: refs/heads/master@{#473957}

https://pdfium.googlesource.com/pdfium.git/+log/1b02d0180403..c4ecd7b2e10e

$ git log 1b02d0180..c4ecd7b2e --date=short --no-merges --format='%ad %ae %s'
2017-05-23 dsinclair Cleanup default values and methods in CXFA_Widgetdata

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ia13f388997d6d9d2926a3bac899831f2447fa092
Reviewed-on: https://chromium-review.googlesource.com/512224
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473956}

This CL applies layout-test-tidy to the entire WebAudio layout test
files. Some of expected files needed to be updated because of the
change of the console logging line number.

BUG=725234
TEST=(after the application all tests still passes.)

Review-Url: https://codereview.chromium.org/2895963003
Cr-Commit-Position: refs/heads/master@{#473955}

Cr-Commit-Position: refs/heads/master@{#473954}

- Background:
Updates over cellular is blocked by Chrome UI by default, but we now
allow so if user is actively checking for updates (e.g clicking 'check
for updates' button). But auto-updates over cellular is still not
supported.

- Changes in this CL:
Add a |interactive| parameter to IsUpdateOverCellularAllowed(), which
indicates whether user is actively checking for updates.

Show proper warning message when user is over cellular connection.

- Design doc: go/cros-cellular-updates

BUG=chromium:691108
TEST=go/about_chrome_os_err_msg for screenshots of different messages
shown in different situations.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2897773002
Cr-Commit-Position: refs/heads/master@{#473953}

This fixes flake in ash_unittests in tests that record and read back
histograms, in particular PointerMetricsRecorderTest.

This is similar to the initialization in ComponentsTestSuite,
ContentTestSuiteBase, etc.

BUG=725287
TEST=run ash_unittests locally, PointerMetricsRecorderTest doesn't retry

Review-Url: https://codereview.chromium.org/2901703002
Cr-Commit-Position: refs/heads/master@{#473952}

Before this patch, the desktop web payments UI omitted sorting code and
dependent locality when constructing labels for shipping addresses. That
would confuse users located in such countries as France, where sorting
code is used.

This patch moves the iOS functions to create labels for shipping and
billing address labels into components/payments/core/strings_util.h and
uses these functions from both iOS and desktop. After this patch, the
shipping addresses on desktop show i18n addresses from all countries
correctly.

Bug: 725182
Change-Id: I9d1fcc513d11914b54553644f82743d2685972c0
Reviewed-on: https://chromium-review.googlesource.com/511102Reviewed-by: mahmadi <mahmadi@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473951}

Revert of Add ScopedTaskEnvironment::ExecutionControlMode. (patchset #6 id:100001 of https://codereview.chromium.org/2891363005/ )

Reason for revert:
Is causing consistent test failures on the main waterfall in net_unittests URLRequestSimpleJobTest.CancelAfterFirstReadStarted, for example:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_Tests%2F41620%2F%2B%2Frecipes%2Fsteps%2Fnet_unittests%2F0%2Flogs%2FURLRequestSimpleJobTest.CancelAfterFirstReadStarted%2F0

[1130:771:0523/094643.091773:30621298248173:FATAL:scoped_task_environment.cc(178)] Check failed: !task_queue_empty_closure_.
0   net_unittests                       0x0000000102d4603c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   net_unittests                       0x0000000102d5db70 logging::LogMessage::~LogMessage() + 224
2   net_unittests                       0x000000010302df97 base::test::ScopedTaskEnvironment::RunUntilIdle() + 183
3   net_unittests                       0x000000010205f824 net::URLRequestSimpleJobTest_CancelAfterFirstReadStarted_Test::TestBody() + 260
4   net_unittests                       0x00000001022adf56 testing::Test::Run() + 246
5   net_unittests                       0x00000001022ae9f0 testing::TestInfo::Run() + 288
6   net_unittests                       0x00000001022aef57 testing::TestCase::Run() + 263
7   net_unittests                       0x00000001022b5057 testing::internal::UnitTestImpl::RunAllTests() + 871
8   net_unittests                       0x00000001022b4cc3 testing::UnitTest::Run() + 163
9   net_unittests                       0x00000001030309b3 base::TestSuite::Run() + 163
10  net_unittests                       0x000000010303e176 base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) + 134
11  net_unittests                       0x0000000101fdf008 main + 440
12  libdyld.dylib                       0x00007fff8d4495fd start + 1
13  ???                                 0x0000000000000007 0x0 + 7

Original issue's description:
> Add ScopedTaskEnvironment::ExecutionControlMode.
>
> This enum controls whether tasks posted within the scope of a
> ScopedTaskEnvironment can run as they are posted or have to wait
> until a call to RunUntilIdle() to run.
>
> BUG=724077
> TBR=gab@chromium.org
>
> Review-Url: https://codereview.chromium.org/2891363005
> Cr-Commit-Position: refs/heads/master@{#473925}
> Committed: https://chromium.googlesource.com/chromium/src/+/fc7b5ec521b29a97e63a7cda5921aa5ed793679a

TBR=gab@chromium.org,robliao@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=724077

Review-Url: https://codereview.chromium.org/2903633003
Cr-Commit-Position: refs/heads/master@{#473950}

Fix ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Windows 10 with PlzNavigate.

The tests were loading a tab that would be closed. The test code was waiting for both a didstop IPC (inside InProcessBrowserTest::AddTabAtIndexToBrowser) and for the extension-unloaded notification (what the test is really testing). With PlzNavigate, the didstop IPC is sent later and it's racy whether the renderer will send it before the tab is closed. So remove the first wait.

BUG=699437

Review-Url: https://codereview.chromium.org/2896853005
Cr-Commit-Position: refs/heads/master@{#473949}

BUG=725470
NOTRY=TRUE
TBR=shinyak

Review-Url: https://codereview.chromium.org/2902753002
Cr-Commit-Position: refs/heads/master@{#473948}

on x86/c64 bots. The problem was that VrShellDelegate.java depends on
VrFeedbackStatus.java which was only available when enable_vr was set to true.
This CL build VrFeedbackStatus as part of chrome_java_sources instead of
chrome_vr_java_sources.

Original CL: https://codereview.chromium.org/2887383002/
Revert: https://codereview.chromium.org/2896933002/

Revert "Revert "Show an infobar prompting the user to enter feedback when they exit VR""

This reverts commit 007ec6f3.

TBR=mthiesse
BUG=706438

Review-Url: https://codereview.chromium.org/2899013002
Cr-Commit-Position: refs/heads/master@{#473947}

TBR=wychen@chromium.org,yusufo@chromium.org,mlamouri@chromium.org

Bug: 725534
Change-Id: Ifc0696d08d82d0ea41fc96c7ef09e54cf161b3f2
Reviewed-on: https://chromium-review.googlesource.com/512365Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473946}

Before this patch, typing "3103106000" into a phone number field in web
payments UI on desktop would leave the field as-is, which is difficult
to read.

This patch extends ValidationDelegate to also handle text field
formatting. Formatting happens only when the user is typing at the end
of the field or when user has left the field (blur). Typing in the
middle of the field does not cause reformat because Views does not have
functionality to position the cursor, which is required to make
auto-formatting feel natural.

After this patch, typing "3103106000" into a phone number field in web
payments UI on desktop will format-as-you-type this number into "+1
310-310-6000".

Bug: 725161
Change-Id: Id39de49e2a79a681ff2615541489be057b37d2de
Reviewed-on: https://chromium-review.googlesource.com/511422Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473945}

Revert of Why do we have this line when it makes sliders look editable? (patchset #2 id:20001 of https://codereview.chromium.org/2893963002/ )

Reason for revert:
Is causing test failures such as https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/67395

DumpAccessibilityEventsTest.AccessibilityEventsAriaSliderValueTextChange

c:\b\c\b\win\src\content\browser\accessibility\dump_accessibility_browsertest_base.cc(363): error: Value of: is_different
  Actual: true
Expected: false
[4988:5300:0523/092002.409:37981750:ERROR:dump_accessibility_browsertest_base.cc(388)] Diff:
* Line Expected
- ---- --------
*    1 EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%" IA2_STATE_EDITABLE,IA2_STATE_VERTICAL
     2 <-- End-of-file -->
Actual
------
EVENT_OBJECT_VALUECHANGE on role=ROLE_SYSTEM_SLIDER value="2%" IA2_STATE_VERTICAL
<-- End-of-file -->

Original issue's description:
> Why do we have this line when it makes sliders look editable?
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2893963002
> Cr-Commit-Position: refs/heads/master@{#473911}
> Committed: https://chromium.googlesource.com/chromium/src/+/b78f1ba01120e4f9dfa9faf541b670d893883cfe

TBR=dmazzoni@chromium.org,aleventhal@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2900953004
Cr-Commit-Position: refs/heads/master@{#473944}

UI screenshot:
https://drive.google.com/open?id=0Byo6-Nuda2jgSUJKeTBQMndhbnc
Constraints screenshot:
https://drive.google.com/open?id=0Byo6-Nuda2jgYnZ3SnRPdERxQzA

BUG=682880

Review-Url: https://codereview.chromium.org/2901663002
Cr-Commit-Position: refs/heads/master@{#473943}

BUG=724491

Review-Url: https://codereview.chromium.org/2895693002
Cr-Commit-Position: refs/heads/master@{#473942}

This CL adds metrics that report success for downloading favicons on
demand (both for existing code for PopularSites and for the new code for
MostLikely).

BUG=536988

Review-Url: https://codereview.chromium.org/2888393002
Cr-Commit-Position: refs/heads/master@{#473941}

BUG=None

Review-Url: https://codereview.chromium.org/2886763003
Cr-Commit-Position: refs/heads/master@{#473940}

When chromevox is enabled or the braille is connected, a notification will be shown to
users through the notification center. The screenshot of the notifications can be found
in the crbug.

TEST=TrayAccessibilityTest.ShowNotification

BUG=685845

Review-Url: https://codereview.chromium.org/2838903002
Cr-Commit-Position: refs/heads/master@{#473939}

BUG=724157

Review-Url: https://codereview.chromium.org/2899873002
Cr-Commit-Position: refs/heads/master@{#473938}

If the TPM is not ready, don't try to load the system token. It would
fail anyway and prevent the TPM initialization process from running on
user sign-in (because TPMTokenLoader only performs the initialization
process once). Also, delay system token initialization until cryptohome
is ready.

BUG=725346,655266
TEST=Manual test on Chrome OS:
(1) On a freshly resetted device (not enrolled, not owned), the system
    token is simply not loaded on the sign-in screen
(2) On an enrolled device, the system token is loaded on the sign-in
    screen. Device-wide EAP-TLS networks can connect.
In both cases, there should be no errors related to TPM init in
  /var/log/chrome/chrome.

Change-Id: If810287747f05361ffa3a0a06fe9f2c8988ea676
Reviewed-on: https://chromium-review.googlesource.com/512662Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473937}

BUG=725532
TBR=changwan@chromium.org

Review-Url: https://codereview.chromium.org/2898213002
Cr-Commit-Position: refs/heads/master@{#473936}

The flat_tree pretty-printer is hooked up so that base::flat_set can be
displayed.

The regular expressions for base::Value were incorrect. These were separated
out into three exact matches for clarity.

Point and Rect printers were removed. The default view shows the data well
enough, and it's confusing to see different member names being printed than the
actual class has in it.

Review-Url: https://codereview.chromium.org/2895973003
Cr-Commit-Position: refs/heads/master@{#473935}

https://skia.googlesource.com/skia.git/+log/92de631edd3e..e980174d0f3a

$ git log 92de631ed..e980174d0 --date=short --no-merges --format='%ad %ae %s'
2017-05-23 mtklein simpler portable round()
2017-05-23 reed add gm to test alpha in drawPatch
2017-05-23 jvanverth Fix TSAN error for shadow cache
2017-05-23 scroggo Revert "sk_fgetsize to not use ftell."

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ie34a0e5421dab869ca3809669bc630d413c35f83
Reviewed-on: https://chromium-review.googlesource.com/512364Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473934}

This adds URLRequestContextBuilderV8, which can construct a
URLRequestContext using either type of ProxyResolver. When using such
a resolver, the ProxyService will fetch requests using the
URLRequestContext that was created with the builder.

Added a subclass instead of modifying URLRequestContextBuilder so it
can continue to be used without depending on V8.

This was originally landed in
https://codereview.chromium.org/2881613002/, and reverted in
https://codereview.chromium.org/2888043008/.  This version of the CL
fixes a test-only lifetime issue.

BUG=717253, 724471

Review-Url: https://codereview.chromium.org/2898073002
Cr-Commit-Position: refs/heads/master@{#473933}

BUG=596760

Review-Url: https://codereview.chromium.org/2901843002
Cr-Commit-Position: refs/heads/master@{#473932}

|new Document()| creates a new Document instance.

Intent-to-implement-and-ship:
https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/IxyBdzkSU98/LJ12LwjKAAAJ

This CL fixes 168 failures in external/wpt/.

WPT changes:
* Adds 'origin' check to dom/nodes/Document-constructor.html.
* Adds dom/nodes/Document-constructor-svg.svg
* Adds dom/nodes/Document-constructor-xml.xml

BUG=238234, 643043

Review-Url: https://codereview.chromium.org/2881323002
Cr-Commit-Position: refs/heads/master@{#473931}

WebView applications can throw run-time exceptions within
WebView-callbacks. When such an exception is thrown from the callback
passed to evaluateJavascript it is not correctly propagated to Android's
feedback mechanism. This is because that callbacks is called through
JNI, and the default way (in Chromium) of handling Java exceptions
thrown on the Java-side of JNI calls is to print the stack trace for the
current exception to the logcat when the JNI call returns to native, and
then intentionally crash in native.

With this CL we avoid the problem of propagating a Java exception back
through JNI and the native stack by posting the WebView-callback (which
can cause the Java exception) as a new task to the current Java Handler.
In that way any Java exception thrown inside the WebView-callback can be
propagated directly up to the Android framework's
UncaughtExceptionHandler which then properly reports the Exception
through the framework's crash reporting mechanism.

BUG=719396

Review-Url: https://codereview.chromium.org/2900033002
Cr-Commit-Position: refs/heads/master@{#473930}

BUG=722949

Review-Url: https://codereview.chromium.org/2884393002
Cr-Commit-Position: refs/heads/master@{#473929}

Review-Url: https://codereview.chromium.org/2898153002
Cr-Commit-Position: refs/heads/master@{#473928}

This API will allow to use DidStartNavigation callback instead of
deprecated -[CRWWebDelegate webWillReload].
DidStartNavigation will check if NavigationContext::GetPageTransition
returns reload transition to act on reload navigation.

BUG=674991

Review-Url: https://codereview.chromium.org/2896623003
Cr-Commit-Position: refs/heads/master@{#473927}

BUG=
R=nparker@chromium.org

Review-Url: https://codereview.chromium.org/2895213004
Cr-Commit-Position: refs/heads/master@{#473926}

This enum controls whether tasks posted within the scope of a
ScopedTaskEnvironment can run as they are posted or have to wait
until a call to RunUntilIdle() to run.

BUG=724077
TBR=gab@chromium.org

Review-Url: https://codereview.chromium.org/2891363005
Cr-Commit-Position: refs/heads/master@{#473925}