- 06 May, 2019 40 commits
-
-
Maggie Chen authored
Increase max_old_space_size to 4 GB based on availability of physical memory. The purpose of this finch is to support web apps that require more heap space for their data sets Bug:958974 Change-Id: I7f6bb9e69a306331242434cfc03acd68ad32333d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592792Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#656851}
-
wutao authored
We need to check window property first before uploading the AX tree. Bug: 959471 Test: manual Change-Id: I14ee0f1d5da34b06944b3113ab7a537fc05b39c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594286Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#656850}
-
James Cook authored
Same as chrome/browser/extensions/api/automation_internal/OWNERS, the accessibility team. Bug: none Change-Id: If5628e8c5998ecead98681e7c993fbb2f4c8cabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592625 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#656849}
-
mrefaat authored
Use WebStateListObserver instead. Bug: 911350, 931852 Change-Id: I25a141153f0378d9e8edf661d6bf4e202ed97389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590062Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#656848}
-
Ben Kelly authored
Bug: 957175 Change-Id: I6b4402b75232ca7812c099422956746b373d2c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589905Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#656847}
-
khmel@chromium.org authored
This adds mentioned charts to CPU overview section and Chrome graphics correspondingly. Also it makes possible to draw charts over event bands and composite tooltips for bands and charts. TEST=Locally BUG=b:122555793 Change-Id: Ic90773f68d5b1d680b1e4a45a3c513e8dc546e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595314 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
-
Mustaq Ahmed authored
Bug: 959850 Change-Id: I447a77e2d4c35298ed4e5f28d139c0184bce68ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595967 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#656845}
-
sczs authored
- Creates InfobarMetricsRecorder which appends the suffix for the InfobarType and records the Histograms. - Adds Histograms for all InfobarBanner actions and events. - Creates Mobile.Messages.Type suffix to record banner metrics for each specific Infobar type. Bug: 911864 Change-Id: I2c14701acb8128cab8113c86ba3f9e02a7d1a302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590550Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#656844}
-
Yi Su authored
web::LoadPhase is an navigation enum in crw_web_controller.h. This CL replaces it with web::WKNavigationState so that later when we extract navigation code out of crw_web_controller into ios/web/navigation, circle dependency on ios/web/web_state can be avoided. This CL only substitutes enums number so it's 100% safe. The "navigationState" property will be removed after the refactor. Bug: 956511 Change-Id: I1ac76e7035ca0a8615f0b7add72e48626fa8f4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594513 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#656843}
-
Tommy Nyquist authored
Up until now, it was not possible to use the feature engagement backend without having a server side configuration. This CL adds support for being able to have a local fallback unless there is no server side configuration. It is still possible to turn a feature off using the server side configuration. The three initial in-product help features that were launched are also ported over in this CL, so it is possible to in the future remove their server side configuration. Bug: 833128 Change-Id: Ia0196a754f2cffad7ea6878bb6ed78883256eeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529579 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d469f480e06d..8705a61f63ca Created with: gclient setdep -r src-internal@8705a61f63ca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@chromium.org,iclelland@chromium.org,dullweber@chromium.org,dalecurtis@chromium.org,jrummell@chromium.org Change-Id: I0f5c0565c11bd2a77a343d2fb86f5ed749bf1221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595657Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656841}
-
Nico Weber authored
We now have a natvis file for libc++ and fixed a bug in lld-link that made it not embed natvis files correctly if there were more than two, so now this switch should no longer negatively affect debugging. Bug: 801780 Change-Id: Iab1b3f8b3e3bbbda3abdf08156287820392d7946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594345 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#656840}
-
Ian Clelland authored
This reverts commit 9ac1e68e. Reason for revert: This has make at least one of the timing tests flaky; tests probably need to be updated to account for the possible change in rounding direction. Several bots started failing at roughly the same time, pointing to this CL as potential culprit. Flakiness dashboad: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=external%2Fwpt%2Fevent-timing%2Fevent-timing-observethenonload.html&testType=webkit_layout_tests Sample failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/8797 https://test-results.appspot.com/data/layout_results/linux-xenial-rel/8797/webkit_layout_tests/layout-test-results/results.html Original change's description: > [EventTiming] Round instead of ceil the |duration| > > The purpose of this change is to expose entries whose |duration| is >= > 100ms. > > Bug: 823744 > Change-Id: Ibb089009ba287769b1365a938cc7564278a86c35 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594818 > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656797} TBR=tdresser@chromium.org,npm@chromium.org Change-Id: I1a048dcbb0fc62f3915195fb0f97158705db2d12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596177Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#656839}
-
Eric Stevenson authored
Currently, the ID is part of BuildConfig.java, which is generated at build time. This doesn't work for Trichrome, since WebView and Chrome have different Firebase app IDs. This CL moves the IDs to code and then sets the correct ID at startup. Can't remove firebase_app_id from build files until the downstream uses are gone. Bug: 957618 Change-Id: I7b7d787eaf3e5cd00452bdf3696e93751304a6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592473 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#656838}
-
Yi Su authored
This CL is a prerequisite work for extracing navigation code out of CRWWebController. Bug: 956511 Change-Id: I239a29f55a54f7ef323b6c1dc5aefdf44d212a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596431 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
-
Gang Wu authored
FeedTaskType should be in "prefix,3" instead of "prefix, 2" Change-Id: Id7e8163111dfb59c6612771b32254caab8961bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594820Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#656836}
-
Bruno Santos authored
Also, launch app regardless of being in an internal build (provided that other conditions are met, i.e. build and feature flags). Bug: 957205 Change-Id: I6a803e68e857c1f42aea5ae242899c364aeef9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592551Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#656835}
-
Saman Sami authored
We always pass nullptr for |share_group| so just get rid of it. Change-Id: I3c59a027748c885df02538f582b1309338f2dc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596842 Auto-Submit: Saman Sami <samans@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#656834}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/afc69d368b03..f51af41d20f0 git log afc69d368b03..f51af41d20f0 --date=short --no-merges --format='%ad %ae %s' 2019-05-06 ehsannas@gmail.com Fix typos in the artifacts links. (#606) Created with: gclient setdep -r src/third_party/shaderc/src@f51af41d20f0 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I95d658616a9a45a676ebd21b2e18eac4c1b8043f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596607Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656833}
-
Tommy Li authored
This reverts commit 8967c490. Reason for revert: Holding off until M76 Original change's description: > [omnibox] Steady State Elisions - Enable flag by default > > To prepare for launch, enabling these dy default on tip of tree. > > Bug: 842236 > Change-Id: I0d40540fcfb6262238670ccfbcbe3d7f371e05e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577488 > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652916} TBR=tommycli@chromium.org,jdonnelly@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 842236 Change-Id: I7d07efad3e5aafd8bfe89de992eb4d9d2f4b9f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596221Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#656832}
-
Scott Violet authored
This has been removed downstream, but hasn't been merged yet and is blocking removal of code. BUG=958062 TEST=test only change Change-Id: Id2bb4b8d16e6953bfbccf001b8dde0d8bfbfb741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596223Reviewed-by:
-
Tarun Bansal authored
In network quality estimator (NQE), reduce the number of unnecessary notifications sent to the observers by modifying the network quality manager to not send spurious notifications if there is no change in Effective Connection Type (ECT). Bug: 951886 Change-Id: I1b25d77bc07b3a65268ceb79542d083c69ac6f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593599Reviewed-by:
-
Alexei Svitkine authored
TBR=rkaplow@chromium.org Change-Id: I5fa7efae2b463feb935d1b4e5ff3d4f3a2546175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596988 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#656829}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ac8733475c13..c71c17f63457 git log ac8733475c13..c71c17f63457 --date=short --no-merges --format='%ad %ae %s' 2019-05-06 chrisforbes@google.com Plumb through Dref parameter to sampler 2019-05-06 chrisforbes@google.com Make shadow compare available in high precision path always 2019-05-06 sugoi@google.com Threaded Queue submit with events and fences 2019-05-06 sugoi@google.com Cube border computation Created with: gclient setdep -r src/third_party/swiftshader@c71c17f63457 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129523279,chromium:b/129523279 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Iea61421d0a91e9b06e852890042f2bd40c109197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596612Reviewed-by:
-
Tien Mai authored
Use the presence of a gaia id passed from GCPW to Chrome when requesting sign in to determine if we are in a reauth flow or a normal sign in flow. Added unit tests to check that the correct query parameters are forwarded to Gaia in these conditions. Bug: 959290 Change-Id: I4efb2624c70b21a1274fa28b56961380e3dae4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594343Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#656827}
-
Kevin Ellis authored
Previously our implementation of animation.playState included a 'pending' state, which is not part of the specification (https://drafts.csswg.org/web-animations/#the-animationplaystate-enumeration). Instead pending paused and plays are to be measured using the animation.pending property, which is introduced in this CL. Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Gstf0GA7cbg Bug: 772407, 827630 Change-Id: If6d78351f800991b6b4450b8fbdadcd6d20d0551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588283Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#656826}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7f0d44ce. With Chromium commits locally applied on WPT: e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591" c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" 9492aa14 "Add touchTapInTarget function for wpt touch event tests" eb4c1182 "Add pointerDragInTarget function for wpt touch event tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ic5e386d94fcc5dd320009068ad02b337b7883e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596838Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#656825}
-
Sean Gilhuly authored
The cc layer tree pixel tests are using a FakeSkiaOutputSurface for Skia mode, which is returning transparent images. Create a TestGpuServiceHolder and a real SkiaOutputSurfaceImpl. Some of these tests are now passing for SkiaRenderer, so enable them. Bug: 948128 Change-Id: I5dd9fa5ab4f80b6917bba0f7f43cdb6266dc8817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572618Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#656824}
-
Theresa authored
- Create a new AppMenuCoordinator under RootUiCoordinator - Move app menu code from Chrome*Activity to this class - Remove appmenu/ dependencies on *Activity - Move around some other stuff to facilitate the refactor (e.g. move EmptyBackgroundViewWrapper initialization to RootUiCoordinator) - Introduce MenuOrKeyboardActionHandler to ChromeActivity to allow classes to register themselves as menu action handlers. BUG=956260 Change-Id: I1e0e195c3b8827abe79f84002ca400e153d79c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586216 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#656823}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/37860a707163..c22ef61f3aeb git log 37860a707163..c22ef61f3aeb --date=short --no-merges --format='%ad %ae %s' 2019-05-06 geofflang@chromium.org Vulkan: Store fences instead of serials in SurfaceVK::SwapHistory Created with: gclient setdep -r src/third_party/angle@c22ef61f3aeb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: Ic08b5ee81dcf7a495b7c1a1ed019135a880e8788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596608Reviewed-by:
-
jdoerrie authored
This change prepares //device for the upcoming switch of base::string16 to std::u16string. Bug: 911896 Change-Id: I8247b7ee8b6519997a574698d66c088d7d67f7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591524Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#656821}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2f3637bf2ed4..7d2ad0fdef01 git log 2f3637bf2ed4..7d2ad0fdef01 --date=short --no-merges --format='%ad %ae %s' 2019-05-06 michaelludwig@google.com Fix local matrix for crop rects in backdrop image filters Created with: gclient setdep -r src/third_party/skia@7d2ad0fdef01 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:955467 TBR=robertphillips@chromium.org Change-Id: I47076b891972dfd7e558069960c53985713c76d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596610Reviewed-by:
-
Ian Kilpatrick authored
This is in preparation for the "simplified" layout pass within NG. Basically we should only consider in-flow descendants, and floats for the MayHaveDescendantAboveBlockStart check. The current implementation will miss the cache if we have an absolute positioned child, above the block start edge. Bug: 635619 Change-Id: I56c3839ac1ddcfb0a97cc5d9245ea7814e505ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594181 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#656819}
-
Evan Stade authored
Bug: 958192 Change-Id: Ia1b98023783955d48f7d4f3c9114b1c47bfce82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593601 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Saman Sami authored
This reverts commit 06a207b8. Reason for revert: The fix has caused its own regressions. I'll try to fix the original regression in a different way. Original change's description: > viz: Immediately ack clients that submit later than display deadline > > When a client misses the display deadline, it should not be blocked > until the next DrawAndSwap because it will forever lag behind the > display by one frame: > - Renderer submits CompositorFrame after display deadline. > - On next BeginFrame, display schedules an immediate deadline because > the renderer has an undrawn frame. > - Since the renderer can't beat display's immediate deadline, its > CompositorFrame comes after display's deadline again. Repeat. > Instead, we should immediately ack the client when it misses the > display deadline. > > Bug: 951992 > Change-Id: I672912c0cef346dd29aa9d6b2e9deb8eb04a4c7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588436 > Auto-Submit: Saman Sami <samans@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#655983} TBR=jonross@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 951992 Change-Id: If209e3ed09c2862acaefb371adfe1a7216614e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596832Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#656817}
-
John Abd-El-Malek authored
We want to remove this boolean as devtools won't need it anymore (it'll use a different mechanism). The raw headers weren't used by GaiaAuthFetcher. Change-Id: Icd07a01986f86fa6f9da0a08a38632b7a6260f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593498Reviewed-by:
-
Jérôme Lebel authored
Adding transparent button in background for the identity chooser view. This button is used for accessibility. The button implementation (AccessibilityCloseButton) is shared between PopupMenuViewController and IdentityChooserPresentationController. Bug: 943174 Change-Id: I8cce0d99e87fb51d9468d9eca9e24592b038542b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592652 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Bug: 938905 Change-Id: I50f23a199782c1d9ecffd74cb650d7acc4f1f92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595653Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#656814}
-
Tien Mai authored
The text "Windows Password" that appears greyed out in the password field when a user needs to update their windows password needs to have a localized value. Bug: 958355 Change-Id: I89960b281b947906d653b737ed0f64b703b0a5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591425Reviewed-by:
-
Chris Hamilton authored
Further CLs will expand the public interfaces one by one. BUG=958115 Change-Id: Iedf6382e40bfc02af3d9404a5b380f97d9d02a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594928 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#656812}
-
