GitLab

Discrepancy is a measure for the largest area of jank in a series of time stamps.

Inverse RMS frame time is a generalization of frames/second that penalizes longer frame times. We can switch to the inverse of another generalized mean with a higher exponent if we want to penalize long frame times even more.

R=nduca@chromium.org, tonyg@chromium.org, klobag@chromium.org, vangelis@chromium.org
BUG=280627, 281544

Review URL: https://chromiumcodereview.appspot.com/23506030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221782 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a few tests were broken by minor changes in behavior 
introduced in http://crrev.com/220164.

BUG=281730
TEST=MediaSourcePlayerTest.StartTimeTicksResetAfterDecoderUnderruns
     and MediaSourcePlayerTest.ReadFromDemuxerAfterSeek pass now.

Review URL: https://chromiumcodereview.appspot.com/23620012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221781 0039d316-1c4b-4281-b951-d872f2087c98

Compile error:

render_text_unittest.cc(1662) :error C2039: 'Range' : is not a member of 'ui'

Revision 221776 change collided with revision 221762, which moved Range
from ui to gfx namespace.

> RenderTextWin: Break runs between any two characters that are not in the same code block
> 
> BUG=278913
> 
> Review URL: https://chromiumcodereview.appspot.com/23522018

TBR=ckocagil@chromium.org

Review URL: https://codereview.chromium.org/23707025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221780 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/23458018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221777 0039d316-1c4b-4281-b951-d872f2087c98

BUG=278913

Review URL: https://chromiumcodereview.appspot.com/23522018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221776 0039d316-1c4b-4281-b951-d872f2087c98

Generate passwords only for the forms that autofill server classifies one of its fields as ACCOUNT_CREATION_PASSWORD.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23432002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221773 0039d316-1c4b-4281-b951-d872f2087c98

This is required for EthernetEAP, because that one will not show up in the network list of NetworkStateHandler.

BUG=126870

Review URL: https://chromiumcodereview.appspot.com/23902011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284817
R=creis@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/23448003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221771 0039d316-1c4b-4281-b951-d872f2087c98

Adds a flag to about:flags to make the "Add to Homescreen"
menu item visible.  Requires a downstream patch to actually put
the menu item in.

BUG=286156

Review URL: https://chromiumcodereview.appspot.com/23676005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221770 0039d316-1c4b-4281-b951-d872f2087c98

find_unused_resources.py thinks that resources defined in third party
libraries are all unused. This updates the script to ignore those
resources.

BUG=149661
R=bulach@chromium.org, cjhopman@chromium.org

Review URL: https://codereview.chromium.org/23591017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221769 0039d316-1c4b-4281-b951-d872f2087c98

BUG=257093, 257098

Review URL: https://chromiumcodereview.appspot.com/23536030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221768 0039d316-1c4b-4281-b951-d872f2087c98

Previously we use a central trace-event buffer to store trace events
from all threads, which needs a lock. Measurement showed that on
Android the lock contributes over 50% of the total overhead of
trace event.

Use thread-local trace-event buffers so that in most times trace
events can be handled lock-free.

TraceLog::Flush() now may asynchronously call the callback.

TODO: Now for a message loop running a blocking task, async flush
doesn't work. The async flush will timeout and finish without
collecting the last batch of such thread if any.

On Nexus 4 this patch can reduce the average overhead of trace_event
from 15~20us to about 5~8us for a busy app. Note the numbers are not
very accurate because
- the time tick seems 30us on Android. The average number may be just
a result of increased percentage of trace events whose overhead < 30us.
- there are differences in the measurement method of the overhead
because of the change of the code structure.

BUG=264667
TEST=Updated existing tests: TraceEventTestFixture.DataCapturedOnThread
and TraceEventTestFixture.DataCapturedManyThreads. Existing unit/browser
tests using trace_event should still pass.
R=nduca, dsinclair
TBR=phajdan.jr (for base/test/trace_event_analyzer_unittest.cc)

Review URL: https://chromiumcodereview.appspot.com/22962004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221766 0039d316-1c4b-4281-b951-d872f2087c98

We used to track and handle user-resizing by ourselves. This brings up a few problems and makes the user-resizing hard to use on Mac. For example, the user-resizing could not be triggered outside or on the edge. Switching to doing it via system solve all these problems.

Also removed EnableResizeByMouse which is not really used in our code.

BUG=282652,282657
TEST=manual test by user-resizing panels

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221651

Review URL: https://chromiumcodereview.appspot.com/23918002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221765 0039d316-1c4b-4281-b951-d872f2087c98

PepperMessageFilter is used for PPB_NetworkMonitor and
PPB_X509Certificate. Neither of these APIs is supported for
in-process plugins.

TBR=sky@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/23997002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221764 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285169

Review URL: https://chromiumcodereview.appspot.com/23943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221763 0039d316-1c4b-4281-b951-d872f2087c98

Part of a set of changes to fix the circular dependency between ui/base and ui/gfx, with the aim of making gfx its own component.

R=jam@chromium.org, jschuh@chromium.org, rsesek@chromium.org
BUG=285385,103304

Review URL: https://codereview.chromium.org/24012002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221762 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221761 0039d316-1c4b-4281-b951-d872f2087c98

The LSS update changes the prctl() wrapper, which requires pulling in
an updated Breakpad version too.

BUG=none
TEST=trybots

Review URL: https://chromiumcodereview.appspot.com/23869004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221760 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221759 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221757 0039d316-1c4b-4281-b951-d872f2087c98

This is intended to fix flaky crashes in the current ref builds on the startup
and blink_perf measurements.

BUG=282098,278582,273988
TBR=xusydoc@chromium.org

Review URL: https://codereview.chromium.org/24047002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221756 0039d316-1c4b-4281-b951-d872f2087c98

Keep autofill dialog related constants in named namespace.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23546007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221755 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23627008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221754 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286074
R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/23583039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221751 0039d316-1c4b-4281-b951-d872f2087c98

R=avi@chromium.org

Review URL: https://codereview.chromium.org/23471009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221750 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286319

Review URL: https://chromiumcodereview.appspot.com/24027005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221749 0039d316-1c4b-4281-b951-d872f2087c98

http://crrev.com/23478020 was incomplete and this CL implements the rest.

BUG=280219
TEST=none

Review URL: https://chromiumcodereview.appspot.com/23615013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221748 0039d316-1c4b-4281-b951-d872f2087c98

UI for the consent prompt is not ready yet but we want a way to perform an
end-to-end integration test.  This allows the consent to be explicitly given
on the command line.

BUG=chromium:270316
TEST=unit, manual

Review URL: https://chromiumcodereview.appspot.com/23470003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221747 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23688006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221745 0039d316-1c4b-4281-b951-d872f2087c98

NativeViewAccessibilityWin needs to do hit testing in
web content as well as views. While implementing this,
I realized that it isn't necessary to have a special
interface to a RWHV to get an object by child id - we
can just rely on WebView overriding
GetNativeViewAccessible and do the lookup using a
native call.

The same trick works for hit testing - we check if
the point is inside a child's bounding rect, and if so
we call accHitTest on that child's native view
accessible - and since WebView overrides
GetNativeViewAccessible, the recursive call to
accHitTest will return the correct result from inside
the web content.

We still need AccessibleWebViewRegistry (because
looking up objects from child ids gets called A LOT,
but it's much simpler now, just a set of Views.

BUG=284803

Review URL: https://chromiumcodereview.appspot.com/23506027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221744 0039d316-1c4b-4281-b951-d872f2087c98

Will update data to match (including both new and old URLs) before landing.

R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/23450024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221743 0039d316-1c4b-4281-b951-d872f2087c98

oobe timeout error is no longer accurate, so update it.
Do not copy the chrome_login_ext if it's not going to be used.

BUG=None
Test=login_CryptohomeTelemetry, login_CryptohomeIncognitoTelemetry, and telemetry unittests for cros (regular + guest)
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23710017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221742 0039d316-1c4b-4281-b951-d872f2087c98

* Move files out of the roout of examples/ to resources/
* Move files from examples/resources to resources/
* Move Makefile templates to resources/ and rename them.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/23919004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221741 0039d316-1c4b-4281-b951-d872f2087c98

Restoring the change. Verified that this was not the cause of bug 278543.

> Revert 219146 "[sync] Force re-auth during sync setup if Oauth2 ..."
> 
> > [sync] Force re-auth during sync setup if Oauth2 token is unavailable
> > 
> > If an enterprise user disables sync via a dashboard clear, and goes on
> > to re-enable sync at a later time, set up can fail due to an expired or
> > missing Oauth2 token.
> > 
> > This patch updates SyncSetupHandler::OpenSyncSetup to first check if an
> > auth token is available for sync, and if not, force a re-auth.
> > 
> > R=atwilson
> > TBR=fgorski,rogerta
> > BUG=276650
> > TEST=Disable sync for an enterprise user, exit chrome, delete "Web
> > Data*" from the profile dir, restart chrome, and set up sync. Re-auth
> > must be forced in this case.
> > 
> > Review URL: https://chromiumcodereview.appspot.com/23005016
> 
> TBR=rsimha@chromium.org
> 
> Review URL: https://codereview.chromium.org/23759003

TBR=sail@chromium.org

Review URL: https://codereview.chromium.org/23458028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221740 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/23999002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221739 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280900
TBR=erg

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221619

Review URL: https://chromiumcodereview.appspot.com/23437015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221738 0039d316-1c4b-4281-b951-d872f2087c98

The ChromeOS Wifi provider was erronously reporting an initial
scan of 0 wifi access points when the shill's scanning had not
yet completed. This resulted in a fallback to IP geo for the
first request and then proper Wifi based location on the
second request.

BUG=236418

Review URL: https://chromiumcodereview.appspot.com/23889009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260494
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/22903016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221736 0039d316-1c4b-4281-b951-d872f2087c98

Reposting happens when a menu is running and you click outside the
menu. The code was not setting the root_location of the newly created
event, resulting in anyone attempting to use the root (such as the app
list) getting the wrong thing.

BUG=285662
TEST=see bug
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23694022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221735 0039d316-1c4b-4281-b951-d872f2087c98

Retrieves list of printers for Google Cloud Print. Lets users look up printers
by ID or iterate over all printers.

BUG=286157

Review URL: https://chromiumcodereview.appspot.com/23658020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221733 0039d316-1c4b-4281-b951-d872f2087c98