- 07 Sep, 2018 40 commits
-
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d84b6737fa10..3b9680534909 git log d84b6737fa10..3b9680534909 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 fjhenigman@chromium.org Clean up state in EGLDebugTest. 2018-09-07 jmadill@chromium.org Vulkan: Make ContextVk driver uniforms a dirty bit. 2018-09-07 jmadill@chromium.org Vulkan: Correct gl_FragCoord with default FBO. 2018-09-07 fjhenigman@chromium.org Fix ClearTest.RGB8WithMaskFramebuffer. Created with: gclient setdep -r src/third_party/angle@3b9680534909 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:880495 TBR=fjhenigman@chromium.org Change-Id: Ibc35a52b39df10cc9d6cab6500eff19204dca7aa Reviewed-on: https://chromium-review.googlesource.com/1213826Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589705}
-
Wez authored
If mapping of a DLL into the sandboxed process is blocked then we unmap it and return an "unsuccessful" status, but we left the DLL base-address out-parameter set to a non-NULL value. Reset the out-parameter to null when blocking a DLL, to ensure that callers don't get confused into thinking the operation was successful. This replicates the change from https://chromium-review.googlesource.com/c/chromium/src/+/1211322 to the ThirdPartyModulesBlocking implementation of NtMapViewOfSection(). Change-Id: I7c326a1c78870888c2141f24ae357d0f9be55a62 Reviewed-on: https://chromium-review.googlesource.com/1213561 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#589704}
-
Mathias Carlen authored
R=gogerald@chromium.org Bug: 806868 Change-Id: I1b7503c801916fb7bd7e0bcde2361f0bfd15d7cf Reviewed-on: https://chromium-review.googlesource.com/1202205 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#589703}
-
Andrew Xu authored
Modify the function CanHandleToggleCapsLock: pressing any redundant key will prevent triggering the Capslock shortcut. In original code, pressing Alt + M + Search then releasing Alt will trigger CapsLock. Because AcceleratorHistory will receive Alt + Search when Search is pressed. The fact that key M is pr- -essed is ignored. R=afakhry@chromium.org Bug: 789283 Test: ash unittests Change-Id: Id359d11cda4562a0b90da97af6c3dde3faf33c53 Reviewed-on: https://chromium-review.googlesource.com/1199853 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#589702}
-
Ryan Hansberry authored
Improve user experience by showing the "Start" page first, and the "Password" page after, making for a less jarring experience. Bug: 881610 Change-Id: I0a54c0d6c8b5ffc11e6bfdd2aba80adf6bab374d Reviewed-on: https://chromium-review.googlesource.com/1214169Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#589701}
-
David Tseng authored
In some instances, we receive a significant number of attribute changes within a short delay. This change throws away attribute changes that generate the same output on the same target. Test: manually on settings page. Verify that ChromeVox only announces the radio button once rather than > 30 times (and plays the radio button earcon 30 times). Change-Id: I92127ad074b3a73ce269077cae6b69ba71f59c52 Reviewed-on: https://chromium-review.googlesource.com/1211972 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589700}
-
Katie Dillon authored
Bug: 878975 Change-Id: If951e1f175c4103006845bda9bb740f2b2a6afc6 Reviewed-on: https://chromium-review.googlesource.com/1212090 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#589699}
-
Vikas Soni authored
The code in CompositorImpl currently assumes that only a single CompositorImpl instance exists for an application in management of the GPU process. This includes sending app foreground/background state updates to the GPU process and to GpuDataManagerImpl. This is a brittle assumption since the embedder can potentially create multiple Compositor instances. This CL uses the ApplicationStateListener to correctly detemine the state of application. Bug: 859723 Change-Id: Icdad848298f1cdd75995f496b2f0bdf70385336b Reviewed-on: https://chromium-review.googlesource.com/1205202 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#589698}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/26fbb0328d57..5fea8ca820be git log 26fbb0328d57..5fea8ca820be --date=short --no-merges --format='%ad %ae %s' 2018-09-07 hnakashima@chromium.org Force gclient sync in safetynet_compare.py. Created with: gclient setdep -r src/third_party/pdfium@5fea8ca820be The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia33549f08a52f9e17ac427d8fb51858227a319e8 Reviewed-on: https://chromium-review.googlesource.com/1214282Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589697}
-
John Abd-El-Malek authored
Most features work now. Change-Id: I3e3d73ff98fafa567bb66162eb4ab30a75739ee3 Reviewed-on: https://chromium-review.googlesource.com/1213278Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#589696}
-
Ted Meyer authored
It is basically a mimic of the h264 picture, and will be used in the D3D11Vp9accelerator class, when that is ready. There also appear to be two styles for accelerators to downcast, where vaapi & V4L2 use as___Picture() methods to get a raw pointer, but D3D11 just uses static casts. I think a future good cleanup is to get rid of the extra methods and not rely on forward declarations. Bug: 881922 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6a7cfbb81e230a7ea46ae3c3e27aebf52a559913 Reviewed-on: https://chromium-review.googlesource.com/1213871 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#589695}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/febcf8764dc1..ead23c2a266c git log febcf8764dc1..ead23c2a266c --date=short --no-merges --format='%ad %ae %s' 2018-09-07 dtu@chromium.org [pinpoint] Fix edge case in _Percentile(). Created with: gclient setdep -r src/third_party/catapult@ead23c2a266c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:881661 TBR=sullivan@chromium.org Change-Id: I4cfde01f46b232a9328c49a03ae33a75537be9a7 Reviewed-on: https://chromium-review.googlesource.com/1214283Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589694}
-
Scott Chen authored
Bug: 832933 Change-Id: I6399c3c2687e553d5d05df14d6b5263e985badab Reviewed-on: https://chromium-review.googlesource.com/1194835Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589693}
-
Stephen McGruer authored
Storing a scoped_refptr<ComputedStyle> in SVGElementRareData can cause a noncollectable Blink GC reference cycle, as there can be a path from the Document --> SVGElementRareData, and a path from ComputedStyle --> SVGLocalResource --> Document. The scoped_refptr in the center stops Oilpan from being able to detect the cycle. To fix this we clear the overridden ComputedStyle when the SVGElement is detached from the layout tree. Doing so breaks the cycle and allows Oilpan to collect everything as normal Bug: 878032 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib1095a9ae63b0499332e0e7369621ec6b8f961c0 Reviewed-on: https://chromium-review.googlesource.com/1213367Reviewed-by:
Anders Ruud <andruud@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589692}
-
David Tseng authored
TBR=dcheng@chromium.org Bug: 669134 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I91a10a1f39a1a353ace08d54611f6daec35ea1de Reviewed-on: https://chromium-review.googlesource.com/1213879 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589691}
-
Steven Bennetts authored
This CL: * Eliminates some scenarios using fake implementations (tests, linux) where bogus ERROR messages were being spammedn. * Converts some usage of base::DictionaryValue to base::Value. Bug: None Change-Id: If63ddfe3b00ecd7125848a162f0fffb9dcf7d679 Reviewed-on: https://chromium-review.googlesource.com/1211956 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#589690}
-
Manuel Rego Casasnovas authored
The CSSWG has recently resolved that layout containment should create a stacking context like paint containment (see issue https://github.com/w3c/csswg-drafts/issues/2942). This is the spec text about this (https://drafts.csswg.org/css-contain/#containment-layout): "5. The element creates a stacking context." The patch is just a simple change in ComputedStyle::UpdateIsStackingContext() to add the new condition. Apart from that TestExpectations file is updated as we're now passing some tests from WPT. We're also failing one test, but for an unrelated issue (see bug #880802). BUG=870157 TEST=external/wpt/css/css-contain/contain-layout-016.html TEST=external/wpt/css/css-contain/contain-layout-018.html TEST=external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-layout-stacking-context-001.html Change-Id: Icdc102692801534364adf3fc0929192b886cdbc4 Reviewed-on: https://chromium-review.googlesource.com/1211922 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589689}
-
Sunny Sachanandani authored
Automatically growing transfer buffer removed the flush when it would run of space. This decreased canvas throughput by reducing pipelining. Automatic flushes are another way of improving throughput by submitting work to the GPU process often. This CL enables automatic flushes for the shared main thread context used for canvas which might have been disabled unintentionally. Bug: 880901 Change-Id: Ib48d9c56c18c9e2d449d7c42f74b16609ad3ea55 Reviewed-on: https://chromium-review.googlesource.com/1213665Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#589688}
-
Yuchen Liu authored
JS may invoke Image.decode without capturing the Image object. If GC kicks in, ImageLoader will be destroyed as no one owns it, which leads to unresolved/unrejected Promise. The callback of ChromeClient::RequestDecode should take a persistent reference instead of weak reference to avoid ImageLoader GC. BUG=881060 TEST=LayoutTest image-decode-promise-when-gc.html Change-Id: Ief9c7956ddd0df81ea1f1643eb6f6c7bac946a7c Reviewed-on: https://chromium-review.googlesource.com/1205798Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589687}
-
Istiaque Ahmed authored
Use ServiceWorkerContext::RunTask() to make sure that ServiceWorkerContext* is kept alive while transitioning from UI thread to IO thread. Bug: 875376 Change-Id: Ib961931260b453e8a99828b8598d77c7821cff06 Reviewed-on: https://chromium-review.googlesource.com/1211971 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589686}
-
Frank Henigman authored
Update "Mac FYI dEQP Release AMD" on the GPU FYI waterfall to look for machines running OS 10.13.6. Bug: chromium:881952 No-Try: True Change-Id: I12e0f82f4cc29fdbe36f7f76ad5d945228eaf4a7 Reviewed-on: https://chromium-review.googlesource.com/1213704 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589685}
-
Mythri Alle authored
This reverts commit f17b2cd3. Reason for revert: <INSERT REASONING HERE> Original change's description: > Update ResourceLoader to also fetch cached code for inline scripts > > V8 also stores code caches for inline scripts in the html resources. > This cl updates ResourceLoader to fetch cached code for inline scripts > in MainResources. > > Bug: chromium:880212, chromium:812168 > Change-Id: I822453b52897aac292444df20e50937d8198064d > Reviewed-on: https://chromium-review.googlesource.com/1208391 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589137} TBR=kinuko@chromium.org,mythria@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:880212, chromium:812168 Change-Id: I4e24815c37378a86e334c8fe88129dff39ee87dd Reviewed-on: https://chromium-review.googlesource.com/1213094Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#589684}
-
Ryan Tseng authored
They need large core machines. This is fine since auto_builder_dimensions is on. Bug: 868213 TBR: tandrii Change-Id: I3aa153e09afbd7e9ddc885441a09183f73727232 Reviewed-on: https://chromium-review.googlesource.com/1214220Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#589683}
-
John Budorick authored
This adds filter file support to all test types that previously supported gtest-style test filtering, notably including instrumentation and junit tests. This was requested in crrev.com/c/1208442 Change-Id: I552843898735b52b773bdc397c39ecf64e4df275 Reviewed-on: https://chromium-review.googlesource.com/1214083 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#589682}
-
Tibor Goldschwendt authored
Change-Id: I65c3968959acf071019294acfa05ce5e0b4f23ba Reviewed-on: https://chromium-review.googlesource.com/1214165 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#589681}
-
Sammie Quon authored
But splitview is still tablet only. Test: manual Bug: 879761 Change-Id: I8957eaab9c37b98a219caa2addcfab35bacffc1d Reviewed-on: https://chromium-review.googlesource.com/1211109 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#589680}
-
Clark DuVall authored
VariationsService was not initializing ResourceRequestsAllowedNotifier on the OS_ANDROID portion of the #ifdef, which was preventing it from being notified of network changes. This should fix the regressions in Variations.SeedFreshness on Android: https://uma.googleplex.com/variations?sid=aeb0078452c432f2d6b3aa76b79354cd Bug: 868021 Change-Id: I40eaeea5dbd97e87c5ed16c7161781e3f7f67659 Reviewed-on: https://chromium-review.googlesource.com/1213316Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#589679}
-
Stefan Zager authored
As explained in the bug, "tracking document" should be associated with IntersectionObservation, not IntersectionObserver. One side effect of this change is that for a given observer, each of its observations runs its algorithm independently, so that notifications may not be generated in the order in which the observations were created (i.e., the order of calls to observer.observe()). To preserve the idiomatic web platform behavior that notifications are delivered in the order in which the targets were observed, this patch moves the storage of pending notifications from IntersectionObserver to IntersectionObservation. BUG=879798 R=chrishtr@chromium.org Change-Id: I9b6f6ad8a26387f0c072ccdff7f18cea9a88004c Reviewed-on: https://chromium-review.googlesource.com/1200388Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#589678}
-
Yi Fan authored
To fix the issue of decoder reporting different sample rate from the demuxer. some AAC streams' (from NBC Sports/ESPN, etc) ADTS header info, especially the sample rate, does not match the payload. The demuxer reports wrong sample rate to mixer, causing incorrect audio resampling. Currently the decodedbuffer does not include the sample rate property, so add AudioConfig field to the callback to return the info back to mixer and adjust the sample rate when needed. It should apply to all audio paths that needs AudioConfig. Bug: internal b/112898981 Test: local test NBC sports, audio sounds normal Depends-On: eureka-internal/199064 Change-Id: Iebef3acf50e856c8fcb47c8d0b13c3598c6df20f Reviewed-on: https://chromium-review.googlesource.com/1213320 Commit-Queue: Yi Fan <yfa@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#589677}
-
nednguyen authored
Previously, the benchmark timing files & shard map files are manually named. This CL simplifies all of them to be based on the builder names. This simplifies the implementation of tools/perf/core/bot_platforms.py file. This should be a pure refactoring & has no visible effect on how we schedule tests This is a follow up of Juan's comment in https://chromium-review.googlesource.com/c/chromium/src/+/1188945/6/tools/perf/core/bot_platforms.py#85 Bug:863768 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I7aa08e10978f54b7f2b15759d20d64a9c7bd8533 Reviewed-on: https://chromium-review.googlesource.com/1213317Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#589676}
-
wutao authored
UI review requests to put the Continue Reading behind the Open Tabs toggle. Changes: 1. Revert previous setting for Continue Reading. 2. Use syncPrefs.tabsSynced to control the feature. Bug: 880933, 843839 Test: manual. Change-Id: Iac3464a7c7a08b3bb33e9e3a93d48e9dc365acec Reviewed-on: https://chromium-review.googlesource.com/1208031 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589675}
-
Yuri Wiitala authored
Introduces the "outer shell" API to for GLScaler, with upcoming patches coming soon to fill-in the rest of the implementation. This is a major refactoring of GLHelper+GLHelperScaler to: 1) fix dangerous memory management issues, 2) provide a cleaner interface for client-side code, 3) unblock performance and color management efforts. Bug: 870036,758057 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ib8f0ed9b988bfe914bd8983940b089262543e8c7 Reviewed-on: https://chromium-review.googlesource.com/1194783 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589674}
-
James Wallace-Lee authored
Don't close the ZoomBubbleView on timeout if one of the buttons inside it has focus. (The bubble doesn't close on timeout if the mouse is inside the bubble; screenreaders should have the same experience). Also add an accessible title (read with Insert+T on JAWS and NVDA). Bug: 849486 Test: ZoomBubbleBrowserTest.FocusPreventsClose Change-Id: Idbe2e46ab0c6d896691850ff6fee5a843abee2f9 Reviewed-on: https://chromium-review.googlesource.com/1189044Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Cr-Commit-Position: refs/heads/master@{#589673}
-
Kevin Strohbehn authored
Bug: 878178 Change-Id: I90a27bea589fafc048cb165ffb698c44cb7bb049 Reviewed-on: https://chromium-review.googlesource.com/1212762 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589672}
-
Nick Carter authored
Create opaque SecurityOrigins for nonstandard schemes, unless they are local. Allow creation of url::Origins for local, nonstandard schemes. The root problem here was inconsistency between url::Origin and SecurityOrigin -- url::SchemeHostPort (and thus url::Origin) rejects anything with a nonstandard protocol, but SecurityOrigin::Create(KURL) would allow this creation to proceed as a tuple origin ("protocol", "", 0). The allowance of local+nonstandard schemes seems to be necessary, at least temporarily, to avoid breaking the Android-only "content:" scheme, and the ChromeOS-only "externalfile:" scheme. Other nonstandard schemes shouldn't generally commit, but this does seem to be possible via LoadDataWithBaseUrl; for example in the test "NavigationControllerBrowserTest.CrossDomainResourceRequestLoadDataWithBaseUrl" BUG=862282 Change-Id: I351a067521cd846d2c77cca2498e58580613b4e2 Reviewed-on: https://chromium-review.googlesource.com/1208811 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#589671}
-
Luke Halliwell authored
Fixes a NOTREACHED crash on eng builds whenever you touch the screen. Bug: internal b/112437110 Test: touch screen on eng build Change-Id: Iab827b9943df6869a919443b43bfd2eba43da3fc Reviewed-on: https://chromium-review.googlesource.com/1211707 Commit-Queue: Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#589670}
-
Peter Kotwicz authored
When resources for a screen density are missing in a WebAPK (e.g. the WebAPK only contains an icon for xxxhdpi), Resources#getDrawableForDensity() returns a scaled bitmap. On Android versions up to Android M, Resources#getDrawableForDensity() would sometimes return an incorrectly scaled cached bitmap instead of rerequesting the resource and scaling it for the passed in density. See the bug for more details. This CL moves the icons to the mipmap-nodpi folder in order to disable the automatic scaling when requesting a resource. The scaling now occurs inside of ImageView. The move fixes the caching bug. It also increases how often we use the webapp_splash_screen_no_icon.xml layout on high density devices. In particular, if the WebAPK only has a 144x144px sized icon on xxxhdpi devices: Prior to this CL: We used webapp_splash_screen_small.xml and upscaled the icon. With this CL: We will use webapp_splash_screen_no_icon.xml BUG=879194 Change-Id: I3c87898ca39cc7a47b614d4b219aee5f1e41ce74 Reviewed-on: https://chromium-review.googlesource.com/1199768Reviewed-by:Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589669}
-
sebsg authored
CL was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1214105 The issue was another CL that renamed a function landed at the same time. It used to get the Primary Account's email but should get the active account's one instead if in Butter state. Bug: 881730 Change-Id: I9b5b489bc5237d044e7e36fde5eda7f7da7ada27 Reviewed-on: https://chromium-review.googlesource.com/1214063 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589668}
-
Ben Kelly authored
This change modifies the disk_cache API to support 64-bit cache sizes. Individual entries are still limited to 32-bit sizes. The blockfile and memory backends will enforce a 32-bit cache size limit at runtime. The simple backend is currently the only implementation that fully supports 64-bit cache sizes. R=jsbell@chromium.org, morlovich@chromium.org Bug: 653630 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo Change-Id: I9278b9e14e0a3253a66d20e57cf77026a462b4ac Reviewed-on: https://chromium-review.googlesource.com/1194508 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#589667}
-
Chris Lu authored
MDCAppBar will be deprecated soon, so eliminating any existing imports now will prevent errors later. Bug: 874471 Change-Id: I67073fc90e935daee1c55d94db84eced20062999 Reviewed-on: https://chromium-review.googlesource.com/1213373Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#589666}
-