- 09 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e09869ed5268..e16a901fb853 git log e09869ed5268..e16a901fb853 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 bryan.bernhart@intel.com D3D12: Move resource into allocation handle. 2019-10-09 enga@chromium.org Skip tests if no adapter is available 2019-10-09 cwallez@chromium.org Make the dynamicOffsets optional in SetBindGroup. 2019-10-09 rharrison@chromium.org Roll ahead to fix and update .gni to unbreak shaderc Created with: gclient setdep -r src/third_party/dawn@e16a901fb853 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: If1ed302990f0efa3c15ef98d7ebb7d0b31b3cc3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849588Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704270}
-
Jasper Chapman-Black authored
No-Presubmit: true Bug: 1011921 Change-Id: I7726c1100978d0cbc73e62d2f2ef39f8f1bdf98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849941 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#704269}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f86cc6ba6a29..bc88fe8e4a2c git log f86cc6ba6a29..bc88fe8e4a2c --date=short --no-merges --format='%ad %ae %s' 2019-10-09 lamontjones@chromium.org trigger_cr50_signing: use compiled build api. Created with: gclient setdep -r src/third_party/chromite@bc88fe8e4a2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib33ade87bc750b87756dc683c988ae314151f0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704268}
-
Steve Kobes authored
This partially reverts crrev.com/700726, which removed the threshold, and caused significant perf benchmark regressions (see linked bugs). The test that verified the existence of the threshold is not restored, since we no longer intend to spec this behavior. Bug: 1003893,1009569,1009641,1009801 Change-Id: I284e53ba1f4c4c36cfcb2b54eaf5122758530c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848899Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#704267}
-
Peter Kasting authored
This is hopefully unnecessary now, and causes problems for views that paint to a layer and outlive their windows. Bug: none Change-Id: I211e30550af9923bca821e3d7a65b8e112211185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848911Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#704266}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1007760 Change-Id: I682335ec1e5b64a1b8523be7b05e551d3b0e56eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849483 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#704265}
-
Alexander Timin authored
Delete RenderFrameHostTester::SimulateNavigationStop as all relevant work should be done automatically by NavigationSimulator. R=clamy@chromium.org,ahemery@chromium.org TBR=mmenke@chromium.org,csharrison@chromium.org, BUG=1011770 Change-Id: I48009cc5b1c4e018626121cbf904c63e4af2000e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834150 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#704264}
-
Maks Orlovich authored
Change-Id: I41e011a0fae441369f4ca0474ba1706246803cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849120Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#704263}
-
Sahir Vellani authored
Updated thumb position calculation in GetScrollOffsetForDragPosition to yield 1.0 if the thumb position is calculated to be > 0 and < 1. Added more test cases in mouse-scrolling-on-div-scrollbar to test scroll offset when scrollbar is dragged some portion along the track. Bug: 1009892 Change-Id: I3a649c583dcb025773511619fce7564e71ccd131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833791 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704262}
-
Charlene Yan authored
Also migrated off HoverButton. Bug: 1003911 Change-Id: If60bee2739530094e95fbe06584706a13f979ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846086 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704261}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=mek@chromium.org Bug: 1007760 Change-Id: I6bf1a807b55ea0c6075a1fdf6b4a7a5a77f92789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849544 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#704260}
-
Dominic Mazzoni authored
Bug: 999236 Change-Id: I85ebdf7da06874cb55672fab6ec7071144858418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825958Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#704259}
-
chrome://omniboxmanuk authored
Above each response, the debugs page displays result details including: 1) cursor position 2) elapsed time 3) all providers done 4) host 5) has isTypedHost These are updated when inputting into the HTML omnibox, but when inputting into the window omnibox, only (3) is updated correctly. This CL: 1) Updates the 5 fields when inputting from the window omnibox. 2) Adds 'input type' (e.g. URL). 3) Wires in cursor position similar to the other 4 fields from the page handler and removes the hacked cursor position wired in from query inputs. 4) Updates the label for (5) to 'is typed host'. 5) Rearranges related variables to be consistent between files. Bug: 1011632 Change-Id: I830b4af3d01d18faafbdaaeaea8614624a401c4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846311Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#704258}
-
Will Harris authored
This CL contains no functional changes, but unblocks work on OSCrypt. BUG=1012495 Change-Id: If50354853c4d2fa287acadf45a6937c15a38809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848575Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#704257}
-
Justin Cohen authored
This reverts commit 8f80402d. Reason for revert: broken downstream tests Original change's description: > [multiball] Replace AppDelegate's window with Scene's window. > > Adds |window| property to SceneState. It is backed by SceneDelegate's > |window| property and by UIWindowScene's |scenes| property on iOS 13 > with multiwindow; or with an ivar otherwise. When it's an ivar, > SceneController is now responsible for window creation. > Note that the getter for AppDelegate's window remains for iOS 12 compat. > Note that the window is always a ChromeOverlayWindow. > > have tested it manually on my machine and it still works) > > Bug: none > Test: verify that the incognito screenshot blocker works as expected (I > Change-Id: Ic418ece228854e43aa0e4c9d9e503c1b54bca901 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827373 > Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701569} TBR=marq@chromium.org,stkhapugin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1012794 Change-Id: I895ea478396be1db4265b8a092d6b12fed76bc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849432Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704256}
-
Connie Wan authored
Rather than repainting the active tab always, only repaint it in the situations when it's needed: 1) if it's added to a new group (since in some cases the tab will not move, and therefore will not be repainted), and 2) if the group color changes (since again this doesn't cause relayout and may not cause repaint). This significantly reduces the CPU that tab groups uses. With just 1 tab, it was a difference of ~0.3% CPU w/o groups vs. ~1.4% CPU with groups (at least on my machine, with a local build). Now both are comparable at ~0.3%. Bug: 1009138 Change-Id: Iab07698de2711af936e25002ee9deab2f916ac82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845825 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#704255}
-
Tibor Goldschwendt authored
We don't forsee that being used. Thus, remove code and reduce maintenance burden. Bug: 1012714 Change-Id: Ia3d93513c39f67e4a1c120e6b0688b4734a0aba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849940 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#704254}
-
David Roger authored
This CL saves the identity pill animation time in a user data attached to the profile, and a histogram that records how long after the animation the button was clicked. This will allow to confirm whether users tend to click more on the button after the animation. This information is also used to show the identity pill only at Chrome startup, as opposed to every window creation. Bug: 1009441 Change-Id: Icbfa9a3175340eca42d1686a93499991e1897a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844988 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#704253}
-
Andrew Grieve authored
Change-Id: Icb892aa6fec0fd5f38582f604bbe8e81bcfccdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849097 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704252}
-
Nico Weber authored
Bug: none Change-Id: I90e76f3c0c441fbbb32449cb7a85c8da774e643a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849122Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#704251}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=mlamouri@chromium.org Bug: 1007760 Change-Id: Ic923e29d988364e6e5eb31ee37e5bc2c6d77d501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849479 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#704250}
-
Jonah Ryan-Davis authored
large-uniform-buffers.html is now passing after a fix in ANGLE. Bug: 906683 Bug: angleproject:3388 Change-Id: I3cfeb9a3a3aa0290da019077c10032f9f6c3df84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848419Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#704249}
-
Friedrich Horschig authored
This CL adds the TextView showing the origin for PSL matched credentials if there is one. Colors, height and margins are adjusted accordingly. Screenshots (one for eliding, one for a simple label are in the bugs). Bug: 1011833,1012184 Change-Id: Ie6968579557aafc70e9ed0ce1d2cba90e4e3d193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848389 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#704248}
-
Xianzhu Wang authored
1. Switch ScrollbarLayerInterface to ScrollbarLayerBase which is in the layer class inheritance hierarchy, to avoid the need of ScrollingCoordinator::ScrollbarLayerGroup. I think we added ScrollbarLayerInterface when we might have different parent layer class for the different scrollbar layer classes. This is no longer the case. And that won't be the case for crbug.com/1009291. 2. Remove SolidColorScrollbarLayerImpl's is_overlay parameter because it's only for overlay scrollbars in real world. Bug: 1009291 Change-Id: If12422481330b1d778899180c1147d52948fce8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845489 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704247}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e1092c0bc8b8..955f8fd0477e git log e1092c0bc8b8..955f8fd0477e --date=short --no-merges --format='%ad %ae %s' 2019-10-09 perkj@webrtc.org Add virtual method rtcp::RtcpPacket::SetSenderSsrc 2019-10-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b2d00427..8e1616e4 (703937:704145) 2019-10-09 aleloi@webrtc.org Removing outdated tests. 2019-10-09 peah@webrtc.org AEC3: Send the spectral power estimates for all channels to AecState 2019-10-09 nisse@webrtc.org Delete large up-front allocation in LibvpxVp8Encoder::InitEncode 2019-10-09 gustaf@webrtc.org Run fullband processing at output rate on ARM 2019-10-09 peah@webrtc.org AEC3: Remove redundant class 2019-10-09 eshr@google.com Add Duration field to EventRateCounter 2019-10-09 saza@webrtc.org Delete AecState::EchoPathGain() Created with: gclient setdep -r src/third_party/webrtc@955f8fd0477e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:1012256,chromium:b/130016532 Change-Id: Iff2a55dcd7c672360792f55bb79fb7b6173ea188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704246}
-
Aaron Colwell authored
- Adds logic to CPSPI::CanCommitOriginAndURL() to verify opaque origin precursor info and documents exceptional cases that need followup work. - Extended URL origin check and "same origin" checks in CPSPI::CanCommitOriginAndURL() to apply to all URLs instead of just "standard" URLs. - Updated RFHI::CanCommitOriginAndURL() origin check for debug URLs to also apply to opaque origin precursors. - Update DocumentLoader::FillNavigationParamsForErrorPage() to force the error page commit origin to be an opaque origin with precursor info that matches the original document's origin. This ensures that the error page origin will be consistent with the process lock of the process that the error page is displayed in. Bug: 991607 Change-Id: Iec661e29880fcaf8e066bb2f1c3e5e6cf292decb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837093 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#704245}
-
Brandon Goddard authored
In the network tool, selecting the "Group by Frame" option will group several requests under their parent iframe. When navigating the network data grid using a keyboard, reaching a group frame node with the arrow keys will cause the node to expand and collapse instead of select. This prevents navigation to the children or the rest of the requests under the table. This CL addresses the issue by allowing selection of group frame nodes. Since selection === open the sidepane, the group frame node defaults to displaying the first child request in the sidepane when selected, Similar to how the waterfall column displays Also, Clicking on a group frame node name now selects instead of expanding. The node can be expanded by clicking in the "disclosure" triangle to the left of the name, which is the behavior in the rest of the datagrids in the devtools. Before: https://imgur.com/gMGgTkd After: https://imgur.com/AyMHnba Bug: 1007508 Change-Id: Ibb4063e90aefde96129108e7e44b76cac611741e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823721Reviewed-by:
John Emau <John.Emau@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704244}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd575424..0aff71c3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b58fdbd5d6b60ff5417b8f73c8021f5e402fecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850071Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704243}
-
Lily Chen authored
Previously this method was virtual, and the default implementation just did nothing. However this would cause the unique_ptr argument to just be destroyed, and that was causing segfaults in tests which tried to hold onto the pointer to the delegate (and use it to set expected values, etc.), if the CookieStore they were using had the default implementation. This change moves the implementation of SetCookieAccessDelegate from CookieMonster to its base class CookieStore, and stores the delegate in the base class itself, to avoid this problem. Bug: 978172 Change-Id: Iee2c2ee7a5edae9e98266a7c4d38774f5babb3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849114Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#704242}
-
Robert Ogden authored
Bug: 1011457 Change-Id: I2ce266270a5189bb3dc4d09de2d193b3d0737209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846042Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#704241}
-
John Budorick authored
https://ci.chromium.org/p/chromium/builders/ci/android-avd-packager/8 Bug: 922145 Change-Id: Ibad4b68179f4a8fc63ae3cbfed43411a22ad63a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849192 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704240}
-
Lorne Mitchell authored
Modified Action.title() to only call ls() on the options title property. Previously it would call ls() on the title property of Extension.title(), which already calls ls(). This resulted in a duplicate call. Bug: 941561 Change-Id: Idc8d5da56c2ddd219234beb148d3eddd8fb6edd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838700 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#704239}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d903e9334991..b91063d99c88 Created with: gclient setdep -r src-internal@b91063d99c88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I987eca61b32b4b0cffe822d4b7a0a644806debbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849263Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704238}
-
Jakob Gruber authored
V8 will shortly drop this script. Import our own copy in mojo/public/tools/ and use that for mojo's build. The concatenate-files.py script is copied, modulo license header, from V8's tools/ directory. Bug: v8:7624 Change-Id: I07c6a64f061c3957002ca6f2c83c7f93b3ec009d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845764Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#704237}
-
zhaoyangli authored
"automation_action.mm" implements autofill automation actions for iOS through earlgrey framework. This change makes it fully EG2 compatible. This is part of autofill automation framework EG2 migration. - Removed unused headers and changed headers for EG2. - Changed web view test util method calls to methods in chrome_matchers and chrome_actions which are EG2 compatible. Bug: 987646, 1003605 Change-Id: Idad2a2fbe68436cccd623c92044b46f0137f32d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847904Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#704236}
-
Xianzhu Wang authored
Previously RWHV::SetSize(gfx::Size(800, 600)) at the beginning of a web test didn't work on Mac if the previous test synchronously set renderer window size (which didn't affect browser window size), because the call was a no-op due to the early return in the function when it found that the new size was the same as the old size. This left some inconsistent state caused by the previous synchronous resize persist until we changed the window size to another value. Now to ensure RWHV::SetSize() to reset the previous state, we call it twice, first with a different value, then with the desired value. This reduces number of unexpected flaky tests on mac-rel from about 300 to about 180. Bug: 1011191 Change-Id: I00fe653f5c44639d2a841bb5d4db779be0da6147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845479 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#704235}
-
David Narsiya authored
This is a reland of 78b72848 There was a problem with dependencies when "base/stl_util.h" was included in generated file, so I removed this include and solved problem of generating kAllEnginesLength variable differently. Original change's description: > Added behaviour to generate array of search engines > > All search engines are described in prepopulated_engines.json. In > template_url_prepopulate_data.cc there was an array kAllEngines > consisted of them, created by enumeration. There is a danger of > modifying prepopulated_engines.json without modifying this array. This > changes contain automatical generation of kAllEngines. > > Change-Id: Idc78552372f73b07fc7070fff66c000a30c6a6ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807312 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> > Cr-Commit-Position: refs/heads/master@{#701133} Change-Id: I9f68f2c6b408e50041680b6972ccb736aec840b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832272 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#704234}
-
Michael Lippautz authored
The previous implementation of using a trait had the problem of not being able to override already instantiated templates. Rely on a different type "v8::TracedReference" instead that does not come with a destructor. Bug: 995684 Change-Id: Ia6d5ae1964b47e7460f76aa5df154f1b4d0c63d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848011 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#704233}
-
Emil A Eklund authored
Bug: 1011885 Tbr: cbiesinger@chromium.org Change-Id: Id4186d64cef5eac6e4c0868dbe2a30fe3c129ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846568Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#704232}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8e7d9d6c2326..ef4c25e71c32 git log 8e7d9d6c2326..ef4c25e71c32 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 geofflang@chromium.org GL: Skip buffer validation for transform feedback buffers. Created with: gclient setdep -r src/third_party/angle@ef4c25e71c32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ia4d7515f2a0d21d53007a83f76c7585588f0ab72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849262Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704231}
-