- 21 Sep, 2019 8 commits
-
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/08a6c955af00..e3f2f7bd0ddd $ git log 08a6c955a..e3f2f7bd0 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 fayang relnote: On server side, do not process the first initial QUIC packet received from a client if the UDP datagram is < 1200 bytes. Instead, send a connection close with PROTOCOL_VIOLATION if the version is supported. Protected by quic_reloadable_flag_quic_donot_process_small_initial_packets. 2019-09-19 nharper Don't create NullEncrypter/Decrypter in QuicFramer 2019-09-19 ianswett Remove obsolete comments from QuicDispatcher. 2019-09-18 ianswett Shorten names of UberQuicStreamIdManager methods. 2019-09-18 dschinazi Fix QUIC core test display Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I8ac7823ea7dd5d8165c597da64e7b8cf526e80b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815886 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#698688}
-
Taylor Bergquist authored
Tab drag sessions need mouse capture to function; losing capture therefore ends the drag. There are, evidently, some cases where SetCapture() can cause the drag session to lose capture, thereby ending the drag as it's beginning. Bug: 964322 Change-Id: I6bcd53f04aefb7461e6c28abf1085df1a012545a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817211 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#698687}
-
Steven Bennetts authored
This eliminates everything in cr_onc_types.js except for CrOncStrings and moves that to cr_onc_strings.js. This also includes some additional minor cleanup to reduce the use of networkingPrivate and its types. Bug: 1001598 Change-Id: I8e848657a3190354ae6baa85f91da0922b59d665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808316 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#698686}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/38b295de3851..0c4d75931a0f git log 38b295de3851..0c4d75931a0f --date=short --no-merges --format='%ad %ae %s' 2019-09-20 bsheedy@google.com Disable BufferSetSubData.ManySetSubData on Metal Created with: gclient setdep -r src/third_party/dawn@0c4d75931a0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ib200b33393a0cfa2f6c9baedd57179205bf3c8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815596Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698685}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2ef66b69cea5..1f89f58faeb8 git log 2ef66b69cea5..1f89f58faeb8 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 jmadill@chromium.org Do not call Scheduler destructor in libVulkan. Created with: gclient setdep -r src/third_party/swiftshader@1f89f58faeb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141380274 Change-Id: Ic55c236e22edc71668ddccd5cab3a2f5e3f5078e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817277Reviewed-by:
-
Rayan Kanso authored
- Make the ContentCategory optional. - Rename getDescriptions to getAll. Bug: 973844 Change-Id: I05817729e508b916fbc2e3ef84e0da839dc718d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793163Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#698683}
-
Ben Joyce authored
Bug: 896755 Change-Id: If714651fa1a4fa0fadf78f106f22d25f6eb9d13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789428Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#698682}
-
Malay Keshav authored
The device scale factor set for the 320 and 220 DPI are off by a fraction and hence do not match the entries in the display zoom table. This patch fixes it. Bug: b/141325696 Change-Id: Ib4c5effb66bee7e1e360cfdf724d8100a10cd702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815353Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#698681}
-
- 20 Sep, 2019 32 commits
-
-
Anastasia Helfinstein authored
Performing the standard action "showContextMenu" on an automation node currently does nothing. This change removes it as an option so as not to slow down navigation without adding value. Bug: None Change-Id: Ia677d8236840580fc153b5e6799055b87ea66504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814639 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#698680}
-
Henrique Ferreiro authored
Convert the implementation and all users of the content::mojom::BrowserTarget interface. Bug: 955171 Change-Id: I08eaa10a37dca519bb7952cc88985fbd468186a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800665Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#698679}
-
Erik Chen authored
This CL has no intended behavior change. It updates RenderViewImpl::Send and RenderViewImpl::PrintPage. Previously, Send() had a RenderWidget::is_closing(). This is unnecessary since destruction of RenderViewImpl is now synchronous, see Destroy(). Bug: 912193 Change-Id: I828d58a458956ba2569f94d72b7f86d653519e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815499Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698678}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aa1b7640..39f2488b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7b79a350aaf8330e2d5abc981ad551e254a67589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817080Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698677}
-
Michael Crouse authored
Change-Id: I8b484bd4d68c72adc5ef453f2a8e0969aeb5eea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815577 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#698676}
-
Nick Diego Yamane authored
So far, KeyEvent's DomKey extraction used to happen lazily at GetDomKey()/GetCharacter() calls. Such approach assumes native_event() is available and holds the underlying XEvent instance so it is able to extract event info straight out of it. Document [1] details the effort to eliminate native event usage outside platform code so that it is possible to migrate Aura/X11's PlatformEvent away from XEvent* to ui::Event instead (part of broader X11 migration to Ozone). This issue addressed in this CL is one those remaining cases listed in doc [1]. CL modifies it to extract DomKey value at KeyEvent construction as it is done in most Ozone backends (e.g: ozone/evdev). Additionally this modifies X11EventSourceDefault, currently used by Ozone/X11, to do the same. [1] https://docs.google.com/document/d/1Neh2p6f8pew9SPuEAtnJMafozAY7uhAIfhwd43CLETc Bug: 987939 Change-Id: I9dddad2359b1c345fcb98dabce4506c677269b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813417 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#698675}
-
Toni Barzic authored
In tablet mode, if onscreen keyboard is shown and then hidden while app list is being dragged, the app list window boudns get misplaced. The reason is that when the keyboard is hidden, the app list bounds are restored to the bounds set before the keyboard was shown - which might not be the intended bounds if the app list view chnaged its position in the mean time. Similar issue that ocured when switching to tablet mode while onscreen keyboard was shown with the app list in the search state. This issue was fixed by clearing wm::kVirtualKeyboardRestoreBoundsKey window property on tablet mode change. This CL extends that approach by clearing the property when the on screen keyboard gets hidden, and then calling SetState to ensure the app list view is updated to match the current state. Also, avoids clearing app list widget transform when the keyboard is hidden unless necessary (i.e. when UI was translated up to ensure the folder header input is visible with the keyboard on screen), as that might mess with the app list position during drag in tablet mode (which is implemented using layer transform). BUG=1004390 TEST= 1. Enable a11y keyboard, show applist, and start typing in the search box - the virtual keyboard should get shown. Switch to tablet mode, and hide the keyboard - the search box widget (and search results view) should stay put. 2. Switch to tablet mode, and start dragging the app list down. In the middle of the drag tap the search box (this should activate app list search, and cause virtual keyboard to pop up). Drag the app list up (and/or end drag), and hide virtual keyboard - the app list UI should not jump down. Change-Id: I7217bd60c5bede7b54485fd56aa8716ab65a508f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815907Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#698674}
-
Daniel Libby authored
crrev.com/c/1774911 changed how the first scroll update is detected. That information is consumed in order to determine whether or not a scroll update event should get queued and dispatched on the next begin frame, or if it should be dispatched immediately. The refactoring had a logic bug because it was trying to detect GSB within the block of has_ongoing_compositor_scroll_or_pinch_ and thus the flag was never reset. This wasn't caught by the unittest for this behavior since the flag was initialized to false in the constructor. I'm adding another scroll begin update sequence to the unittest so that we have coverage on the state transition. Bug: 1002045 Change-Id: I781d782de794ccb0639d972325a4579e1c61abe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816360 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#698673}
-
Ryan Hamilton authored
Change-Id: I152b0cc50fab5a8ec20e730238558a62a163eb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815938Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#698672}
-
Evan Stade authored
Bug: none Change-Id: If5638142eff88e547ba37fe9288faf9be7cdc286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814869 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#698671}
-
Erik Chen authored
Previously, RenderFrameProxy always relied on existence of a RenderWidget. This CL updates RenderFrameProxy to not have a RenderWidget if the proxy is for the main frame, or a subframe of a remote main frame. Change-Id: Ia24cd85276df77d835e723563fd25de9c4c8be5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809514 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698670}
-
Sophie Chang authored
This is in preparation to support fetching hints for users with the "Make searches and browsing better" setting No functional changes - my plan is to share the site engagement logic and evaluate different blacklist prefs for the different consent models Bug: 1005279 Change-Id: I1844a5e0e7d983ef90318c76a859bc8a65ffb9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816957Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#698669}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6f647b543901..11b57f8d09f5 git log 6f647b543901..11b57f8d09f5 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 seanabraham@chromium.org Revert "cros_mark_as_stable: Add auto_merge for server-side rebase." Created with: gclient setdep -r src/third_party/chromite@11b57f8d09f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic6addcb366352fadcf55f4db80d600e3b2be2f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815595Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/410cf3af9982..d4d1ba4971aa git log 410cf3af9982..d4d1ba4971aa --date=short --no-merges --format='%ad %ae %s' 2019-09-20 ehmaldonado@chromium.org git-cl: Use buildbucket v2 to schedule try jobs. Created with: gclient setdep -r src/third_party/depot_tools@d4d1ba4971aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:976104 Change-Id: I31da36727b1d0e0ac4f56996b86f1ddd82c7085a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815833Reviewed-by:
-
Miguel Casas authored
This CL migrates MailboxVideoFrameConverter from using Textures to using SharedImages. No external functionality changes are expected. Couple of things need to be added: - ScopedSharedImage: an internal class to scope a SharedImage lifetime. SharedImages are kept in |shared_images_|, indexed by a unique id. - Added GetGpuChannelCB that can be derived from the GetStubCB and that is needed for SharedImage creation and destruction. They are generated on Create(), so this interface doesn't change. - This CL uses a WeakPtr to the GpuChannel, accessing its SharedImageStub and the gpu::Scheduler that way. Most of the work goes in: - InitializeOnGpuTaskRunner() and then - the sequence ConvertFrameOnGPUThread() (calls either GenerateSharedImageOnGPUThread() or UpdateSharedImageOnGPUThread()) then jumps back to WrapMailboxAndVideoFrameAndOutput(). Test: crosvideo.appspot.com resolution-changing videos (vp9, h264, vp8) of course with the new VD decoder, on kohaku and scarlet/dru. Bug: 998279 Change-Id: Ic9b5b2270d1b488562bc2725bba89dc2a0350012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772642 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#698666}
-
Matt Menke authored
The class has a per-server cache that could be used for fingerprinting. As it's defined outside of net/, rather than make QuicCryptoClientConfig NetworkIsolationKey-aware, this CL has QuicStreamFactory create one QuicCryptoClientConfig per NetworkIsolationKey, as needed. Once there are no live QuicSessions/QuicStreamFactory::[.*]Jobs using a particular QuicCryptoClientConfig, the QuicCryptoClientConfig is added to an MRU cache of recently used configs, and reused/evicted as needed. This CL also passes in a NetworkIsolationKey to the HttpServerProperties::*QuicServerInfo calls, to finish hooking up NetworkIsolationKeys to HttpServerProperties. It's needed in this CL because the only integration tests for QuicCryptoClientConfig rely on those methods. Bug: 1003423, 969890 Change-Id: Id1823012104b84677f6684205bb58fa0227825b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809601Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a75fd3592a81..7c07ddc63030 Created with: gclient setdep -r src-internal@7c07ddc63030 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1003454 Change-Id: Ifa7e52e3e9e210060e71b4c41fb911da72dec4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815834Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698664}
-
James Cook authored
These were added to support mustash/mash but we're not doing that project any more. aura::client::kMinimumSize is written, but the value is never actually used to apply a constraint. aura::client::kMaximumSize is never used. This CL is a partial revert of: [mus+ash] Fixes minimum browser window size with --mash https://codereview.chromium.org/2914793005 Bug: 728455 Test: existing unit tests and browser tests Change-Id: I0733ca35ddd4cec7ba04e11d47189d40549248f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815726 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
-
Sven Zheng authored
All new live tests should inherit from LiveTest. Bug: 992143 Change-Id: Ic8f0d05275a2f3fd4ab8eec40d8cb21c5215f8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767087Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#698662}
-
Ana Salazar authored
The page switcher buttons on the folder view didn't show the ripple effect when hovered, as opposed to the page switcher on the app list. This change adds the effect to be consistent Bug: 998388 Change-Id: I49e48680a9bb4106e069c0e031b1e43c7c120794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816982 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#698661}
-
Steven Bennetts authored
Bug: 1001598 Change-Id: I93286efb961af979168f011360dd0329aa23ce9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803787 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Peter Boström authored
Makes sure this class is not instantiated during the kExtensionsToolbarMenu experiment. Also clearly documents that we expect this class to be removed once the experiment is launched. Bug: chromium:985834 Change-Id: Ic9cd2bb03cba4a3765317cb6d67bf7a2676e418c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814661 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#698659}
-
Gavin Mak authored
Currently, common.py uses the capability 'loggingPrefs'. Since ChromeDriver 75.0.3770.8, this name has been renamed to 'goog:loggingPrefs' as required by W3C standard. 'goog:loggingPrefs' has been changed to be the default capability. The flag --ignore_logging_prefs_w3c enables the 'loggingPrefs' capability instead. Bug: 1004566 Change-Id: Ib6b8f3260560ce48471952946fc2b98849157b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808088Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6b921b7e4add..942d69fa9d5f git log 6b921b7e4add..942d69fa9d5f --date=short --no-merges --format='%ad %ae %s' 2019-09-20 ethannicholas@google.com Revert "Fixed GLSL ES compilation error in GLTestAtlasTextRenderer" 2019-09-20 ethannicholas@google.com Fixed GLSL ES compilation error in GLTestAtlasTextRenderer 2019-09-20 bsalomon@google.com Check for scratch textures in GrResourceProvider. Created with: gclient setdep -r src/third_party/skia@942d69fa9d5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:1005237 Change-Id: I4b656d62de889c974622d551cc7cb73cea34fb44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815831Reviewed-by:
-
Manu Cornet authored
This is mostly useful for tests where the display ID starts off as this invalid ID. Not adding a unit test in this change because after CL 1814222 at least two tests will fail if this regresses. Bug: 982512 Change-Id: Ie447aa88fda66794a722d7e9cf478749ff4f8398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816734Reviewed-by:
-
Miguel Casas authored
Original CL got reverted due to breaking ChromiumOS ASAN and Linux ChromiumOS MSan builders: [48790/51498] LINK ./content_shell FAILED: content_shell ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecsta...(too long) ld.lld: error: undefined symbol: media::ChromeosVideoDecoderFactory::GetSupportedConfigs() >>> referenced by gpu_mojo_media_client.cc:162 (../../media/mojo/services/gpu_mojo_media_client.cc:162) >>> services/gpu_mojo_media_client.o:(media::GpuMojoMediaClient::GetSupportedVideoDecoderConfigs()) in archive obj/media/mojo/services/libmedia_mojo_services.a clang: error: linker command failed with exit code 1 (use -v to see invocation) Cq-Include-Trybots:luci-chromium-try:linux_chromium_chromeos_asan_rel_ng;luci-chromium-try:linux_chromium_chromeos_msan_rel_ng Original CL description ---------------------------------------------- This CL restricts //media/gpu:image_processor and :video_frame_mapper to ChromeOS and ChromeCast, since they are only implemented for these platforms. Same for image_processor_test. video_frame_file_writer.cc sandwiched some uses of |video_frame_mapper_| in an OS_LINUX and left others unprotected, which confused OS_WIN builds. This CL changes those to if defined(OS_CHROMEOS), since I don't think this file is meant to be compiled nor run on OS_LINUX. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787467 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#698566} Bug: 1006266 Change-Id: I6c9982015829863694e9f48815105f371548f9a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816799Reviewed-by:
-
Miyoung Shin authored
This CL converts IdentityAccessorPtr and BindingSet<IdentityAccessor> in chromeos and services to the new Mojo type. Bug: 955171 Change-Id: Icb122470713bd84a6718483853f50aff45df1b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810449Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#698654}
-
Robert Ogden authored
Bug: 1005295 Change-Id: Ie301aae1507a6fa0f020fe302386458d924c4256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811959 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/234dcc192464..2ef66b69cea5 git log 234dcc192464..2ef66b69cea5 --date=short --no-merges --format='%ad %ae %s' 2019-09-20 natsu@google.com [android] Add missing lib to _common_debug target Created with: gclient setdep -r src/third_party/swiftshader@2ef66b69cea5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/138239233 Change-Id: Iaf3329e4dec9b913c116d6044983eedf216e7644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815829Reviewed-by:
-
Kelvin Jiang authored
This CL removes the NONE action type. Instead of returning a vector of one action with the NONE type, RulesetManager::EvaluateRequest will instead return an empty vector if no DNR rules match with the request. Bug: 1004006 Change-Id: I7dc2b7b59540f3d185b9585e530818f92e6201b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809882Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#698651}
-
Avery Musbach authored
The present CL rids ShellObserver of OnSplitViewModeStarted and OnSplitViewModeEnded, because they are not especially conducive to the plan that each RootWindowController shall have its own SplitViewController which shall have its own observers. Bug: 970013 Change-Id: Ic7fbf7b4cad35d148928b03142bf0a892c5742cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811643 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
-
Toni Barzic authored
AppListFolderView should ensure it respects apps container margins when shown with ScalableAppList feature enabled, in particular it should ensure its bounds do not overlap with the search box widget. It was using search_box_fullscreen_top_padding() to determine search box location, but this does not work correctly for ScalableAppList - when the feature is enabled, use AppsContainerView::CalculateMarginsForAvailableBounds to get the container margins. BUG=999273 Change-Id: Ie842da042cf6215fe9b1345229a1575d10ca55a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815581 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
