- 25 Sep, 2018 40 commits
-
-
Devlin Cronin authored
Gracefully handle null web contents in ExtensionActionViewController::GetIcon(). This can happen when TabStripModel::GetActiveWebContents() returns null. Add a regression unittest for the same. Bug: 888121 Change-Id: Iaf3194b3d0475314b9a953158951bd3cb23af503 Reviewed-on: https://chromium-review.googlesource.com/1242195Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593814}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Icbb9ffd719540844413717d14d0cb125177b5e36 Reviewed-on: https://chromium-review.googlesource.com/1242334Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#593813}
-
Eugene But authored
This argument has incorrect value when displaying SSL interstitial and during provisional navigation. This CL replaces RequestInfo::source_url usage with WebState::GetLastCommittedURL, which actually represents page URL. RequestInfo::source_url will be deleted in a separate CL. Bug: None Test: App Launcher prompt works correctly. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0e320bd2d68df9eb96f5ca71c6e764bb12c6e7f5 Reviewed-on: https://chromium-review.googlesource.com/1217583Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593812}
-
agrieve authored
This reverts commit a2136115. Reason for revert: Broke Cronet bot (see bug) Original change's description: > Network servicification of NQE in network metrics provider > > Use Network Quality Tracker (NQT) in network metrics provider > instead of the network quality estimator (NQE). > > NQT works when network servicification is enabled or disabled. > NQE works only when network servicification is disabled. > > Note that NQT is to be used on UI thread, while NQE was on > IO thread, which makes the code a bit simpler. > > Change-Id: If95a8882d578ef6d00ea1a51e4bc5a861b3a47a2 > Bug: 882482 > Reviewed-on: https://chromium-review.googlesource.com/1215371 > Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593566} TBR=rkaplow@chromium.org,tbansal@chromium.org,robertogden@chromium.org,ryansturm@chromium.org Change-Id: I339700eb7875d805413eddf3b5405243ad02a5c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882482, 888612 Reviewed-on: https://chromium-review.googlesource.com/1242198Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#593811}
-
Kunihiko Sakamoto authored
These will help to understand UA-side time skews. Design doc: https://docs.google.com/document/d/1kzQRLybaUk12UgG8YTyACwNZ7tpcXwdjzPXU3CV25J8/edit Bug: 863305 Change-Id: I61d900cc6e6dd7d64ef49cd534a1837cf6b47b1d Reviewed-on: https://chromium-review.googlesource.com/1237901 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#593810}
-
momohatt authored
ServiceWorkerNewScriptLoader uses an internal variable called |network_loader_state_| to control the state of URLLoaderClient. This state is changed from kLoadingHeader to kWaitingForBody at the end of OnReceiveResponse(). However, WriteHeaders() could call OnWriteHeadersComplete() synchronously and it calls MaybeStartNetworkConsumerHandleWatcher() when |network_loader_state_| is set to kLoadingHeader. And later OnStartLoadingResponseBody() calls MaybeStartNetworkConsumerHandleWatcher() again and hits DCHECK_EQ(kNotStarted, body_writer_state_). Change-Id: I3b9450ca53e6b98423d532ea02134d002d7753b6 Reviewed-on: https://chromium-review.googlesource.com/1237634Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Momoko Hattori <momohatt@google.com> Cr-Commit-Position: refs/heads/master@{#593809}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7f62e82c. With Chromium commits locally applied on WPT: 398ba6bd "service worker: Add WPT tests for resultingClientId." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25176 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm bjonesbe@adobe.com: external/wpt/css/css-shapes creis@chromium.org, lukasza@chromium.org, nick@chromium.org: external/wpt/fetch/corb ecobos@igalia.com: external/wpt/css/css-display foolip@chromium.org: external/wpt/fullscreen guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy jsbell@chromium.org: external/wpt/resources kojii@chromium.org: external/wpt/css/css-text/i18n external/wpt/css/css-writing-modes ksakamoto@chromium.org: external/wpt/resource-timing mkwst@chromium.org: external/wpt/x-frame-options mstensho@chromium.org: external/wpt/css/css-break rego@igalia.com: external/wpt/css/css-contain rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card external/wpt/payment-request yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ic3a05c47b49666a3614d28ffb45208cad3d910f7 Reviewed-on: https://chromium-review.googlesource.com/1242077 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#593808}
-
Justin DeWitt authored
Version as integer timestamp has problems when considering caching versions that are actually filtered dynamically on the server, so we switch to an opaque string version_token that the server can choose. Client loses the ability to determine if a new version is "newer" or "older" but this doesn't seem like much of a loss. Bug: 867488 Change-Id: I43fadaf2ccfecec8143f45473d1b863f38345cac Reviewed-on: https://chromium-review.googlesource.com/1241531 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#593807}
-
Tsuyoshi Horo authored
TBR=dmazzoni@chromium.org,dtseng@chromium.org Bug: 888824 Change-Id: Iec684ed1c801070ee2c1af5dcac39afee750910b Reviewed-on: https://chromium-review.googlesource.com/1242473Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#593806}
-
chrome://extensionsDevlin Cronin authored
Bug: 884878 Change-Id: I595c6c8f0a26db7ceafc4f08882c071233162eda Reviewed-on: https://chromium-review.googlesource.com/1242394Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593805}
-
momohatt authored
A variable named test_loader_factory, declared in SetUp() of the ServiceWorkerNewScriptLoaderTest is not used and therefore can be removed. Change-Id: I5d344dc6d29c5c473e62a76c6a1a005f3e6cc349 Reviewed-on: https://chromium-review.googlesource.com/1237693Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Momoko Hattori <momohatt@google.com> Cr-Commit-Position: refs/heads/master@{#593804}
-
Erik Luo authored
Bug: none Change-Id: Ib88d07f8a3456f1974db490980d14907cf774274 Reviewed-on: https://chromium-review.googlesource.com/1240714Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#593803}
-
Alan Cutter authored
The color of Ash app window title bar was changed to the same color of the settings app title bar accidentally in https://chromium-review.googlesource.com/c/chromium/src/+/1125512. This changed DevTools, the Terminal and Chrome App windows to be blue. This CL fixes the unintentional change in behavior by updating UpdateFrameColors() to use the same guard as CreateFrameHeader() when setting the frame color to kMdWebUiFrameColor. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359594&signed_aid=Yr-u3b9GUhWb0iEc6igy5Q==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359595&signed_aid=rfGnleo9Sj8jmcVXfDipeg==&inline=1 Bug: 879851 Change-Id: I8980b7f52f529390938a1a5ff05742b336e665d2 Reviewed-on: https://chromium-review.googlesource.com/1223951 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#593802}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5272a543705e..e2d2270a6f75 git log 5272a543705e..e2d2270a6f75 --date=short --no-merges --format='%ad %ae %s' 2018-09-25 jmadill@chromium.org Vulkan: Merge append/beginWriteResource. Created with: gclient setdep -r src/third_party/angle@e2d2270a6f75 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I8ca2a8236320efce9657032e82746edfdaa93e37 Reviewed-on: https://chromium-review.googlesource.com/1242313Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593801}
-
Jialiu Lin authored
Change from "AdvancedProtectionStatus" to "AdvancedProtectionStatusRollout" to match .../finch/gcl_studies/AdvancedProtectionStatus.gcl Change-Id: I364235ce83d1efa9c8f0230c8f5875f464b413db Reviewed-on: https://chromium-review.googlesource.com/1241954Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#593800}
-
Junliang Yan authored
As we decided to drop support for 31-bit s390 and 32-bit ppc, so those are cleaned up here. Change-Id: I400c88639c461de7380f59bfcb6a2900f4541972 Reviewed-on: https://chromium-review.googlesource.com/1240864Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#593799}
-
Ramya Nagarajan authored
Bug: none Change-Id: Ieefde51da92fd4f896007c07ee45321423360e83 Reviewed-on: https://chromium-review.googlesource.com/1241938Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593798}
-
Christopher Cameron authored
The feature has been around for a while, but having it in about:flags will help development along. Bug: 859152 Change-Id: I3da5fff7b57961f3c41a628c69a9b65b69122860 Reviewed-on: https://chromium-review.googlesource.com/1226298 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#593797}
-
Luciano Pacheco authored
Issue is explained here [1], in crrev.com/c/1237754 I changed this in the Files app, however the Polymer component is used in Audio Player, so moving the CSS fix to Audio Player. [1] - https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away Bug: 875525 Change-Id: Ideab2aa12fe6dcdfb5665be201e867687e046c50 Reviewed-on: https://chromium-review.googlesource.com/1239801Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#593796}
-
Luciano Pacheco authored
Bug: 875525 Change-Id: I81fd85c9636537f15735801ead680ef5d67c3bea Reviewed-on: https://chromium-review.googlesource.com/1237755Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#593795}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a85f3a138cbc..e514fa0f1a6c git log a85f3a138cbc..e514fa0f1a6c --date=short --no-merges --format='%ad %ae %s' 2018-09-24 brianosman@google.com Report "correct" color type for lazy images Created with: gclient setdep -r src/third_party/skia@e514fa0f1a6c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I60a0f82f40db8869cda99fff4049f8e6dd3e9bb8 Reviewed-on: https://chromium-review.googlesource.com/1241598Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593794}
-
Eugene But authored
This should dismiss ‘Add to Apple Wallet’ dialog as intended by BVC. Bug: 810379 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Id4cb59c20adb0730808ff47492653468f2a12d18 Reviewed-on: https://chromium-review.googlesource.com/1241934 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#593793}
-
Tom Anderson authored
This CL adds the initial wiring and observer interface for dynamic MD mode switching. Currently, parts of browser windows get a relayout when switching to/from tablet mode on ChromeOS, but there are still several imperfections that must be fixed by registering with the observer interface that this change adds. BUG=737995,881371 R=robliao,sky Change-Id: I0e2169850b32d3fe1c79a40a28654389293727e2 Reviewed-on: https://chromium-review.googlesource.com/1238546Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#593792}
-
Dmitry Gozman authored
We can do this from the worker thread itself now, since we have all the tokens available. Bug: none Change-Id: Ibc1f0de3bc46974dd8ec037226a4c610b2cb53bd Reviewed-on: https://chromium-review.googlesource.com/1232877 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#593791}
-
David Black authored
This code is never called as neither AssistantHeaderView nor AssistantMainStage have direct children whose visibility is modified. Bug: b:115784427 Change-Id: Ic89d0c809110d9059ee32c944c95ebcc5e21c448 Reviewed-on: https://chromium-review.googlesource.com/1241936 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#593790}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I2fb983c293be0f4290025e212139df64e9647791 Reviewed-on: https://chromium-review.googlesource.com/1242057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593789}
-
Sadrul Habib Chowdhury authored
Remove the various _per_second metrics in favour of the _per_frame metrics. (see linked bug for more details) BUG=888114 Change-Id: I95c8b547cfdf03414f9abaec7d32ceee907df687 Reviewed-on: https://chromium-review.googlesource.com/1235340Reviewed-by:
Victor Miura <vmiura@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#593788}
-
Josh Pratt authored
This CL skips parts of the uninstall flow if the Termina VM was not installed. This occurs if installation and uninstallation occurs offline. BUG=884284 Change-Id: I7e669605844b0914948bde792f67891e55ad0e7a Reviewed-on: https://chromium-review.googlesource.com/1233016Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Josh Pratt <jopra@chromium.org> Cr-Commit-Position: refs/heads/master@{#593787}
-
Daniel Vogelheim authored
This makes the header accessible to all platform clients. Preparation for https://crrev.com/c/1238465 Bug: 739170 Change-Id: Ia30feccae93704f734f0892a8f654f711e3f7251 Reviewed-on: https://chromium-review.googlesource.com/1240315 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#593786}
-
Martin Kreichgauer authored
CountWebAuthnCredentials counts the number of Touch ID WebAuthn credentials stored in the keychain for a given profile with a creation date in a given interval. This will be used to implement a counter label for these credentials in the browsing data deletion dialog. Bug: 879548 Change-Id: Iacac0ee3c13f69a0b7f9ea1c1f2e1b10f0ce949e Reviewed-on: https://chromium-review.googlesource.com/1239537 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#593785}
-
Robbie McElrath authored
This CL migrates ConnectionFactoryImpl from NetworkChangeNotifier to NetworkConnectionTracker, which works with the network service enabled. Bug: 883116 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I03a8004151d5750d2ba590d670ae41a3461be03f Reviewed-on: https://chromium-review.googlesource.com/1226074 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593784}
-
Peter Boström authored
Introduces a kHighlightPathKey property to views and uses it as a default for FocusRing and CreateInkDropMask in InkDropHostView. If no highlight path is added this fall backs to prior behavior, which allows introducing this change in parts. This highlight path is added to the bookmarks-bar buttons and the dialog close button. CreateInkDropMask and installing the focus ring is removed from the prior. Bug: chromium:861975, chromium:888204 Change-Id: I7eb682efe82caea7e8088d7277733698967d0234 Reviewed-on: https://chromium-review.googlesource.com/1239715Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#593783}
-
Karan Bhatia authored
This CL adds metrics for the action taken by the user through the extension icon context menu. BUG=885201 Change-Id: I5eb2261f493298667ec978d24e554b15814e5f84 Reviewed-on: https://chromium-review.googlesource.com/1239217 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593782}
-
Kyle Horimoto authored
This CL changes "@apply(--foo);" to "@apply --foo;" for all affected MultiDevice CSS. See [1] and [2] for context. [1] https://www.polymer-project.org/2.0/docs/upgrade#shadow-dom-styles [2] https://bugs.chromium.org/p/chromium/issues/detail?id=739532 Bug: 884058 Change-Id: Id7a0c3e479cae58bfea736093883c92ae44f1d61 Reviewed-on: https://chromium-review.googlesource.com/1242055Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#593781}
-
Alexey Kozyatinskiy authored
This test should not rely on stability of V8 sort algorithm. TBR=dgozman@chromium.org Bug: chromium:855582 Change-Id: Ia1678da6d4ba8a04d5b7135f34e1748632414720 Reviewed-on: https://chromium-review.googlesource.com/1242042Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#593780}
-
Xing Liu authored
This CL adds a metrics to records the type of directories shown to the users so we can analyze the percentage of users that have SD card as an option to download. Bug: 888619 Change-Id: Ifaee43b748bb7967ac321f5c53523d4ebe5e0ace Reviewed-on: https://chromium-review.googlesource.com/1240201 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593779}
-
Adrienne Walker authored
Bug: 590373 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7661646f0980a07f13f1376d34e9a6ef117bd13a Reviewed-on: https://chromium-review.googlesource.com/1229693 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593778}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2070a13fbde..d6b25c280cdc Created with: gclient setdep -r src-internal@d6b25c280cdc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I893a99ad45a157d1c40d08c1bc9cd275c5ac1ff5 Reviewed-on: https://chromium-review.googlesource.com/1241597Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593777}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/482d615b83e1..64b61330ec7f git log 482d615b83e1..64b61330ec7f --date=short --no-merges --format='%ad %ae %s' 2018-09-24 iannucci@chromium.org [led] Roll led to fix missing expiration_secs issue. Created with: gclient setdep -r src/third_party/depot_tools@64b61330ec7f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875089 TBR=agable@chromium.org Change-Id: I27e0bdd4fb470ecd7304c86c2c4563d2c0623c1e Reviewed-on: https://chromium-review.googlesource.com/1242054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593776}
-
Yue Cen authored
Fonts that are applied on different platforms: macOS - Menlo Windows - Consolas Chrome OS - DejaVu Sans Mono Linux - DejaVu Sans Mono This can help user distinguish some characters such as 'l' and 'I'. Bug: 768825 Change-Id: I74416fe4fc327ff992d162a7c4ad427c18ee07b5 Reviewed-on: https://chromium-review.googlesource.com/1220373Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#593775}
-