- 02 Mar, 2020 40 commits
-
-
Xing Liu authored
Disable flaky ConfirmManagedSyncDataDialogIntegrationTest# testDialogIsDismissedWhenRecreated. TBR=bsazonov@chromium.org Bug: 1054855 Change-Id: If4303f12d5aec847b7a2d23392dd7c895e767d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081521Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746131}
-
Moe Ahmadi authored
The PZPS header information is expected in the following format in the Chrome suggest response. Every suggestion with a header has a header group id in its respective "google:suggestdetail" dictionary which maps to a header text inside "google:headertexts>a". ... "google:headertexts":{ "a":{ "40009":"Recommended for you" } }, "google:suggestdetail":[ ... { "zl":40009 }, { "zl":40009 } ], ... This CL parses that information and adds the respective header as a |header| field on the first ACMatch in every group of adjacent matches with the same header, unless: 1) Matches with the same header are not adjacent to one another, i.e., are interleaved by matches with different headers or matches without one. 2) Matches without a header come after the ones with headers. Note that the headers do not determine classification or ranking of the matches. They are expected to be valid after the AutocompleteResult is finalized. These error conditions, however, are in place to safeguard the integrity of the displayed headers. Bug: 1052519 Change-Id: Ibbd3a812690605cd13763e41f109197ef75c1727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079303Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746130}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.25-1582540590-benchmark-82.0.4072.0-r1 to 82-4044.31-1583148634-benchmark-82.0.4072.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I68aad14edb2a7b81af241a78c3232471acdb6eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083854Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746129}
-
Brandon Wylie authored
When new tab pages are reparented, the view isn't loaded completely. New tab pages have their own logic to restore scroll position, which is the only outstanding state that would change between theme change. Bug: 1052246,1055228 Change-Id: I5c7b42f6daecc30a6499bcdf4bc6ded97795afab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067385 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746128}
-
Patrick Noland authored
In this design, the OptionalBrowsingModeButtonController queries individual providers and shows the provider with the highest precedence. Changes of note: - ExperimentalButton has been renamed to OptionalButton. -"enableExperimentalButton" is now "updateOptionalButton" and does not assume that it's starting from a disabled state. We no longer update the drawable in a separate code path. - IdentityDiscController now lives in its own package/directory. - Neither ShareButtonController nor IdentityDiscController need to care about the OverviewModeState - Optional button IPH is triggered by the OptionalBrowsingModeButtonController Bug: 865801 Change-Id: I254d42311bd20104b96c001508767f1f7fe3a4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065308 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Mia Glaese <glamia@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746127}
-
Xianzhu Wang authored
http/tests/input/discard-events-to-unstable-iframe.html http/tests/misc/synthetic-gesture-initiated-in-cross-origin-frame.html http/tests/misc/destroy-middle-click-locked-target-crash.html None of them seems recent regression. TBR=wangxianzhu@chromium.org NOTRY=true Bug: 980969,1057822,1057087 Change-Id: I39863216af0d0b8f24f9b35da0e9f2453d51f52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083931 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746126}
-
yilkal authored
This CL corrects a bug which occurs in the following situation: 1. Chrome and its web apps are active for X(example 1 hour). 2. Chrome is still active when time limit is changed to anywhere in 0 > new_limit < X(above). 3. Observe that other web apps are paused where chrome is not. Bug: 1057724 Change-Id: I1984057fff376e07bf738aaa31e6cc7eb49b5908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083630 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#746125}
-
Kevin McNee authored
promise_rejects_dom and promise_rejects_js are strict about which constructor is being used for the exception. In portals WPTs, we frequently open a new window to run the test as we can't destroy the context the test harness is running in. We now specify which window is producing the expected errors. Bug: 1057783 Change-Id: Ia3b4b55a0a12f0df96fc4bed45cd7c82a97ed5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083826Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746124}
-
Ben Joyce authored
Bug: 1052460 Change-Id: Ib6d918fd3ab24344ff6b2e30f342801673dd4e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080817Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#746123}
-
Xinghui Lu authored
To make policy_engine build on iOS, replace browser_context with pref_service and is_off_the_record. Bug: 1050859,1028755 Change-Id: I343b1b9f83dc1e69cdb5304d0b64f062120e844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071159 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#746122}
-
Wan-Teh Chang authored
Put MATCHER(ContainsDecoderErrorLog, "") in the unnamed namespace. aom_video_decoder_unittest.cc, dav1d_video_decoder_unittest.cc, and gav1_video_decoder_unittest.cc all have a MATCHER class with this name. Putting them in the unnamed namespace avoids name conflicts. Strangely, the linker did not warn about duplicate symbols. Include <memory> and <utility> in aom_video_decoder_unittest.cc and gav1_video_decoder_unittest.cc. Use the correct base::Bind variants (Repeating or Once) for the OutputCB and DecodeCB callbacks. $ gn args out/Default # In the editor, add the following lines: # enable_libgav1_decoder = true # enable_libaom_decoder = true $ autoninja -C out/Default media_unittests $ out/Default/media_unittests Tested: Change-Id: I535ba5847717b736074bf7a29ffae1e897fd0acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081243 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746121}
-
David Tseng authored
Some web trees, in particular: rootWebArea iframe ***rootWebArea iframe rootWebArea *** will set its tree->data().focus_id but not either its focus->GetStringAttribute( ax::mojom::StringAttribute::kChildTreeId) nor its tree->data().focused_tree_id The code assumed this more strict interpretation of the data, which appears to not work in this case. The topmost tree directly points to the innermost frame, skipping the frame in-between. Fixed: 1038739 Test: manually on the snippet in the bug. Change-Id: I5174cfcfabeb3bb4606d8636ab0f867d1310e52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080783Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746120}
-
Michael Chang authored
Bug: 1042224 Change-Id: I165b2ab1d625ceac23c31efd92b5e2db82d722a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079262 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746119}
-
Rakesh Soma authored
to support TOS acceptance feature in previous versions of chrome as well. Bug: 1045536 Change-Id: I7ba5fd35549acf10d5335960bb77c61a7470d484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082111 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#746118}
-
Ian Kilpatrick authored
We were inconsistent with how we named the variables, however most of them were pural, e.g. "MinMaxSizes sizes;" This changes: - MinMaxSize -> MinMaxSizes - MinMaxSizeInput -> MinMaxSizesInput - ComputeMinMaxSize -> ComputeMinMaxSizes This should have no behaviour changes. Change-Id: Ib0c352197dd6d5317b908b4037109ec1b459099c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080895Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746117}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 35a1546b. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools nsatragno@chromium.org: external/wpt/webauthn NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I87e113530a9b1106b00170ecafe976535872f063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083691Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746116}
-
Dale Curtis authored
a22cc239 moved this section out of UpdateNativeAudioHardwareInfo(), but forgot to bring the lock along. R=guidou Bug: 1043040 Change-Id: I5b17a2cf0ad55d61c0811db1dae7045af4a91370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083814 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746115}
-
Tommy Li authored
This CL enables OmniboxPreserveDefaultMatchAgainstAsyncUpdate by default. This will roll out with M82. Bug: 1021217, 398135 Change-Id: I83b3b542c6cc2d246480388d8f98d9f4ac00535a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082426Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#746114}
-
Scott Violet authored
ComposedBrowserControlsVisibilityDelegate (by way of ObservableSupplierImpl) may post a task to notify the observer (the Tab in this case). If the Tab is destroyed before the task runs, then when the task runs we get a crash as the Tab has been destroyed (specifically mNativeTab is 0, which means the jni call DCHECKs). I would like a test for this, but it proved slightly tricky. BUG=1057657 TEST=none Change-Id: I85534c464fe11121fb9f65710fc3fb69b48b0d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083813Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#746113}
-
Andrew Xu authored
It is a regression issue caused by my recent CL: https://crrev.com/c/2052593. A test case is added for this scenario. Bug: 1057710 Change-Id: Iccdffd7f0eab7d4216a0ae9bc675797f52dc0f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080954Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746112}
-
Robin Lewis authored
Bug: 1039781 Change-Id: Ie89490e0087a752cc746453184cba0f62cb16fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083345 Commit-Queue: Robin Lewis <wrlewis@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#746111}
-
Gregory Guterman authored
This reverts commit 5c614415. Reason for revert: The CL is missing an important piece of validation code. 'generate_buildboy_json.py --check' needs to validate the new bucket files, which it does not in this CL. Original change's description: > infra: Generate source side spec by bucket > > Doesn't include internal builders. > > Bug: 1028719 > Change-Id: Iec40cb84086ed23cd7d5ca60c317296460466497 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033847 > Commit-Queue: Gregory Guterman <guterman@google.com> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745574} TBR=agable@chromium.org,martiniss@chromium.org,guterman@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1028719 Change-Id: I9f0beb4efc49f532eb8a25137aafc6ad35c36354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083621Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gregory Guterman <guterman@google.com> Cr-Commit-Position: refs/heads/master@{#746110}
-
Shimi Zhang authored
AutoCloseableRouter implements close() method from java.io.Closeable, however close() will be called only when used with try-with-resources statement. Normally this class won't be in a try-with-resources statement unfortunately, so one needs to call close() explicitly. Bug: None Test: No logic change, only comments. Change-Id: I9c0b36372b8b51f0d3610fb82799db42a1fb910d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081012Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#746109}
-
Mason Freed authored
Prior to this CL, the chrome://settings and other WebUI pages would report deprecation messages in the Console, such as: [Deprecation] HTML Imports is deprecated and will be removed in M80, around February 2020. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 and https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade for more details. These will no longer be shown. Additionally, this usage of the deprecated APIs will also no longer be counted. Fixed: 1057337 Bug: 965770 Change-Id: Ibef14072bda8b4ad1147593d587d4fd941669ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081236 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#746108}
-
Peng Huang authored
Base on the log, the crash is because ProduceSkia failed, so we need check it indead of assuming ProdcueSkia() will be always successfully. So the upper level can handle the failure properly. [ERROR:shared_image_backing_factory_ahardwarebuffer.cc(843)] Failed to bind egl image [ERROR:shared_image_manager.cc(219)] SharedImageManager::ProduceSkia: Trying to produce a Skia representation from an incompatible mailbox. Bug: 1055511 Change-Id: Ib7e3494c36a3172efd3e6c3e66b51df771f09328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083713Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746107}
-
Johannes Kron authored
Add receive time to video.rAF for remote video sources according to a recent update of the specification https://github.com/WICG/video-raf/pull/17 Bug: chromium:1011581 Change-Id: I7bd7450ff50e5c69f5e85ca3f1182d4d5f264848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073940 Commit-Queue: Johannes Kron <kron@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#746106}
-
Aaron Gable authored
This reverts commit b9f529d2. Reason for revert: The underlying host didn't have its OS updated, so builds weren't able to find any hosts capable of running them. Original change's description: > Promote Mac10.14 Tests to main waterfall > > Mac10.14 Tests is now stable and green, and is ready to be promoted > to the main waterfall alongside its prior-release siblings. This CL > makes a few changes to accomplish that: > 1) Updates the OS of the existing main waterfall Mac Builder to 10.14 > 2) Moves Mac 10.14 Tests to be triggered by Mac Builder > 3) Moves it from just master (like all FYI bots) to exist in branch CI > as well > 4) Moves it from FYI to CI consoles > > This change leaves Mac Builder Next intact, so that it can be updated > and used for 10.15 soon. > > Bug: 1018852 > Change-Id: I3d5723ab7c565c37681696acb2f2de79ddcac1f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036769 > Commit-Queue: Aaron Gable <agable@chromium.org> > Auto-Submit: Aaron Gable <agable@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746074} TBR=ellyjones@chromium.org,agable@chromium.org,jbudorick@chromium.org Change-Id: I04c9d8b05cc1ca68465ae22730549ecfd0cf7ed7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081617Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746105}
-
Christopher Cameron authored
This feature has been shipping for a while now. TBR=avi Bug: 982024 Change-Id: Ia16055903779e734836ca6b3868c49fe88a07c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083533Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#746104}
-
Lei Zhang authored
Link it to device/bluetooth/OWNERS. Change-Id: I368888c62b22883162bfbf4af7d62afef2a0811c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079164Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#746103}
-
Jeff Yoon authored
Run iOS test runner unit tests as part of presubmit. Keeping scope to functional tests, and will have separate CLs for the remaining files that require further fixes. * PRESUBMIT.py - include unit test execution for ios/build/bots/scripts * run.py - unit tests caught logic incorrectness. Running the json parsing first, before validation. * wpr_runner_test.py - remove install xcode mock, fixed broken tests * test_apps_test.py and xcode_log_parser_test.py - include main call to unittest. Bug: 1056457 Change-Id: Ifc233695ba8f6120f862586a497df61e96d4954f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076765Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746102}
-
S. Ganesh authored
We create the service with a new name if the creation with the original name failed. I think this should take care of failures, and may perhaps fix issue 1023080 as well. The idea here is that in some cases, a deletion of the original service may not be complete and there may still has some stale state left over in the SCM database. In such cases, we may be unable to open it or recreate it. In these cases, we now will create a new name and install a new service. Bug: 1055470 Change-Id: I7e0f5e76892fe29fa597c77cd4b64702a3f717c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071387Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746101}
-
Henrique Ferreiro authored
This CL migrates the mentioned legacy IPC message to the content.mojom.FrameHost Mojo interface as RequestOverlayRoutingToken => UnguessableToken. Because it now uses a callback to return its result, the related FrameMsg_SetOverlayRoutingToken message used to receive the token is removed. Bug: 1047321 Change-Id: Id5bb1158c475ec788f95e36160b10adf23ebf30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061159Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#746100}
-
Yicheng Li authored
This change implements the GetAssertion operation in ChromeOS authenticator. It uses the first assertion returned by ChromeOS platform daemons. Resident credentials are not supported yet. Bug: b:144861739 Change-Id: Icc9ae86568d42a4f15f95e6fdc5cc8fd367353cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040064 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#746099}
-
Adam Langley authored
This change reflects https://github.com/w3c/webauthn/pull/1375 in code. Since that spec change isn't breaking, it's fine to implement this first as the format still conforms to general JSON. This change will allow some validators to test against it, prove out that it works, and then we'll report back results to the W3C group — hopefully resulting in the WebAuthn spec change being accepted. Change-Id: Icedf405bf7eb91b752493badccad892aa9822e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083394 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#746098}
-
Robert Liao authored
use_color_pipeline is undergoing conversion to a runtime flag. This also moves dump_colors to the same deps as //chrome. BUG=1057239 Change-Id: Ifac81badcd85f338e8374a9ea1d085900ac8264e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080854Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#746097}
-
Stephen McGruer authored
This diff was generated by running: find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)new ([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs' Then manually fixing up whitespace and making the following changes: fast/dom/geometry-interfaces-dom-matrix.html - use assert_thows_dom instead fast/dom/geometry-interfaces-dom-matrix-readonly.html - use assert_thows_dom instead fast/dom/geometry-interfaces-dom-matrix-setMatrixValue.html - use assert_thows_dom instead fast/xpath/parser-crash-by-deep-expression.html - use assert_throws_dom instead http/tests/credentialmanager/federatedcredential-basics.html - use assert_throws_dom instead http/tests/credentialmanager/passwordcredential-basics.html - use assert_throws_dom instead typedcssom/cssUnitValue_toMethod.html - use assert_throws_dom instead Bug: 1051932 Change-Id: Ia4272f7f0a01df7c392007e99aa2c4d14f92017b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079452Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#746096}
-
Thomas Tellier authored
Bug: 1047175 Change-Id: If7e1aea305a80889d0527bc12e2f0924ec28ba15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082916Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#746095}
-
Travis Skare authored
Change-Id: I128817e07c195d1403faccd80f6ee846b179cabe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080789 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#746094}
-
Guido Urdaneta authored
It is possible to modify the data field without replacing it, so syncing always. Will work on an optimization for a follow-up CL. Bug: 1052765 Change-Id: Ibc5b143413163f12af3c6cacefb3a9ee028b7eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083092Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#746093}
-
Nate Chapin authored
Change-Id: I3bbae75aa5dfa99bf2ae4053993a50daca3b6bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049915 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746092}
-