- 18 Jul, 2020 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I6bbc5596eda5fed4b9a49eaa4b767fbf2bd7bd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305750Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789740}
-
Yuheng Huang authored
Related CL: https://chrome-internal-review.googlesource.com/c/chrome/browser/resources/tab_search/+/3164617 Bug: 1099917 Change-Id: Ie9add185ce58b7055f8febb119ba18ec31c2917c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298282 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#789739}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/de90862cce95..20b701f3d79c 2020-07-17 deadbeef@webrtc.org Revert "sdp: parse and serialize b=TIAS" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0e3a24939eebe6d837cb948efbc33e2669c61653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789738}
-
Reilly Grant authored
This manual test architecture allows us to build integration tests. A connected serial device with its transmit and receive pins connected together is assumed. Bug: 884928 Change-Id: I960faa894776723fd5a858ff7f35a1999afa2955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277582 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#789737}
-
Stephen Martinis authored
This is a reland of 8ab0b856 Original change's description: > Parallelize fetching telemetry benchmark deps > > The fetching script currently fetches about 2 GB (on my linux workstation) > from cloud storage serially. This can (and is) trivially parallelizable, and > should speed up the fetching script significantly. > > This script has been taking 20 minutes on mac machines for a long time. This > will hopefully significantly speed the mac builders up. > > Bug: 1102597 > Change-Id: I93d2fa2b1f4b4ef6e27e9c894a9dd4c0d0e12d7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285503 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786521} Bug: 1102597 Change-Id: I37d0055fadb26bf4eae2b0b5fe0ecc4732edde3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288740 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789736}
-
Xianzhu Wang authored
This is a part of the work of removing DisplayItemClient::VisualRect() which is an obstable of integrating FragmentData with LayoutNGBlockFragments. Added BoxDrawingRecorder() which calculate visual rect for a LayoutBox from SelfVisualOverflowRect() and paint offset. Bug: 1104064 Change-Id: I4ba09257d65e7aa2a6287fe74e2fb8190fac488a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304775 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789735}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c80db6e1..1d62b368 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3744c411cf02820c567d744bb54d460728b0a4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302838Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789734}
-
Rushan Suleymanov authored
This CL restricts adding, removing and notifying observers in SpecialStoragePolicy within one thread using sequence checker. It also makes all call sites to notify observers from the correct (IO) thread. The fix should also mitigate MigrationSingleClientTest tests flakiness. Bug: 1094907 Change-Id: Ife32fe48af22129ef0e04779c62c707b5f20f3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301972Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789733}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/28652ef368ef..d07e90e7ff54 2020-07-17 bclayton@google.com Kokoro: Migrate linux bots to ubuntu docker image If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Icf6f41d2846fd420f3ce12bd688a660aa6a71ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305092 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Yuke Liao authored
Different test targets should be handled differently depending on whether they require a display server: * If they do, download and starts an ash-chrome before running tests. * Otherwise, run them directly like a regular Linux build. Bug: 1104318 Change-Id: I10e15bc31efbb502c60cd797f59c1a5c2613631a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303973Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789731}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7f4980e7d265..1233b66c90d4 2020-07-18 enga@chromium.org Guard [MTLDevice recommendedMaxWorkingSetSize] only on MacOS 2020-07-18 enga@chromium.org Add offset argument in BufferZeroInit mapping test 2020-07-17 cwallez@chromium.org Add offset and size to Get[Const]MappedRange. 2020-07-17 enga@chromium.org Call vkFreeCommandBuffers before destroying the vkCommandPool 2020-07-17 enga@chromium.org Remove depth sampling tests of non-normalized depth values 2020-07-17 enga@chromium.org Make common/ compile with Emscripten If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1082181 Tbr: cwallez@google.com Change-Id: I2abf8058dafda7791e533eb857a810f3873cd5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305244Reviewed-by:
-
Kelvin Jiang authored
chrome_style applies styling for an extension's embedded options page. The styling is old and inconsistent with the modern WebUI appearance. Since some extensions with many users are still using this flag, support for it will be phased out in manifest v3 Bug: 973157 Change-Id: I0ae424227bd3a0eda34dc56a5631d9d1a6461464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298726 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789729}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595008812-2b2b78d6e899231c2064ae01a2341404f1a2dcab.profdata to chrome-mac-master-1595028747-81e43afb2ec18845c639db32e07c52ff5831a7c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I758b30a11125790542770ed0cdb224673cfc2915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305242Reviewed-by:
-
Gang Wu authored
This is a reland of 5ae112d1 Original change's description: > Reland "[Omnibox] Use ActivityState to check if we are in browser mode" > > This is a reland of be1e9636 > > Update the test to run on UI thread. > > Original change's description: > > [Omnibox] Use ActivityState to check if we are in browser mode > > > > > > In multi windows mode, check if we are in browser mode by WindowAndroid > > is not working, should check ActivityState instead. > > > > Bug: 1102640 > > Change-Id: I35a720a2aa6f337cc9f9ae43e39d83c9368fcb5a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286478 > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#786636} > > Bug: 1102640 > Change-Id: Iefba5a5d0c181535bd7fb86cf0e073be2ebdbcdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293074 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788816} Bug: 1102640 Change-Id: I6da3c7ad8402cef83083a53f7ffc517f975720f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301285 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#789727}
-
Daniel Hosseinian authored
Unlike other printer settings, color does not have its own function in the Core Printing API [1]. Therefore, color needs to be set using the generic PMPrintSettingsSetValue() function. When printing using CUPS IPP, the passed key-value pair must be IPP constants. All other printer settings work fine with CUPS IPP because they are handled with their own Core Printing functions. [1] https://developer.apple.com/documentation/applicationservices/core_printing Bug: 1106437 Change-Id: I7ad153fc97f9e5797b263a6ec2ac10726deb27b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303992 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#789726}
-
Josh Nohle authored
The local device data updater builds and queues UpdateDevice RPC requests. It uses the Nearby Share HTTP client to make the calls when ready. It also enforces the specified timeout. Bug: b/157685298 Change-Id: I27372ccfdb27307c5a048b4293a4eac005f61a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280581Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#789725}
-
Reilly Grant authored
This change enhances the abort() and close() methods on the writable attribute of a SerialPort object so that it is possible to request either a flush[1] (discarding buffered data) or drain[2] (waiting until buffered data has been transmitted). [1]: https://reillyeon.github.io/serial/#serialportsinkabortalgorithm-port [2]: https://reillyeon.github.io/serial/#serialportsinkclosealgorithm-port Bug: 989653, 989656 Change-Id: I95226e6f3069214b483935abdf4ae1e87d5961a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277074 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#789724}
-
Victor Costan authored
Bug: 1016065 Change-Id: I54c16b4ff463e7885ced521b66f65444c97028a4 Tbr: falken Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301117 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#789723}
-
dpapad authored
Previously the code was imperatively registering such listeners on |document.body| which was unnecessary. Moreover, adding meaningful type checking for such listeners, since previously they were lacking type info. Bug: None Change-Id: I1041f0becf89d1f88b03a1ad2dc9ec9e85a99e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304956 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789722}
-
Lei Zhang authored
It no longer builds after https://crrev.com/788162, so comment it for now to unblock the affected Chrome OS builders. Bug: 1106355 Change-Id: I2895dd2d21253c72ec728ae9af2ce2c9fce60414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304551Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#789721}
-
rbpotter authored
- Modify the new toolbar's input field to display the current zoom level. - Also update the fitting for the new toolbar for fit to width and fit to page to account for the toolbar height, since the new toolbar does not auto-hide. Bug: 1105701 Change-Id: I34c0cf26f1d570023ea9904dd63da0da703e7781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303991Reviewed-by:
-
James Cook authored
Select file dialogs are implemented in ash-chrome via SelectFileDialogExtension, which requires an aura::Window owning window for the dialog. Use the currently active (frontmost) window, which will usually be the spawning Lacros window. Verify that it's still a ShellSurface, just in case window activation has changed between when the user initiated the file picker and ash-chrome has received the mojo message. This isn't quite right -- in theory a non-active window could spawn a file picker -- but it's better than a modal file picker that blocks the whole desktop. Bug: 1090587 Test: multiple lacros windows can have their own file picker children Change-Id: I582cd534e49228f3da5ab67e5ad99812f1a48432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303681Reviewed-by:
-
Dale Curtis authored
Allows us to avoid spinning up a real audio device for muted playbacks, which saves ~200-300mW of power per Intel. R=tmathmeyer Bug: 764133 Change-Id: I0a6404858eea2ac643d53cb623f653f988c99330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305114 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789718}
-
Daniel Hosseinian authored
The version of GetColorModelForMode() that ChromeOS uses will be used by macOS. Rename it to GetIppColorModelForMode() and move it to print_settings.h. Meanwhile, add some simple tests. Bug: 1106437 Change-Id: Ic01d1cf242c6e77774d247253f6cd912c2566f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303855 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d0c9d0cb7ffa..9662fd6cbdfb 2020-07-17 mtklein@google.com support 64-bit PixelFormats 2020-07-17 johnstiles@google.com Fix swarming task failure on Debian10-Clang-arm-Chromebook-GLES. 2020-07-17 mtklein@google.com add 64-bit load/store ops 2020-07-17 csmartdalton@google.com Implement indirect draws with ANGLE's multi draw extension 2020-07-17 nifong@google.com Run both puppeteer tests in a WebGL 1 and 2 configuration. 2020-07-17 mtklein@google.com support 16161616 in fm 2020-07-17 herb@google.com split glyph and geometry data apart 2020-07-17 jcgregorio@google.com Use the new swiftshader bucket. 2020-07-17 mtklein@google.com use precise is-normalized test in gm/p3.cpp 2020-07-17 robertphillips@google.com Clean up some uses of GrContext in tests 2020-07-17 johnstiles@google.com Update GrMorphologyEffect to take an inputFP. 2020-07-17 johnstiles@google.com Update existing TestCreate methods to honor the inputFP in the TestData. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Ie24eb9fcfae7af52a4023d2a882488dc0ea65705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305176Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e8dd233c7a85..a8b8ef775c75 2020-07-17 amaiorano@google.com Fix Win32 Chromium and ANGLE builds 2020-07-17 capn@google.com Remove Travis CI and AppVeyor build badges 2020-07-17 capn@google.com Update Kokoro's clang-format to version 10 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1106623 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie251a4eea02b8ef95a16ff1e007916cb71b8fd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304381Reviewed-by:
-
Lukasz Anforowicz authored
This CL tries to speculatively avoid 1) cases where a |direct_network_factory_| might be getting used with non-opaque origins (see https://crbug.com/1105794) and 2) cases where a |request_initiator_site_lock| doesn't match |request_initiator|. We speculate that one such case might occur when RenderFrameObserver::ReadyToCommitNavigation triggers a fetch in a new document *before* the new factories have been installed. After this CL, the new factories are installed earlier, before calling RenderFrameObserver::ReadyToCommitNavigation. Bug: 1105794, 1098938, 920634, 1056949 Change-Id: I1f06750d4211e12d196eba0f3a78edeaeaa98cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303678 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#789714}
-
Lei Zhang authored
Since pdf/pdf.cc is just the implementation for an interface into the internals code, separate it and its header out into a separate target. Put the majority of the code in pdf/ into an "internal" target, since that's what it is. To make the dependencies work out, also put pdf/pdfium/pdfium_assert_matching_enums.cc into its own target. Bug: 1103478 Change-Id: I95da94e55f1bddf957a26cece899d27222756584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293457 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789713}
-
Yue Zhang authored
This CL adds e2e test to cover item 1.6.15 in https://testtracker.googleplex.com/testplans/details/32981. Bug: 1105511 Change-Id: Ib19c38b064d0fd201918af0bee0584170db72786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296343 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789712}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d8628ddce9a..7043cea402ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC atotic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1104558,chromium:1105096,chromium:1105606,chromium:1106471 Tbr: atotic@google.com Change-Id: I6cb49cb38b04ad36db89888fb668b6924d37020e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305170Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789711}
-
Nathan Zabriskie authored
This is a follow up CL to crrev.com/c/2280228 which added surface origin and alpha type to SharedImageInterface. It finishes piping that information through to SharedImageBacking. Bug: 1034086 Change-Id: Ia8c2042051d0c36ca73217fcf79da9da0deb181e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304099 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#789710}
-
Daniel Classon authored
Added the Polymer Behavior to fetch the settingId parameter from the URL and then focus on elements containing that settingId. Imported in the OS Reset Page. Bug: 1084154 Change-Id: I52bb73227447d6293a7b31402f7cc5a29e045309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296008 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789709}
-
Devlin Cronin authored
Bug: 1103302 Change-Id: I653a90da2e2d628fd1e00ddd28902017f045ac86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288353Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789708}
-
Christopher Cameron authored
Change SharedImageBackingGLImage to not allocate a GL texture until it is going to be used, and also delete the GL texture when it is no longer in use. This is needed for Metal-only SkiaRenderer, where we really don't want to be using GL (and actually can't, because there isn't a context hanging around at all times). TBR=geofflang Bug: 1092155 Change-Id: I6c14d03b50f40bd96de1c0c7355c03493c22865d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298723Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#789707}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc4668dae26e..de90862cce95 2020-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3cd7ca07..d2f62519 (789472:789613) 2020-07-17 danilchap@webrtc.org Delete callbacks from RtpDemuxer on ssrc binding 2020-07-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b8a4405e..3cd7ca07 (789356:789472) 2020-07-17 philipel@webrtc.org Removed unused include from encoded_image.h. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1e57407b69d32aa1a9c4dcf9cc8b7f5ad9bdd3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305289Reviewed-by:
-
Martin Kreichgauer authored
This reverts commit c10ef92a. Reason for revert: Causes GATT connection failures on Windows (crbug.com/1106597) This is a partial revert. I'm not including updates to the comments in device/bluetooth/bluetooth_discovery_session.h because they were unrelated to the actual change and are still correct despite the revert. (See the PS1/PS2 diff for the re-revert.) Original change's description: > fido: stop scanning for BLE advertisements before connecting > > Anecdotally, GATT connection reliability on Windows is higher if the > Bluetooth adapter is not scanning while the connection attempt occurs. > Hence, make FidoCableDiscovery invoke BluetoothDiscoverySession::Stop() > before connecting to a device. Obviously, there is a possibility of > scans occurring for other reasons. But that's unlikely to happen and we > can't do anything about it. > > Note that stopping the scan probably means a single FidoCableDiscovery > instance can at most connect a single device. However, caBLEv1 > currently only really supports a single authenticator anyway. > > Change-Id: Ibaac6bc1563e4429dad0df9570f77c594ed1469c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211281 > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781094} Bug: 1106597 Change-Id: I1e4fcf5b6be1d26a4d7634ad1fe96df1d07b176a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303683 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#789705}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/320ceb93a21c..4bbdfa583e74 2020-07-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib06e97bec490a7100e713362a05d6469cc458390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305233 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Matt Menke authored
These are not commonly included in header files, but fairly often used in cc files, so including them in a widely used header can lead to IWYU issues (this header isn't widely used directly, but was transitively included in 8,000+ files). Bug: None Change-Id: Id08418b088d6b9e55cd9c86852363b016b842b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300033Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789703}
-
Greg Thompson authored
This CL adds FLAG_SHARE_DELETE to many file operations in Chrome's installer; including in delta patch processing and archive extraction utilities. This allows processing on files that are held open to be deleted by another entity so that we can eventually hold temporary files open with FILE_FLAG_DELETE_ON_CLOSE. BUG=516207 Change-Id: I1cd03f6360dfcd61fcd2f09797f0923331076415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302109Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#789702}
-
Alexander Alekseev authored
This Cl exposes viz::DebugRendererSettings members as checkboxes in ash HUD overlay. Bug: 1085288,1085287,1085279 Change-Id: Id6ad4aa632cb552277ba47d076056b5ca0cc51f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303468Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#789701}
-
