GitLab

- This patch added command line to write the minidump to log
- and enable it by default for WebView.

Bug: 979082
Change-Id: I9dd7fc282261356ec6d26b030333c0e86e92ea93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037083Reviewed-by: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738686}

The Baseline Content-Alignment feature is not implmemented yet, so the
tests realated to that feature should be skipped.

Additionally, the 'last baseline' keyword is marked as risk, so it's
not implemented yet; the related tests should be skipped as well.

Bug: 1047575
Change-Id: If9754ff23c111560398a37e0dd3da3f97c5fbd7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039191Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#738685}

This change makes two improvements to the distributed ThinLTO scripts:
 1. When no code generation is necessary, invokes the local linker
    correctly even when --gomacc or --jobs options are specified.
 2. Change create_file to ensure_file to only create files if they
    do not already exist, reducing unnecessary rebuilding.

R=gbiv,hans,rnk,thakis
BUG=877722

Change-Id: I29ffa028202c31f77df95d306432f726e3f7bda9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039996
Auto-Submit: Bob Haarman <inglorion@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738684}

iOS current writes out full_results.json, but moving forward the
Chromium recipe expects an output.json file. We write the same
contents of full_results.json to output.json such that the Chromium
recipe can collect_task and run the noop_merge merge script.

Changes to the content of output.json will be required for utilizing
the standard gtest merge script.

Bug: 1031338
Change-Id: Ifff558d37618afeb371944693a6b76a4be46547d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032809Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738683}

By the time the GPU info collection is requested, the GPU vendor id
and device id should be available. Something must be wrong if the
device id is 0. In this case, no need to collect GPU info.

This CL also renames the info collection GPU process from
GPU_PROCESS_KIND_UNSANDBOXED_NO_GL to
GPU_PROCESS_KIND_INFO_COLLECTION

Bug: 896565
Change-Id: I00e1a70448f337f148ae7ad4f016d2308c284fba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036940
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738682}

So the name better matches the actual use.

Merge-With: eureka-internal/360190

Bug: none
Change-Id: Icad7d7496a67e6af96f72ccc73e41e0c2d68d935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039295Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738681}

Makes CircleHighlightPathGenerator use RoundedRect. Tested manually and
the highlights/ripples/focus rings look the same, minus the previous
extra renderpass.

Test: manual
Bug: 1042303
Change-Id: Ib2010b4b8ba9838bfee9f9d6eb696bb6fffb843f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037849
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738680}

trybot_commit_size_checker.py now specifies if a metric delta is a large
improvment (greater than the limit, in the opposite direction). A
boolean is set on the binary size gerrit plugin json object for each
metric if it is a large improvement. This allows the plugin to showcase
those differently on the CL page.

Bug: 921090
Change-Id: I0b809835289f8af9046d477826abdd7d7d9a7387
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037958Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738679}

Change-Id: Iedce6a403777db230dcd959725f21c6cce2c0a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039891
Commit-Queue: Herb Derby <herb@google.com>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Herb Derby <herb@google.com>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738678}

Modifying the set returned by SharedPreferences#getStringSet() is
forbidden by the API, but nothing stops the developer from doing so.
It can cause consistency issues resulting in loss of data.

Change-Id: I84907d4c4475d2a97974a6b57e16c50a411d915c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039811
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738677}

This fixes a bug where some of the logging from the audio process is not
forwarded to chrome://media-internals.

Fixed: 1049114
Change-Id: I958e47557ba9b6bdc9c9d3e8352994bc140ffb3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037677
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#738676}

This verifies that the JSON which gets produced with the sampled
frames, matches the format that the internal processing pipelines
expect.

R=ssid@chromium.org,etienneb@chromium.org
BUG=1046918

Change-Id: Iaa4e853fe44f8ea16ac81410383413c55cbfbd6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031941
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738675}

Fixed: 945966
Change-Id: I7f89e5a9df35cd615f7bd30d5725d7e3ac773801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035951Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738674}

Remove OAuth2LoginVerifier and make the OAuth2LoginManager observe
AccountReconcilor instead of doing /MergeSession.

DD: http://doc/1fACI5GQgXvmlmEJj6aPedazXeDZAZPw9jH_E91WGe3w

Bug: 977137
Change-Id: Iaa21dd12f0ca6568d920f135bbfdddf3f9def088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674099Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738673}

This CL finishes off the componentization of
//chrome/browser/captive_portal by putting the componentized files in
the captive_portal namespace. The CL additionally removes all
now-unnecessary references to the captive_portal namespace from within
these files.

Bug: 1030692
Change-Id: Ia9bb3498413aa95cdd6eeb2a652061e6dbca6b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038778
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738672}

The Apps Foundation team is implementing metrics for measuring success
and OKR progress. This metric measures whether an app that is
uninstalled was within 7 days of having been installed. A new histogram
was created to track this metric.

BUG=1044710
REVIEWERS:
    bcwhite: please review histograms.xml

Change-Id: I030dfc65835118e2ba15480ad779db64d304e272
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035501Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Commit-Queue: Alex Linker <ajlinker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738671}

This reverts commit 3599b7a3.

Reason for revert: Incorrectly reverted...see https://bugs.chromium.org/p/chromium/issues/detail?id=1012527#c9

Original change's description:
> Revert "Reland "Call MFShutdown in places where MFStartup is called""
> 
> This reverts commit 5019665f.
> 
> Reason for revert: broke capture_unittests on chromeos-amd64-generic-rel per http://crbug.com/1048934
> 
> Original change's description:
> > Reland "Call MFShutdown in places where MFStartup is called"
> > 
> > This reverts commit 5be12bf8.
> > 
> > Reason for revert: Fixing the issue, and running on more trybots
> > 
> > Original change's description:
> > > Revert "Call MFShutdown in places where MFStartup is called"
> > > 
> > > This reverts commit abf9a1f5.
> > > 
> > > Reason for revert: Broke tests on Win7 dbg, see linked bug
> > > 
> > > Original change's description:
> > > > Call MFShutdown in places where MFStartup is called
> > > > 
> > > > Bug: 1012527
> > > > Fixed: 1012527
> > > > Change-Id: Id9ef248aadb0aa24704dec973b60ea23c9e1f1ed
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032332
> > > > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
> > > > Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#738063}
> > > 
> > > TBR=xhwang@chromium.org,tmathmeyer@chromium.org
> > > 
> > > Change-Id: I267213cc06b42769736c7eb337432ade7953de20
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1012527
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036057
> > > Reviewed-by: Marc Treib <treib@chromium.org>
> > > Commit-Queue: Marc Treib <treib@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#738130}
> > 
> > TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org
> > 
> > Change-Id: I8f87e933e133d0dcbf9904c002af7738af450f41
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1012527
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037811
> > Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> > Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#738344}
> 
> TBR=xhwang@chromium.org,treib@chromium.org,tmathmeyer@chromium.org
> 
> Change-Id: Ieba1f172a5a2bed58e338f15c638c6deae8b0685
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1012527, 1048934
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037855
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738410}

TBR=xhwang@chromium.org,kbr@chromium.org,treib@chromium.org,tmathmeyer@chromium.org

Change-Id: I6ca750208e811eeda8acd9c6f57924a9cb57f04d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1012527, 1048934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040191Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738670}

BUG=chromium:878390

Change-Id: I0a5dd1e09f42a0332fd107cdecb677d499d4cef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020769
Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738669}

This CLs organizes most of the drag and drop logic to its own
manager service, in preparation for more complex logic. This CL
does not change any implementation and only moves code around.

Follow up CLs will modify the drag interactions to only modify the
DOM and allow canceling drag sessions, with drop being the commit
to move tabs or tab groups. This will also prepare the manager to
be able to support dragging tabs from other windows into place.

Bug: 1048894
Change-Id: Ieb66ee859a09b972f178a8c50513aa2f284e08d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036932Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738668}

This CL adds custom chromevox announcements for all
settings pages in the system tray.

Bug: 1009714
Change-Id: Ied1735f1afc1289de6c66fb449c1bce70ac5fd25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037956Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738667}

We weren't yet calling out explicitly that TRACE_EVENT_NESTABLE_ASYNC
should be preferred over TRACE_EVENT_ASYNC.

Bug: 1038710
Change-Id: Ib0e386d435a17ca0f21354e4ce5c955e0616fef5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037996
Auto-Submit: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738666}

This CL creates a SharedImageRepresentationGLTexture for Ozone-based
SharedImages. The representation creates a GLImage from the pixmap
via GLImageNativePixmap::Initialize and then binds it to a GL texture.

Like in the case of the Pixmap Dawn representation, synchronization
will be added in a future CL.

Also, updates SharedImageBackingOzone to properly track the cleared
rect now that it is being used on SIRGLTexture::BeginAccess as per
chromium-review.googlesource.com/1990195.

Bug: 1023997,996470
Change-Id: Icacf20bc0f754fbc8acb37693618f2aca64568e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913085
Commit-Queue: Brian Ho <hob@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738665}

Going through each of the usages will take some care, so I want to
essentially fix the API in a no-op pass and properly migrate each of
the callsites independently (or in batches).

Bug: 783819
Change-Id: I91e5d4cbf327dfc08d16296ccc6213a347779a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039171Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738664}

Also fixing the remaining copy related testing that are failing due to
strict mode

Bug: 1046062
Change-Id: I5a07db2b9ee16fb50094a968eab80f34d9b5addd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028928Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#738663}

On the last round of r738645 rdevlin.cronin@ requested two fixes which I
forgot to actually apply before submitting. Oops!

Tbr: rdevlin.cronin@chromium.org
Bug: None
Change-Id: I17eefb78fdddd1d04feca946b506bf6725cccb8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039892Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738662}

Bug: 992074
Change-Id: I2b54639a15222d2c30cf419c606b62ebd28597e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951893
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738661}

This change adds different foreground icon colors to the toolbar buttons
for the hovered and pressed states when the high contrast ink drop
feature is enabled. This is to support the desired platform high contrast
colors. Future work will add foreground color support to other buttons.

New theme properties were added to support the additional _HOVERED and
_PRESSED state high contrast colors. When not in high contrast, these
are the same as the normal icon color. In high contrast (+ flag) they
return the selected text HC color. These new colors are used to create
images in the toolbar buttons for the various button states.

New helper functions we added to ToolbarButton to simplify setting the
images for the different button states, including one that just uses
the standard colors returned by |GetForegroundColor|.

In the future, we might want to do work to allow icons to be separated
from colors to allow for easier recoloring.

Bug: 776871
Change-Id: Id72d8c60a23889f018044a5fcce7abd9359ad61a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029492Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738660}

This removes the code from input_injector_mac.cc that tried to
calculate the correct offset from the desktop configuration and passes
the correct (adjusted) coordinates.

Bug: 946001
Change-Id: Iedea08a9d019c0fcdfa615b1e83a88ed4474f2c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029448Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738659}

Address closure issues caused by moving to more restrictive rules:
  * Tweaked how BluetoothAdapter 'info' was bubbled up to be non-null.
  * The code was previously shoving undeclared 'removed' and
    'connectionStatus' properties into the bluetooth.mojom.DeviceInfo
    struct. I moved this 'removed' property to a separate map (it's a
    hacky property only used for the bluetooth-internals page, so it
    makes no sense to actually add to the struct) and completely tore
    out the notion of a 'connectionStatus' from being attached to a
    DeviceInfo since it was actually not used (!).

Tested by building webui_closure_compile with this CL based on top of
crrev.com/c/2006413, and by manually testing
chrome://bluetooth-internals to verify no regressions were introduced.

Fixed: 1047809
Change-Id: Id5abfec261602e67e9f9783a5621bec7bd97cc65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038078
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738658}

Roll broadwell AFDO profile from 81-4028.0-1580732019-benchmark-81.0.4044.6-r1 to 81-4028.0-1580732019-benchmark-81.0.4044.9-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I34ce681dc21ae74541fdfdcf1aab407dce7265c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039378Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738657}

This CL ensures that AppActivityRegistry::OnAppActive
returns early if the application is already active.

Bug: 1034551
Change-Id: I5133e8b799e4231130f2ae5518469eaf29158dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037967
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738656}

The structured-clone-any.js test is slow as it creates a new database
for each of over a hundred test cases, leading to long (>20s) run
times on debug builds. This would lead to occasional timeouts.

Use the WPT "variant" mechanism and shard the test down to just 20
cases per shard, which drops the test times down to just a few seconds
each (on debug builds).

Bug: 991415
Change-Id: I5fa792ea0042c7ff6ea29d926a459c625958d10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036957
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738655}

Roll airmont AFDO profile from 81-4028.0-1580726817-benchmark-81.0.4044.6-r1 to 81-4028.0-1580726817-benchmark-81.0.4044.9-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ib0eaf6a46c9b7b303b37c1a851a2fa469b8942c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039992Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738654}

Several browser_test test suites implemented the same version of a
helper function to check if a particular element is visible. This CL
refactor these tests to use an already commonly available util function.

The original isVisible functionality is moved to isChildVisible and
isVisible is adjusted to directly check the element parameter. Call sites
that relied on the previous behavior have been refactored to use
isChildVisible.

Bug: 814436
Change-Id: I1d75f0562cd8ba789fab3e89bbd115ea7c85862b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030921Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#738653}

https://skia.googlesource.com/skia.git/+log/d2ccbb522eb0..4777e3addec4

git log d2ccbb522eb0..4777e3addec4 --date=short --first-parent --format='%ad %ae %s'
2020-02-05 robertphillips@google.com Cleanup program building a bit
2020-02-05 brianosman@google.com In SkRuntimeEffect, just use hash of SkSL as the ID
2020-02-05 bsalomon@google.com GrTextureEffect handles insets for float rects as well as integer rects.
2020-02-05 csmartdalton@google.com Don't use tessellation FB barrier after NVIDIA 440.00

Created with:
  gclient setdep -r src/third_party/skia@4777e3addec4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: scroggo@google.com
Change-Id: Icc40f76aca82b67c728dd312101548eed0e36d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039690Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738652}

which is 0x101 (in response to 0x1) instead of 0x102. This only affects unit tests.

BUG=1045010

Change-Id: I38610619dfde7c409ee226468e61ca0ab2b37059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024848Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#738651}

As per Polymer style guide identifiers should be camelCase, this CL
changes site_settings_page to conform to style.

Additionally the mis-naming which caused the associated bug is fixed.

Bug: 1049082
Change-Id: I2c57d987c70e6587cc98f7b3749f6c948d3ffb3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037675Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#738650}

The usage of ProxyBypassRules in TrustedSourcesManager isn't
appropriate, since ProxyBypassRules was only designed to be used for
proxy rules. It implicitly allows rules such as <-loopback> and <local>,
which TrustedSourcesManager may not want.

With the newly introduced SchemHostPortMatcher, which implements the
most ProxyBypassRules has but more general, we can replace the usage of
ProxyPypassRules with it for TrustedSourcesManager.

Bug: 1030092
Change-Id: Ia0742d589fdbc083e8bbecbd64aacca573b8be91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036368Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#738649}

Roll silvermont AFDO profile from 81-4028.0-1580727432-benchmark-81.0.4044.6-r1 to 81-4028.0-1580727432-benchmark-81.0.4044.9-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ic58d4b29910477c6a2c6fb823433d3ffe4dc1e21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039377Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#738648}

Using these metrics, we can track if any particular websites are broken
when users change their iOS default text size.

Bug: 1046356
Change-Id: Ia324cce81bf2926affc93c1622fcc6f6cde53dcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029515Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#738647}