GitLab

Bug: 667892
Change-Id: I59ba41ab12c7a29a7011a7dc6bca16b0daa38895
Reviewed-on: https://chromium-review.googlesource.com/881582
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531686}

Use base::nullopt instead of std::string() for Optional parameter in WebrtcAudioPrivateGetAssociatedSinkFunction.

DCHECK was hit because of incorrect usage; fixed with this change.

Bug: 804836
Change-Id: Ia09f9a6bc563b6468236fd821ade49e1cb8f0fa7
Reviewed-on: https://chromium-review.googlesource.com/883343Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531685}

Incorrect histogram suffix was used in histograms.xml

In code we use "*.FromApp" || "*.NotFromApp"
In histograms.xml we had "*ForApp" || "*.NotForApp"

Bug: 805063
Change-Id: Icad5459e2aaf2b641e4a45e98163e658131c64ac
Reviewed-on: https://chromium-review.googlesource.com/882123Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531684}

Before we introduce CustomUserTiming, we need to ensure the edge cases behave
the same between the old and the new API while the feature flag of the new API
is off.

Hereby, we identify the following use cases. As the start/end marks are in
String type, when passing the following args, they are converted to respective
Strings:

{} -> '[object Object]'
null -> 'null'
51.15 -> '51.15'

This CL introduces some test cases to cover these behaviors.

Bug: 758385
Change-Id: I4ad60f907f3d794309bee1d8e3ce4268e2e5f49f
Reviewed-on: https://chromium-review.googlesource.com/883943
Commit-Queue: Liquan Gu <maxlg@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531683}

The remaining static code in use moves to PendingView. References are
updated to use ManagePasswordsBubbleDelegateViewBase directly.

Also removes SINGLE_VIEW_COLUMN_SET in favor of using a FillLayout and
cleans up unreferenced ColumnSet enums.

Bug: chromium:654115
Change-Id: I54d6ed26132388bd33c3e93e504ce153146f43ec
Reviewed-on: https://chromium-review.googlesource.com/882161
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531682}

This patch fixes NGPaintFragment::VisualRect for inline fragments.
Incorrect VisualRect causes parts of fragments not being painted.

Inline boxes with 'position: relative' is still incorrect. This
patch includes tests, but disabled for now. The fix involes other
parts of the code that it will be in a separate patch.

22 failures turn to pass.

Bug: 714962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib101051642f1c4b91d8b13df0822bf55e1481c1b
Reviewed-on: https://chromium-review.googlesource.com/882789
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531681}

Bug: 778289
Change-Id: I65a3710f7b5728c44d714d4a43405ad78720edb2
Reviewed-on: https://chromium-review.googlesource.com/862258Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531680}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d8c2020e..bcd1365c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I35fcc00217d722656a64bceb39da4b6213394474
Reviewed-on: https://chromium-review.googlesource.com/883723Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531679}

Also, move some existing include guards closer to the top of the file.

Change-Id: I7dda7da99fce2a82354fd5db5ef62bee01444bec
Reviewed-on: https://chromium-review.googlesource.com/882322
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531678}

This was a hack to allow Ozone DRM build to run using the Intel mesa gbm
platform. This is no longer used (since we're using minigbm on all DRM
platform).

Bug: None
Test: Ran updated chrome on samus and verified it starts up.
Change-Id: I352d5e07051b08151773a9b0a4b259e8f3d21cd2
Reviewed-on: https://chromium-review.googlesource.com/883969Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531677}

ComputedAccessibleNode will have access to a snapshot of the
accessibility tree stored in content/renderer via the AomAXTreeProvider.
This provider is exposed to the ComputedAccessibleNode via Platform.

BUG=792783

Change-Id: I7a715bbdb7ad30d542c8d1848b3f1a39d77f5ccd
Reviewed-on: https://chromium-review.googlesource.com/848575
Commit-Queue: Meredith Lane <meredithl@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531676}

The current definition ("Tabs.MaxWindowsInADay: The maximum number of
windows opened at the same time over the course of a day") is a little
bit confusing because it's not clear if this is tracking open events,or
how many windows are existing in general, this CL clarify this.

Bug: 720131
Change-Id: Ie1cf08d7b98719a7e393b8fcd366f8ee0bea9ffb
Reviewed-on: https://chromium-review.googlesource.com/884326Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531675}

We change uses of Function.prototype.call to the safe builtin
$Function.call throughout guest view code.

Bug: 803668
Change-Id: I43ddeafe4e39d0d5092e366496da6757ad322855
Reviewed-on: https://chromium-review.googlesource.com/879245Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531674}

This cl does several things.

First, It removes the PrinterDetector::Observer::OnPrinterScanComplete
API hook.  That hook exists because we expected zeroconf printer
detection to take a non-trivial amount of time and we wanted to be
able to enable some UI indication that we were still looking for
printers until the scan was complete.  However, it turns out that
mdns/dns-sd traffic is all cached anyways by the ServiceDiscovery,
so we get initial printers back for zeroconf almost instantly, making
this hook pointless.

Second, the Observer API is changed so that it no longer guarantees an
OnPrintersFound callback to the caller after registration; instead the
client observing printer change events is responsible for calling
PrinterDetector::GetPrinters() to do the initial population of the
printer list.  This removes a lot of weird hacks to get thread safety
right.

This change also removes CupsPrintersManager::Start() and
PrinterDetector::StartObservers(), as these are no longer needed to
make startup safe.  These calls were added out of concerns that we
would encounter something like:

(in class Foo's constructor):
my_detector_->AddObserver(this);
   ->OBSERVER CALLBACK HAPPENS BEFORE Foo::Foo() IS FINISHED<-
	 ...rest of Foo's constructor...

However, this isn't a real problem for the API AFAICT.  Since the
observer callbacks are on the same sequence as the constructor, they
can't start until after the constructor finishes, meaning this is a
non-issue.

I think.  I would appreciate reviewers taking a bit of time to think
this through and see if they also believe this is now safe without the
Start() calls, as concurrency is sometimes hard to reason about.

This cl also removes some tests around StartObservers() that are no
longer relevant with the API changes.

Bug: 754834
Change-Id: Ia2e4c34b82ddf99a7551756c2bc037889f52df5b
Reviewed-on: https://chromium-review.googlesource.com/871660
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531673}

Change-Id: I067ad9a11dd0b852ce8d0a7eb78a287682a686c4
Reviewed-on: https://chromium-review.googlesource.com/882402Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#531672}

Content unittests crash when they call
RenderWidgetHostImpl::SubmitCompositorFrame because it calls
renderer_compositor_frame_sink_->DidReceiveCompositorFrameAck(resources)
that tries to dereference a nullptr (|receiver_|).

In my change, I stub out |renderer_compositor_frame_sink_| with a mock
in each failing content unittest, by replacing
CompositorFrameSinkClientPtr (|renderer_compositor_frame_sink_|) with a
CompositorFrameSinkClientPtr bound to MockCompositorFrameSinkClient.

Bug: 795397
Change-Id: Ibb820023332c7c6d2203b6e48549043ec0aa638f
Reviewed-on: https://chromium-review.googlesource.com/875013Reviewed-by: Yi Xu <yiyix@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Shridhar Sundarraj <sundarrajs@google.com>
Cr-Commit-Position: refs/heads/master@{#531671}

Bug: 721516
Change-Id: I80ef1e4b11cb44019f2136c60d3bb05431fa7916
Reviewed-on: https://chromium-review.googlesource.com/883979Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531670}

The waterfall tests on Mac appear to be flaky so disabling GPU for Mac platforms as well.

Bug: chromedriver:1695
Change-Id: Id39fea14a40857bec33e78ffe2d3c65e51ada91c
Reviewed-on: https://chromium-review.googlesource.com/884303
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531669}

This patch is in preparation for switching the accessibility
enums in ui/accessibility/ax_enums.idl to a .mojom file instead.
Because the generated C++ headers from a .mojom file use enum
class instead of enum, we need to explicitly cast anytime we
use an enum as an int. Some helpers are added to AXNodeData
for the most common cases.

Bug: 650275
Change-Id: Icf2df4bdedb7faf6d1e7bd3ffd3639faa8c1409f
Reviewed-on: https://chromium-review.googlesource.com/875551
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531668}

This is so we could have one simple flag to use for a holdback group and
be able to query its status in client code (eg, in interventions-internals).

Bug: 803221
Change-Id: I8591de5ce107a4088e2e9c634c4ca4a90bb75d7b
Reviewed-on: https://chromium-review.googlesource.com/871730Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531667}

Remove dependency on NotificationUiManager but keep dependency on
MessageCenter (this test is testing code that has to run in the same
process as MessageCenter).

This should make one flaky test more consistent. One other test is
deleted because it's a duplicate of another test also named
WebNotifications (currently lives in ash/ with a todo to move to
ui/message_center).

Bug: 783018
Change-Id: I9c6f6e5aa149fe4d65c526d7ad8c4f5d6eeb074f
Reviewed-on: https://chromium-review.googlesource.com/882883Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531666}

Headers are not always available in WillProcessResponse, only on HTTP(S)
responses.  This change updates the documentation to make that clear.

Change-Id: I1ef27b07aa643310bcf9d76d2c1f1d3a854b721a
Reviewed-on: https://chromium-review.googlesource.com/879128Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531665}

This CL allows parallel download to work with network service.
It uses ResourceDownloader to send the parallel requests.

Bug: 715640
Change-Id: I50094ddfc59be2615d8543a30c3c54199abcdea7
Reviewed-on: https://chromium-review.googlesource.com/884203
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531664}

The API |CVC.performAccessibilityAction| had not been previously
implemented but accidentally hooked to the correspodning a11y method
in one of the refactoring efforts https://crrev.com/c/c863082.
This CL reverts it.

This cannot be the root cause of the reported bug since the bug predates
the culprit CL. But makes sense to link to it since it is related.

Bug: 805014
Change-Id: Ib8065bd89a551397a4e1249f1bd448872c7a71a8
Reviewed-on: https://chromium-review.googlesource.com/882525Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531663}

https://chromium.googlesource.com/angle/angle.git/+log/7e9b13b5b0d2..adcf0ae6162d

$ git log 7e9b13b5b..adcf0ae61 --date=short --no-merges --format='%ad %ae %s'
2018-01-24 lucferron Replace all NULL with nullptr

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I39b2b12e728e4264bae120248041e4270e29b71b
Reviewed-on: https://chromium-review.googlesource.com/884327Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531662}

This patch completely changes the layout:
* The extension icon is now on the left. The icon, title, and webstore
  data are moved into BubbleFrameView's title area, which simplifies
  the layout.
* The extension info section (permissions, etc) is now the width of the
  dialog, instead of having a fixed width.
* The extension info section is no longer bulleted, instead it uses a
  secondary text style to distinguish lines from each header. Detailed
  permissions are still bulleted. Indentation in this section is
  removed.
* Each block in the extension info section now creates a {header,
  content} representation that's handled in a standard way when
  creating the layout.
* The animation when showing details is removed. The dialog will now
  expand to accommodate the details if it has room to do so.

See screenshots in the associated bug.

Bug: 605657
Change-Id: Ie6815038138e524ff053449ec393d6cc6c1cf956
Reviewed-on: https://chromium-review.googlesource.com/841746Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531661}

Test was waiting for activity to be created, but not for native
initialization to complete.

Bug: 804521
Change-Id: I5964546bdb4178f26fd60940443ecb9493e76912
Reviewed-on: https://chromium-review.googlesource.com/882942Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531660}

Applaunchertabhelper's RequestToLaunchApp doesn't retain urls before prompting.
Adding Retaining to the URLs.

Bug: 805577
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5c0cb8b236997126534bc3fc0d16a90e4504cc47
Reviewed-on: https://chromium-review.googlesource.com/884304Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531659}

This fixes bad font visuals on Pixel XL.  It's unclear why this was not
happening on other platforms, but maybe clamping to 0.5 made the nearest
neighbor fall on the wrong pixel in some cases.

We should not be bothering to clamp when there is not bilinear filtering
on anyway, so this should be a positive change for all platforms in
terms of shader work.

Bug: 803374
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ia81af34fbef2a33883c50582adbfc59ce2ae6714
Reviewed-on: https://chromium-review.googlesource.com/883944Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531658}

Bug: 798079
Change-Id: I45d5bdf444d8d8d1605593afa83dfe25d68d3bb0
Reviewed-on: https://chromium-review.googlesource.com/862259
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531657}

This CL adds a subtitle to the MediaControls captions overflow button
that displays the name of the selected text track, or "Off" if no text
track is selected. The logic for determining the name of the track is
reused from MediaControlTextTrackListElement, and has been moved to
MediaControlsImpl to be shared.

Bug: 775539
Change-Id: I450e7be2bcd994f3461e388e6ddc5e160617c8c6
Reviewed-on: https://chromium-review.googlesource.com/881583
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531656}

Add crbugs to the use_client_side_arrays_for_stream_buffers workarounds.

TBR=kbr@chromium.org

Bug: 178093
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8516cefd80bc96e06f1787f39c405f528fd10e58
Reviewed-on: https://chromium-review.googlesource.com/882489Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531655}

This reverts commit 8eb4ed81.

Reason for revert: Broke Mac Retina Release (NVIDIA) under
chromium.gpu.fyi:
https://ci.chromium.org/buildbot/chromium.gpu.fyi/Mac%20Retina%20Release%20%28NVIDIA%29/7282

Original change's description:
> Mac gl_unittests: reenable GLImageBindTest BGRX_1010102
> 
> This CL reenables the GLImageBindTest for BGRX_1010102, adding a provision
> to swap the B and R components on nVidia platforms to avoid some mysterious
> bug -- this is likely afflicting only the glReadPixels() since other tests
> (e.g. crrev.com/c/862326 render colors without swapping), filed as
> http://www.openradar.me/36824694, rdar://36824694.
> 
> Bug: 803473
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I73dbe09b1c1d26cc8ac195808545de63da082ac7
> Reviewed-on: https://chromium-review.googlesource.com/879331
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#531557}

TBR=ccameron@chromium.org,mcasas@chromium.org

Change-Id: Ica55ba2ed4b1ed64d11e72bb6c254e155cf14fc7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 803473
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/883642Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531654}

I extended chrome.passwordsPrivate with the onPasswordsFileExportProgress
event and a callback to exportPasswords function. These serve to notify
the UI about the progress of an export request.

Bug: 789561
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic2e3c81c2c92128c0726da3193205765350b8df0
Reviewed-on: https://chromium-review.googlesource.com/787472Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531653}

No-Try because the test has not been imported yet.

TBR=foolip

No-Try: True
Bug: 805463
Change-Id: I3418bc42699e7f9aa7e8e501c53ab881b5933594
Reviewed-on: https://chromium-review.googlesource.com/883729Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531652}

Bug: 800137
Change-Id: I7e69b12cb914519f7ae47b234e6db2477d803d2d
Reviewed-on: https://chromium-review.googlesource.com/875004
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531651}

This test was re-enabled last year (May 2017) in order to investigate
the flakiness but it appears to still be flaky and is causing several
failures per day in sheriff-o-matic.

TBR=vmiura@chromium.org

BUG=713260

Change-Id: Idefbba7c8b6fa32e1bd75a39fcae422ca9c5d4b9
Reviewed-on: https://chromium-review.googlesource.com/884181Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531650}

https://skia.googlesource.com/skia.git/+log/44804c030bc2..c341d3829d47

$ git log 44804c030..c341d3829 --date=short --no-merges --format='%ad %ae %s'
2018-01-24 halcanary SkQP: make report.html smaller
2018-01-24 fmalita [skottie] "hold" keyframe support

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: I9017e1ef8f4e99ea585d9516916d177a5a2344b2
Reviewed-on: https://chromium-review.googlesource.com/884202Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531649}

This fixes "Removed" not appearing if you click a download after
deleting its file from disk.

Bug: 802232
Change-Id: Ia131bda2ef5968eaeb40005132dada4fe070ed58
Reviewed-on: https://chromium-review.googlesource.com/883727Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531648}

recordTimesHistogram() and siblings use |long|, but UMA only
accepts int32, so the values are clamped in function
recordCustomTimesHistogramMilliseconds(). Assert the ranges
are within int32 to be safe.

Bug: 803541
Change-Id: I498b08f343391858586b2931442cf15eb39fd3c3
Reviewed-on: https://chromium-review.googlesource.com/834763
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531647}