GitLab

Steps to reproduce:
1. Type some keys in |mUrlTextView| to show some suggestions.
2. Press "Go" button.

What heppended:
The url loading starts but the suggestions does not disappear.

BUG=none

Review URL: https://codereview.chromium.org/312673007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274575 0039d316-1c4b-4281-b951-d872f2087c98

This is another attempt to try to figure out where we are really
hanging when this test hangs on the Win7 WebRTC bot.

no-try to bypass flaky win_rel bot.

TBR=grunell@chromium.org
BUG=373252
NOTRY=true

Review URL: https://codereview.chromium.org/309273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274574 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274571 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378414
TEST=several unittests

Review URL: https://codereview.chromium.org/309793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274570 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175314:175351&mode=html

TBR=jchaffraix@chromium.org
NOTRY=true (don't trust the Android try-bot to be correct, will stick around)
BUG=

Review URL: https://codereview.chromium.org/315603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274569 0039d316-1c4b-4281-b951-d872f2087c98

Update native modifier state to reflect the rewritten ui::Event state before the X11 mouse code uses it.

Also splits code for the various ui::Event subclasses out of RewriteEvent() for clarity.

BUG=372485
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/280413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274568 0039d316-1c4b-4281-b951-d872f2087c98

This broke various builds (http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/54738/steps/runhooks/logs/stdio for example) since chrome_renderer.gypi (and maybe other files) still have refernces to the old location of these resources.

> Move some extensions renderer resources to extensions_renderer_resources.grd.
> 
> This breaks the remaining dependency from src/extensions to chrome resources files.
> 
> BUG=368334
> 
> Review URL: https://codereview.chromium.org/307833002

TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/309413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None 
CID=115769

Review URL: https://codereview.chromium.org/309113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274564 0039d316-1c4b-4281-b951-d872f2087c98

Populates the count of entities per type in about:sync.

Includes C++ code to count and emit the set of deleted and non-deleted
counts, though for space reasons only the non-deleted count is displayed
on the about:sync page.

This calculation is somewhat expensive.  It could be made cheaper by
having an index in the Directory to keep track of which entities belong
to which type, but that doesn't exist at the moment.  For now, we just
avoid calculating these counts unless the about:sync page is open.

BUG=349301

Review URL: https://codereview.chromium.org/302283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331453,380238
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/309403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274562 0039d316-1c4b-4281-b951-d872f2087c98

Apparently libtool on Mac doesn't understand the "@" syntax.

BUG=
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/309113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274561 0039d316-1c4b-4281-b951-d872f2087c98

* Remove null check
* Simplify NestedAcceleratorDelegate interface.

BUG=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/312483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274560 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/291933002 solved
these suppressions.

BUG=364675,158510

Review URL: https://codereview.chromium.org/308713013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274559 0039d316-1c4b-4281-b951-d872f2087c98

This breaks the remaining dependency from src/extensions to chrome resources files.

BUG=368334

Review URL: https://codereview.chromium.org/307833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274558 0039d316-1c4b-4281-b951-d872f2087c98

Currently, subprocess_mu_ is held the entire time the ld subprocess is
starting. This blocks a larger refactor that I'd like to make as part of nexe
loading.

I'd like to change ServiceRuntime::LoadModule() to be asynchronous to simplify
threading behavior on the plugin side when loading nexe modules. However, this
requires that many methods are made asynchronous, including
Plugin::LoadHelperNaClModule().

PnaclTranslateThread will need to use a pattern similar to WaitForSelLdrStart()
to resume execution on a background thread. However, I don't like the idea of
introducing another mutex and condvar to deal with while holding
subprocess_mu_.

This change narrows the time that subprocess_mu_ is held to make that refactor
possible. This follows a similar change made for the llc subprocess.

BUG=333950
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/308193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274557 0039d316-1c4b-4281-b951-d872f2087c98

Broke BookmarkAppHelperExtensionServiceTest.CreateBookmarkApp on Linux Clang (dbg) and other bots: 
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Clang%20%28dbg%29&number=60356 

[ RUN ] BookmarkAppHelperExtensionServiceTest.CreateBookmarkApp 
[26813:26813:0603/095344:697268828:FATAL:render_process_host_impl.cc(501)] Check failed: is_self_deleted_. RenderProcessHostImpl is destroyed by something other than itself 
#0 0x7fb30098e8de base::debug::StackTrace::StackTrace() 
#1 0x7fb300a21b85 logging::LogMessage::~LogMessage() 
#2 0x7fb308595006 content::RenderProcessHostImpl::~RenderProcessHostImpl() 
#3 0x7fb3085955a9 content::RenderProcessHostImpl::~RenderProcessHostImpl() 
#4 0x000000eef1df (anonymous namespace)::BookmarkAppHelperExtensionServiceTest::TearDown() 
#5 0x0000039dd3c3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() 
#6 0x0000039ca68e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() 
#7 0x0000039c159a testing::Test::Run() 
#8 0x0000039c1c6b testing::TestInfo::Run() 
#9 0x0000039c225a testing::TestCase::Run() 
#10 0x0000039c6868 testing::internal::UnitTestImpl::RunAllTests() 
#11 0x0000039d60d3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() 
#12 0x0000039cc26e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() 
#13 0x0000039c64f4 testing::UnitTest::Run() 
#14 0x00000594af51 RUN_ALL_TESTS() 
#15 0x000005949ff7 base::TestSuite::Run() 
#16 0x00000595dc4d content::UnitTestTestSuite::Run() 
#17 0x000003a80772 base::internal::RunnableAdapter\u003C>::Run() 
#18 0x000003a806dc base::internal::InvokeHelper\u003C>::MakeItSo() 
#19 0x000003a8068a base::internal::Invoker\u003C>::Run() 
#20 0x000002b6f0de base::Callback\u003C>::Run() 
#21 0x00000594404e base::(anonymous namespace)::LaunchUnitTestsInternal() 
#22 0x000005943d40 base::LaunchUnitTests() 
#23 0x000003a80450 main 
#24 0x7fb2f7c6076d __libc_start_main 
#25 0x000000710379 \u003Cunknown> 

> Add generateAppForLink function in chrome.management
> 
> This function takes a url and a title as input, generates and
> returns a bookmark app.
> 
> R=benwells@chromium.org,kalman@chromium.org,calamity@chromium.org
> BUG=370350
> 
> Review URL: https://codereview.chromium.org/266353006

TBR=wjywbs@gmail.com

Review URL: https://codereview.chromium.org/313633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274556 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379128

Review URL: https://codereview.chromium.org/315493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274553 0039d316-1c4b-4281-b951-d872f2087c98

This function takes a url and a title as input, generates and
returns a bookmark app.

R=benwells@chromium.org,kalman@chromium.org,calamity@chromium.org
BUG=370350

Review URL: https://codereview.chromium.org/266353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274549 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368495
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/314483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274547 0039d316-1c4b-4281-b951-d872f2087c98

As discussed with cpu@, transition the ownership to waffles@.

Review URL: https://codereview.chromium.org/315463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274546 0039d316-1c4b-4281-b951-d872f2087c98

This interface will be used by controller's UI to pass through pairing.

BUG=375191

Review URL: https://codereview.chromium.org/304603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274545 0039d316-1c4b-4281-b951-d872f2087c98

Fix for https://codereview.chromium.org/293693003

BUG=369409
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/307393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274544 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/309173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/314453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274542 0039d316-1c4b-4281-b951-d872f2087c98

Create AccountServiceFlagFetcher which downloads an account's Gaia service flags, using https://accounts.google.com/GetUserInfo.

BUG=372381

Review URL: https://codereview.chromium.org/284763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274541 0039d316-1c4b-4281-b951-d872f2087c98

If a commit aborts, then PictureLayer::update_source_frame_number_ will
be stale since only a finished commit would update the
LTH::source_frame_number_.  This could lead to an issue where a commit
aborts and then on the next frame a layer's size is updated *and* it is
set to not draw.  This causes it to skip being updated (meaning the pile
size is not updated) but the layer bounds have changed and trips an
assert in PushPropertiesTo that tries to make sure that the pile and
layer bounds are the same when a layer has been updated that frame.

The fix here is to update the source frame number even for aborted
commits.  This causes the PushPropertiesTo assert to properly be
ignored.

BUG=375675

Review URL: https://codereview.chromium.org/307653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178409
TBR=phajdan.jr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/311863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274539 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379986

Review URL: https://codereview.chromium.org/302403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274538 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274531 0039d316-1c4b-4281-b951-d872f2087c98

This change pulls out more OpenManifestEntry code from service_runtime, making
PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
logic out of the trusted plugin.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/302093012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274530 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces ProfilerMetricsProvider, which takes the profiler data
recording responsibilities that were previously part of MetricsLog.
ProfilerMetricsProvider records profiler data into a cached proto and then
merges this data into the actual UMA proto in RecordGeneralMetrics().

BUG=379881

Review URL: https://codereview.chromium.org/306023010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274528 0039d316-1c4b-4281-b951-d872f2087c98

R=rmcilroy@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/300223008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274526 0039d316-1c4b-4281-b951-d872f2087c98

The version script was being ignored in non-gcc (clang) builds.

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/315563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274525 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380081

Review URL: https://codereview.chromium.org/310753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378713
TEST=manual test:
1Launch chrome and navigate to chrome://webrtc-internals/. 
2.Expand "Create Dump" option >> Check the checkbox option of "enable Diagnostic audio recordings". 
3.With "Save File" overlay opened, again uncheck the same checkbox.

Review URL: https://codereview.chromium.org/310463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274523 0039d316-1c4b-4281-b951-d872f2087c98

This refactors GetDeviceIdentifier function into GetDeviceIdentifier
and GetSaltedString. GetSaltedString is a utility function that can
be used elsewhere.

Review URL: https://codereview.chromium.org/309963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274520 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376860

Review URL: https://codereview.chromium.org/304983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274519 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the Enumeration to be based on 
a callback passed to the VideoCaptureDeviceFactory.
It is used for QTKit enumeration on UI thread:
this is speculatively better than trying to run
-performSelectorOnMainThread:withObject:waitUntilDone:

-- Description --

Currently VCM::EnumerateDevices() issues an internal 
PostTaskAndReplyWithResult where the first part
is GetAvailableDevicesInfoOnDeviceThread() on 
DeviceThread and the second is 
OnDevicesInfoEnumerated() in IO thread.

This CL changes this to a simple PostTask to the 
VCDFactory::EnumerateDeviceNames() with a callback
to VCM::ConsolidateDevicesInfoOnDeviceThread().
This method has a jump at the end to 
VCM::OnDevicesInfoEnumerated() on IO thread. So
what used to be a simple back-and-forth jump is
now a 3 hop process. 

This is used for QTKit to be able to override the
VCDF::EnumerateDeviceNames and run the device
enumeration in UI thread. 

Note 1: The UI thread is currently passed in Create()
method for all implementations. This is changed to
earlier: on VCDF::CreateFactory(); injected from 
MediaStreamManager; and only used in VCDFLinux 
(for ChromeOS) and in VCDFMac for QTKit enumeration.
This approach is cleaner since we don't send UI thread
references to derived classes that don't need it.

Note 2: VideoCaptureDeviceFactoryMac::Create()
used to have a search-and-find for |device_id| that
is removed; the search was a precaution for devices
that disappeared between first enumeration and use.
However, using a |device_name| that is gone would
just cause a fail on AllocateAndStart() anyhow, and
enumerating twice is very expensive.
 For compatibility reasons, this behaviour is kept
for AVFoundation devices and blacklisted QTKit
devices (that behave as a subset of AVF-type ones).



BUG=255552, 115327

Review URL: https://codereview.chromium.org/294893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274518 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274516 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff mvstanton@chromium.org in case of problems.

TBR=mvstanton@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/310813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274515 0039d316-1c4b-4281-b951-d872f2087c98