GitLab

ImageBitmap can fail to be created, if it doesn't fit in memory.

Bug: 936885
Change-Id: I694ed4fb964782f84cdec33d465a1e404aca6324
Reviewed-on: https://chromium-review.googlesource.com/c/1496921
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636848}

Do the same for ConstrainedDialogWebView. Fix lint errors along the way.

Change-Id: I8ce13cb4fd8891c610a20c49dcec32b465327c1b
Reviewed-on: https://chromium-review.googlesource.com/c/1496449
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636847}

Bug: 936505
Change-Id: If468227536553d528951ce88744146c5f6913d58
Reviewed-on: https://chromium-review.googlesource.com/c/1495597
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636846}

Also adds a ui::test::TestEventSource to consolidate some shared
unit test support.

Excludes keyboard rewriters, which will be converted in a separate CL,
together with the non-ash ChromeOS event rewriter.

See crrev.com/c/1437697 (review) or http://crrev.com/631851 (commit)
for full information on the API change.

Bug: none
Test: converted unit tests
Change-Id: Ib310e07efd0c5f2730514f15ae2cb82d2e6993ca
Reviewed-on: https://chromium-review.googlesource.com/c/1435902Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636845}

R=ericrk@chromium.org

Bug: 936575
Change-Id: I0265188debd9a94083272b4658b57994767bbc5f
Reviewed-on: https://chromium-review.googlesource.com/c/1492424
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636844}

Bug: 934054
Test: run_cts.py --platform M -f android.webkit.cts.WebViewSslTest.testSecureServerRequestingClientCertDoesNotCancelRequest
Test: run_cts.py --platform N -f android.webkit.cts.WebViewSslTest.testSecureServerRequestingClientCertDoesNotCancelRequest
Change-Id: Ia4128fe82932719cc0336beb5b67eaae36978150
Reviewed-on: https://chromium-review.googlesource.com/c/1496252Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636843}

TBR=riajiang@chromium.org

Bug: 937134
Change-Id: I01fa4a4023a778f40a72c9f035b30270d969bb0a
Reviewed-on: https://chromium-review.googlesource.com/c/1495973Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636842}

Don't assume a certain number of frames for receiving style updates
rather poll everyframe until change is noticed.


Bug: 915352
Change-Id: I92c78bc94c82de561f4867a596c449eb6dd39603
Reviewed-on: https://chromium-review.googlesource.com/c/1495227
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636841}

This CL generates Java GAIAServiceType IntDef from GAIAServiceType enum.
Manually added values are removed an existing usages are annotated with
@GAIAServiceType.

Bug: 936953
Change-Id: If443591ba5fc0df234b4d2eb86f562e504037747
Reviewed-on: https://chromium-review.googlesource.com/c/1495549Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636840}

[nil description] returns nil, not @"nil", which meant that doing:
  EXPECT_NSEQ(a, b)
where either a or b is nil and a != b will cause a test to crash rather than
failing, when the CmpHelperNSEQ function tries to use StringDescription(nil).
This only affects comparisons of NSObject instances with *_NSEQ/*_NSNE.

NOPRESUBMIT=true

Bug: None
Change-Id: I29ef9adc1fd8cba5d1d690d6fa7b7c2bd3600dcd
Reviewed-on: https://chromium-review.googlesource.com/c/1494796Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636839}

Most of these are macros that expand to nothing when dchecks are off, but
to a declaration when dchecks are on. They are meant to be used to declare
member variables.

Since clang-format gets very confused on class member declarations that
don't end in a semicolon and since we require clang-formatting,
we need some way to still permit a semicolon after these macros even
with dchecks off. To that end, add a dummy static_assert() at the end
of these macros.

Alternatively, we could surround all uses of these macros with explicit
DCHECK_IS_ON() checks.

Depends on https://skia-review.googlesource.com/c/skia/+/196421

TBR=dalecurtis

Bug: 926235,936856
Change-Id: I66ab08f383b2f27dc6a7617f67f33fa66ddfa00c
Reviewed-on: https://chromium-review.googlesource.com/c/1495041
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636838}

This CL adds methods to shut down the ReportingService and the
NetworkErrorLoggingService. Previously, we were destroying the
NEL service and the ReportingService when the NetworkContext was
torn down, leading to a use-after-free when destroying the
ReportingService caused pending uploads to be cancelled,
generating NEL reports for the cancelled requests, that would be sent
to the already-destroyed NEL service. This fixes the issue by shutting
down rather than destroying the NEL service and ReportingService in the
destructor of ContainerURLRequestContext.

Bug: 935209
Change-Id: Id53d8430a974336b8016d0cd73fa837f2a1e1d1b
Reviewed-on: https://chromium-review.googlesource.com/c/1489098Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636837}

• Updated logic of calculating initial current time of non-composited scroll-linked animations to
  ensure that the start time is always initialized to zero.
• Changed signature of cc::ScrollTimeline::CurrentTime to return base::Optional<base::TimeTicks>.
  This is to enforce cc: WorkletAnimation::CurrentTime operating in the same units of
  base::TimeTicks and correctly handling NaN values.
• Adjusted start time of scroll-linked animations when playback rate is updated.


Bug: 852475
Change-Id: Iffd966c1b3ef6d821eef7cc2f6f79dae790a69f3
Reviewed-on: https://chromium-review.googlesource.com/c/1461513
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636836}

... to use downcast helpers

BUG=891908

R=jbroman@chromium.org
CC=blink-reviews-vendor@chromium.org

Change-Id: I73216ed5fadbd095498e98613e089cea1b7514fb
Reviewed-on: https://chromium-review.googlesource.com/c/1494680
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636835}

This CL intends to disentangle frame-based and BrowserPlugin-based IPCs
(browser to renderer) by:
  1- Making MimeHandlerViewContainerManager the entry point of browser
     to renderer IPCs.
  2- Move the frame-based only IPCs to MimeHandlerViewContainerManager.
  3- Replicate the IPC
     ExtensionGuestViewMsg_MimeHandlerViewGuestOnLoadCompleted for
     frame-based MimeHandlerView inside MimeHandlerViewContainerManager.
  4- Remove some code which becomes useless after the change.

Eventually the renderer to browser IPCs will also be disentangled.

Bug: 659750, 896679
Change-Id: I85d7a2a1d7a1f7176c0a3d4ddf80d025f3fcadd5
Reviewed-on: https://chromium-review.googlesource.com/c/1491994
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636834}

This is addressing an old TODO, that should be safe to address.

Bug: 455427
Change-Id: I6cdcd6072ef942a49c0e3eb996e2f93df7b293e1
Reviewed-on: https://chromium-review.googlesource.com/c/1496453Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636833}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07a259de1240..329fac37dd27


Created with:
  gclient setdep -r src-internal@329fac37dd27

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id31cd550d0ca31885ff584a90fef4a0936cf726b
Reviewed-on: https://chromium-review.googlesource.com/c/1496952Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636832}

The formatter creator is in charge of constructing the appropriate formatter.
Formatters are responsible for producing labels according to the formatter
type.

These labels contain disambiguating information to display to users in the
Autofill dropdown.

Change-Id: Ia63ab173e4449dc744d7ee39ea887494466dff29
Reviewed-on: https://chromium-review.googlesource.com/c/1489181
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#636831}

A <textarea> currently exposes all text like so:
textarea node
  static text node
    inline text box node
    ...

i.e. all lines are under just one static text. Given 1000+ lines, this amounts to a fairly flat tree structure. The computation of necessary text attributes such as indexing into the lines for the purposes of finding the line with text selection becomes increasingly expensive.

In a similar content editable, the large static text would hvae been split into multiple static texts.

The user consequence is that in a textarea with just a few hundred lines becomes unusable. ~4 second latency between key press and speech output.

Bug: 936947:
Change-Id: I9772851ba34c8ec1945e83a7d0baa2676cedad3f
Reviewed-on: https://chromium-review.googlesource.com/c/1496299Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636830}

Moves the filtering responsability to the password store. This causes a
faster and smaller fetch when not all the credentials are needed.
Updates the API of the mediator and the fetcher so only the required
args are passed.
Renames |disableFilter| to something that reflects the actual intent of
that variable.
Updates local test to include the complete spec of the saved password,
so the query works when it is not a domain.

Bug: 932089
Change-Id: Ibcf64953db4e314f4111289e1fff4a248fd8679b
Reviewed-on: https://chromium-review.googlesource.com/c/1491652Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636829}

TBR=peter@chromium.org
NOTRY=true

See dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fbackground-fetch%2Ffetch.https.window.html

Bug: 937312
Change-Id: Icef179aa3da1120419c4d59ee0005f871cebccaf
Reviewed-on: https://chromium-review.googlesource.com/c/1496477Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636828}

This is a reland of ae50f0f0

Original change's description:
> Unify input delay computations for UMA, UKM, and EventTiming
>
> This CL moves the input delay computations for UKM to further down the
> pipeline to where they are computed for EventTiming. After this CL, the
> same types of events are logged by both UMA/UKM and EventTiming. The
> WebViewTest is fixed so that the artificial events move further enough
> down the pipeline. The tests checking for pointerCancels are no longer
> applicable since these only applied to the UMA/UKM computations, per
> issue 924278.
>
> By unifying input delay computation, this CL also fixes frame
> attribution for the UMA/UKM input delays: PageWidgetDelegate does not
> know the target frame (before, it would tell the root that an event has
> occurred even if it occurred in an iframe.
>
> Bug: 897656, 925130
> Change-Id: I27dba1cbb82ad780d21166a5469001e266612a78
> Reviewed-on: https://chromium-review.googlesource.com/c/1476070
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#635687}

TBR=dtapuska@chromium.org, holte@chromium.org

Bug: 897656, 925130
Change-Id: Ifa253657428ee7a04d3af7b06257482d7e948b58
Reviewed-on: https://chromium-review.googlesource.com/c/1496336Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636827}

After selecting an item, the menu disappears. Then if we refocus on the
EditableCombobox we expect the filtering to be based on the selected
item. Before this CL it would still be based on the last thing we typed
(a substring of the selected item), so it could show more items than
necessary.

This CL fixes the issue, adds a unit test, and refactors a little bit.
It moves the ShowDropDownMenu call out of HandleNewContent, which is
called inside OnItemSelected to fix the bug.

Bug: 923660
Change-Id: Iaf6a713763d9d5dd5b2c96186fe2ea0898eec978
Reviewed-on: https://chromium-review.googlesource.com/c/1493516Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Edin Kadric <edinkadric@google.com>
Cr-Commit-Position: refs/heads/master@{#636826}

TBR=pkotwicz@chromium.org

Bug: 937109, 937242
Change-Id: Icce1df35be4168053d8e3f22e0f502e56fd9d642
Reviewed-on: https://chromium-review.googlesource.com/c/1495971
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636825}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d01c24e5..c4eb13c7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I468fa88ad1f085426a22617566b41d806b6b2292
Reviewed-on: https://chromium-review.googlesource.com/c/1496764Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636824}

This will ensure that no observers are being leaked.

Change-Id: I41d20eb4105afb894423113029563a548ec8507e
Reviewed-on: https://chromium-review.googlesource.com/c/1487361Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636823}

This change removes third-party-doodles, and adds a comment to the switch it
used to control explaining test URLs to use.

Bug: None
Change-Id: I37e1d90ec6aafa032bc95eac4f670a6b7f1d4cc2
Reviewed-on: https://chromium-review.googlesource.com/c/1494894
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636822}

https://webrtc.googlesource.com/src.git/+log/859abef68cb5..2997ec9a7a46


git log 859abef68cb5..2997ec9a7a46 --date=short --no-merges --format='%ad %ae %s'
2019-03-01 srte@webrtc.org Removes unused keep-alive from RtpTransportControllerSend.
2019-03-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 24eaf090..8eb8e09f (636660:636762)
2019-03-01 srte@webrtc.org Inject TaskQueueFactory to video streams.


Created with:
  gclient setdep -r src/third_party/webrtc@2997ec9a7a46

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia606fa78fa45fbc17bb18515655e356c8c6f4532
Reviewed-on: https://chromium-review.googlesource.com/c/1496894Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636821}

Per email discussions with mpearson and jdonnelly.

Bug: None
Change-Id: Ide70ace4a2c845f79eb82b311f60830692b802fe
Reviewed-on: https://chromium-review.googlesource.com/c/1496917
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636820}

This page is a Mojo-based WebUI page, and it supports the following
operations:
* Read key/value properties of the system, currently flag state,
  country code, and server endpoint.
* Clear the catalog database.
* Override the request country.
* Force a network request.

Bug: 900673
Change-Id: Iafff7c0b66f37a93bd46e7251ba231823951a513
Reviewed-on: https://chromium-review.googlesource.com/c/1310757Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636819}

Bug: 870056
Change-Id: I6e1dbf041d0b57a9457eb421cf7a4cc2a9cc7ebc
Reviewed-on: https://chromium-review.googlesource.com/c/1494721Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636818}

Per email discussions with jdonnelly and mpearson.

Bug: 936854
Change-Id: I33cf7093df298aab93f4ddeac01a58226f93a1a2
Reviewed-on: https://chromium-review.googlesource.com/c/1496913
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636817}

Currently we only call SetProfile once during initialization with
non-null |profile|. Remove preconditions that allow null |profile| if
|profile_| is already set.

This simplifies metrics recording logic in upcoming change as we no
longer consider null |profile|.

Bug: 929583
Change-Id: I68b4ac064ec07984844dc04f92ea46cf36613a21
Reviewed-on: https://chromium-review.googlesource.com/c/1493632Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636816}

This reverts commit 50c337ce.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Disable flaky test testPendingUpdateFileDeletedAfterUpdateCompletion
> 
> TBR=pkotwicz@chromium.org
> NOTRY=true
> 
> Bug: 937109
> Change-Id: I877a311f3256b88a667ff8224904e2fe71acb30b
> Reviewed-on: https://chromium-review.googlesource.com/c/1496767
> Reviewed-by: Yi Gu <yigu@chromium.org>
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636812}

TBR=pkotwicz@chromium.org,yigu@chromium.org

Change-Id: I6d4183a9d42acc43566506e23b863bfd439b8033
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 937109
Reviewed-on: https://chromium-review.googlesource.com/c/1496163Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636815}

This reverts commit 6c5b9879.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Disable flaky test testFileDeletedIfStoreWebApkUpdateRequestToFileFails
> 
> TBR=pkotwicz@chromium.org
> NOTRY=true
> 
> Bug: 937242
> Change-Id: Ic705e4dcfa5abb1dcd0ff5baa32b51f7f84c6b42
> Reviewed-on: https://chromium-review.googlesource.com/c/1496765
> Reviewed-by: Yi Gu <yigu@chromium.org>
> Commit-Queue: Yi Gu <yigu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636805}

TBR=pkotwicz@chromium.org,yigu@chromium.org

Change-Id: Ib48da2f508e3fd302c5116ca23e2b9fd0030b727
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 937242
Reviewed-on: https://chromium-review.googlesource.com/c/1495970Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636814}

Bug: chromium:907849
Change-Id: I94d4b14b3b7a23e6cc1888c26c0e1f2f16183f4c
Reviewed-on: https://chromium-review.googlesource.com/c/1495529Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636813}

TBR=pkotwicz@chromium.org
NOTRY=true

Bug: 937109
Change-Id: I877a311f3256b88a667ff8224904e2fe71acb30b
Reviewed-on: https://chromium-review.googlesource.com/c/1496767Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636812}

When a queue is disabled or blocked it's removed from the WorkQueueSet.
It is invalid to call WorkQueueSet::OnQueuesFrontTaskChanged for a
queue that is not in the set. Unfortunately
RemoveAllCanceledTasksFromFront was doing that in the currently
reverted patch to periodicallly reclaim memory. This patch adds a
check to see if the queue is in the set before calling
WorkQueueSet::OnQueuesFrontTaskChanged.

Bug: 936734
Change-Id: Ib4a2e9d85d8360924fdf97f314e32c83a12c5800
Reviewed-on: https://chromium-review.googlesource.com/c/1495541Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636811}

This extra will be moved to CustomTabIntent eventually.

Bug: 922969
Change-Id: I510e8c8901758fb9f4a5a009fee20df2e8ed71dc
Reviewed-on: https://chromium-review.googlesource.com/c/1496875Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636810}

At present TouchSelectionController uses |show_touch_handles_| to decide
when handles are shown by touch events. It is set to 'true' in
TouchSelectionController::WillHandleTouchEventImpl(). But if this value
is defaulted to true, then PDFs may show the handles on the first
selection, even if initiated by non-touch means. This doesn't show up
in non-PDF pages, as there seems to be a mechanism in
RenderWidgetHostViewAura that prevents the TouchSelectionController from
ever being told about selection changes from non-Touch events.

Some tests were fixed, since they relied on the old default value to
avoid having to send actual touch events.

The CL changes the default to avoid handles showing up for the first
mouse selection in PDFs.

Bug: 933631
Change-Id: I1d66df070c22481141f68f6085f04878842c9f2b
Reviewed-on: https://chromium-review.googlesource.com/c/1491794
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: AJITH KUMAR V <ajith.v@samsung.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636809}