Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 10 Nov, 2020 8 commits
    • Mark Pearson's avatar
      Revert "Reland "[Media Session] Fix for Lacros"" · 23f48a7f
      Mark Pearson authored 
      This reverts commit dde3defc.

Reason for revert:
browser_tests on linux-lacros-tester-rel consistently fail after this landed in
https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/4381

Failures are:
MediaKeysListenerManagerImplTest.ListensToTheCorrectMediaKeys
MediaKeysListenerManagerImplTest.PressPlayPauseKey
MediaKeysListenerManagerImplTest.OtherDelegatesPreemptHardwareKeyMediaController

They all crash:

[ RUN      ] MediaKeysListenerManagerImplTest.ListensToTheCorrectMediaKeys
DevTools listening on ws://127.0.0.1:37255/devtools/browser/5be580d5-fcf2-46b2-8f43-033ac20657af
[22277:22277:1109/134807.593313:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path.
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x55ec232b31d9 base::debug::CollectStackTrace()
#1 0x55ec2322bc63 base::debug::StackTrace::StackTrace()
#2 0x55ec22e77786 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f5f63b034c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf)
#4 0x55ec20957235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread()
#5 0x55ec22e76577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#6 0x55ec22f20fde content::ShellBrowserMainParts::PreMainMessageLoopRun()
#7 0x55ec226b9896 content::BrowserMainLoop::PreMainMessageLoopRun()
#8 0x55ec22b09c33 content::StartupTaskRunner::RunAllTasksNow()
#9 0x55ec226b8877 content::BrowserMainLoop::CreateStartupTasks()
#10 0x55ec226bb278 content::BrowserMainRunnerImpl::Initialize()
#11 0x55ec226b6f68 content::BrowserMain()
#12 0x55ec218feeb3 content::ContentMainRunnerImpl::RunServiceManager()
#13 0x55ec218feaa6 content::ContentMainRunnerImpl::Run()
#14 0x55ec218fbf54 content::RunContentProcess()
#15 0x55ec218fc8dc content::ContentMain()
#16 0x55ec22e75f8c content::BrowserTestBase::SetUp()
#17 0x55ec21670678 testing::Test::Run()
#18 0x55ec2167150f testing::TestInfo::Run()
#19 0x55ec21671ef7 testing::TestSuite::Run()
#20 0x55ec2167f677 testing::internal::UnitTestImpl::RunAllTests()
#21 0x55ec2167efdf testing::UnitTest::Run()
#22 0x55ec22ebf284 base::TestSuite::Run()
#23 0x55ec22e48027 content::ContentTestLauncherDelegate::RunTestSuite()
#24 0x55ec22e9a871 content::LaunchTests()
#25 0x55ec22e47fe0 main
#26 0x7f5f63aee840 __libc_start_main
#27 0x55ec1fce43ea _start

[ RUN      ] MediaKeysListenerManagerImplTest.OtherDelegatesPreemptHardwareKeyMediaController
DevTools listening on ws://127.0.0.1:37481/devtools/browser/4cec391a-3d7f-4854-bdcf-7c8abf8b0cbe
BrowserTestBase received signal: Segmentation fault. Backtrace:
[25621:25621:1109/134831.864948:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path.
#0 0x5636f5a041d9 base::debug::CollectStackTrace()
#1 0x5636f597cc63 base::debug::StackTrace::StackTrace()
#2 0x5636f55c8786 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7fbfcb8e44c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf)
#4 0x5636f30a8235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread()
#5 0x5636f55c7577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#6 0x5636f5671fde content::ShellBrowserMainParts::PreMainMessageLoopRun()
#7 0x5636f4e0a896 content::BrowserMainLoop::PreMainMessageLoopRun()
#8 0x5636f525ac33 content::StartupTaskRunner::RunAllTasksNow()
#9 0x5636f4e09877 content::BrowserMainLoop::CreateStartupTasks()
#10 0x5636f4e0c278 content::BrowserMainRunnerImpl::Initialize()
#11 0x5636f4e07f68 content::BrowserMain()
#12 0x5636f404feb3 content::ContentMainRunnerImpl::RunServiceManager()
#13 0x5636f404faa6 content::ContentMainRunnerImpl::Run()
#14 0x5636f404cf54 content::RunContentProcess()
#15 0x5636f404d8dc content::ContentMain()
#16 0x5636f55c6f8c content::BrowserTestBase::SetUp()
#17 0x5636f3dc1678 testing::Test::Run()
#18 0x5636f3dc250f testing::TestInfo::Run()
#19 0x5636f3dc2ef7 testing::TestSuite::Run()
#20 0x5636f3dd0677 testing::internal::UnitTestImpl::RunAllTests()
#21 0x5636f3dcffdf testing::UnitTest::Run()
#22 0x5636f5610284 base::TestSuite::Run()
#23 0x5636f5599027 content::ContentTestLauncherDelegate::RunTestSuite()
#24 0x5636f55eb871 content::LaunchTests()
#25 0x5636f5598fe0 main
#26 0x7fbfcb8cf840 __libc_start_main
#27 0x5636f24353ea _start

[ RUN      ] MediaKeysListenerManagerImplTest.PressPlayPauseKey
DevTools listening on ws://127.0.0.1:36939/devtools/browser/4a443d13-30b6-430d-a4b3-503ecbbdc73e
[4137:4137:1109/134809.976176:WARNING:ozone_platform_wayland.cc(200)] Failed to find drm render node path.
BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x5647f92c11d9 base::debug::CollectStackTrace()
#1 0x5647f9239c63 base::debug::StackTrace::StackTrace()
#2 0x5647f8e85786 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f6dac3524c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf)
#4 0x5647f6965235 content::MediaKeysListenerManagerImplTest::SetUpOnMainThread()
#5 0x5647f8e84577 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#6 0x5647f8f2efde content::ShellBrowserMainParts::PreMainMessageLoopRun()
#7 0x5647f86c7896 content::BrowserMainLoop::PreMainMessageLoopRun()
#8 0x5647f8b17c33 content::StartupTaskRunner::RunAllTasksNow()
#9 0x5647f86c6877 content::BrowserMainLoop::CreateStartupTasks()
#10 0x5647f86c9278 content::BrowserMainRunnerImpl::Initialize()
#11 0x5647f86c4f68 content::BrowserMain()
#12 0x5647f790ceb3 content::ContentMainRunnerImpl::RunServiceManager()
#13 0x5647f790caa6 content::ContentMainRunnerImpl::Run()
#14 0x5647f7909f54 content::RunContentProcess()
#15 0x5647f790a8dc content::ContentMain()
#16 0x5647f8e83f8c content::BrowserTestBase::SetUp()
#17 0x5647f767e678 testing::Test::Run()
#18 0x5647f767f50f testing::TestInfo::Run()
#19 0x5647f767fef7 testing::TestSuite::Run()
#20 0x5647f768d677 testing::internal::UnitTestImpl::RunAllTests()
#21 0x5647f768cfdf testing::UnitTest::Run()
#22 0x5647f8ecd284 base::TestSuite::Run()
#23 0x5647f8e56027 content::ContentTestLauncherDelegate::RunTestSuite()
#24 0x5647f8ea8871 content::LaunchTests()
#25 0x5647f8e55fe0 main
#26 0x7f6dac33d840 __libc_start_main
#27 0x5647f5cf23ea _start


Original change's description:
> Reland "[Media Session] Fix for Lacros"
>
> This is a reland of ddb531f7
>
> There is a fix in media_session_service.cc to allow the tests to pass
> when ash-chrome is not running.
>
> Original change's description:
> > [Media Session] Fix for Lacros
> >
> > At the moment in Lacros there are two instances of the
> > Media Session Service (MSS) one hosted in ash-chrome and
> > the other in lacros-chrome. This means that sessions in
> > either browser process cannot see sessions from the other.
> >
> > This changes it so when a client asks for lacros-chrome
> > MSS instead of providing a locally hosted MSS it binds
> > the MSS in ash-chrome.
> >
> > BUG=1140215
> >
> > Change-Id: Ic155a6cd928f0735095f849f309f9075dbb1d36f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485850
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Tommy Steimel <steimel@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Erik Chen <erikchen@chromium.org>
> > Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#825016}
>
> Bug: 1140215
> Change-Id: I64834d9be778998b42bf3447444a6955265215ef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525851
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825439}

TBR=avi@chromium.org,dcheng@chromium.org,erikchen@chromium.org,beccahughes@chromium.org,steimel@chromium.org

Change-Id: I284aea77c32a39c8641df70d83baa5b2e09b8641
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1140215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528306Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825549}
      23f48a7f
    • Vincent Boisselle's avatar
      Disable the feed V2 feature for NewTabPageTest browser UI tests · 7375cb7d
      Vincent Boisselle authored 
      We also re-baseline the goldens by incrementing the version number
since the testRender_FocusFakeBox test
had its baseline golden with the new feed header UI enabled which
we don't want anymore since the features flags related to that UI
change are now disabled.

Bug: 1146197
Change-Id: I0bb2525102dea745a3e419d2b8252abf1525811b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525741Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/master@{#825548}
      7375cb7d
    • Yulun Wu's avatar
      Update login shelf icons and coloring for light/dark mode. · 5e03844d
      Yulun Wu authored 
      Bug: 1143063
Change-Id: Icd0ec2088508d633757ed20749790b80a1dc09d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508558Reviewed-by: default avatarMin Chen <minch@chromium.org>
Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: default avatarThomas Tellier <tellier@google.com>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825547}
      5e03844d
    • chromium-autoroll's avatar
      Roll Chrome Win32 PGO Profile · d1b5a6ec
      chromium-autoroll authored 
      Roll Chrome Win32 PGO profile from chrome-win32-master-1604685414-0763f88efc3380eb5f7b102366bfe07c0bfcf724.profdata to chrome-win32-master-1604931688-79a6ca0d5aca76d3d27163162f00dd49eb38f0e8.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I0fa1c97fdd9f6fe204bc9ac9c5b3582165ff26b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526609Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#825546}
      d1b5a6ec
    • Frank Liberato's avatar
      Rename media::ErrorOr to media::StatusOr. · 04a6beac
      Frank Liberato authored 
      Also adds StatusOr::code() as a convenience.

Change-Id: Id54fc2f2657b0589bad5b910b78022ac8cfef502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523541
Auto-Submit: Frank Liberato <liberato@chromium.org>
Reviewed-by: default avatarTed Meyer <tmathmeyer@chromium.org>
Reviewed-by: default avatarXiaohan Wang <xhwang@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825545}
      04a6beac
    • Andrew Grieve's avatar
      Fix get_goma_dir.py when depot_tools has trailing slash · 221a810e
      Andrew Grieve authored 
      Having "PATH=/foo/depot_tools/" is valid, but the script didn't accept
it because os.path.basename('/foo/depot_tools/') == ''

Bug: None
Change-Id: I3e0b16f022ac0d99559a16d5866376523749681a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519608Reviewed-by: default avatarFumitoshi Ukai <ukai@google.com>
Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825544}
      221a810e
    • Peter Boström's avatar
      Remove PlatformStyle::kPreferFocusRings · df2b9969
      Peter Boström authored 
      This has been true on all platforms for a long time now. Its presence is
more confusing (suggests platforms where this is not true).

Bug: 924232
Change-Id: Ib73c8d3f785e96912739a83e6d325db33c85a27e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527365
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825543}
      df2b9969
    • Yuri Wiitala's avatar
      Remove dead code / content public API: AudioLoopbackStreamCreator · a5af2468
      Yuri Wiitala authored 
      A recent change removed the use of this content public API. It provided
legacy/duplicate functionality to that found in
content/public/browser/audio_service.h.

Bug: 1111026
Change-Id: Ie498c0b743f7c03cc65bb5613dd2765a3f2d2de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523744
Auto-Submit: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825542}
      a5af2468
  3. 09 Nov, 2020 32 commits