- 25 Feb, 2019 40 commits
-
-
Lukasz Anforowicz authored
This is a 2nd reland of https://crrev.com/c/1441277 (1st reland was in https://crrev.com/c/1481535). This reland lands just the product code changes, without a test that flakily failed on linux-chromeos-rel. We will attempt to also reland the test in separate follow-up CL - this work will be tracked in http://crbug.com/934612. Original CL description follows below: Google Translate executes its scripts inside "isolated worlds". This is quite similar to how extension content scripts execute and has a consequence of using |request_initiator| set to the origin of the isolated world (rather than to the origin of the page where the script was injected). This is problematic for 2 reasons: 1. It leads to renderer kills, when an AppCache verifies |request_initiator| using CPSPI::CanAccessDataForOrigin. 2. It leads to incompatibility between |request_initiator| and |request_initiator_site_lock| which can also cause wrong/harsh security decisions (e.g. CORB blocking of otherwise benign requests). This CL addresses the problems above, by making sure that requests initiated by the Translate's "isolated worls" will use a separate URLLoaderFactory. - For injecting and selecting the factory on the renderer side, the same mechanism is used as for extension content scripts (i.e. URLLoaderFactoryBundleInfo::initiator_specific_factory_infos is populated for the origin associated with the "isolated world"). - For simplicity and to avoid races, the separate URLLoaderFactory is sent from the browser to the renderer process in the same, single IPC that triggers script injection into an isolated world (i.e. in translate::mojom::Page::Translate method). As a side effect, this CL also causes Translate's requests to go directly to the NetworkService (rather than to the AppCache's AppCacheSubresourceURLFactory). This seems desirable. Bug: 925457, 934612 Tbr: John Abd-El-Malek <jam@chromium.org> Tbr: Daniel Cheng <dcheng@chromium.org> Change-Id: I638d3065c2afc001e67d7631e09658015c9c9d3c Reviewed-on: https://chromium-review.googlesource.com/c/1482944 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#635217}
-
Peter Kasting authored
Bug: 431427, 820435, 828063, 863296 Change-Id: I40b7b8129ebc72b3798f5d360e4ed2fa933847c7 Reviewed-on: https://chromium-review.googlesource.com/c/1483677Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#635216}
-
Mei Liang authored
This CL integrates TabModelFilter into the following UI: * TabCountProvider * LayoutManager and changes these UIs to wait for events from TabModelFilter instead of TabModel. TabModelFilters are provided by TabModelFilterProvider class. They observe TabModel changes and notify their observers about the changes. Bug: 930960 Change-Id: Iad95594f9b3f9002103fcac564f2197468cbee58 Reviewed-on: https://chromium-review.googlesource.com/c/1464118 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635215}
-
Nico Weber authored
Bug: 926235 Change-Id: I32c7a9f15f1f544caaceef28b0d34ebd643aa35d Reviewed-on: https://chromium-review.googlesource.com/c/1486880Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#635214}
-
Jarryd authored
QuotaManager currently uses a custom deleter that ensures the deletion happens on the IO thread. This CL removes the custom logic, and instead has QuotaManager inherit from RefCountedDeleteOnSequence. This CL was previously submitted with https://crrev.com/c/1479302 as d82ad3d0. It is currently broken up to minimize the impact of a potential revert. Change-Id: If39890da03f577771b31faf71a1ae479ca11cc9d Reviewed-on: https://chromium-review.googlesource.com/c/1481591 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#635213}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/afb82004c0be..ebeca2a9eb81 git log afb82004c0be..ebeca2a9eb81 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 eseckler@google.com Merge "protos: Add v0 of new TrackEvent protos" Created with: gclient setdep -r src/third_party/perfetto@ebeca2a9eb81 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia82906c6b1c9ca7c3e27e536ddc9278e8c40818f Reviewed-on: https://chromium-review.googlesource.com/c/1487192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635212}
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: I6a402d08ecafa76447aef58b498fc4e33867fd2f Reviewed-on: https://chromium-review.googlesource.com/c/1486871 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#635211}
-
Devlin Cronin authored
Make the PermissionSet constructor accept URLPatternSet parameters by value, enabling std::move()ing the parameters rather than necessitating a copy. Update call sites that are easily modified. Bug: 908536 Change-Id: I80ce85497b3272285a5b2a2299f8dc153530df51 Reviewed-on: https://chromium-review.googlesource.com/c/1383537Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635210}
-
Yue Li authored
Bug: 930994 Test: Manual Test Change-Id: I18da4e8c5767002c709f72293c76c8e67259d1d9 Reviewed-on: https://chromium-review.googlesource.com/c/1484231Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#635209}
-
Xiaocheng Hu authored
Bug: 935665 Tbr: fsamuel@chromium.org Change-Id: I96afe7230617c4399c8aa992cd56aae4be4c0209 NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/1487179Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635208}
-
Nico Weber authored
TBR=pastarmovj Bug: 926235 Change-Id: If49ed5cf5da0138db5b2249f6c51286f6306b446 Reviewed-on: https://chromium-review.googlesource.com/c/1486876 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#635207}
-
Sigurdur Asgeirsson authored
Bug: 910288 Change-Id: I10193ba9b6531707ac2891b99565e2c1e2e089b9 Reviewed-on: https://chromium-review.googlesource.com/c/1487291 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#635206}
-
Varun Khaneja authored
See also: http://cl/235019478 Bug: 909778 Change-Id: I1082d8c4f81c27ab62840ed78196db9cb71c8b3e Reviewed-on: https://chromium-review.googlesource.com/c/1481602Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635205}
-
Sahel Sharify authored
This cl changes scrollend/overscroll events to bubbling when the target node is document. With this change overscroll/scrollend events' bubbling behavior will be identical to the bubbling behavior of scroll event and registering an overscroll/scrollend event listener on window will work. To try the cl locally use --enable-blink-features=OverscrollCustomization runtime flag. Bug: 907601 Change-Id: I9a170a5ba3406f82d08e06c8c20e51bc5b001f6c Reviewed-on: https://chromium-review.googlesource.com/c/1483350Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635204}
-
Jimmy Gong authored
- Implements Net::NetworkChangeNotifier::NetworkChangeObserver to SmbService. - Optimizes the workflow of host name resolution by calling on host discovery whenever a network change is discovered, rather than only running host discovery on an error returned by StartReadDirectory. Bug: 922273 Test: manual end to end Change-Id: I9e91a1527fe06570b3d82c7abc92c448c07ed74a Reviewed-on: https://chromium-review.googlesource.com/c/1484501 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#635203}
-
David Bienvenu authored
When native-win-occlusion is turned on, this will cause the page visiblity API to get triggered when the screen is locked/unlocked. Bug: 532128, 813093 Change-Id: Ic747188d31ebf9a692a6913d9b84a70f86c9d2aa Reviewed-on: https://chromium-review.googlesource.com/c/1481581Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#635202}
-
Frank Poole authored
This change adds a minimal testable implementation of the UIA IWindowProvider interface and associated unit and browser tests. IWindowProvider::get_IsModal is implemented while the remaining APIs are added as unsupported (we do not intend to implement them). IWindowProvider is made available through IRawElementProviderSimple::GetPatternProvider when an accessibility node is explicity set as modal or not modal. This mapping for aria-modal is required by Core-AAM: https://www.w3.org/TR/core-aam-1.1/#mapping_state-property_table Bug: 847971 Change-Id: I2b0a6ec359302dbf8aae7cfcd21cbe23b527f962 Reviewed-on: https://chromium-review.googlesource.com/c/1480694Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Frank Poole <frpoole@microsoft.com> Cr-Commit-Position: refs/heads/master@{#635201}
-
Elly Fong-Jones authored
This change: 1) Removes the protect-sync-credential and ProtectSyncCredentialOnReauth flags; 2) Removes their backing features; 3) Removes SyncCredentialsFilter::GetAutofillForSyncCredentialsState(), which collapsed into always returning ALLOW_SYNC_CREDENTIALS after (1) and (2); 4) Removes AutofillForSyncCredentialsState, since (3) made it unused except in SyncCredentialsFilter::FilterResults(); 5) Removes SyncCredentialsFilter::FilterResults(), since it collapsed down to the identity function; 6) Removes CredentialsFilter::FilterResults() altogether, since (5) removed the only non-test override of that function, and removes it from StubCredentialsFilter; 7) Removes test coverage for CredentialsFilter::FilterResults; 8) Marks PasswordManager.SyncCredentialFiltered as obsolete, since it can no longer be generated; 9) Cleans up a bunch of now-unneccesary includes. Bug: None Change-Id: I8ef8a0798110d954afc44e6c7bdddc4b1e6f381b Reviewed-on: https://chromium-review.googlesource.com/c/1483394 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#635200}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e3b205b1202f..f6b0439fb639 git log e3b205b1202f..f6b0439fb639 --date=short --no-merges --format='%ad %ae %s' 2019-02-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e2d8b1286ce3..5efe61188243 (1 commits) 2019-02-25 bungeman@google.com Remove fuzz samples. 2019-02-25 ethannicholas@google.com fixed SkSL float literals in Arabic locale 2019-02-25 bungeman@google.com Remove defunct SkJSCanvas 2019-02-25 jvanverth@google.com Check for zero offsets for PolyUtils 2019-02-25 borenet@google.com [infra] Make the presubmit bot use recipes from CIPD 2019-02-25 fmalita@chromium.org [skottie] Layer blend mode support 2019-02-25 reed@google.com fill the layer if there is a backdrop filter Created with: gclient setdep -r src/third_party/skia@f6b0439fb639 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I3fd8175d1ca143e9a838be57a679fe0b27cb9bbe Reviewed-on: https://chromium-review.googlesource.com/c/1487072Reviewed-by:
-
Mike Wittman authored
All implementations of this function are now empty. Bug: 931418 Change-Id: I87d875a5523fa12a9db9b52b1e3baef41118e62b Reviewed-on: https://chromium-review.googlesource.com/c/1478073 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635198}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/2901ec32a9..93d155bc44 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/2901ec32a9..93d155bc44 Bug: None Change-Id: I0089165c94f2676eb7069fd8c53908fc25ff351f Reviewed-on: https://chromium-review.googlesource.com/c/1485952Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#635197}
-
Marcin Wiącek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing PanelState enum in the form common with other Chrome @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries 4. with comment about numbering from 0 without gaps 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface There is additionally removed one unnecessary Map. BUG=919666 Change-Id: I8149a0800bd5c0bb205028d230edadc83016ebb9 Reviewed-on: https://chromium-review.googlesource.com/c/1142764Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eb111e85e7e..4a8da2c58a9d Created with: gclient setdep -r src-internal@4a8da2c58a9d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia6d19a65a49a99429f9e1222c9cda370414cfb36 Reviewed-on: https://chromium-review.googlesource.com/c/1487132Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635195}
-
Elly Fong-Jones authored
Bug: None Change-Id: I023840d139f7494636224358c8c0d3519b6179f2 Reviewed-on: https://chromium-review.googlesource.com/c/1486491 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#635194}
-
James Cook authored
Use "Chromebox" vs. "Chromebook" depending on device type. Bug: 872739 Change-Id: I1ef4b6db7b176c8cd27979e39cde5aaf77f76cea Reviewed-on: https://chromium-review.googlesource.com/c/1484507Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#635193}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7a49ee027d224abc8bb8e5228201bfb69df41c12 Reviewed-on: https://chromium-review.googlesource.com/c/1486836Reviewed-by:
-
Lukasz Anforowicz authored
Before this CL, a comment in //extensions/browser/url_loader_factory_manager.cc used to incorrectly link to an internal doc with a draft of https://www.chromium.org/Home/chromium-security/extension-content-script-fetches (this comment landed back when we were still considering just making the doc public, rather than moving the content under https://www.chromium.org/Home/chromium-security). Bug: 846346 Change-Id: I55a09bc55523bb0f59d21133402da8a53dd94625 Reviewed-on: https://chromium-review.googlesource.com/c/1487351Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#635191}
-
Christian Biesinger authored
{Min,Max}PreferredLogicalWidth only constrains the size by the min/max-width if it is a fixed value. However, ChildIntrinsicLogicalWidth needs to constrain even for percentages and others. R=mstensho@chromium.org Bug: 935022 Change-Id: I3f5eff5e6f8e99484185635e44e3afa426c741fb Reviewed-on: https://chromium-review.googlesource.com/c/1484854 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#635190}
-
Xiaocheng Hu authored
Bug: 935638 Change-Id: I5bd95e9e38a713a42863d2b2607fc1c6bb824bef Tbr: xiaochengh@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/1487195Reviewed-by:
-
Sylvain Defresne authored
Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. Bug: 926204 Change-Id: Iae27a30eb1a4bc45987f003fbb9c82142715e9cb Reviewed-on: https://chromium-review.googlesource.com/c/1483019 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#635188}
-
Nektarios Paisios authored
When an object that is aria-owned by another object is re-parented as a layout object we remove any aria-owned children mappings it may have in the AXRelationCache, in addition to the mapping to its aria-owning parent. However, we don't remove any mappings from its parent to the removed object from the AXRelationCache. After the children of its parent will have been marked as requiring an update, the AXRelationCache will try and unmap the parent's existing owned children before adding the new ones. During the unmap process, we check if any of the previous children are already owned by another object, in order to skip removing them from the cache if so. However, we forget to check whether any of the previous children has been removed from the cached because it has been re-parented and its AxID has been re-used because its the same DOM node that has been provided with a layout object. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 934529 Change-Id: I298d396987f444d061a2f2324580726e987a739b Reviewed-on: https://chromium-review.googlesource.com/c/1485064Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 15512 15515 15525 15533 15546 15561 15579 15582 15590 15597 15603 15609 15618 15628 15641 15648 15650 15651 15652 15668 15670 15674 15679 15684 15691 15698 15701 15703 15715 8 lines were removed and 9 lines were deflaked by consecutive results since 15651. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I8c16a3cb1f4ee33c527192b69f917f96cc03e19a Reviewed-on: https://chromium-review.googlesource.com/c/1481182Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#635186}
-
Elly Fong-Jones authored
This change removes: quick-unlock-pin quick-unlock-pin-signin and removes the old constants for quick-unlock-fingerprint, which is already gone. Bug: 935613 Change-Id: I30338572d5f06737f7f1ab37aafe0616f8386869 Reviewed-on: https://chromium-review.googlesource.com/c/1487251 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#635185}
-
bsheedy authored
Ensures that VrShell.nativeIsDisplayingUrlForTesting() gets called on the UI thread. Not doing so was causing issues for https://chromium-review.googlesource.com/c/chromium/src/+/1478358. Bug: 934351 Change-Id: I42be8a69107758d5fb8b1fa5960a9dbec2dbef89 Reviewed-on: https://chromium-review.googlesource.com/c/1483732 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#635184}
-
Gary Kacmarcik authored
This moves the display scanning code to always be in the DesktopCapturerProxy (DCP). Previously, it was located in the DesktopSessionAgent (DSA) for Windows and in the DCP for Mac. The change to record the display id along with the geometry info broke Windows because that info was calculated in the DSA, but not available in the DCP. By moving all the display scanning into the DCP, this problem is fixed. This also removes the duplicate code and increases the likelihood that it2me will "just work". This works because, on Windows Me2me, the DSA serves as the ClientSessionController, and passes the message across the process boundary to the real ClientSessionController. Bug: 915411 Change-Id: Iecdd827b82c5e75e4a493f31cc31a6555388d4ca Reviewed-on: https://chromium-review.googlesource.com/c/1485016Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#635183}
-
Aditya Keerthi authored
Currently, RenderThreadImpl::RendererIsHidden() is implemented by keeping track of the total number and the number of hidden RenderWidgets in a renderer. If there is a non-zero amount of RenderWidgets and the two numbers are equal, RendererIsHidden() will return true. However, the current implementation is broken, as it does not account for the existence of inactive RenderWidgets. Inactive widgets refer to widgets that are created to support out-of-process iframes, but that do not represent actual widgets. These widgets exist with the sole purpose of maintaining state. Consequently, this widgets are never explicitly marked as hidden or visible, they are simply considered "frozen". This behaviour effects the implementation of RendererIsHidden(), as each time an inactive RenderWidget is created, the total number of RenderWidgets is incremented. However, those widgets will never be marked as hidden, and there will always be a difference between the total number and the number of hidden widgets. As a result, renderers that contain inactive widgets are incorrectly considered visible. Note that RenderProcessHostImpl already has information regarding a renderer's backgrounded and visibility state, using ChildProcessLauncherPriority. Rather than computing this information twice, we can forward the information from the browser process to the renderer process. The existing SetProcessBackgrounded IPC was modified to SetProcessState, now taking a RenderProcessState enum as a parameter. The process can be marked visible, hidden or backgrounded. Depending on the state transition, RenderThreadImpl calls OnRendererHidden, OnRendererVisible, OnRendererBackgrounded and OnRendererForegrounded at the appropriately. The new approach resolves a flaw in the current approach to determine renderer visibility and ensures that we have a single source of truth regarding a renderer's backgrounded and visibility state. Bug: 927440 Change-Id: Ib5aa60cd515443e17a0be691c211721caaf573ac Reviewed-on: https://chromium-review.googlesource.com/c/1448742 Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#635182}
-
Lukasz Anforowicz authored
This CL fixes a problem where the last committed origin of RenderFrameHost was never set after document.write cancels an initial navigation in a subframe or in a popup. In addition to running the new regression tests, I also manually tested that the repro steps from https://crbug.com/932067 no longer hit the bug - in particular, the console output included both "onupgradeneeded" and "onsuccess". Bug: 932067 Change-Id: If1f031b988005e498a3515abe3137680db35ea0e Reviewed-on: https://chromium-review.googlesource.com/c/1480670Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch fixes lines to break in the following conditions: 1. When wrappable elements appear inside of nowrap elements. 2. When wrappable spaces after nowrap appear inside of nowrap elements. 3. When non-space break opportunities appear after nowrap. fast/text/whitespace/018.html improves but still doesn't pass. It doesn't pass in Edge/Gecko, and at least some of what it expects look questionable. Further investigation is deferred to future CLs. Bug: 920177 Change-Id: Ieba4d446b818120f423b87a7f4a44b3c63a9d995 Reviewed-on: https://chromium-review.googlesource.com/c/1477629 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#635180}
-
Alan Cutter authored
Bug: 788051 Change-Id: I4f8c1775eecec9fccd13e6e1ca495dba2d30f823 Reviewed-on: https://chromium-review.googlesource.com/c/1485614 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#635179}
-
Elly Fong-Jones authored
This change assigns: enable-explicit-dma-fences overlay-strategies tint-gl-composited-content to chromeos-gfx@google.com and marks them all as non-expiring. These flags are used for graphics debugging in ChromeOS production builds. Bug: None Change-Id: I062dd408c8b2a2bd814798227e1ad41a1e2c7692 Reviewed-on: https://chromium-review.googlesource.com/c/1486872 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#635178}
-
