- 28 Mar, 2019 40 commits
-
-
Kuo Jen Wei authored
TEST=Test take photo/recode video, see if the saved filename is correct. Change-Id: I30af029ef862bb5577c6c8e14ee5a2814d79dc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539628Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#645216}
-
Peter Kasting authored
This eliminates some uses of child_count(). Bug: 940135 Change-Id: I8720a5f2be0da68fb4c2b55e51cbebaa2cd95c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536739 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#645215}
-
Chris Blume authored
Currently, SharedImageBacking and its derived classes are not thread safe. This CL makes it thread safe by adding a flag to SharedImageBackingFactory::CreateSharedImage. There is also a consistent way to acquire the lock if needed or do nothing otherwise. Bug: 938594 Change-Id: I3fe2c2ecc627f327f26cedab029a1388bfabf913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504894 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#645214}
-
Sangseok Jang authored
Existing implementations do not work with widgets displayed in other processes(e.g, PWAs). StackAbove and StackAtTop are implemented through BridgedNativeWidget mojo interface Bug: NONE Change-Id: I61ee9391332d61081d59865ac61994671ebc0093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522492Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sangseok Jang <sangseok.jang@navercorp.com> Cr-Commit-Position: refs/heads/master@{#645213}
-
Leo Zhang authored
Set ime service flag enabled by default on TOT. Bug: 888885 Change-Id: I80254287be9e0d8b3fbaf24d090e2a1960e1f05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542742Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#645212}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/705f480f4506..e810ad90799c git log 705f480f4506..e810ad90799c --date=short --no-merges --format='%ad %ae %s' 2019-03-28 syoussefi@chromium.org Vulkan: dump summary of commands in digraph 2019-03-28 syoussefi@chromium.org Vulkan: roll Vulkan repos to v1.1.102 2019-03-28 syoussefi@chromium.org Vulkan: remove dependency to inheritedQueries Created with: gclient setdep -r src/third_party/angle@e810ad90799c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: I4e19af909b41da0162528449d54b09a899c73e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542982Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645211}
-
Nico Weber authored
Bug: 464945 Change-Id: I7ed5179a01266ab43782b590dc48da8865b44f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542680 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#645210}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0b19d73c4b89..3240800a9487 git log 0b19d73c4b89..3240800a9487 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@3240800a9487 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: If91047b65b190f9c69f2ab8e6c4538ca9626b26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542981Reviewed-by:
-
Peter Kasting authored
This avoids some uses of child_count(). Bug: 940135 Change-Id: I583b471a7750f0dccba5e2eb6bd4f61661c9a4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535293 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit fc93308f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 644811 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmM5MzMwOGY1Zjk0YmJhYzJlMDcyNGU2YmUzZDRmN2Q2OWRlNjQyNgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Linux/70364 Sample Failed Step: sandbox_linux_unittests Sample Flaky Test: ParameterRestrictions.ptrace_getregs_allowed Original change's description: > Disable ParameterRestrictions.ptrace* tests on Android < N. > > Bug: 934930 > Change-Id: I0c9bae607e06a921c4587fcfb50ebc574c830c7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540281 > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644811} Change-Id: I9628666758500dba61d72b4cfa7e2890b9ff798a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542905 Cr-Commit-Position: refs/heads/master@{#645207}
-
Simon Que authored
R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 945731 Change-Id: Ifc7362c11b630b2d97a3eb10315204d678ceaa86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541621Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#645206}
-
Alan Cutter authored
This CL adds a GetChromeTestDataDir() helper for browsertests to use instead of hard coding the chrome test data directory many times. This also removes redundant calls to tell the embedded_test_server() to serve the chrome test data directory. This gets set up in InProcessBrowserTest's constructor. Bug: 946403 Change-Id: I994d1c8e3b798f0e3a70e4c48a56da3f94cdb83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539366Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#645205}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/editing, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the second to clean up Foo::Create() in renderer/core/editing. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ibb38a1f6047c7cb9566f5b352f9fe7b4cf7223cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542747Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#645204}
-
Simon Que authored
R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 945731 Change-Id: I3a37b6b44b30ef2fee3ac86dd59fd620a8bf6150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541620Reviewed-by:
-
Dan Beam authored
Screenshots: https://drive.google.com/corp/drive/u/0/folders/1e3dizEeFQ_TvLfST7rCUzH_A58C75ky8 R=rbpotter@chromium.org BUG=926883 Change-Id: Ia79875072b2c261e348c96a4d4a3762935715639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542725Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#645202}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c881d8d4872a..6822584e81a7 Created with: gclient setdep -r src-internal@6822584e81a7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: Ic3ed75d84475b49e6663fa7f76d5ec5f03fc1afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542979Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645201}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01a065884b7d..0b19d73c4b89 git log 01a065884b7d..0b19d73c4b89 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 179c932426b3..57e05b8be2d9 (1 commits) Created with: gclient setdep -r src/third_party/skia@0b19d73c4b89 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I182580c3b7ea29a93177282121b548d14d38d1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542980Reviewed-by:
-
James Darpinian authored
The new validation added in http://crbug.com/809237 failed to consider that sampler object state overrides texture object state if a sampler object is bound. Fix this by using the correct sampler state object. WebGL conformance test is here: https://github.com/KhronosGroup/WebGL/pull/2823 Bug: 940080, 809237 Change-Id: I1ad35f87aed288b4fe98c9ea298c5b3013968935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513199 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#645199}
-
Robbie McElrath authored
Requests from WebUI are curently sent to a WebUIURLLoaderFactory unless another URLLoaderFactory is registered for the requests's scheme. ChromeOS's oobe has some about:blank requests in it, which get routed to the WebUIURLLoaderFactory when you attach devtools to the oobe page. The WebUIURLLoaderFactory expects request to have the 'chrome' scheme, and the renderer crashes when it doesn't. This CL adds an 'about' handler in RenderFrameHostImpl to make sure these requests get handled before being sent to the WebUIURLLoaderFactory. Bug: 941221 Change-Id: Ia6e99b001d57d7e00186a85092b01d14f690d94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542661 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#645198}
-
Raul Tambre authored
This was done on Windows. Non-Windows platform-specific code hasn't been converted. This is a mechanical change. See bugs for justification and details. Bug: 776257, 778942 Change-Id: Iad35c3a9911e5a1c8ae3ce77c5b5c9e8481a9c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536067Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#645197}
-
Miyoung Shin authored
- int -> int32_t and long -> int64_t in template - long -> size_t considering sizeof() return type - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930251 Change-Id: Ib1ed091219c74b1906245bbd8b7a84acbd3f22f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542737Reviewed-by:
-
Miyoung Shin authored
- long -> int32_t - no logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930251 Change-Id: Ibd4692de40e80b8147e18b22b28f7ca928eb3a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538273Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/179c932426b3..57e05b8be2d9 git log 179c932426b3..57e05b8be2d9 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 chrisforbes@google.com Add support for OpMatrixTimesScalar Created with: gclient setdep -r src/third_party/swiftshader@57e05b8be2d9 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126873455 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I164e2f48f5608a6897a866aa1c212dac9db20cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542978Reviewed-by:
-
Peter Kasting authored
This avoids some uses of child_count(). Bug: 940135 Change-Id: Iddbeeee9206e674dac79854ced121afc034284a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536684 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e18ff25d261d..705f480f4506 git log e18ff25d261d..705f480f4506 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 jie.a.chen@intel.com ParallelCompile: Enable worker on GL backend 2019-03-28 syoussefi@chromium.org Vulkan: Fix subpass declaration for depth/stencil-only FBOs 2019-03-28 syoussefi@chromium.org Vulkan: Correct RenderTargetVk extents to image mip Created with: gclient setdep -r src/third_party/angle@705f480f4506 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:922936 TBR=jonahr@chromium.org Change-Id: I742559006899dee797e88367fd801128d5f578e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541453Reviewed-by:
-
Takashi Toyoshima authored
This CL is almost equivalent to revert commit ee469355. But, the feature is also disabled by default on Android. Original change's description: > Remove FeatureList switch for the cache-aware WebFonts loading > > Now the feature has been enabled by default, and this change > removes the kill-switch. > > Bug: 570205 > Change-Id: I9408d9c8f60edb562a817736816f376c5739ae61 > Reviewed-on: https://chromium-review.googlesource.com/c/1466542 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632125} Bug: 570205, 942440 Change-Id: I107906a7dd3b1629e362d3e5e8e4bad4daab1121 TBR: kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534806 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#645191}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e4c67058ddb1..01a065884b7d git log e4c67058ddb1..01a065884b7d --date=short --no-merges --format='%ad %ae %s' 2019-03-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 83d44af5..eb8d3bc0 (520 commits) Created with: gclient setdep -r src/third_party/skia@01a065884b7d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I5e69ae0f0ef23b2d8ea429a059c170b4623f0626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541452Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9614b75c12b4..c881d8d4872a Created with: gclient setdep -r src-internal@c881d8d4872a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I5bbe5dd57d857d5dfa28ab22ec0267370c095b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541454Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0aba234faff966b69b2a357dd58c39d5a140c4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543016Reviewed-by:
-
Noel Gordon authored
external/wpt/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html fails on non-newtork-service-webkit-layout-test step ... and reds those bots that run that step. Update test expectations. Tbr: robertoch@ No-try: true Bug: 946890 Change-Id: Ic158d25318a3b629497b9385824131f89d87ec65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542745Reviewed-by:
-
Gyuyoung Kim authored
Remove Create() methods that return an instance created by MakeGarbageCollected<> in core/editing - 1 As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/editing, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. There are too many usages of Foo:::Create() that returns an instance through MakeGarbageCollected<>. So following CLs will continue to replace them. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I9365832d0f070f8381a98515e800abac53fa6734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541622Reviewed-by:
-
Nicholas Verne authored
Bug: 899568 Change-Id: Iedc639ec1da770bd79c3cbbc8572120b8707a24d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541538Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#645185}
-
Peter Kasting authored
The underlying goal here was primarily to avoid child_count(). In many cases the resulting code is also shorter and easier to maintain, although sometimes it's longer. I chose to use algorithms over manual loops (using e.g. range-based for), based partly on my own preference (I think these give readers a better idea of the general purpose of the loop without having to back-figure from the actual function) and partly on encouragement from various other team members who apparently also prefer algorithms. This also fixes an apparent logic bug in MenuItemView::GetChildPreferredSize() which would add padding before the first visible child in some cases. Bug: 940135 Change-Id: I1cd657a21066bbd23b2ae1df46f9d6ad411772a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535291 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#645184}
-
Peter Kasting authored
This allows deleting GetMenuItemCount() and makes a number of callers more efficient. I did not attempt to delete GetMenuItemAt(), which would likely require more int->size_t conversions. Bug: none Change-Id: I1b8ad0e6f653001f27781343931e3d89b4e6a6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536638Reviewed-by:
-
Matt Menke authored
Only the first is marked as flaky, but the second presumably is as well, for the same reason: There's no way to wait on an idle socket being added to the socket pool. This CL makes the tests make network requests with nominally reusable sockets. Waiting for them to complete is a way to guarantee the idle sockets have been added back to the socket pool. It also combines the tests, because making sockets this way takes a fair bit of boilerplate. Bug: 905423 Change-Id: Ia6b9a9d983e18c8025edf472435f4be416c87104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542337 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#645182}
-
Doug Arnett authored
This is the 2nd part of dropping the abstract interface for HintCacheStore. It is a simple rename of the implementaion name from HintCacheLevelDBStore to HintCacheStore. There are no functional changes. Change-Id: I276b47200b6ec206e1741d2f33947cf7aa83b24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542686Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#645181}
-
Christian Biesinger authored
This has a 7.1% improvement on add-remove-inline-floats: https://pinpoint-dot-chromeperf.appspot.com/job/10b95f77f40000 Change-Id: Ief88091dd5d945bf2624907434ac740595505998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540737 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#645180}
-
Dave Tapuska authored
Remove two usages of SimplifyWhiteSpace that didn't do anything with the return result. These can be safely removed because String::Split won't append a result because |allow_empty_entries| parameter to the function is false. BUG=756221 Change-Id: Iad498bd4bf4ec0f55bf8eb7464a5adc465d938d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542146 Auto-Submit: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/889d743baa3d..5f4bcbb9467f git log 889d743baa3d..5f4bcbb9467f --date=short --no-merges --format='%ad %ae %s' 2019-03-28 jiawei.shao@intel.com Disallow creating multisampled 2D array textures 2019-03-27 natlee@microsoft.com Destroy frontend and backend for Textures Created with: gclient setdep -r src/third_party/dawn@5f4bcbb9467f The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I18301ce58af6b9dab70cc1088bcb98ab375e8549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542977Reviewed-by:
-
Robert Ogden authored
Fixes all but testServerReturnsLitePageAfterRedirect which I'll keep working on. It's a special snowflake somehow but this change should apply to all the tests. Bug: 946215 Change-Id: Id6ad309c451e7d60a56ae074ca81be2ba9b1b9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540541Reviewed-by:
-
