- 11 Oct, 2019 40 commits
-
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=yangguo@chromium.org Bug: 1007760 Change-Id: Id6da42c61527457fcb365f49ce3561bc0fce3399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849542 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705069}
-
Ewann authored
Fixing action buttons: - Check if the location bar is in steady state. If yes, the Copy button is displayed. If not, if there is selected text the Copy button is displayed. In other cases, the Copy button is hidden. - display Paste & Search for Copied Text buttons when omnibox is empty. - hide Select & Select All buttons when omnibox is empty. - display Select All button when selected text and hide Select button. Corresponding integration tests dded. Bug: 864984 Change-Id: I321546571272235eac0b749753f041bff0922608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786639 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705068}
-
Roman Sorokin authored
It's in fact user visible :) Bug: 1008270 Change-Id: I0b6dafea8883c9aaeb8e76f162dc427029752b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853924Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705067}
-
Antonio Gomes authored
... and the respective unittest, transceiver_state_surfacer_unittest.cc This CL works out phase 7.4 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I25384e38468cdfaf5e5fa2157f8f5993f1591f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820062 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#705066}
-
David Roger authored
TBR=yhirano Bug: 1013523 Change-Id: Iad71979f640ed5ae42c7fe00982da2876935fb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855978Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705065}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=msramek@chromium.org Bug: 1007760 Change-Id: If363fd450c6a7118b8d622e8ae3b9c2777f96524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849541 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705064}
-
Maksim Moskvitin authored
In theory, keystore keys might not arrive together with NigoriSpecifics, for example, in case of throttling. To make USS implementation more robust in this situation, we allow pending keys in keystore mode. Cryptographer should be properly initialized once we receive keystore key, which was used for encryption of keystore_decryptor_token. This CL extends pending keys concept to keystore_decryptor_token, because we need to store it until decryption. Note: Directory implementation implicitly had this concept, since it stored NigoriSpecifics itself as the local state. Note: this CL doesn't add support for initialization of default Nigori in case bridge has no keystore keys. Bug: 922900 Change-Id: I9a138d2190e28b617789bb0632d3751fa226d8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840694 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705063}
-
Michael Lippautz authored
This change moves DOMDataStore on Oilpan's heap and models wrappable->wrapper connections using an ephemeron hash map for non-main worlds. Previously, DOMDataStore would be off heap and the that maintains the references would use Untraced<> as well as custom Trace() methods for non-GCed objects. That also required callbacks on the references to manually remove the entries to compact the hash map. With ephemerons: - The hashmap is kept compact (unused buckets are deleted) by the GC which allows us to avoid callbacks on references. - There are no more GC plugin exceptions. - All trace methods will be on garbage collection objects. - There's no need to trace through all DOM worlds for each ScriptWrappable in its trace method. - References will show up in heap snapshots. Bug: 1013212 Change-Id: Id3475707d34191f9f3b6b099c2495ee0150d982e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849677 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#705062}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/69077a26ccaf..1550399cc0a1 git log 69077a26ccaf..1550399cc0a1 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 khokhlov@google.com [Telemetry] Save story tags in intermediate results Created with: gclient setdep -r src/third_party/catapult@1550399cc0a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:981349 Change-Id: I6cb9f6a0060a5464073d02cb58ba7cf346e66d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854808Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705061}
-
Lowell Manners authored
Note that as part of adding these tests, a bug was discovered (https://crbug.com/1012707). Change-Id: Ib8fe265f673bf773efc6968c743445ad3c4eb7b0 Bug: 1012707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831803Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#705060}
-
Lowell Manners authored
This test recently broke, likely due to https://crrev.com/c/1819251. TBR=ahemery@chromium.org Change-Id: Ided00fc067ec266440a02aa0c1b08a7d632f8ae8 Bug: 1013550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856038Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#705059}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic86ae666289b3f97beda457ec3d8de7d93da4812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854806Reviewed-by:
-
Clemens Backes authored
The TransferrableModule became obsolete with https://crrev.com/c/1847366 and will be deprecated soon. This CL switches all uses to the WasmCompiledModule. R=mlippautz@chromium.org Change-Id: Ib53653c661e0381377cb1fe653f02c8a289b2141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855822Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#705057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a1e314b0399..67486ec24551 git log 3a1e314b0399..67486ec24551 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 82f84c4b8f19..feb154921397 (3 commits) Created with: gclient setdep -r src/third_party/angle@67486ec24551 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:None Change-Id: I2e582fa2e38003ee6cdd9e55042b97a2e2adc515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854807Reviewed-by:
-
Fergal Daly authored
This adds WebSchedulerTrackedFeature::kWebLocks and registers its use from LockManager::request. The test I added failed before I add the code to disable bfcache. Bug: 1013069 Change-Id: I534cb3b712875459e8e991161b444fe8a03a87c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851634 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705055}
-
Elly Fong-Jones authored
This concept does not belong in DialogDelegate, since it is implemented only in BubbleFrameView. This change moves the policy decision of when BubbleFrameView should snap a bubble's width into BubbleFrameView itself. This change also removes the only override outside Views of ShouldSnapFrameWidth, which was on ExtensionsMenuView; this class was overriding it to return true while also returning a static width from CalculatePreferredSize, meaning that it actually has a fixed width anyway. Bug: 1011446 Change-Id: I99369e83b7c467b8cbc2927727f0d268c44e6ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854458Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705054}
-
Tim van der Lippe authored
This includes rollup Bug: 1013129 Change-Id: I30147d21af77c8886a0ba83f56cd30e76a7d3dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853225Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 1008862 Change-Id: I99425c705f94ef6d36df20254e8a4a219f60754b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855958 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705052}
-
Koji Ishii authored
This patch fixes |NGLineBreaker| to cache 'letter-/word- spacing' values when it is constructed with a break token. This seems to be an old bug. r527007 (crrev.com/c/846585) initialized |current_style_| without calling |SetCurrentStyle|. Then r590190 (crrev.com/c/1217708) skipped caching locale and letter-/word-spacing in such case. The issue has been there since then, but it seems r701601 (crrev.com/c/1826063) turned it to more frequent crashes. Bug: 963521 Change-Id: I4abe207505917f351c8074a5e7e3cb139c9515d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851625 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#705051}
-
Gauthier Ambard authored
This CL changes the matcher for the Close button, making sure that it is enabled. Bug: 1013542 Change-Id: Ibf971693cbd6f8615c64a795d76c5b6db9ad5093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855823Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#705050}
-
Elly Fong-Jones authored
Updating the cookie count every time it changes is extremely expensive (each update causes a relayout of the page info dialog) and, worse, causes the dialog to be unusable to screen readers. In the extreme case, JS-heavy websites cause this dialog to be read as endless repetitions of "Cookies" as the screen reader repeatedly cuts itself off while trying to read the changing text. This change makes the dialog text not update; other possibilities considered were: * Removing the text altogether * Collapsing the state down to "cookies in use" or "no cookies in use" I feel that this change is less intrusive and less of a design change to the dialog than either of those two, but one of them (especially the first, IMO) is probably a good direction to go later. To test this change, try https://www.washingtonpost.com: navigate to the site with a cold cache, open the page info dialog, and watch the text change rapidly. Bug: 984651 Change-Id: If7f996470a1768a7f9acadc72fcf13cec41a73a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853112Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705049}
-
Elly Fong-Jones authored
This change introduces DialogDelegate::Params::button_labels and DialogDelegate::set_button_label(), and makes the default behavior of DialogDelegate::GetDialogButtonLabel() check Params::button_labels for a label assigned to the specified button. This change also converts a random handful of dialogs in //chrome to using this method to demonstrate how it will eventually look. There are many, many more to convert (~200) so subsequent CLs will be necessary. One big open question is what to do with dialogs like LocalCardMigrationDialogView, which change the reults of GetDialogButtonLabel based on the dialog's internal state... Bug: 1011446 Change-Id: Idbf9464fe32e519a2150b00a2179558cd7b78adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853045Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#705048}
-
Antonio Gomes authored
... and the respective unittest, rtc_rtp_transceiver_unittest.cc This CL works out phase 7.3 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ In order to avoid colliding files and classes names with existing homonyms in renderer/modules/peerconnection, the following renames were performed: - rtc_rtp_transceiver_impl.cc -> rtc_rtp_transceiver_impl.cc - rtc_rtp_transceiver_impl.h -> rtc_rtp_transceiver_impl.h.h - rtc_rtp_transceiver_unittest.cc -> rtc_rtp_transceiver_impl_test.cc Also, RTCRtpTransceiver became RTCRtpTransceiverImpl. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ibd84b5911ac64b9e1ad25e139a8e31ddfdccf281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820060 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c3b10013ca7..3b819f3d8bbe git log 7c3b10013ca7..3b819f3d8bbe --date=short --no-merges --format='%ad %ae %s' 2019-10-11 nisse@webrtc.org Move video_sources_.clear() call to CallTest::DestroyStreams Created with: gclient setdep -r src/third_party/webrtc@3b819f3d8bbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I7788e4f9fdd09efbec4c16c26c47223e70830987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854949Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/82f84c4b8f19..eba98c4eb781 git log 82f84c4b8f19..eba98c4eb781 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 afdx@google.com spirv-fuzz: Add fuzzer pass to add NoContraction decorations (#2950) 2019-10-11 afdx@google.com spirv-fuzz: Add fuzzer pass to change function controls (#2951) 2019-10-10 paulthomson@users.noreply.github.com reduce: add large tests and fix (#2947) 2019-10-10 afdx@google.com spirv-fuzz: Add fuzzer pass to change loop controls (#2949) 2019-10-10 afdx@google.com Fixed include paths and order according to Google style. (#2957) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@eba98c4eb781 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,geofflang@google.com Bug: None Change-Id: I8a142dd1dcbefcc43ceba36f4ee0fe63d7a02a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854844Reviewed-by:
-
Antonio Gomes authored
... and the respective unittest, rtc_rtp_sender_unittest.cc This CL works out phase 7.2 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ In order to avoid colliding files and classes names with existing homonyms in renderer/modules/peerconnection, the following renames were performed: - rtc_rtp_sender_impl.cc -> rtc_rtp_sender_impl.cc - rtc_rtp_sender_impl.h -> rtc_rtp_sender_impl.h.h - rtc_rtp_sender_unittest.cc -> rtc_rtp_sender_impl_test.cc Also, RTCRtpSender became RTCRtpSenderImpl. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I40f7e7c139839beb88b72b4e509a352db3d4ecbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819811 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Lowell Manners authored
After a page enters the BackForwardCache, a user may navigate to a new page on the same site as the cached page (See BackForwardCacheBrowserTest.NavigateToTwoPagesOnSameSite). In the above case, it's important not to reuse the RenderViewHost(s) owned by the frames in the BackForwardCache, because this could lead to two main frames (the one in the cache, and the one the user just navigated to), existing at the same time for a single RenderViewHost (not allowed). To solve this, we can simply stop reusing RenderViewHosts that belong to a page when it enters the BackForwardCache, and begin reusing them again when it leaves the BackForwardCache. This approach also allows us to remove a work-around in navigation_controller_impl.cc that was aggressively deleting cached frames. Note: RenderViewHost is owned by RenderFrameHost, this CL changes nothing WRT object lifetimes. Change-Id: I18698fc4f737f3945ab41270bd07d1538ca096a5 Bug: 993337, 999846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833616Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/284b45288355..69077a26ccaf git log 284b45288355..69077a26ccaf --date=short --no-merges --format='%ad %ae %s' 2019-10-11 khokhlov@google.com Add ms to legacy unit infos Created with: gclient setdep -r src/third_party/catapult@69077a26ccaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:981349 Change-Id: I249687208830bed352fabd4e9f14037007acda32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854947Reviewed-by:
-
Vadym Doroshenko authored
In order to send a crowdsourcing vote, FormStructure object should be constructed. And now there is no simple way to do this. This CL introduces constructor that takes only signatures (which are bare minimum). This constructor will be used for sending votes for username forms in username first flow. Along a way, initialization in header is done instead of initialization in constructors, in order to decrease code duplication. Bug: 959776 Change-Id: Id593dfc36ef2235302b14f3f15b97b29dae666df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849387 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#705041}
-
Benoît Lizé authored
Replaces comments with annotations for variables protected by mutexes in blink/platform. This allows the static analysis pass in clang to check locking at compile time. Changes are: - Annotate member variables with GUARDED_BY() - Add a few Mutex::AssertAcquired() assertions. These mark the mutex as acquired to the checker, and do not generate any code when DCHECK()s are off. - Add required locking to some unit tests only methods. The code wasn't incorrect before as these are typically single-threaded, but this is still required in principle. While in the neighborhood, also fix a few "git cl lint warnings": missing include guards comments, explicit constructors, and include what you use. Bug: 1013082 Change-Id: If957288537f1930f821f94296dd89e5525649ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851709 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
-
James Cook authored
The "Split Settings Sync" project is decoupling Chrome OS system preferences from browser preferences. This CL adds the sync protocol buffers for the new data types. C++ visitors and tests will be updated later, in the CL that adds the new ModelType. Bug: 1013466 Change-Id: I4e8c9a95a5b8107d1ca15250e4e181b1ebc19c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855218 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#705039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/545a481a74a3..90a30f154a61 git log 545a481a74a3..90a30f154a61 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 apodtele@gmail.com * src/sfnt/pngshim.c (premultiply_data): Optimize for __SSE__ only. Created with: gclient setdep -r src/third_party/freetype/src@90a30f154a61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: Ia7556a6ba9a1d8fff959df1c73913d1d404a1a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855120Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#705038}
-
Javier Ernesto Flores Robles authored
Updates the current separator color to a dynamic one. Bug: 1008832 Change-Id: I1b408fb1b60a6f516fd2bfab430e18f79fbb58dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855741 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#705037}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome BUG=762641 TBR=oshima@chromium.org Change-Id: I74adbbd6aacb924efdd2cf6cce18adee886bbba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855778Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705036}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f505d9d8..464d407d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff0bcb321c2a12f79f536cb55a591512113066f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855659Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705035}
-
Oliver Chang authored
Change-Id: I56f11fa5e877f64a42139d584fe6fcd5a8030fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855619 Commit-Queue: Oliver Chang <ochang@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#705034}
-
Renato Silva authored
This commit adapts the encryption migration screen on crOS for devices with a small screen. It also improves the messages in the event of insufficient space. Tested locally Bug: 1002097 Change-Id: I6afb449e8499047f029b8c0159df4c9cea72d3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845218 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705033}
-
Marina Ciocea authored
The logic for kRemove tab strip model changes is covered in OnInfobarRemoved. Drive-by reset tab capture indicator on StopSharing. This wasn't a bug, the indicator would get destroyed in dtor, but it's more logical to remove it on StopSharing and it makes testing easier. Bug: 996722 Change-Id: I49943226dcc4fc7eab8a4776f45aaa7c9fd98d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855738Reviewed-by:
-
arthursonzogni authored
A page using the WebBluetooth API shouldn't be frozen and shouldn't enter the BackForwardCache. When navigating away from a page: 1) The Bluetooth connection should be released. 2) The tab indicator should be removed. This won't happen if the RenderFrameHost is kept in the back-forward cache. Some background on why we sometimes need to disable bfcache: https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8 Bug: 1001087 Change-Id: I27cb850ed6e94de440486b33111332811942c930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837936 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Canon Mukai authored
Use partition alloc for zlib allocations instead of malloc. Bug: 999091 Change-Id: I3481fc08fcb943f3c458e5122a7237638a75929c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855143Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#705030}
-
