GitLab

Test is flaky on the slower bots MSAN/ASAN with selection failures. Add
more steps, add step result checking. Use more precise selectors on the
file list operations. Do an initial focus on the file list. Load photos
only in SetUpAndWaitUntilReady (for more speed). Check that the renamed
folder is shown in the directory tree and the file list.

The new steps are cargo-culted from the create_new_folder.js test which
is a similar test, with similar selection flakes (fixed on CL:1186008).

Tbr: lucmult
Bug: 874954,877557
Change-Id: Ib9f988e0dadafd0a52bd509ae664aa3cbfe395fb
Reviewed-on: https://chromium-review.googlesource.com/1188178Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586122}

This CL also changes InputMethodManagerImpl and language settings api to
allow ArcInputMethodManagerService to restrict ARC IMEs.

Bug: 845079
Test: Ran on DUT and unit tests.
Change-Id: I61516b3c6a65775f42aae7e51583e933d55ab1b6
Reviewed-on: https://chromium-review.googlesource.com/1179733Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586121}

TBR=cmumford@chromium.org

Change-Id: I3126e1df73ffcf02f191ab3abc0ab0f5e1f26fe6
Reviewed-on: https://chromium-review.googlesource.com/1189172Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586120}

Reland "[RenderProcessHost/Desktop] Update process priority on process launch and fix navigation priority inversion"

This is a reland of c492203d
Reverted @ https://crrev.com/c/1188963 per the new test being flaky.
I'm pretty sure it's just because 10us for the recurring check was
too aggressive for that kernel and starved the test (which also
explains why ASAN was flaking -- looking back it was a termination
failure (timeout) not an ASAN failure -- so I've re-enabled both.

Original change's description:
> [RenderProcessHost/Desktop] Update process priority on process launch and fix navigation priority inversion
>
> This is a second take on
> https://chromium-review.googlesource.com/c/chromium/src/+/754299
>
> It's under an experiment to (1) be able to see the side-effects and (2)
> make merge to M69 easier. Intentionally kept old (and buggy) behavior
> intact under the non-experimental branch for comparison.
>
> This fixes all aspects of crbug.com/560446:
>  1) Fixes the OP better than r385608 did.
>  2) Fixes the side-effect of r385608 which was to default all tabs
>     created backgrounded to run at foreground priority until visiblity
>     was toggle on/off again.
>  3) Fixes a major priority inversion on foreground navigation which
>     could cause them to background their associated renderer while
>     navigation (which reintroduced the OP but worse since all background
>     tabs were running foregrounded per r385608)...
>     See https://crbug.com/560446#c74 for details.
>
> Updated ChildProcessLauncherPriority::is_background() to consistently
> reflect backgrounding decision to all callers and renamed
> |ChildProcessLauncherPriority::foreground| to
> |ChildProcessLauncherPriority::visible| to better reflect that it's a
> property but not the resulting foreground/background state.
>
> See in code comment on ShouldBoostPriorityForPendingViews() for more
> details.
>
> TBR=haraken@chromium.org (side-effect in third_party/blink)
>
> Bug: 560446
> Change-Id: I901b702506a44704b53c007bcdd498fb60824e94
> Reviewed-on: https://chromium-review.googlesource.com/1142593
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585918}

TBR=nasko@chromium.org (trivial reland)

Bug: 560446
Change-Id: Ib8daff024edabd488afda0b4b9da6f6e0fda77d4
Reviewed-on: https://chromium-review.googlesource.com/1189204Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586119}

Using wpt-import in Chromium 1c9af66d.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23257

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org:
  external/wpt/compat

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: Ib6ca7496379ae8a349f7b15c08bccc2983cb24ff
Reviewed-on: https://chromium-review.googlesource.com/1189167
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586118}

This Cl updates Chrome OS Discover Welcome module code to match the latest
specs.

Bug: 864686
Change-Id: Icbfb4c98976055daaa49bce51e1eb399aa6da078
Reviewed-on: https://chromium-review.googlesource.com/1186188
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586117}

Bug: 877254
Test: gtk3-demo
Test: exo_unittests
Change-Id: Iec316067589088e85dec3429df4fe9f5a5604a65
Reviewed-on: https://chromium-review.googlesource.com/1188343Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586116}

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.
This CL migrates HttpBridge and FinancialPing away from URLFetcher.

Note that this CL slightly changes the flow of the HttpBridge{Factory} code.
Previously, an URLRequestContextGetter instance was acquired on UI thread,
passed to the Sync and IO threads.
However, URLLoaderFactory and SimpleURLLoader have stricter threading
restrictions than URLFetcher and URLRequestContextGetter. For instance, a
SharedURLLoaderFactory instance needs to be created, used and deleted on
the same thread.

For this reason methods like HttpBridgeFactory::OnSignalReceived
can not simply null out |url_loader_factory_| which is created on the "sync"
thread.

Additionally, some preexisting tests do not seem relevant for the context
of network service, and got removed, eg TestUsesSameHttpNetworkSession,
RequestContextGetterReleaseOrder and EarlyAbortFactory.
Particularly, the last two used to deal with URLRequestContextGetter
destruction. With the URLLoader migration, HttpBridge now holds on
to mojo pipes  instead of URLRequestContextGetter.

BUG=773295,844968

Change-Id: I185f814ba171dca69fec55b913b86a0cc9993ef1
Reviewed-on: https://chromium-review.googlesource.com/1174655
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586115}

R=rch@chromium.org

Change-Id: I1a89779519bc63ca669d0d9ba01a81fb2e9952e0
Reviewed-on: https://chromium-review.googlesource.com/1189102Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586114}

Bug: 806581
Change-Id: I26467c5fc2c9fc9ecf918a5229a97650bd29a5e5
Reviewed-on: https://chromium-review.googlesource.com/1185370Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586113}

This CL updates OOBE Discover code to make it loadable as an app.

Bug: 864686
Change-Id: I1e9840041f193ce2d69e0defd34f2ab56f8dcbb1
Reviewed-on: https://chromium-review.googlesource.com/1186185
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586112}

Report how long it takes to update the views hierarchy in response
to a search-string. Also report how long it takes before the update
is visible on screen.

BUG=865295

Change-Id: I103aa5cbd86be3189ab44121e72d375e6d742b4b
Reviewed-on: https://chromium-review.googlesource.com/1188755Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586111}

This metric will help to diagnose possible URL spoofing bugs in Slim
Navigation feature. _documentURL is used as proxy for legacy navigation
manager URL, which is generally reliable and almost always match
last committed URL.

Collection review doc:
https://docs.google.com/document/d/14SygQ8BzLkzedTLuDfOHhakQHZOOJSU8TAJT3rxBGv4/edit#

Bug: 1182320
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6dcf5711f0fd42063b67afb0fa0a99b77ce4c7a0
Reviewed-on: https://chromium-review.googlesource.com/1187014
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586110}

Bug: 866914
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib5c6351cbad98221447e5218e54e4feeefb8e692
Reviewed-on: https://chromium-review.googlesource.com/1184968Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586109}

- Console prompt is cleared when text is pinned
- Pins persist across refresh
- Newly created pin runs with side effects until text differs
  or new expression is committed (on blur)
- Ctrl-Enter moves focus from Pin to Console prompt
- Added command menu option to create new pin
- Pressing Tab indents, moves focus iff pin is empty
  (same logic as Console prompt)
- Pins producing errors show error message on red background
- Pin text is trimmed upon blur/commit

Bug: 849875
Change-Id: I641abb6b5e19a84c17b1a6cd3e50ca7b459f2015
Reviewed-on: https://chromium-review.googlesource.com/1141096
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586108}

This reverts commit d687c016.

Reason for revert: No longer necessary to attempt to expand
SSHPortForwarder's functionality to support bidirectional port mapping.

Original change's description:
> Minor change to support bidirectional port mapping
>
> Change-Id: I650d6df01f471f5f896a4fdfd48b6f3db939231e
> Reviewed-on: https://chromium-review.googlesource.com/1170314
> Commit-Queue: Stephan Stross <stephanstross@google.com>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582727}

TBR=kmarshall@chromium.org,sergeyu@chromium.org,stephanstross@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I7bd2efdca42cb09bf5a0a96e537c2cb0d0ac030d
Reviewed-on: https://chromium-review.googlesource.com/1188452Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586107}

Introduces "setShowSelectionOnKeyboardFocus" to make a
tree's selection visible only when it has focus. Navigating a
tree via Arrow keys also happens to require items be:
focusable and selectable.

All ObjectPropertiesSections are now focusable when there is
a selected element. Later CLs will add default selections to
Sources' Watches, Scope, and Network's JSONView.

Screenshot: https://imgur.com/a/WCToYLH

Bug: 865674
Change-Id: Ie7239ddfe4ead101baa0e64dd4893b1587b95336
Reviewed-on: https://chromium-review.googlesource.com/1152463
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586106}

This change will make the 1st-party IME extension be able to access
our IME service on ChromeOS, which includes:
  * create a customized Mojo bindings for the IME extension, and it's
    only accessible by mojoPrivate API with private permission.
  * register the service request in renderer process and forward it to
    the service manager via connector.
  * Service manager will launch the IME service in Utility process
    on demand and bind it to the request from extension.

See go/cros-ime-decoders-mojo for an outline of this IME service.

Test locally on my workstation and verified all the basic functions.

Bug: 837156
Change-Id: I1b75e9c807816156676c5da26d828968ad902f40
Reviewed-on: https://chromium-review.googlesource.com/1151084
Commit-Queue: Leo Zhang <googleo@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586105}

Bug:731358
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ia637891e8b864efceabc527675f1280eb65fe396

TBR=sdefresne@chromium.org

Change-Id: Ia637891e8b864efceabc527675f1280eb65fe396
Reviewed-on: https://chromium-review.googlesource.com/1189162
Commit-Queue: Eric Foo <efoo@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586104}

No-Try: True
Bug: 781271
Change-Id: I3f5a6e19775181cd28151634c95397834abf91bd
Reviewed-on: https://chromium-review.googlesource.com/1189135Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586103}

This is a reland of 088dc9df

GpuProcessHost::Get() is now called with force_create set to false.

BUG=877058
TBR=dgozman@chromium.org,kbr@chromium.org

Original change's description:
> DevTools: Restore GPU tasks recording in performance profiles.
>
> Add GPU process pid to the list of processes where tracing is enabled.
>
> Change-Id: Ic401ee4ea7d218cad36f687be226d092cd4e54a0
> Reviewed-on: https://chromium-review.googlesource.com/1182304
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585301}

Change-Id: I21d6bc8e28724ced518d37a128af6797addaa1c0
Reviewed-on: https://chromium-review.googlesource.com/1187085
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586102}

This CL keeps OffscreenTabOwner in TabCapture API, but moves
OffscreenTab to chrome/browser/media to allow it being used by the
mirroring service to support OffscreenTab mirroring. Implementation is
not changed at all. No functional or behavior change either.

Bug: 734672
Change-Id: Ia8de3680853b86824809d70dc96c6180e9a0c957
Reviewed-on: https://chromium-review.googlesource.com/1180588
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586101}

This reverts commit 4117b35a.

Reason for revert: The issue which was leading to the original crashes here has been addressed.

Original change's description:
> Sheriff: Mark animations/animation-shorthand-overriding.html etc with Crash on Android
> 
> Bug: 874737
> Change-Id: I11c23cf99defa75625cd14284b010e28bb297c72
> Tbr: nhiroki@chromium.org
> Notry: true
> Reviewed-on: https://chromium-review.googlesource.com/1177219
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583565}

TBR=nhiroki@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 874737
Change-Id: I44fa371cdc4d2ee1b1d513484643372774c6943f
Reviewed-on: https://chromium-review.googlesource.com/1188495
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586100}

This is a reland of f933e705

Original change's description:
> Chrome OS: Add Discover window UI.
>
> This CL adds Chrome OS Discover UI in separate window.
>
> Window need further changes to match the specs, but this
> change mostly adds infrastructure.
>
> Bug: 864686
>
> Change-Id: I2834d8f9efb3660050a31768508992acb1f3f262
> Reviewed-on: https://chromium-review.googlesource.com/1182880
> Commit-Queue: Alexander Alekseev <alemate@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#586034}

TBR=isherman@chromium.org,xiyuan@chromium.org

Bug: 864686
Change-Id: I384e150da88aa60b09a5ed93b06403f2bab8e4eb
Reviewed-on: https://chromium-review.googlesource.com/1189166
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586099}

This CL
  - Introduces url_pattern_index::kUrlPatternIndexFormatVersion to keep a track
    of the current format version of the UrlPatternIndex schema.
  - Adds checks to url_pattern_index clients (Declarative net request and
    subresource_filter) to ensure that their ruleset format versions are updated
    whenever kUrlPatternIndexFormatVersion is changed.
  - Adds presubmit checks to components/url_pattern_index to ensure that
    kUrlPatternIndexFormatVersion is kept updated.

BUG=877214, 755717

Change-Id: Ib82b775e3da2112d5f17a2040ec495a7ff8e18d9
Reviewed-on: https://chromium-review.googlesource.com/1187706
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586098}

Observe the target WebContents for Tab/OffscreenTab mirroring.

Bug: 734672
Change-Id: I65194a345f81b38967396c80e5f614d4119782e4
Reviewed-on: https://chromium-review.googlesource.com/1176110Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586097}

CAOS was refactored to simplify the logic for the service connector,
multithreading, and unit tests.

The CAOS::Backend object was renamed to CAOS::CmaWrapper, and much of
the implementation was moved out into CAOS to simplify the object.

The service connector is created in CastAudioManager and passed to
CAOS's audio thread. Instead of passing this then to the media thread
as done previously, we only utilize the connector in the audio thread.
The connector can be easily overriden for tests.

CAOS runs on two threads. It is constructed and controlled from
CastAudioManager in the audio thread. All CMA construction and control
happens in the media thread in the CAOS::CmaWrapper object.

The thread usage in the unit tests has been significantly simplified.
Instead of using RunLoops and multiple threads, we use a single thread
retrieved from a ScopedTaskEnvironment in CAM, CAOS:audio, and CAOS:media.
This means that everything in the unit tests are running on a single
thread, and the tests are far less flaky.

In order to allow everything to run on a single thread, the usages of
WaitableEvent were removed. WaitableEvent was previously used to allow
the synchronous behavior of the audio thread to work with the
asynchronous thread hopping. To compensate for this, certain task
postings between threads can be cached or cancelled, and errors are
returned late.

The following unit tests were added to verify the above behavior and
fill in untested implementation:
- CastAudioManagerTest
  .HasValidOutputStreamParameters
  .CanMakeStream
  .CanMakeMixerStream
- CastAudioOutputStreamTest
  .CloseWithoutStart
  .CloseWithoutStop
  .CloseCancelsOpen
  .CloseCancelsStart
  .CloseCancelsStop
  .StartImmediatelyAfterOpen
  .SetVolumeImmediatelyAfterOpen
  .StopCancelsStart
  .StopDoesNotCancelSetVolume
  .PushFrameAfterStop
  .PushFrameAfterClose
  .MultiroomInfo
  .SessionId

Bug: b/111993375
Test: cast_media_unittests, udon build
Change-Id: Ib7dce8df8a36a2311e13d6a0062b7e56d4928995
Reviewed-on: https://chromium-review.googlesource.com/1159824
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586096}

This CL adds functionality for two edge cases:
(1) If all sub-features are prohibited by policy, the Better Together
    suite should also be prohibited.
(2) If a feature would have been enabled except that the suite as a
    whole is disabled, the feature is now in the
    kUnavailableSuiteDisabled state.

Note: This CL also renames the kDisabledByPolicy enum value to be
kProhibitedByPolicy instead for clarity.

Bug: 870113, 824568
Change-Id: I11bdfcfbfd3313490599831606d31cb5ffa22983
Reviewed-on: https://chromium-review.googlesource.com/1187834
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586095}

If services are launched without full browser process, they need to retrieve
the network service from the service manager connector they have.
This CL adds a helper method to allow that to work.

BUG=695115

Change-Id: I362b814b03d60d9645523664a7243555bac6f053
Reviewed-on: https://chromium-review.googlesource.com/1188776Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586094}

https://chromium.googlesource.com/angle/angle.git/+log/dc248f716822..8707af516c46


git log dc248f716822..8707af516c46 --date=short --no-merges --format='%ad %ae %s'
2018-08-24 syoussefi@google.com Add a test case for enabled-but-inactive vertex attributes
2018-08-24 syoussefi@google.com Disable vertex attributes if not active in program


Created with:
  gclient setdep -r src/third_party/angle@8707af516c46

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ied6acdbd1d1776e21827cc16e315f32360be4ef3
Reviewed-on: https://chromium-review.googlesource.com/1188926Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586093}

We're seeing crashes in GetContextOwner(), which is used to return an
identifier for a v8::Context that is constant across multiple contexts
for that same owner (e.g., an extension id). The crash is happening
at a failed CHECK:

ScriptContext* script_context = GetScriptContextFromV8ContextChecked(context);
const std::string& extension_id = script_context->GetExtensionID();
bool id_is_valid = crx_file::id_util::IdIsValid(extension_id);
CHECK(id_is_valid || script_context->url().is_valid());

Looking at the crash dumps, it appears that this crash happens with a
ScriptContext that has neither an associated extension nor a valid URL
(the URL is empty). The context type is for a Feature::WEB_PAGE_CONTEXT.

In theory, this should never happen, because contexts should only be
classified as a WEB_PAGE_CONTEXT with a valid URL. However, there is a
chance that it could, as described in https://crbug.com/877658. My
suspicion is that this happens during page navigation, when we are
loading/initializing a new context.

Both native and JS-based bindings use the same check for validity, but
it appears this crash only happens in native bindings. The primary
difference is that native bindings check a context owner's identity
immediately on event construction, whereas JS bindings do it lazily on
listener addition/removal.

In order to try and mitigate the crashes, change native bindings to
mimic JS bindings behavior, where the context identity is determined
lazily. This will not fix the underlying context issue, but should
hopefully address the crashes. If it doesn't, we'll have to go back to
the drawing board.

Bug: 877401

Change-Id: I8b29ec872b1fdb33f74b96bfa85e721b5e26b870
Reviewed-on: https://chromium-review.googlesource.com/1188764
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586092}

https://chromium.googlesource.com/catapult.git/+log/72712b0d6078..bc2c0a930728


git log 72712b0d6078..bc2c0a930728 --date=short --no-merges --format='%ad %ae %s'
2018-08-24 zmo@chromium.org Exclude a few more folders with large data from telemetry data set


Created with:
  gclient setdep -r src/third_party/catapult@bc2c0a930728

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:872521
TBR=sullivan@chromium.org

Change-Id: I905c391cc4d42a8e3d7334203aa1af701a1bbc66
Reviewed-on: https://chromium-review.googlesource.com/1188931Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586091}

The caller expects the decoder to populate memory in the allocator if
set, but the MockImageDecoder was not doing this. This causes failures
in MSAN where the memory remains unitinitialized.

Fix MockImageDecoder to respect this expectation.

R=chrishtr@chromium.org

Bug: 877497
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I441095eb3fb89c90cf3b9bf592438cd20b126391
Reviewed-on: https://chromium-review.googlesource.com/1188877
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586090}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2916d264903a..28763cdcff7e


Created with:
  gclient setdep -r src-internal@28763cdcff7e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I9ab941a0a6d3ec57a6f5c3ea687396e7f4b9a826
Reviewed-on: https://chromium-review.googlesource.com/1189123Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#586089}

Since Bluetooth power preference became user-specific, we disallowed
non-primary users to change Bluetooth power setting for UX consistency
with system tray.

Bug: 853374
Change-Id: If61d2c0c048e7d8c764e24798da0ebbf2ab6c68f
Reviewed-on: https://chromium-review.googlesource.com/1187601
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586088}

This CL adds ref count to a ServiceWorker while dispatching an
extension event to it. The ref count is decreased when we receive an
ack for worker thread, similar to vanilla extension events.

This CL adds the event ack IPC from worker thread to browser process.

The ref counting methods in //content (Starting/FinishedExternalRequest)
requires service worker version id within a SWContext, this CL adds
support for this:
  - in browser process: EventListeners now also include service
    worker version id.
  - in browser process: ServiceWorkerContext::StartWorkerForPattern
    returns version id along with existing information (render process
    id and worker thread id). ServiceWorkerTaskQueue uses it to
    dispatch event through EventRouter.
  - in worker thread: ScriptContext of a worker also stores the
    version id, used while sending event ack from WorkerThreadDispatcher.

Bug: 876207
Change-Id: Ia0d2df39091ac07504444523020fef9579e42696
Reviewed-on: https://chromium-review.googlesource.com/1175420
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586087}

When we seek a video being casted with the FlingingRenderer, time never
gets updated on the phone after the seek completes. This is because
Blink doesn't get the appropriate seek completion signals, since WMPI's
buffering state never goes back to BUFFERING_HAVE_ENOUGH.

This CL fixes issue by always returning BUFFERING_HAVE_ENOUGH in
FlingingRenderer::StartPlayingFrom(). Because there is no need to buffer
when using the FR, we can always consider the media pipeline to be fully
buffered. Sending a buffering state change in StartPlayingFrom() might
be suprising, but we do the same with the MediaPlayerRenderer, and it
has not caused any (known) problems so far.

Bug: 875517
Change-Id: If6069d501af12ec20f844d0adc1ea980935fb99f
Reviewed-on: https://chromium-review.googlesource.com/1184060
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586086}

This should guard against a crash.
It's not clear exactly what the cause of this null is, but it's
probably some kind of failure to allocate the SkImage (e.g.
out-of-memory, GPU process loss, or other unpredictable failure case).

Bug: 852303
Change-Id: I10a817f2dccd801f5834be343ad687af09e06721
Reviewed-on: https://chromium-review.googlesource.com/1188515Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586085}

This simplifies many conditions around the code in
chromeos/components/tether.

Bug: 561800
Change-Id: I69c25666ae1b1362df6df67889a9a45226961387
Reviewed-on: https://chromium-review.googlesource.com/1188060Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: DongJun Kim <djmix.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#586084}

Avoids linker errors from LLD about -Wl, not being a recognized command
line flag.  This will fix the Windows CFI and ThinLTO FYI bots.

Factor out a variable for the optimization level so we need one less
conditional.

TBR=agreive@chromium.org, agrieve@chromium.org, gbiv@chromium.org, pcc@chromium.org

Bug: 807147
Change-Id: I8a928eaab93ec181ba057cdda4cb635389f30926
Reviewed-on: https://chromium-review.googlesource.com/1188879Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586083}