GitLab

This is a minimal fix suitable for merging to M38. The underlying problem
is that we create a new MenuButton instance (with its own click handler)
for every connection. I recently changed the behaviour of MenuButton so
that it toggles the 'active' class instead of adding it so that clicking
on the button while a menu is open will dismiss it. However, this breaks
if there an even number of MenuButton instances for a single DOM element.

The correct fix is to make the tool-bar buttons owned by the tool-bar,
which is a singleton. However, this minimal fix, which restores the M37
behaviour, is a better option for merging to M38.

BUG=415410

Review URL: https://codereview.chromium.org/584693003

Cr-Commit-Position: refs/heads/master@{#295759}

Move FindFullName outside LIBPEERCONNECTION_LIB definition block. This is to solve a link break when new finch experiment is defined inside peerconnection.cc while libpeerconnection.so is built as a shared library.

BUG=

Review URL: https://codereview.chromium.org/582133002

Cr-Commit-Position: refs/heads/master@{#295758}

Currently there are no keyboard shortcuts to rotate pdf
documents. This patch adds the following keyboard shortcuts
to rotate pdf documents :

Rotate counterclockwise : Control + [
Rotate clockwise        : Control + ]

BUG=111232

Review URL: https://codereview.chromium.org/581913003

Cr-Commit-Position: refs/heads/master@{#295757}

BUG=415382

Review URL: https://codereview.chromium.org/583873003

Cr-Commit-Position: refs/heads/master@{#295756}

Moves debug logging and tracing logic off the command processing path
when they are disabled.

BUG=394570

Review URL: https://codereview.chromium.org/553293002

Cr-Commit-Position: refs/heads/master@{#295755}

BUG=414808
R=scottmg@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/589633002

Cr-Commit-Position: refs/heads/master@{#295754}

BufferedResourceHandler passes the response to both the old and the new
handler, so there is a race where the streams logic could access headers on the
UI thread while the old handler (AsyncResourceHandler) is busy modifying them
(via ChromeResourceDispatcherHostDelegate).

BUG=none

Review URL: https://codereview.chromium.org/588643002

Cr-Commit-Position: refs/heads/master@{#295753}

BUG=none
R=
TEST=none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/587773002

Cr-Commit-Position: refs/heads/master@{#295752}

WebRTCInternals uses NotificationRegistrar which must be deleted on the UI thread. In cases where the UI thread is not the same as the main thread (like in Chromium Embedded Framework) the destruction of WebRTCInternals via AtExitManager at shutdown will cause a CalledOnValidThread() check failure. There's no particular reason why the object needs to be deleted at shutdown so just leak it instead.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/575283004

Cr-Commit-Position: refs/heads/master@{#295751}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/43d361f..87e2437

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/589593002

Cr-Commit-Position: refs/heads/master@{#295750}

On trybots, the viewer shutdown is frequently taking 16s, making ash_unittests
as a whole take ~20m. Killing the viewer more aggressively makes all the tests
run at the "normal" time in the 1-500ms range, dropping total time to 5-6m.

R=cpu@chromium.org
BUG=411147

Review URL: https://codereview.chromium.org/584513004

Cr-Commit-Position: refs/heads/master@{#295749}

Review URL: https://codereview.chromium.org/492773002

Cr-Commit-Position: refs/heads/master@{#295748}

Generalize crypto::SignatureCreator to allow choice of hash function, so as to support SHA256 (not just SHA1).

BUG=412531

R=rsleevi@chromium.org,davidben@chromium.org

TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/560583002

Cr-Commit-Position: refs/heads/master@{#295747}

Chrome for Android can use the same code for displaying the application
version on the about:version page as other platforms. There's no need to
special-case it.

Review URL: https://codereview.chromium.org/583003002

Cr-Commit-Position: refs/heads/master@{#295746}

This should be consistent with the other targets in the builder.

BUG=391895

Review URL: https://codereview.chromium.org/584953002

Cr-Commit-Position: refs/heads/master@{#295745}

BUG=NONE

Review URL: https://codereview.chromium.org/584153002

Cr-Commit-Position: refs/heads/master@{#295744}

This brings in <paper-ripple> implemented with CSS instead of <canvas>,
and presumably a slew of other changes.

TBR=ykkyip@chromium.org,nduca@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/586823002

Cr-Commit-Position: refs/heads/master@{#295743}

This patch adds the enterprise policy changes for ImportAutofillFormData
preference.

BUG=415975

Review URL: https://codereview.chromium.org/581583004

Cr-Commit-Position: refs/heads/master@{#295742}

BUG=387410
R=qyearsley@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/560123004

Cr-Commit-Position: refs/heads/master@{#295741}

BUG=415409
TEST=Logged in as regular user, checked that "Import and bind to device" button is enabled. Installed a cert using platformKeys API and it was listed on chrome://settings/certificates. chrome://network listed "Certificates Loaded".

Review URL: https://codereview.chromium.org/585823002

Cr-Commit-Position: refs/heads/master@{#295740}

BUG=None
R=sadrul@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/582923002

Cr-Commit-Position: refs/heads/master@{#295739}

Previously it would check all of the arguments, and use the last test found.
This is causes problems as different tests can be used to create the parser and
accepts the parsed flags.

SHERIFFS: If errors related to parsing flags for run_measurement, run_benchmark
or run_gpu_test.py appear, this is likely the cause. It is safe to revert.

BUG=413334

Review URL: https://codereview.chromium.org/582793002

Cr-Commit-Position: refs/heads/master@{#295738}

This allows us to read MSRs on Windows Vista+.
Also move ReadMsr into PlatformBackend.

BUG=336558
TEST=tools/telemetry/run_tests msr

Committed: https://crrev.com/2156b0323c83d6f11e68344ecf7e7e0c833cfa14
Cr-Commit-Position: refs/heads/master@{#295634}

Review URL: https://codereview.chromium.org/578123002

Cr-Commit-Position: refs/heads/master@{#295737}

BUG=413370

Review URL: https://codereview.chromium.org/585003002

Cr-Commit-Position: refs/heads/master@{#295736}

Third side of crrev.com/552293002/

BUG=408636

Review URL: https://codereview.chromium.org/584833002

Cr-Commit-Position: refs/heads/master@{#295735}

BUG=415846

Review URL: https://codereview.chromium.org/582133003

Cr-Commit-Position: refs/heads/master@{#295734}

it wasn't observing the display change.

BUG=316217
TEST=install the test app attached in the bug and change the scree resolution.

Review URL: https://codereview.chromium.org/581023003

Cr-Commit-Position: refs/heads/master@{#295733}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a Mac build.

BUG=110610

Review URL: https://codereview.chromium.org/584083002

Cr-Commit-Position: refs/heads/master@{#295732}

BUG=412458

Review URL: https://codereview.chromium.org/587613002

Cr-Commit-Position: refs/heads/master@{#295731}

R=darin@chromium.org

Review URL: https://codereview.chromium.org/585633004

Cr-Commit-Position: refs/heads/master@{#295730}

This will replace AttachMessagePipeEndpoint(), once I get rid of all the
calls to it. (This change is required to move the "paused message queue"
from the ProxyMessagePipeEndpoint to the ChannelEndpoint.)

Also factor out the message writing (WriteMessageNoLock()) from the
message enqueueing (EnqueueMessage()) in ChannelEndpoint. After I move
the paused message queue to ChannelEndpoint, the latter will put stuff
into said queue if it can't write.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/584723002

Cr-Commit-Position: refs/heads/master@{#295729}

When the shadow layer bounds is smaller than the full shadow image size,
we should crop the corner tiles by reducing aperture values instead of making
the shadow layer invisible.

This allows shadow to draw correctly when window size is very small.

BUG=415514
TEST=visually verify that window shadows are drawn correctly with very small windows.

Review URL: https://codereview.chromium.org/581273002

Cr-Commit-Position: refs/heads/master@{#295728}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f782639..43d361f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/585993002

Cr-Commit-Position: refs/heads/master@{#295727}

The flakiness is caused by issue 415401. Temporarily disable tests that close
the FileIO during pending read or write.

This also reenables ECKEncryptedMediaTest.FileIOTest by reverting commit
5af9a9c9.

BUG=415401,415742

Review URL: https://codereview.chromium.org/582233003

Cr-Commit-Position: refs/heads/master@{#295726}

This reverts https://codereview.chromium.org/520743002/

BUG=394287

Review URL: https://codereview.chromium.org/580403004

Cr-Commit-Position: refs/heads/master@{#295725}

BUG=None

Review URL: https://codereview.chromium.org/575193002

Cr-Commit-Position: refs/heads/master@{#295724}

BUG=none

Review URL: https://codereview.chromium.org/585883002

Cr-Commit-Position: refs/heads/master@{#295723}

Remove XP from list of perf trybots in telemetry
Add error message for perf tryjobs on win XP

BUG=414830

Review URL: https://codereview.chromium.org/570413003

Cr-Commit-Position: refs/heads/master@{#295722}

The following behaviour implmented:
* If "new-remora-oobe" switch is not set, OOBE starts with with the regular
  "remora" UI. At the same time wizard controller we start to listen for
  incoming connection from shark controller. If connection is established, we
  switch UI to the new one.
* Otherwise, we launch the new UI from the beginning of OOBE.

Several small issues fixed as well.

BUG=405150
TEST=manually

Review URL: https://codereview.chromium.org/528803002

Cr-Commit-Position: refs/heads/master@{#295721}

As code for MetricsReportingEnabled checkbox has been refactored not to use pref in HTML, it is not possibly to test the policy enforcement with the current test (codereview.chromium.org/506663003).

Therefore we skip MetricsReportingEnabled test to have a quick solution for failing bots, until a new test will be created.

Also, just because I was touching this file I fixed OFFICIAL_BUILD to be GOOGLE_CHROME_BUILD(discussed in crbug.com/399462).

BUG=414945

Review URL: https://codereview.chromium.org/586453002

Cr-Commit-Position: refs/heads/master@{#295720}