- 21 Jan, 2021 40 commits
-
-
Luciano Pacheco authored
When running as non-js-modules the <bread-crumb> has its images in-lined by grit, however when running as JS modules the <bread-crumb> is in-lined via rollup, then it runs from the path foreground/js/ instead of its actual path foreground/js/ui/ making the relative address to its images incompatible. Fix by duplicating the 2 affected images, moving them up 1 directory so the relative path is consistent. NOTE: These 2 images are the only references to "/images" inside the ui/ directory. [1] [1] - https://source.chromium.org/search?q=%22images%2F%22&sq=&ss=chromium%2Fchromium%2Fsrc:ui%2Ffile_manager%2Ffile_manager%2Fforeground%2Fjs%2Fui%2F Bug: 1133186 Change-Id: I71a10286c325e54c3adecc0f079002aeab7a0344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640006Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845547}
-
Xiaodan Zhu authored
This CL implements the reordering of the desks by keyboard. When a desk thumbnail is highlighted. - Pressing Ctrl + -> will swap current desk with the right one. - Pressing Ctrl + <- will swap current desk with the left one. Bug: 1164025 Change-Id: Ibb14098073191faa4d31e9075cde275006a29edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623719Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845546}
-
Gavin Williams authored
Move the common dropdown code for sorting and choosing the default option to SelectBehavior. Add getSelectedOption(), sortOptions(), and isDefaultOption() to each settings dropdown. These functions are called from SelectBehavior. Bug: 1168346 Change-Id: I186a6e2ef18b335fdba0f81e4002f4859d27d0eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638499 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#845545}
-
Luciano Pacheco authored
The i18n strings in the deferred elements need the `loadTimeData` which is initialized in the background page and in the initBackgroundPagePromise_. Change the initialization for JS modules to wait the background promise before importing the deferred elements. Bug: 1133186 Change-Id: I2f82cc3ca89964900c5711652379fbcbdff17acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641785 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/821a84558bd4..3c142940b9dd 2021-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 311a17a8feae to 762814bd9229 (7 revisions) 2021-01-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 89fd1480b47e to b3e5c440d239 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I0b05fe93dd42dc6a98f308619bfa28099785b7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845543}
-
Shik Chen authored
Bug: b/176879728, b/172344433 Test: Manually verify the animations Change-Id: I6bd326171812531c3d150b1531564fe4cecc38a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639613Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#845542}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96b7ec727bac..d5c88e60cff4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1164189,chromium:1166926 Tbr: keishi@google.com Change-Id: I9dcdf56fe37aee5ee87dd0f0fc928b78c4c1befb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641648Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845541}
-
Bartek Nowierski authored
The names are highly confusing and misleading. These functions don't return an actual size, but an underlying capacity, which may or may not be readily available to the app. AllocationCapacity* names reflect the behavior better. Change-Id: I4c59dbf75397b31ed58c1467c019ca23057031c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636748 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845540}
-
Nikolai Artemiev authored
Allows the --form-factor flag to be used to override the form factor value from the LSB release info. BUG=b:173179861 TEST=CQ Change-Id: Ic4dd3eb52dd562d35debac3fea168f686d728e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631393 Commit-Queue: Nikolai Artemiev <nartemiev@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Nikolai Artemiev <nartemiev@google.com> Cr-Commit-Position: refs/heads/master@{#845539}
-
Bruce Dawson authored
Chrome sometimes needs to detect when an object has been deleted in the middle of a member function. Manually maintaining a destroyed pointer/flag is error prone and verbose so this change switches to using WeakPtr. In the NativeMenuWin case the destroyed pointer wasn't even used, making deleting it particularly easy. Idea from dcheng@ Bug: 1152152 Change-Id: Ie913fa6255c5db4667e59b724732df2dbedf5580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637268Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#845538}
-
Kenichi Ishibashi authored
This reverts commit b53ca149. Reason for revert: Caused test flakiness (crbug.com/1168509) and crashes (crbug.com/1168509). Original change's description: > Quota: Mojofy Service Workers's QuotaClient. > > Bug: 1163048 > Change-Id: I1744df8280e11bc96073415354a0006f49fd6a9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628078 > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Commit-Queue: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844768} TBR=falken@chromium.org,pwnall@chromium.org,siggi@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1163048 Change-Id: I1ae404f8353ca73c65ed0a8aa8621055c34e3efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640317Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845537}
-
Nancy Wang authored
The full restore calls BrowserAppLauncher::LaunchAppWithParams to restore the system web apps: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/full_restore/app_launch_handler.cc;l=210 So modify BrowserAppLauncher::LaunchAppWithParams to save the launch parameters to prepare the full restore for the next reboot. Modify ExtensionAppsChromeOs to save the launch parameters for platform apps only. Modify WebAppsChromeOs to save the launch parameters for the system web apps only. Because if the apps opened in tab or with browser, the full restore component can get the info from the window property kWindowIdKey, and Chrome session restore can restore browsers, so we don't need to save the launch parameter. BUG=1146900 Change-Id: I1231bcbc1d665918f5f6d7efbf19751387bf8ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639346Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845536}
-
edchin authored
Extracts web_contents from PasswordProtectionRequest into a derived class. The base class will be moved to /core in a future CL. Bug: 1147967 Change-Id: I011f1a853168ce6c40108bc5d0fb1dd78e1321fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638775 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#845535}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7acbae90a490..561f5af9ef1e 2021-01-21 tsepez@chromium.org Enable incremental sweeping for XFA 2021-01-21 tsepez@chromium.org Remove includes of windows tchar.h. 2021-01-21 awscreen@chromium.org Roll third_party/skia/ ae95077db..81bfabeb1 (783 commits) 2021-01-21 awscreen@chromium.org Roll third_party/zlib/ c29ee8c9c..2c183c9f9 (1 commit) 2021-01-21 awscreen@chromium.org Roll third_party/libjpeg_turbo/ d5148db38..518d81558 (4 commits) 2021-01-21 awscreen@chromium.org Roll v8/ c52956d09..1d681a1a9 (483 commits) 2021-01-21 awscreen@chromium.org Roll base/trace_event/common/ eb94f1c7a..9b2775773 (1 commit) 2021-01-20 awscreen@chromium.org Roll third_party/instrumented_libraries/ 6ba978ccb..4d3867052 (1 commit) 2021-01-20 awscreen@chromium.org Roll third_party/icu/ 6a33b647c..899e18383 (4 commits) 2021-01-20 awscreen@chromium.org Roll third_party/googletest/src/ 4fe018038..d128fc825 (156 commits) 2021-01-20 awscreen@chromium.org Roll third_party/freetype/src/ 8cc4d0dc3..03ceda970 (87 commits) 2021-01-20 awscreen@chromium.org Roll third_party/depot_tools/ 18f45d287..3253a1dec (83 commits; 22 trivial rolls) 2021-01-20 awscreen@chromium.org Roll tools/clang/ 9ec0bb322..683dad603 (18 commits) 2021-01-20 awscreen@chromium.org Roll buildtools/ 6302c1175..c38b5ab1c (5 commits) 2021-01-20 awscreen@chromium.org Roll build/ 33d5eb773..781f0025b (185 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156170 Tbr: pdfium-deps-rolls@chromium.org Change-Id: If5588051d04a818c95631e7bad57a3670f0e5fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641647Reviewed-by:
-
Asami Doi authored
This CL adds 3 test cases for clients.claim(): 1) a blob URL worker (parent) creates a blob URL worker (child) 2) a blob URL worker (parent) creates a worker (child) 3) a worker (parent) creates a blob URL worker (child) Bug: 1017034 Change-Id: Iaef9c84661f0fe1c1b10a4a6f8cccc5e839355c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638960 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#845533}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Ieebd11507009669b138584be6a09d31e4ce20a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640316Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aeaf8b9be0c2..f1a39a74b67f 2021-01-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-21 andoli@chromium.org [module.json extensions] mobile_throttling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87d59897389f7ae57c36796fae86cb5f68b18a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641646Reviewed-by:
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: I65e1a8acdf573ce233b9d78bcdc213f12cb1109e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639431 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Jenny Zhang authored
This cl makes several improvements: 1. Run callback function of LacrosChromeService api with return value on IPC thread instead of UI thread. 2. Run GetCompressedHistograms in base's thread pool instead of UI thread, since it calls functions marking as blocking. 3. Do not store the callback passed to LacrosChromeServiceDelegateImpl. Bug: 1167026 Change-Id: I85ec998517e78bad067f1da49c7cff05e4222539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633192Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845529}
-
Kenton Lam authored
Brief changes: - Set dialog window size. - Fix emoji spacing. - Hide (currently non-functional) search field. - Use Roboto font. - Sticky tab row to top while scrolling emoji. - Replace "frequently used" with "recently used" to match its behaviour (which is not implemented yet). Screenshot: https://screenshot.googleplex.com/4Y8zvfGgpmMHq9y.png Bug: 1152237 Change-Id: I25c3a1787e80f6693edd483f502692fafe586e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639615Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#845528}
-
Inker Kuo authored
This reverts commit a6df04e9. Reason for revert: crbug.com/1168666 Original change's description: > [VideoCapture] Make VideoCaptureHost per frame instead of per process > > Prior to this CL, there was a VideoCaptureHost mojo object per renderer > process. This CL makes it per frame, which is preferred. > > This CL keeps the mojo client (VideoCaptureImpl and > WebVideoCaptureImplManager) in platform since they do not really need > to know about frames, only about a browser interface broker. > LocalVideoCaptureClientImpl is moved to modules/mediastream, where it > can know about frames and can pass the corresponding BIB to the video. > The other user of the video-capture client is pepper, which already > knew about frames. > > > Bug: 1167900 > Change-Id: I699a1b0e1285e8b384c9be6bb9c6d04d0951c9c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632614 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845096} TBR=kinuko@chromium.org,haraken@chromium.org,guidou@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6d4e81112386671fb49a0d73a5cf892c98dc25b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1167900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641824Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/08f5311ae142..821a84558bd4 2021-01-21 reed@google.com remove dead code from old drawimage virtuals If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I42a58c0d83938e862199f60f756dbd13c7323927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641354Reviewed-by:
-
John Palmer authored
View an autocorrect as accepted if we hide the underline after 4 keypresses. There is one minor edge case where the user has an autocorrect and quickly leaves the text field. I think for now, it is safe to ignore this edge case. Requires some changes to blink code as existing getAutocorrectRange() only works when cursor is in the autocorrect range, otherwise it returns an empty range. This change means that getAutocorrectRange() works even when the cursor is not in the range, which is needed to know if the range is still there to record the metric. Bug: b/170682691 Change-Id: I44f22b7c6990a2dd03dc45072290924710c968e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613845Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845525}
-
Fergus Dall authored
We're trying to track down the cause of some login flake in tast tests, which is inhibited by not being able to see the error response from the gaia servers. Add some VLOG statements to GenerateAuthError to record the exact error type and response. These will be enabled in some tast tests. Bug: 1166530 Change-Id: Ie9fc408f49e406ffc3790a7ec5dc65bf1eedf2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639338Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#845524}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f9759b6f..ed78a103 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3dd915d96a438482df3866bb748f688425b2dafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641305Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845523}
-
Steven Bennetts authored
The 'Tethering' string property was once used to identify networks that might be metered. That has since been replaced with a 'Metered' boolean property which is now used in the UI. There are no remaining uses of 'Tethering' in Chrome. This CL eliminates the ONC property and the NetworkState member to reduce confusion. BUG=1078427 Change-Id: Iafaa7aba430d31c792f462d26cde43d15968057f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639818Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#845522}
-
Piotr Bialecki authored
This CL adds new enterprise policy that is used to gate access to immersive-ar sessions in WebXR Device API. The enterprise policy is per-profile, and is implemented by propagating the pref value from browser process to blink via WebPreferences. Additionally, the CL also introduces new AndroidBrowserTest that exercises the added glue code, with the assumption that the enterprise policy code that controls the pref is correct. Other changes: - add manifest entry in test jinja template in order for them to work on newer Android versions - add DVLOGs in WebXR code paths to assist with debugging Bug: 1159067 Change-Id: I27eba5fc0e7bae3dca2d47ca3fb2e935facbd37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627778 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#845521}
-
Kent Tamura authored
'menulist' and 'listbox' Also, this CL replaces the remaining '-webkit-appearance' usages with 'appearance'. The new behavior matches to Firefox. Bug: 965432 Change-Id: Ic091a0825beb437d634bdfe4959b9e364666cf92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634882 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec4d81245d2c..96b7ec727bac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112471,chromium:1150968 Tbr: keishi@google.com Change-Id: I9643f82fb1d4ffd90d6d78f2e33317992c58e591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641395 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
rbpotter authored
On Windows, it is being reported that fetching capabilities for deleted printers sometimes succeeds. This is problematic for the dropdown, as dropdown destinations' existence is checked by verifying that their capabilities can be fetched from the backend. This is a speculative fix to instead fetch printer lists from the backend instead of capabilities, as these printers are reported to eventually disappear, indicating they are not being found for the dialog (which uses the lists). A printer's existence in the list is then used to determine whether to show it in the dropdown. To achieve this, fetch all destinations corresponding to the dropdown destinations and/or default destinations (from policy or the system) origins at initialization. Fetch capabilities only once a printer is auto-selected. Possible downsides: if fetching printers is significantly slower than fetching capabilities, this may result in additional startup delay. However, this does not seem to be the case, and the dialog printers are now potentially populated more quickly (since many may have already been retrieved). Note: this also prevents the need for a timeout, as there are no known cases of indefinite hanging on the getPrinters() call (vs calls that try to get a specific printer). As printers get added to the store, the possible candidates for autoselection are searched for in order of priority. This has the additional benefit of reducing the amount of code in destination store by removing the timeout and pre-fetching capabilities logic. Bug: 1092926 Change-Id: I54860b06bf9de6b77939781b82031671760f82f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600268 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845518}
-
chrome://emoji-pickerKenton Lam authored
Currently, there is basic testing of the <emoji-picker> component to make sure that clicking the tab icons correctly activates and deactivates the tabs. Change-Id: I29762bba9dec60fc7260311247df68c44fd22d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631395Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bb3adfa42822..137271ffc54d 2021-01-21 sunnyps@chromium.org Support specifying array slice for D3D11 texture EGLImage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1116101 Tbr: cnorthrop@google.com Test: Test: D3DTextureTest.TextureArrayImage* Change-Id: I0b58eedaa197b16860b4797180bbbcaf37665ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640836Reviewed-by:
-
Aleks Totic authored
2 tests in this test suite seem inconsistent: test#2 asserts that tbody.height=10px > tr.height=1px > td.height=1px implies td.offsetHeight = 1px test#4 asserts that tbody.height=10px > tr > td.height=1px implies td.offsetHeight = 10px Edge 17 is the only browser that agrees with #2 and #4 FF agrees with #2, but not #4 Chrome agrees with #4, but not #2 Safari agrees with #4, but not #2 To me, #2 and #4 seem to be in conflict. Either tbody height propagates to rows, or it does not. The problem is that #2 is overconstrained. My suggestion is that tbody height always propagates to tr. Bug: 958381 Change-Id: I28bfd108c67968d31d0372b536c316c997d2d958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586097Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#845515}
-
edchin authored
This CL makes it easier/clearer to split up PasswordProtectionRequest in a future CL. GetDomFeatures should be wrapped in a SAFE_BROWSING_AVAILABLE buildflag since it's declaration is wrapped in that buildflag. Bug: 1147967 Change-Id: I4a06732c97ba49ad1212816bd073b6e526b29ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638242 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611165592-7dc454a3a93e8067ea7c07bb6e94372701a24ad7.profdata to chrome-win32-master-1611187144-091cd0ce23c5cf7321279c1e02f3c90b64671b48.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I131fe5d80d5dc0054beae1d16fe01512c6b4b753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641186Reviewed-by:
-
Angela Gyi authored
This CL refactors the title preview feature in the sharesheet by moving it into a dedicated SharesheetContentPreviews class. Bug: 1167935 Change-Id: I2671c0e53e04779e8fe8bdf3d37d30f91161d3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636734Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Angela Gyi <angelagyi@google.com> Cr-Commit-Position: refs/heads/master@{#845512}
-
Takuto Ikuta authored
This reverts commit 487e7412. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/Win%207%20Nvidia%20GPU%20Perf/17285 Original change's description: > Reland "trigger_scripts: support go client in chromeos_device_trigger" > > This reverts commit 78d95924. > > Reason for revert: > This fixes previous failure and has a test > > Original change's description: > > Revert "trigger_scripts: support go client in chromeos_device_trigger" > > > > This reverts commit 3fd9ba25. > > > > Reason for revert: > > https://ci.chromium.org/p/chrome/builders/ci/android-go_webview-perf/23071 > > > > Original change's description: > > > trigger_scripts: support go client in chromeos_device_trigger > > > > > > This scripts needs json conversion similar to > > > https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62 > > > when using go client. > > > > > > This is fix for breakage like > > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159 > > > > > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel > > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > > > Bug: 1127205 > > > Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275 > > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#844979} > > > > TBR=tikuta@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com > > > > Change-Id: I96bf20546c714a40a53c44afb57bab5924da5d7e > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1127205 > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638954 > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#844987} > > # Not skipping CQ checks because this is a reland. > > Bug: 1127205 > Change-Id: I6b408eed0dbf16608b6ee7084ec093ff4ab51233 > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639441 > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845499} TBR=kbr@chromium.org,tikuta@chromium.org,bsheedy@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com Change-Id: I94525d422ea33245c3142696752cbf64f02e841a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127205 Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639349Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#845511}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I00634d73fef108a4c73b2b8caaf3c66ec2459ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641479Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845510}
-
Azeem Arshad authored
This CL also updates hermes dbus constant references that were pulled in with this uprev. https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/adce67ac57ed..1ee85a708f6a $ git log adce67ac5..1ee85a708 --date=short --no-merges --format='%ad %ae %s' 2021-01-20 pholla system_api: Fix hermes's dbus constants 2021-01-13 kimjae minios: Daemonize minios 2020-11-05 damiendejean shill: add always-on VPN configuration to Profile. 2020-11-11 kevinptt runtime_probe: use ProbeConfigLoader to load probe configs 2020-12-22 yich system_api: moving bootlockbox-protos to shared lib 2020-12-22 yich system_api: build tpm_manager goprotos Created with: roll-dep src/third_party/cros_system_api Bug: 1093185 Change-Id: I247131016f8019892ac9645b440473d202046ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641195 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Jerome Jiang authored
Except ChromeOS and Android. Change-Id: I54acfaa74f5df5799c1709a2004d34fb9a27e60d Bug: 1095763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617229 Commit-Queue: Jerome Jiang <jianj@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#845508}
-
