- 30 Mar, 2020 40 commits
-
-
Justin Miron authored
This change calls OnMainFrameDocumentIntersectionChanged for the main frame. The RenderFrame resets the main frame's intersection when the frame commits a navigation to ensure we propagate a new intersection for each committed navigation (otherwise we may lose updates when the render frame observer propagates values for uncommitted loads to page load metrics). This allows consumers to compare frame intersections with the main frame's rect. This is a precursor to measuring page ad density. BUG=993453 Change-Id: I689505c086ed0216af9f216ed4dd3d13f9c3ec1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105622 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#754626}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e7603d3ab878..de6d9fd4428c git log e7603d3ab878..de6d9fd4428c --date=short --first-parent --format='%ad %ae %s' 2020-03-30 treehugger-gerrit@google.com Merge "TrackEvent: Add entry point for track+timestamp+lambda" Created with: gclient setdep -r src/third_party/perfetto@de6d9fd4428c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I81ef5c156ff65d13a23270b1f016c9d4432e1870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127421Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754625}
-
Avi Drissman authored
Attempting to keep a list of proxied methods on MTLDevice is a losing battle. So use -forwardInvocation: to implement blanket forwarding. Bug: 1065146 Change-Id: I3110a3b02430590664545be5072c993e64a14cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125462 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#754624}
-
Clark DuVall authored
This implements a basic CookieManager for WebLayer which allows getting and setting cookies. Bug: 1054160 Change-Id: I4d875ce95abc75f8012a222778e4eb1ed6839a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122475Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#754623}
-
Daniel Libby authored
On Aura and Android, there is a feature that describes the document/frame selection to the compositor for touch selection. These coordinates are layer-relative so that they can later be used to determine whether or not the start and end of the selection is visible and whether the handles should be rendered. This currently relies on Blink being able to query compositing state, which is not available during PrePaint with CompositeAfterPaint enabled. This change has us early-out for CAP and leaves a TODO with bug to go implement this for CompositeAfterPaint Bug: 1007989 Change-Id: I2876a5bdc847b4e9e8afbbf7b75f4701b387fa23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120091 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754622}
-
Devlin Cronin authored
Extensions used to be able to override the bookmark star view in order to provide a custom bookmark manager (this was used for the Stars extension). The extension has been deprecated and removed, and the API never launched. Clean up the remnants. No longer check for extension overrides when bookmarking a tab, and simplify the methods to simply be BookmarkCurrentTab(). In addition to removing what was thought to be dead code, this also fixes a bug that exists today that allowed non-Stars extensions to implicitly override the "Bookmark this tab..." behavior, independent of whether they were actually a bookmark manager. (This was caused because we didn't check the command was active before using it in browser_commands.cc.) Bug: 894447, 1065167 Change-Id: I975cac58e72e113c351fe63735c4be5c3f08aa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123315Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#754621}
-
Patrick Monette authored
This is a reland of 8e70db4d Original change's description: > [PM] Connect dedicated workers to their client frames in the graph. > > Bug: 993029 > Change-Id: Iae20fa0ede4421782fc5fbf2851d21c83cfbf4c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095452 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753319} Bug: 993029 Change-Id: I859f004b938164a02e43b74e6f9225d25e90d083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122476Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#754620}
-
Aran Gilman authored
This reverts commit a18fd063. Reason for revert: Branch is coming up, and this CL is the likely cause of a release-blocking bug on Android (https://crbug.com/1065341). Original change's description: > Persist Reader Mode theme and font family settings on desktop. > > This CL expands the existing JavaScript bindings to allow storing the > theme and font family selected via the in-page appearance settings > dialog to the corresponding synced preferences. > > The ability to persist the font size/scale will be added in a > follow-up CL. Storing that setting requires some additional work to > convert the font size in pixels used by the desktop UI to the scale > relative to base size expected by the pref. > > Bug: 1016615 > Change-Id: Ia7f8c86b8e9fa136b2b18429ba4b9d89272d1893 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922788 > Commit-Queue: Aran Gilman <gilmanmh@google.com> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753277} TBR=estark@chromium.org,wychen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1016615, 1065341 Change-Id: Icd8a8e6d3cdc06931e5f4aa083217a07df3c7a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127908 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754619}
-
Abhishek Pandit-Subedi authored
Change the BluetoothKernelSuspendNotifier flag to be enabled by default. Also extend the expiry to 84 (that is when we will remove the flag entirely). BUG=b:149795111 TEST=Built for Hatch, deploy_chrome, checked flag in guest mode is enabled by default. Verify via shell that prepare_for_suspend in /sys/class/bluetooth/hci0 is set to enabled. Change-Id: Ibe064b57ca5db7dcce516f5c41a5b11de7aff2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116592 Auto-Submit: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> Reviewed-by:Sonny Sasaka <sonnysasaka@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#754618}
-
David Van Cleve authored
This is one of a series of CLs updating Trust Tokens key commitment state to use a singleton in-memory store owned by NetworkService and updated via Mojo from the component updater. This involves 1: Remove key commitment-related state from the on-disk trust token store [2, this CL]: Mojoify TrustTokenKeyCommitmentResult and remove commitment fetching and parsing code: - Remove network::TrustTokenKeyCommitment{Parser, Controller, Result} - Clean up the persistent storage schema, removing the proto TrustTokenKeyCommitment (a key with metadata, similar to Result::Key) 3: Add a centralized issuers-to-commitments store in the network service. 4: Add component updater logic to populate this store. Bug: 1063510 Change-Id: Ie64e778c47a1e570087c8a305bf02c88e223f035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117467 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#754617}
-
Alex Turner authored
Currently, GetURL(url::kAboutBlankURL) is called with returns a GURL ending "/ad_tagging/about:blank" instead of just an about:blank GURL. Bug: 1064783 Change-Id: I11d9e26ec8ee32eef924ccfc6d07c218f144d7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119223Reviewed-by:
-
Hongbo Song authored
Bug: 1051042 Change-Id: I4a2cdae3db41bf4da2839d2779f0928573f5675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127519Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#754615}
-
Dale Curtis authored
Prior to this change there exists a window between when GpuMain() hands off log collection and when GpuServiceImpl::InitializeWithHost() starts forwarding to the GpuProcessHost. We have sometimes lost key debugging logs in these cases. Now GpuServiceImpl handles collection of GpuMain() logs all the way up until GpuServiceImpl::InitializeWithHost() takes over, so no logs are lost during startup. Fixed: 1065082 Change-Id: I1d0376ca917218cb6cb6c7298ad59021ba6832ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123329 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#754614}
-
Alexander Cooper authored
WebXrPermissionsApi is still targeting a launch in 83; however given the current state of affairs, this switches it to be launched as a "soft launch" via finch, so that it can easily be disabled if approval to launch is denied at a late stage. Change-Id: I2ada82e5649fcdb9526a07363bb15ddfd2c32b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122608Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#754613}
-
Raymond Toy authored
If the time requested in cancelScheduledValues overlaps the time of a setValueCurveAtTime, then the setValueCurveAtTime is also removed. Bug: 1063502 Change-Id: I6e8bd4bf802cd76f26b46f60905f977ab76d5b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121353Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#754612}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I11704b29a52ad86fab87455addc8489f7b805bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127906Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#754611}
-
Garrett Beaty authored
lint-luci-milo was modified to not require all of the sub-waterfall to appear in the main waterfall console. This change moves the configuration closer to being able to automatically create the main consoles. Change-Id: I28246c591c0c66cb3a8f0710d9226cc9806b9fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124531Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#754610}
-
Mike Frysinger authored
This fixes running under python3 as codec wrapping requires a binary stream, so don't pass it text mode file handles. Bug: 983071 Test: `python3 ./grit.py newgrd x.grd` works Change-Id: I5e3b7d6a0bcf33a176c3ad82ab9a537eaab2cee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125872 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754609}
-
John Abd-El-Malek authored
This allows resumed downloads to be able to show notifications on restart before a DownloadCallback is set. Bug: 1025603 Change-Id: Id4e631c009684eacfc3ed03f19ee98596c182b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126257 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Katie D authored
We don't want users to copy the reader mode URL (which looks like chrome-distiller://<hash>/<params>) when what they see in the omnibox is the original article URL. With this change, the article URL will be copied instead. Bug: 1064095 Change-Id: I48b088843ba427819bf7bcefc83bac0a8631c5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121339 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#754607}
-
haozhe authored
This patch prevent the cancellation of CSS animation if IgonreCSSPlayState is on Change-Id: I0e8333ad6e45bac48703f46a89d0519a994467c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124604 Commit-Queue: Hao Sheng <haozhes@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#754606}
-
Sadrul Habib Chowdhury authored
Take into account whether two scroll sequences have the same 'scrolling thread' before merging them, to ensure a metric reported under ScrollingThread bucket does not mix up short compositor-driven scrolls with main-thread driven scrolls. BUG=1035460 Change-Id: I5be56688c6033630bc464706245a84fac447fc00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127735 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754605}
-
Filip Gorski authored
Always returns Non-Null DeviceConditions, that are most restrictive in case a valid status cannot be determined (BatteryStatus is null). Bug: 1064899 Change-Id: I82d4ce4c63bad892715469501dd2c466cd4ca9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122455 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#754604}
-
Ahmed Mehfooz authored
Bug: 1065079 Change-Id: I599b603472770f7a4be467c836b7ec81fa0a57b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125698Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#754603}
-
Javier Ernesto Flores Robles authored
Implements persistence in ArchivableStore. Writing and loading is done in the working operation queue. Bug: 1045457 Change-Id: Id66a13e419b47aae9e67de3fc74ff43e69bb24f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126288 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#754602}
-
Denis Kuznetsov authored
Change-Id: If48290e9c890fa3e6f5de526c05db5772bce4728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126931 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#754601}
-
Xing Liu authored
This CL updates the Chrome TOS to Google TOS + Chrome additional TOS in 3 UI surfaces: 1. Legal setting page. 2. FRE dialog. 3. Lightweight FRE dialog. Bug: 1064845 Change-Id: Ia1bed6667b6638b269798dd334ec2e73e9d84a1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121467 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Rohit Rao authored
The appconfig.xml spec does not support dictionary-based policies (for example, the ManagedBookmarks policy). As a result, ios_app_config_writer.py was failing when it encountered dictionary types. For now, skip these policies and do not include them in appconfig.xml. BUG=1065539 Change-Id: Ie0d8891d5325f1c60e84cd8fd0af844b38a7c169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127488Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#754599}
-
Javier Ernesto Flores Robles authored
Implements the memory part of the storage. i.e. Add, Update, Remove and init. Bug: 1045457 Change-Id: Id81acc4b7d618481d8914e62ebc1d39c1d20b2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126229 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c4e06b7d750..11f4a84bb1b3 git log 1c4e06b7d750..11f4a84bb1b3 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 johnstiles@google.com Add quotes around paths in bash scripts. Created with: gclient setdep -r src/third_party/depot_tools@11f4a84bb1b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I901ac2339615298a5bcb53cbabb05373d7f7c1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127754Reviewed-by:
-
Dave Tapuska authored
I believe 4ea14eb9 originally fixed the crashing issue. Remove these tests from failing. blank.html still fails because it uses about:blank as a ref test which it appears the harness doesn't support. BUG=1066130,941471,895777 Change-Id: Iff7fd8658cc3366d942409b316e73b79a8aedbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127728 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#754596}
-
Michael Constant authored
DelayNode needs to buffer maxDelayTime worth of sample frames, plus one for interpolation. If maxDelayTime isn't an integer number of frames, we have to round it up -- otherwise the buffer ends up one frame too short, causing the interpolation to wrap around and access the newest input instead of the oldest. Bug: 1065110 Change-Id: Ia47dbd07c3b3b48734c03442a020d76a680eaaa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122852Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#754595}
-
Mikhail Khokhlov authored
BUILD.gn files are read by ninja only if something depends on targets defined in them. So to make targets in perfetto_binary_roller folder visible, we provide a special group with a dependency on a target from it. Bug: 1050517 Change-Id: I99ca73f11c2a00f70eade250ae9dff93d3c9d3af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124378Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#754594}
-
Victor Hugo Vianna Silva authored
If ManagePasswordsUIController gets notified of the deletion of unsynced credentials, it will now store them in ManagePasswordsState. A corresponding method is added to retrieve those credentials, to be used by UI in future CLs. However, in this CL, the notification method is still not called. Bug: 1060132 Change-Id: I08d502af520f0432184087b70aeb81600c3dd99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111159 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#754593}
-
Peter Wen authored
Rather than depending on all accumulated deps, most targets only need the build config and one other public dep. Being more explicit allows us to see how the java targets interact with one another. Clean up _public_deps by removing build config and compile java targets. Bug: 906803 Change-Id: I2fa424689f312dc2c27cc8c1a1da65f7d15b5b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127510 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#754592}
-
Jorge Lucangeli Obes authored
Weekly aggregates for this histogram are still around 500K, which means we're not really close to being able to delete it. BUG=1066027 TEST=pretty_print, validate_format. Change-Id: I57e0f9ec737e45febf43dadd7e7b1aa2e98afa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127548 Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#754591}
-
Martin Kreichgauer authored
This fixes an error in makeCredential handling where the authenticator would use the CTAP2 clientDataHash parameter as the 'challenge' input to the GMSCore FIDO API. Instead, consume the actual challenge and origin from the extension created to work around the mismatched APIs and use those; then send the result clientDataJSON back to the client with the makeCredential CTAP response. Bug: 1002262 Change-Id: Ide65b19c2adfebfd8357b63c7a7e36c1acada50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125607Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#754590}
-
Vladimir Levin authored
This is a small patch that fixes up the wording of the assert and some of the comments in the test. Also adds a spacer to ensure that the test is not flaky under different viewport intersection algorithms. R=aleventhal@chromium.org Change-Id: Id56f91cf286aa46dc6a927b465a6dd7e62431380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127508Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754589}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8df96b104065..012fbeb999c6 Created with: gclient setdep -r src-internal@012fbeb999c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045009,chromium:1065773 Tbr: jbudorick@google.com Change-Id: Ibb6a62d83b3fea9c3055f5e4e6fb892291bf7b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127747Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754588}
-
Nico Weber authored
This reverts commit 0f71cedd. Reason for revert: .runtime_deps currently aren't always in the root build dir, see https://chromium-review.googlesource.com/c/chromium/tools/build/+/2127067/1#message-9a3c93e50651dc80dfbfefb762db5841ef159b13 (Also, https://crbug.com/1065750) Original change's description: > compare_build_artifacts.py use *.runtime_deps > > *.isolate file is deprecated. > use *.runtime_deps file, generated by gn, instead. > > Bug: 972075 > Change-Id: I5bc47cbe058c1550fdca4d1d89928c3daf4bc0e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061575 > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745827} TBR=maruel@chromium.org,thakis@chromium.org,ukai@chromium.org,tikuta@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1065750,972075 Change-Id: I49426f0a40d013f6ffacc9524120b1b58db2f03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128186 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#754587}
-
