- 27 May, 2020 40 commits
-
-
Raphael Kubo da Costa authored
The only remaining code there was a call to RunLoop::RunUntilIdle() that had been present since this file was added to the tree. Whatever it was waiting for seems to have been fixed since then though, as removing the call still allows all tests to pass, and we get no subsequent crashes. Change-Id: Ie1141f7870d89ed4f1ea89015e4ce2b4b67acc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216223 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#772295}
-
Yi Xu authored
Since Math.random() in python generates a random number in range [0,1), we need to use rand(256) to generate number [0, 255]. Update all calls in canvas perftest to call rand(256). Bug:1087019 Change-Id: I75ded3269cf652d7d352e32eefbfeddb999583b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216736 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#772294}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8ae7f6e09a0b..0b9eddaa2663 2020-05-27 saklein@chromium.org Build API: execute with --debug by default 2020-05-27 dianders@chromium.org remote_access: Fix crash with 'cros flash' if port not specified 2020-05-27 mmortensen@google.com GetBuildMetadata: Port get_models & run_cros_config_host from cbuildbot. 2020-05-26 dhanyaganesh@chromium.org config: Refactor some configs 2020-05-26 saklein@chromium.org cros flash-ap: Fix ssh flash with non-22 port. 2020-05-26 mikenichols@chromium.org chromeos-config: Remove eve-lacros custom configuration 2020-05-26 bpastene@chromium.org cros_chrome_sdk: Create build dirs when using --no-shell. 2020-05-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-26 navil@google.com chromeos_config: Disable release-basic builder. 2020-05-26 navil@google.com chromeos_config: fix fail fast builder gs_path 2020-05-26 morg@google.com Remove (atlas|kukui) boards from vmpi PFQ 2020-05-26 judyhsiao@google.com usergroup_baseline: Add sound_card_init to audio and cras group 2020-05-26 niwa@google.com Remove unused targets (x86 and arm) from ANDROID_VMRVC_BUILD_TARGETS 2020-05-26 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-26 stimim@google.com workspace_stages: remove duplicated android packages 2020-05-25 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-23 vapier@chromium.org cros lint: allow "#!/usr/bin/env python" shebangs 2020-05-23 kerker@google.com image_test: add /usr/lib/node_modules/ to the whitelist 2020-05-22 levinale@chromium.org Add zwisler to the OWNERS.kernel file 2020-05-22 achuith@chromium.org vm: Increase connect timeout for non-KVM. 2020-05-22 manojgupta@google.com chromeos_config: asan: Disable rootfs verification 2020-05-22 bpastene@chromium.org auto_updater: Fix args to RemoteDevice.run() when cmd is a string. 2020-05-22 dianders@chromium.org remote_access: Don't force the port to 22 if unspecified 2020-05-22 malaykeshav@chromium.org Revert "deploy_chrome: Warn before deploying to device with mismatched board" 2020-05-22 levinale@chromium.org Add a per-file permission for kernel Owners file 2020-05-22 vapier@chromium.org OWNERS.chrome: set COMPONENT 2020-05-22 chrome-bot@chromium.org Update config settings by config-updater. 2020-05-22 navil@google.com chromeos_config: Add child builds for fail fast builder. 2020-05-22 navil@google.com chromeos_config: Create template for the fail fast release builder. 2020-05-22 richardfung@google.com Remove android-container-qt targets 2020-05-21 vapier@chromium.org OWNERS: update build settings 2020-05-21 dhaddock@chromium.org paygen_build_lib_unittest: Fix au_e2e control file. 2020-05-21 levinale@chromium.org Chromite: add owners file for the kernel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: 1086560 Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I14a8966aac606a9bb5098c16d350fc8ad36ecf7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772293}
-
Avi Drissman authored
For data gathering re SxS, apparently it's possible for Spotlight to return a search query result for which there is no path. Defend against this. Bug: 1086555, 1061486 Change-Id: I972c6cda16d5c0801673addefd064cdfbc810904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218549 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#772292}
-
Elly Fong-Jones authored
Bug: None Change-Id: Ifcca583ad1f475d78e600584904efdcd4bdac739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218449 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772291}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d81fad6de554..212c527f90e9 2020-05-27 jacktfranklin@chromium.org Upgrade to TypeScript 3.9.3 2020-05-27 tvanderlippe@chromium.org Typecheck browser_sdk/LogManager.js with TypeScript 2020-05-27 jacktfranklin@chromium.org Sort expected files in search results e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iacf63754c8a96505e71c76ae2638396693c562b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218433Reviewed-by:
-
Jan Scheffler authored
Bug: chromium:1011811, chromium:1079233 Change-Id: I9abc4d504fb61809b9dc93d0370c613da3a20fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218051 Auto-Submit: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#772289}
-
Yann Dago authored
Bug: 1072823 Change-Id: I15a96f9568aa98a55e96413652b1e7c5a8a23a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105613 Auto-Submit: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#772288}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=petewil@chromium.org Bug: 1026641 Change-Id: Id676174f093ce32d2cc691ca2deb8415f0b95c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217203 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#772287}
-
Mohamed Heikal authored
monochrome_apk_checker.py gets called from bots and sometimes extra arguments are passed in that are not relevant for this script. This cl just changes the parser behaviour to ignore unknown arguments. Bug: 1084351 Change-Id: I9b574bd6ae8f16e3c097baa7b50811557a2e773b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209115Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#772286}
-
Moe Ahmadi authored
The crash in crbug/1086749 is likely due to the page method calls being handled after destruction of |autocomplete_controller_|. mojo::Receiver guarantees that page method calls will NEVER run beyond the lifetime of the receiver object. Moving the Receiver (as well as the Remote) member variable toward the end of the list of member variables should fix this crash as the receiver object gets destroyed first. Bug: 1086749 Change-Id: I42d1229416e5909c4f3b9bd187a4db2da88b7d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217211 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772285}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590580498-ea3616ac9902235828b373566b290618f1842868.profdata to chrome-mac-master-1590594916-60e361b5828c3c2c59992f70098f83fe3dce39a9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ide13c8a6156086f94e0f1d5d2b69e9ae89db08a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218647Reviewed-by:
-
Stephan Hartmann authored
The decltype(<func>) passed as template parameter to CBBFunctionToVector does not return a function pointer and GCC complains like this: ../../device/fido/virtual_fido_device.cc:104:68: error: 'int(struct cbb_st*, const struct evp_pkey_st*)' is not a valid type for a template non-type parameter 104 | EVP_marshal_private_key>(pkey_.get()); | ^ Fix this by passing decltype(&<func>). Bug: 819294 Change-Id: I8114c3d75c9865779d58c0b6a6c48e6affd3175b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217414Reviewed-by:Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#772283}
-
Peng Huang authored
This is a reland of de6734f7 Original change's description: > vma_wrapper: create VmaAllocator for vulkan 1.1.0 > > For vulkan 1.1.0, VmaAllocator will use dedicated memory > allocation for some big vulkan memory request, and free > it when the allocation is released. Without this change, > the VmaAllocator will allocate memory from self managed > memory blocks for all vulkan memory request. And the > memory may not be released when the allocation is > released. VmaAllocator may keep the memory for later > usage. It could be the reason for the memory regression > in fuchsia. > > Bug: fuchsia:52463 > Change-Id: I7b905435d31b927b2344724f8a2e1738e0544410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215414 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Auto-Submit: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771927} Bug: fuchsia:52463 Change-Id: I4da1f291a574f72ad16811ffafffb3be36392af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218247 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#772282}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=mek@chromium.org Bug: 1026641 Change-Id: I3c723c41dc313d8eaa664260c7569a7bde398076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216737 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#772281}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4a81e3dba0fd..ca092f016532 2020-05-27 gbiv@chromium.org translator: explicitly specify underlying types for enums If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084580 Tbr: ynovikov@google.com Change-Id: I1d19ff3d8252d3f77950217be58b85a870cc4ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218432Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=pkasting@chromium.org Bug: 1026641 Change-Id: Id38d941acd0e77333cdcef9c34a3eb509650755c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215917 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#772279}
-
Raphael Kubo da Costa authored
There is no need to pass a std::unique_ptr to PlatformSensorProviderLinux and also hold the raw pointer in PlatformSensorAndProviderLinuxTest. Instead, just pass the std::unique_ptr and access it directly, as the test class is already a friend of PlatformSensorProviderLinux. R=reillyg Change-Id: I41624ccedb9dfd886f047d0ad9550c877966af3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218047 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Gabriel Charette authored
[base] Make PostTask destination explicit in /content/public/test/browser_task_environment_unittest.cc Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1026641 Change-Id: I87ec188abf4b2e6a359d69409a74bbf90674197c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215918 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772277}
-
Kurt Horimoto authored
When an OverlayPresentationContext's capabilities are updated, OverlayPresenter will hide the currently-presented overlay UI if the new capabilities are insufficient to present it. However, the previous implementation mistakenly checked against GetActiveRequest() rather than |presented_request_| to handle this logic. GetActiveRequest() returns the front request of the active WebState's queue, which is often, but not always the presented request when |presenting_| is true. |presented_request_| is more accurate, as there are two points in time where it differs from GetActiveRequest(): - When presented overlay UI is being dismissed due to request cancellation. At this point, the request will have already been removed from the active WebState's queue. - When presented overlay UI is being dismissed due to a change in the active WebState. The request still belongs to the previously- active WebState, so will not be returned by GetActiveRequest(). Bug: 1065564 Change-Id: I4c7eec8ba28311f520cff482d316bb4ac8e24a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212520Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772276}
-
Raphael Kubo da Costa authored
Its only call site was the function right above it. Merge them together for simplicity. While here, use base::MakeRefCounted<> rather than creating a scoped_refptr<> and passing it to base::Callback::Run(). Change-Id: Id1ccce0493dfdcaccb3689d07b661e0267e2ba46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218068 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
This method was never implemented and is not called anywhere. It is better to readd it if we ever really have a use for it. Change-Id: I1c9b379e3dbe867e91f06f0170dce3abe04b8c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218087 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=sky@chromium.org Bug: 1026641 Change-Id: I54a1ce913a2b19504b20494a930810d1a50f9139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215919 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=hansberry@chromium.org Bug: 1026641 Change-Id: If8c3e0326a77e5ffca7f6e885cbda1bd37c0b3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216735 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#772272}
-
Andrey Kosyakov authored
... by making sure the iframe under test is in-process (there's no point for testing for OOPIF, since JS context isolation is provided naturally there). Bug: 608015 Change-Id: I81382e9e0c8943c67c0226582c90f57a3964dd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216640Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#772271}
-
Nate Chapin authored
Bug: 1083485 Test: fast/frames/document-addressSpace-in-initial-document-after-navigation.html Change-Id: I08229cb5143e3a348d0897d4ad186978a858b7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215443Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#772270}
-
Hitoshi Yoshida authored
This CL introduces following methods for dictionary members whose type is nullabe. These methods are migration adapters, and will be removed after IDL compiler migraiton. - fooNonNull(): Returns a non-null type value for a member |foo|. It crashes if foo() is missing or has a null value. - hasFooNonNull(): Returns true iff |foo| has a non-null value. In practice, however, they are aliases of foo() and hasFoo() in the running IDL compiler. We are changing behaviors of foo() and hasFoo() precisely in the new compiler, and expect these new methods work as migration adapters. Bug: 839389 Change-Id: If19479779ea3d19b498e23a5001aabd38366a2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215648 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#772269}
-
chrome://policyJérôme Gingras authored
Bug: 1020213 Change-Id: Ib637c351af63496ba9b7bb538b0df0639fd18f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212630 Commit-Queue: Jerome Gingras <jgingras@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit 41989bd8 ("Remove/replace unnecessary logging.h includes in .cc files (cc)"). Bug: 957519 Change-Id: I1e782e8310ca548947b2d541af6a2159d928d1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218090Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#772267}
-
Dominic Farolino authored
R=hiroshige@chromium.org, kouhei@chromium.org Bug: 1086507 Change-Id: I4cc1401de2c642d24aab0f4bd6efd94eda18fe65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213820 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#772266}
-
Chris Hamilton authored
Follow-up CLs will add this to the graph display, and then individually wire up the types of opener relationships. BUG=1085129 Change-Id: If25406e0bc15fd6c6cbeeb62cc0db0c438fe9ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215281 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772265}
-
Jan Wilken Dörrie authored
TBR=bokan Bug: 777258 Change-Id: Iabe5d80b83db19610a4b1c775c802e41a9c8c66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218112Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772264}
-
James Cook authored
ExternalPrefLoaderTest.PrefReadInitiatesCorrectly is only relevant pre-SplitSettingsSync, so disable the feature for that test. ExternalProviderImplChromeOSTest.PriorityCompleted needs to be updated to mark OOBE completed and simulate the correct type of priority pref sync. This is in preparation to enable SplitSettingsSync by default. See failing tests in tryjobs from: https://chromium-review.googlesource.com/c/chromium/src/+/2210623 Bug: 1060289 Change-Id: I3a3807c304334fa5a22df7e102f85ee1c629c312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215249Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#772263}
-
Gabriel Charette authored
Task APIs v3 will all have an explicit destination. In the past "default traits" meant ThreadPool. These CLs are thus a no-op except for the few callers that clearly wanted to post a QuitClosure() on the current thread (posting a QuitClosure() to a parallel task will merely bounce it back to the current thread anyways). Those few callers were migrated to ThreadTaskRunnerHandle::Get(). These changes are thus required to phase out task APIs v2 (post_task.h) Design doc: https://docs.google.com/document/d/1tssusPykvx3g0gvbvU4HxGyn3MjJlIylnsH13-Tv6s4/edit This specific change is a subset of https://chromium-review.googlesource.com/c/chromium/src/+/2216733 This CL was uploaded by git cl split. R=dcastagna@chromium.org Bug: 1026641 Change-Id: Ib464bb9af983f16e6561e54e9a40b3352ab33a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217209 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#772262}
-
Dave Tapuska authored
Move RenderWidgetInputHandler into blink and call it from the WidgetBase. Some intermediate methods have been added to WebWidgetClient while the WidgetInputHandlerManager and MainThreadEventQueue are still on the content side. These APIs will eventually disappear when those classes are moved beside the WidgetBaseInputHandler. BUG=1073560 Change-Id: I06a202fb832c1d8655428ae1dff19178a2ba69be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212805Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#772261}
-
Owen Min authored
All future policies will be ignored by default unless it's whitelisted by EnabledExperimentalPolicies. Bug: 1076560 Change-Id: I17cd79bd3d7e501f70eb326348d9b64d37c58bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211091 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
-
Bo Liu authored
This is a reland of 9d2c67b2 Landed changes to relax LifetimeAssert when DestroyActivitiesRule fails. See bug for details. Original change's description: > android: Add LifetimeAssert to WindowAndroid > > Bug: 1081250 > Change-Id: Id0924545fbdb1eb28ae3c8fe015559fd3e9c53d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191785 > Commit-Queue: Bo <boliu@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771220} Bug: 1081250 Change-Id: Iea2dd27c5b114d748c6f0de8edf17c68b3ec98de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216798Reviewed-by:
-
Thomas Lukaszewicz authored
Moved the Accelerator initalizers for TabbedPane into the constructor. This enables TabbedPane to be reparented without redundantly adding accelerators. Bug: 1083822 Change-Id: Iaa6483c6c6484a21c9ad17fa5b3948ca5118d94a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208590 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#772258}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1303a1a15c88..55822f17bd5c 2020-05-27 egdaniel@google.com Add submittedProc to GrFlushInfo. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ic05cc310246fe12a1898d12e8c4ec3cf9c575b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218328Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d0a8b04f..9990e869 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0b3bacad1f51306689668a298b9e80cb29668bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218367Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772256}
-
