GitLab

These metrics will record the number of occluded/visible/hidden native Chrome windows on Windows. This information will be polled and computed on a repeating timer. This information will be used to determine if occlusion tracking on Windows is worth pursuing going forward.

This is a reland from reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1032858 (revert), https://chromium-review.googlesource.com/c/chromium/src/+/1025074 (original)

The fix is the diff after patchset 1.

Bug: 813093
Change-Id: I30635c4b978a210e496cc43e52470f3b3b9f03d3
Reviewed-on: https://chromium-review.googlesource.com/1033272Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Varun Mohan <varunmohan@google.com>
Cr-Commit-Position: refs/heads/master@{#554495}

* This is accomplished by adding a PageViewTimer class, which uses
  a TabObserver and a TabModelObserver to measure time spent viewing
  pages

Bug: 824186
Change-Id: I14fc98112d254f44be969307a5c9b74f7969f93a
Reviewed-on: https://chromium-review.googlesource.com/1023054
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554494}

To simplify naming, update the parameters for SetGeometry(). Once all
call sites are updated, remove SetGeometryGfx().

Bug: None
Test: Compiled
Change-Id: I6ec82851883271732c029586017ddf8394a85295
Reviewed-on: https://chromium-review.googlesource.com/1024190Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554493}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bdb814e9..df1d991f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I01a7d36286623ffcafa44cba0490dd286f7fb97f
Reviewed-on: https://chromium-review.googlesource.com/1032753Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554492}

It looks quite bad. This was an unintended regression from the fixed-width
look. Adding a test for this regression is unfortunately difficult - mocking
out the MenuController used by a single MenuItemView is complex to do.

Bug: 837158
Change-Id: Ie2e094a69c1d25bbcf8b53cfd66da4dec51e0f1b
Reviewed-on: https://chromium-review.googlesource.com/1030038
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554491}

These APIs are not being used.

Bug: None
Change-Id: Iae36aba550cb117baaa1b8cce677f63c5a652178
Reviewed-on: https://chromium-review.googlesource.com/1032761Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554490}

This setup needs to be done earlyish in the browser's lifetime so that
the error badging can be shown and so that the global error bubble can
appear.

This fixes GlobalErrorBubbleTest.InvokeUi_RecoveryInstallGlobalError.

Bug: 834754
Change-Id: I2b61beb1123436fd15c36d265d1eabbf6d9ded2f
Reviewed-on: https://chromium-review.googlesource.com/1033437Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554489}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia6ed918de4495d0938c6400413aee6d8683ce18a
Reviewed-on: https://chromium-review.googlesource.com/949822
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554488}

On Thinkpad X1 with libinput or synaptics driver, touchpad scroll
event report as ScrollClassEvent not ScrollEvent. For touchpad
report with high precision scroll deltas, we add a event source
check when receive ScrollClassEvent.

Bug: 599497
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4c6b5d763275caa98c56f86ec0de0c5aeed9dca2
Reviewed-on: https://chromium-review.googlesource.com/988748
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554487}

Moved flex-direction adjustment from layout method to a computed style
custom hook.

We temporarily switched between rtl and ltr for each layout requiring
the ComputedStyle to be mutable. The test that failed before adding
this hack no longer fails without it, so removing.

TEST=fast/forms/range/input-appearance-range-rtl.html

Bug: 813068
Change-Id: I698859f10fba32aa02f8b5b61d07bd24557667b1
Reviewed-on: https://chromium-review.googlesource.com/1032553
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554486}

These entries were requested for removal via email and have been
validated via DNS.

Change-Id: I9799002be81d11f55ecb775d04e887457e5b3c3b
Reviewed-on: https://chromium-review.googlesource.com/1033474Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554485}

Previously we wouldn't notice that the keyframes had changed until the
next animation update. This CL fixes that by clearing any cached sampled
effects and notifying the owning Animation that it needs to invalidate
it's information.

This also fixes updating composited animations; invalidating the effect
on the animation causes us to properly restart the composited animation.

Bug: 799061, 835824
Change-Id: Ib307a5409c52c5dab1ee0f98c989d7dbaef42937
Reviewed-on: https://chromium-review.googlesource.com/1026700
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554484}

Add retries while making connection to DevTools.

Bug: 826150
Change-Id: I43b708eabdf2202ed14b41cd43677f814b02079d
Reviewed-on: https://chromium-review.googlesource.com/1026153Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554483}

This flag enables a set of features which are intended to help improve
web developer productivity, by restricting the use of web-platform
features which are commonly problematic, as well as adding new high-
level APIs for common development patterns.

This currently just enables three opt-in policy-controlled features:
 - sync-script
 - unsized-media
 - vertical-scroll

Other policy-controlled features and LAPIs are expected to be added to
this set in the future.

Bug: 837344
Change-Id: Id7f89cbe2cc6fdc92278a42ea033e0fef0baabcb
Reviewed-on: https://chromium-review.googlesource.com/1030906Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554482}

This CL moves toggles that needs to be shared into its own element,
<personalization-options>, and changes their label and sub-label when
unified-consent is turned on.

screenshots: https://imgur.com/a/D7wMnx1

Bug: 800973
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6284b5166381b74a146d1c7cbaafd5e790a3bc89
Reviewed-on: https://chromium-review.googlesource.com/1022716
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554481}

Here's the abbreviated recursion call stack:

FrameLoader::DidFinishNavigation
 FrameLoader::RestoreScrollPositionAndViewState
  Document::UpdateStyleAndLayout
   ...
    LayoutView::UpdateAfterLayout
     WebViewImpl::ResizeAfterLayout
      ...
       LocalFrameView::SetFrameRect
        FrameLoader::RestoreScrollPositionAndViewState

This is clearly a bad thing to do, but the actual symptom is a CHECK
failure, because the inner call to RestoreScrollPositionAndViewState
will call Document::UpdateStyleAndLayout, which will advance the
document lifecycle to kLayoutClean.  That's bad because there's still
an outer invocation of UpdateStyleAndLayout that expects the
lifecycle not to change from kInPerformLayout.

BUG=837524
R=bokan@chromium.org

Change-Id: I9a4bfe0b71ce8cef383673776f6d81a47b5d4b2d
Reviewed-on: https://chromium-review.googlesource.com/1033481Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554480}

Bug: 730693
Change-Id: Ia754b382d9c4626b24ecab368d25b3c6331230be
Reviewed-on: https://chromium-review.googlesource.com/1024434
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554479}

We currently expose a couple of alpha-scaling helpers:

 - ClampedAlphaForBlending: float_alpha[0..1] -> int_alpha[0..256]
 - ScaleAlpha: SkColor * int_alpha[0..256] -> SkColor
 - ScaleAlpha: SkColor * float_alpha[0..1] -> SkColor

Some problems:

 1) ClampedAlphaForBlending is prone to int overflows
 2) several clients take the [0..256] alpha and shoehorn it into a paint
    by clamping to 255; this is imprecise because the original [0..1]
    domain is still scaled to [0..256] instead of [0..255]
 3) in general, there is no reason to go through an intermediate/premature
    int quantization

This CL removes ClampedAlphaForBlending and the int-flavored ScaleAlpha
helper, and updates all clients to use the float ScaleAlpha version.  It
also refactors the implementation to clamp in float, before int conversion.

Bug: 836664
Test: svg/custom/opacity-overflow.svg

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2f27c7f606a6bc428dcd90543f583a9f207a58f1
Reviewed-on: https://chromium-review.googlesource.com/1028451Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554478}

Isolated worlds (like extensions) are designed to be able to bypass a
page's specified CSP. However, when executing an asynchronous scheduled
action (such as one initiated through setTimeout()), the actions were
not allowed to execute. This is because ScheduledAction::Execute()
checked Document::CanExecuteScripts(), which checked if the document
was sandboxed and didn't check if it should bypass the CSP.

Fix this by having the document check if it should bypass the CSP, and,
if it should, allow the script execution.

Add unittests for Document::CanExecuteScripts() as well as an end-to-end
test for an extension with a content script and setTimeout().

Bug: 811528
Change-Id: I7f6497784845a7d05d60048c84b24db9b903eae9
Reviewed-on: https://chromium-review.googlesource.com/1030952
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554477}

This is roughly similar to patricialor@'s work in
https://codereview.chromium.org/2010493005/

Per offline conversation,this wasn't submitted
at the time due to some related bugs that are now fixed.

This works well in ChromeVox AFAICT. In VoiceOver,
testing on permission.site, pointer lock works well,
but fullscreen's announcement can sometimes be cut
off by VoiceOver returning to read the rest of the
page. Waiting until the animation is complete helps
a little but doesn't fully fix it, but I'm not sure
what else we could do.

Bug: 610583, 577011
Change-Id: Ic1ef5ba8f81d432eb1f64335be3f6bb6e4ff31f1
Reviewed-on: https://chromium-review.googlesource.com/1015554
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554476}

Bug: 836908
Change-Id: Idb2422e16651df75fe2dac30d0d4bc65410e67aa
Reviewed-on: https://chromium-review.googlesource.com/1031560Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554475}

It's possible that when setting the opacity of the black scrim, the opacity is
a very small negative value. Set it to zero in this case.

Bug: 835900
Change-Id: Ia3b082e86cb5cca25987023a9a6f46625865b335
Reviewed-on: https://chromium-review.googlesource.com/1024243Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554474}

There are two main bug fixes:
1) make sure the poll time gets properly sent through the cycle snapshot so that
   it can be persisted.
2) On startup, if the poll interval expired in the past, schedule a poll soon.
   Without that, it's highly unlikely we ever do polls on platforms like Android
   where apps can get killed anytime. Plus, as notifications are less reliable
   there, polls are actually more relevant.

The feature to potentially poll on start-up is guarded behind a feature flag,
which allows rolling back to the current behavior.

Bug: 832019
Change-Id: If625704eace7a89a48d057c27d61abb8b10d1bb1
Reviewed-on: https://chromium-review.googlesource.com/1030177Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554473}

As per crbug.com/788024 Comment 1 (see mocks):
- Fix error box style
- Dialog width = 448
- Input box width = 200, left aligned
- Additionally: add SPACE between "Invalid PIN" & "Attempts left"

Harmonious nature of the pin-requestin' dialog.

Bug: 788024
Test: Get yourself into some kinda pin-needin' situation and confirm the
Change-Id: Ie573c8a79fdb2001a3c2b66adc4b80a4b09dd723
Reviewed-on: https://chromium-review.googlesource.com/1013412
Commit-Queue: Greg Levin <glevin@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554472}

This reverts commit ce130512.

Reason for revert: broke compilation: https://ci.chromium.org/buildbot/chromium/Win/66613

Original change's description:
> Add ruleset_converter tool to subresource_filter
> 
> This CL also
> - Aggregates all subresource_filter tools into a single target
> - changes subresource_filter tools to use the same (but equiv)
>   condition as some other tools
> - Adds that target to "all"
> 
> Bug: 833419
> Change-Id: I732ac0860f90e036281bdf899f8b5e6e92f3f3e5
> Reviewed-on: https://chromium-review.googlesource.com/1031211
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554455}

TBR=sky@chromium.org,jkarlin@chromium.org,csharrison@chromium.org

Change-Id: I03e004c156e40d695c866ba07a00c480eedcd225
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 833419
Reviewed-on: https://chromium-review.googlesource.com/1033399Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554471}

Bug: 736457
Change-Id: I818c4d048145ae77bfd5c0244cde67886c30f8be
Reviewed-on: https://chromium-review.googlesource.com/1031786Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554470}

Monochrome.apk_Dex
        +2 entries fields
        +5 entries methods
        +1 entries types
        +1 entries strings
Monochrome.apk_Breakdown (+1,897 bytes)
      +145 bytes Zip Overhead
      +251 bytes Non-compiled Android resources size
       +17 bytes Package metadata size
       -20 bytes Java code size
    +1,504 bytes Compiled Android resources size
Monochrome.apk_Specifics
    +2,289 bytes normalized apk size
        +1 zip entries file count
      +392 bytes main dex size

Change-Id: Ia465e1ee3a2b9c411feb4265ab18ef05d3674d7f
Reviewed-on: https://chromium-review.googlesource.com/1033453Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554469}

This change adds a global toggle for the WebUSB "guard" permission to
the site settings preferences on Android. Toggling this setting to
"block" will disregard existing USB device permissions and prevent any
site from requesting access to a USB device by displaying the device
chooser dialog.

To simplify the addition of this global toggle UsbChooserPreferences
has been merged into SingleCategoryPreferences and the entire USB
device permission framework has been refactored to manage the same kind
of opaque "objects" as is done in the desktop UI and underlying
storage infrastructure.

Screenshots of this new UI are included in the design doc:
https://goo.gl/uMPMZZ

Bug: 771703
Change-Id: I6ab766ddd1e00e8663d3b6658d872ef8ad8e95ea
Reviewed-on: https://chromium-review.googlesource.com/1006157Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554468}

Following https://chromium-review.googlesource.com/c/chromium/src/+/1020288

TBR=nick@chromium.org (trivial rename in comment in
content/public/test/frame_load_waiter.h)

Bug: 825327
Change-Id: I5ef7bc522a74fd9c783183ce2baca87ea3fc3291
Reviewed-on: https://chromium-review.googlesource.com/1020804Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554467}

Since there's only one device attached to this bot, set a 3 hour long expiration
time.

Bug: 837727
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia0f112f1620e6dd61c121c06a84f7e00062be2ba
Reviewed-on: https://chromium-review.googlesource.com/1033434Reviewed-by: Shenghua Zhang <shenghuazhang@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554466}

This abstraction is an implementation detail of PinBackend. Further, the
existing API needs to be async, since determining if cryptohome is supported
requires a DBUS call to cryptohome. An alterative design is maintaining a
per-board list if cryptohome is supported, but that imposes a significantly
greater maintance burden.

Bug: 826773
Change-Id: Ib0ef30b4303302b9a8f3f2bf3deabd100d888e56
Reviewed-on: https://chromium-review.googlesource.com/999125
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554465}

https://pdfium.googlesource.com/pdfium.git/+log/575f238334d1..3241bb3e98c0

$ git log 575f23833..3241bb3e9 --date=short --no-merges --format='%ad %ae %s'
2018-04-27 thestig Fix style for many jbig2 methods.
2018-04-27 thestig Add CJBig2_Image::IsValidImageSize() helper method.
2018-04-27 thestig Sanitize another image size in CJBig2_Context::parseHalftoneRegion().
2018-04-27 rharrison Updated libtiff 4.0.8->4.0.9
2018-04-27 thestig Sanitize the SBNUMINSTANCES value in the JBIG2 decoder.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:836872,chromium:837192


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I836d14f6bf7661851deff78a72360d0031648d18
Reviewed-on: https://chromium-review.googlesource.com/1033337
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#554464}

This CL adds an instance of MultiDeviceNotificationPresenter to
ash::Shell; additionally, when the user logs in,
MultiDeviceNotificationPresenter now initiates a connection to the
MultiDeviceSetup service and starts observing it.

Bug: 824568
Change-Id: Ie0c77b3ae4ba4e52ccab3b8034e8473ed71e1a67
Reviewed-on: https://chromium-review.googlesource.com/1022470
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554463}

In preparation for a big refactoring of our logic that computes character and object bounds.

Important changes:
1. Wrote additional tests for scrollable editables and strengthened test for scrollable containers.
2. Tests that the height is the same across lines.

More cosmetic changes:
3. Replaced all-caps constants with newer style guide constants that start with "k".
4. Used raw litteral strings (a C++ 11) feature that allows the use of quotes in HTML code without escaping or the need to remember to use single quotes.
5. Split SetUp methods into more helper functions.
6. Introduced SetUp method for creating scrollable input field and added a test for it.
7. Stopped using net::EscapeQueryParamString because it was not appropriate for escaping HTML code.
R=aleventhal@chromium.org, dmazzoni@chromium.org

Change-Id: I7d9387323ae35a353dc62096c151355897f925eb
Reviewed-on: https://chromium-review.googlesource.com/1030842
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554462}

This patch changes DocumentThreadableLoader not to handle
CORS-preflight, but to delegate it to CORSURLLoader.

Originally preflight errors and usual CORS errors shared a common
error code set, and append extra error strings for preflight
errors, based on the context that DocumentThreadableLoader knows.
After this change, we define different error code for each case
so that DocumentThreadableLoader can create right error strings
without error contexts that only CORSURLLoader knows.

CORSURLLoader is also modified to set the HTTP Origin header
when it is needed, and now use PreflightController to perform
required preflight checks.

PreflightController is modified to use WrappedLegacyURLLoaderFactory.
This is unfortunate, but to make it work with legacy URLLoaderFactory
that relies on ResourceDispatcherHost that needs the legacy request_id.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ibf82243ecf14be84bb11122f733c4cb9030d41b8
Bug: 803766
Tbr: kinuko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/997914
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554461}

- Add MockLibraryCdm, a mock implementation of library CDM interface so
  that we can have more control in the test cases.
- Refactor CdmAdapter so that CreateCdmFunc is passed in constructor
- Refactor CdmAdapterTest so that it can take different CreateCdmFuncs
 * CdmAdapterTestWithClearKeyCdm uses Clear Key CDM and uses the
   CreateCdmFunc provided by CdmModule.
 * CdmAdapterTestWithMockCdm uses CreateMockCdmInstance to use
   MockLibraryCdm for testing.
- Add tests for ChallengePlatform, CreateFileIO and RequestStorageId
  using CdmAdapterTestWithMockCdm.

Bug: 836046
Test: Test class refactoring; added more tests.
Change-Id: If79922b26b57793f8e75f86e583109b0495fda58
Reviewed-on: https://chromium-review.googlesource.com/1027003
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554460}

This is necessary because these flags need to be accessed from within
//ash and //chromeos, which do not have access to chrome_features.h
since it resides in //chrome.

Bug: 824568, 752273
Change-Id: I2d20f244bc88758825dd37edf5b9956336017563
Reviewed-on: https://chromium-review.googlesource.com/1029228
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554459}

The visitor passed for tracing should not be const as tracing actually
modifies visitor-internal state.

The tracing methods themselves and their parameters should remain const.

The CL changes
  virtual void TraceWrappers(const ScriptWrappableVisitor*) const;
to
  virtual void TraceWrappers(ScriptWrappableVisitor*) const;

Bug: v8:7570
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib0132069baac8609a347ebb9c48aa6eda490ffa7
Reviewed-on: https://chromium-review.googlesource.com/1032558
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554458}

TBR=danakj@chromium.org

Bug: 837515
Change-Id: I315d5b9b2add8fd2c06a1c032bf20e4f3c950f85
Reviewed-on: https://chromium-review.googlesource.com/1032872Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554457}

1. Change constant variable naming style, e.g. VP9 -> Vp9. According to
the style guide [1]: "when abbreviations appear in such (Camel Case)
names, prefer to capitalize the abbreviations as single words (i.e.
StartRpc(), not StartRPC())".
2. Update TestMp4EncryptionPlayback() to take a |media_type|, in
preparation for adding other MP4 tests, e.g. FLAC.
3. Some misc changes.

[1] https://google.github.io/styleguide/cppguide.html#Variable_Names

Bug: 327115
Test: No functionality change.
Change-Id: Iab1243ad05f85d2aa845838cd1ab30606245cbf3
Reviewed-on: https://chromium-review.googlesource.com/1031557Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554456}