- 25 Jun, 2019 40 commits
-
-
Anna Mace authored
Implement GetSetSize, GetPosInSet, IsOrderedSet and IsOrderedSetItem overrides for ViewAXPlatformNodeDelegate. These functions currently use the empty base implementation (i.e. return false, 0) so screen readers will not get information about sets for View elements, e.g. groups of radio buttons. With this change, screenreaders using UIA will read 'n of m' for items within a set. The Views-specific implementation for these functions considers two things when calculating set size and pos in set: -If AXNodeData has the attribute kPosInSet or kSetSize, it will return that value first. -If not, it will see if this View is contained in a group (View::GetGroup()). If so, it will count how many nearby Views are in that same group. If the View has a parent, it will start from the parent and include all ancestors of the parent. That way, sibling elements within the same group are included in the count. When calculating position in set, it will return the index of that View in the resulting vector of Views. Views::SetGroup is only used in a few places in the codebase. I have based the implementation off those uses so they are all supported. I general it seems Views that share group ids are siblings, and sometimes also their parent. 1. Radio buttons are constructed with a group_id passed in. Typically, it seems RadioButtons are siblings. 2. Groups of buttons in dialogs (e.g. "Bookmark added" dialog "More", "Done" and "Remove" buttons) may be in groups. See DialogClientView::UpdateDialogButton button->SetGroup(kButtonGroup) 3. ParentAccessView::AccessCodeInput contains multiple AccessibleInputFields. These are all in the same group, including the parent AccessCodeInput. SetGroup(kParentAccessInputGroup); .. field->SetGroup(kParentAccessInputGroup); 4. DesktopMediaListView contains many child DesktopMediaSourceViews, which are all in the same group source_view->SetGroup(kDesktopMediaSourceViewGroupId); Based on that, I think it is reasonable to only count the parent and sibling Views (and their ancestors) in calculating the number of Views in a group. Change-Id: I0fb72ced30b1c8220cd076d92ecb279802d4b36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669329 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#672076}
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 481431, 978371 Change-Id: If5355445e48d3b022b9194b1efc0c8a423d55076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675361Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#672075}
-
Zentaro Kavanagh authored
- Some conditions are evaluated when the page first loads before displays have been fetched resulting in displays being undefined - Some of these cases were previously fixed, but this one was missed because it tries to get a property from displays when the unified desktop flag is enabled. - The result is that the display page in device settings never renders in unified desktop mode. - Add tests for all functions called before displays are populated - Add missing tests for unified desktop BUG=chromium:948888 TEST=manual Change-Id: I6beae6d46982ff632132ae3fe07044d2b73c0843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666743Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#672074}
-
Vladislav Kuzkokov authored
Refactor to |base::OnceCallback| where possible. Explicitly use |base::RepeatingCallback| where it isn't. Leave as is if depends on API that should be updated. Bug: 968109 Change-Id: I8b1c3dee4595b03a1f1cf1a285441be3707e83c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648494Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#672073}
-
Nektarios Paisios authored
Ensures that TableInfo vauches that an object is indeed part of a table and doesn't decide only on the object's role. R=aleventhal@chromium.org Change-Id: If8ddcfef18db4945856fa97751cdf258406a33a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672430Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#672072}
-
Rune Lillesveen authored
Flaky crashes requires this workaround. TBR=lukasza@chromium.org Bug: 976299 Change-Id: Ie8bc0400c8cdb03d730f8a6b224deb3dc0e25e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675360Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#672071}
-
Antonio Gomes authored
BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I502eb37e2131949d513d74288d2c1c21054e10b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673674 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#672070}
-
Richard Knoll authored
Disabling and re-enabling sync creates a new device id. This would lead to multiple entries per physical device until the "old" device is not considered active anymore. This will de-duplicate devices based on their name and only show the ones with the latest last sync time. Bug: 978395 Change-Id: I85f4a9160722244113378a8a92aa9bf300aa2875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675430Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#672069}
-
Anatoliy Potapchuk authored
This CL adds chrome-side implementation of the lookup keys(board_id, device_id) required for Remote Server Unlock process. Bug: 947743 Change-Id: Iac9eee4ac08453bb42d15078b05f65fd86db094b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596748Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#672068}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2308bb223ef2..d3fc161c169d git log 2308bb223ef2..d3fc161c169d --date=short --no-merges --format='%ad %ae %s' 2019-06-25 jakobi@webrtc.org Revert "Change buffer level filter to store current level in number of samples." 2019-06-25 jakobi@webrtc.org Change buffer level filter to store current level in number of samples. 2019-06-25 danilchap@webrtc.org Use DefaultTaskQueueFactory in CreatePeerConnectionFactoryForJava 2019-06-25 mbonadei@webrtc.org Switch rtp_generator to ABSL_FLAG. 2019-06-25 mbonadei@webrtc.org Switch frame_editor to ABSL_FLAG. 2019-06-25 mbonadei@webrtc.org Switch reference_less_video_analysis to ABSL_FLAG. 2019-06-25 mbonadei@webrtc.org Switch psnr_ssim_analyzer to ABSL_FLAG. Created with: gclient setdep -r src/third_party/webrtc@d3fc161c169d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie3f655cb68f5db3a766d5f002619160556a10450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672067}
-
Takashi Toyoshima authored
Deprecate metrics that were introduced to monitor reload duration times to investigate a chance to detect a signal for users' reload intention. But, we could not figure out good characteristics to utilize this information. This change effectively reverts the following CL, but the reload_type_ in NavigationHandleImpl will be remained because it's now used for another purpose. https://codereview.chromium.org/2174293002 Bug: 975314 Change-Id: Idda509df284247c42687a69a2a654607e921b788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670142 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#672066}
-
Antoine Labour authored
Making sure there are at least 2 owners after I leave. This CL was uploaded by git cl split. R=penghuang@chromium.org Change-Id: I16d9dc381699c884d6c335a16664b389fc82dc58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674612 Auto-Submit: Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#672065}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a10a8de2. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 845a980a "KV Storage: add timeout=long and reenable disabled test" 74cc6972 "[Navigation Timing] secureConnectionStart should be non-zero" 73b57b36 "Add sec-metadata test when updating a service worker" 58b8718f "KV Storage: update to match IDL" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ia23e67f9df8f868ef976b7eaa71d483102db4a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676184Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672064}
-
Stephen Nusko authored
This is needed in a future CL to connect via the IPC mechanism used by the system Perfetto service on Android. Bug: 966047 Change-Id: I0521d9e91cc6d3332607be747743a2ab590255ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624817 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#672063}
-
Igor authored
This is a device policy that specifies if the device is allowed to powerwash, either from login screen with shortcut keys, or from settings page. The implementation of the effects on the settings page will be done in a separate CL. Bug: chromium:900369 Test: unit_tests --gtest_filter=DeviceSettingsProviderTest.DevicePowerwashAllowed Change-Id: I3d70c18c6053dbe80d83213dcee543f0b2a96230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599619 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#672062}
-
Joanmarie Diggs authored
AtkTable was supported for all objects of ATK_ROLE_TABLE. Because ARIA treegrid is mapped to ATK_ROLE_TREE_TABLE, this support was absent. Bug: 978056 Change-Id: I39caa49e53f4864fd16f0eab5e4164f5fb8f9ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672747Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Cr-Commit-Position: refs/heads/master@{#672061}
-
Bruno Santos authored
Bug: 977019 Change-Id: Ie798b541d1a0138c4ebef2f5a27adad23839b214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672828Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#672060}
-
Luke Zielinski authored
testing/scripts/run_wpt_tests.py is used to adapt swarming flags to WPT flags (eg: for sharding), and also to kick-off the update_wpt_output.py cleanup step. t_p/b/t/build_wpt_metadata.py is for converting Chromium TestExpectations files into WPT Metadata files for skipped tests. t_p/b/t/update_wpt_output.py is run as a cleanup step on each shard. It rewrites the output of a WPT run by inserting expected statuses from the TestExpectations file, which includes supporting flaky tests (ie: multiple expected statuses) which WPT doesn't currently understand. Bug: 937369 Change-Id: Ic7d2c037ec545f38a1101759db6eb04db54057c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660702 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#672059}
-
Colin Blundell authored
This class provides an implementation of ActiveAccountAccessTokenFetcher that is backed by DeviceOAuth2TokenService. With the pending removal of OAuth2TokenService, the class needs to live in //chrome where it can have direct knowledge of DeviceOAuth2TokenService. This CL makes that change. Bug: 967598 Change-Id: I585dc5b0f27dad7051256f0550867e23733d85d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675550Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#672058}
-
Colin Blundell authored
This class exists to enable making access token requests from threads other than the UI thread. However, it is not used in the codebase, and it has some amount of maintenance cost and confusion associated with it. It can always be brought back if needed. Bug: 967598 Change-Id: I2208d377f852e88f1cd8169202a07ce00d32d53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675648Reviewed-by:
-
Dominik Röttsches authored
If a renderer asks for the font lookup table asynchronously using GetUniqueNameLookupTableIfAvailable and recevied the information that it's not ready yet, then queues a callback for receiving it, but the font table has become ready in between, callbacks may be missed. Cover for the situation in QueueShareMemoryRegionWhenReady() by posting callbacks if the table was already prepared. We cannot DCHECK on !font_table_built_.IsSignaled() as there is a small time window in which the table gets ready between the two IPCs reaching the browser process. Bug: 977283 Tbr: pkasting Change-Id: I9e7b8d7b9a7afe761a5a0e9d11c894eedc0e452a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675353Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Chris Blume authored
This CL adds another flaky test to the list of SkiaVulkan Android flakes on content_browsertests. Bug: 977669 Change-Id: I8ba25d0dbad62f22bdab29efc81a6928035c51ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675226 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#672055}
-
Lucas Tenório authored
Bug: 977566 Change-Id: I697e026c9b2574b7d4e5b8491709b98da5919525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673018 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96f6f7f65b3c..cc84ea1d6c32 git log 96f6f7f65b3c..cc84ea1d6c32 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 borenet@google.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/skia@cc84ea1d6c32 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@google.com Change-Id: Iefe845301ed6153bc3583941043738b1dd387bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676070Reviewed-by:
-
Allen Robinson authored
Bug: 934451 Change-Id: I62b2969964b1f38d1e066f842ef5635286dcea27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671407Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Allen Robinson <arobins@chromium.org> Auto-Submit: Allen Robinson <arobins@chromium.org> Cr-Commit-Position: refs/heads/master@{#672052}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/90c6d1bdc321..2308bb223ef2 git log 90c6d1bdc321..2308bb223ef2 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Switch rgba_to_i420_converter to ABSL_FLAG. 2019-06-25 mbonadei@webrtc.org Reland "Switch frame_analyzer to ABSL_FLAG." Created with: gclient setdep -r src/third_party/webrtc@2308bb223ef2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2e0d07842fbe833629404d6f1398c78018626260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676224Reviewed-by:
-
Christian Dullweber authored
When third party cookies are managed by enterprise policy, the cookie controls preference needs to be forced to be disabled. Bug: 967668 Change-Id: I68a78d083157c63fa9cfe088b097c73f9f3f1ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658156 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#672050}
-
Alexander Griboedov authored
NonMainThreadTaskQueue holds ptr of the voter. Task voter in its turn holds refptr of TaskQueue it was created by. This results in a leak of the both instances. According to other usages of the voter, its ptr should be held by owner of the task queue. As a result, voter ptr and setPaused method is moved to a shared owner. Change-Id: I055bb82db2c1906eb3fd4c5c3329484f07f3b09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670870 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#672049}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/994a35dedd23..dcd49b01615f git log 994a35dedd23..dcd49b01615f --date=short --no-merges --format='%ad %ae %s' 2019-06-25 ilkos@google.com Merge "Add pprof to headers" 2019-06-25 treehugger-gerrit@google.com Merge "Remove unneeded code." Created with: gclient setdep -r src/third_party/perfetto@dcd49b01615f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I2f9f345296f7c2b285361c7c53f73d3db9d92e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676071Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67ad8746..0f67ee5f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d41b61e09b4d2d284a3a9e62999b132bb2f805d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675365Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672047}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1090f3e3087..45f99e2caaf7 Created with: gclient setdep -r src-internal@45f99e2caaf7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: I45bb7176f663b3b88adaf33a8949ff20b4166f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676069Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672046}
-
Rune Lillesveen authored
TBR=vakh@chromium.org Bug: 978405 Change-Id: Ie54327a833a55add5ee6882ce2ae2d93eb0a8ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675670Reviewed-by:
-
W. James MacLean authored
It appears that AccessibilityMsg_HitTest is no longer used, having been replaced by calling AccessibilityMsg_PerformAction with an action of Action::kHitTest. Bug: 977381 Change-Id: I888cb1767ab5a3fb85e6fdb17f895cee25e87b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674344Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#672044}
-
BUG=762641 TBR=alemate@google.com Change-Id: I29bbb5a57e8aad4b2123c851cd59788599328d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676084Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672043}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib39f168b97b50190303f1f8022bc8325063d8905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676068Reviewed-by:
-
Wei Lee authored
This CL fills android.sensor.timestamp field for reprocess request. Bug: None Test: cros_camera_service \ --metadata_inspector_output=/dev/stdout \ --metadata_inspector_whitelist='timestamp' Change-Id: Id23890e7752dd51374801048185ddf059dc8e5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652753Reviewed-by:Ricky Liang <jcliang@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#672041}
-
Benoît Lizé authored
It is not necessary to kill the entire process group to dump it, and it is not required to ptrace() it. Fix the first one, and document why ptrace() may still be useful. Reported by bgeffon@google.com. Bug: 845459 Change-Id: I9f08e7208cfcfdec00bcaf80f83c585f1d4ea195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675649Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#672040}
-
Tanmoy Mollik authored
Sync and Signin files in preferences directory currently does not have an owner. We want to move these files to a dedicated folder for sync so that reviewers have a better context about cls. Bug: 928406 Change-Id: I8137dfbf3f2861ad8507bd1f6843c616e3ab1201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657900Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#672039}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2923d768f010..90c6d1bdc321 git log 2923d768f010..90c6d1bdc321 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Revert "Switch frame_analyzer to ABSL_FLAG." Created with: gclient setdep -r src/third_party/webrtc@90c6d1bdc321 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I11bdeae8ccc63e6801a1722cba9207bb18fd8236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675474Reviewed-by:
-
Pâris MEULEMAN authored
This is a reland of bfe02993 This was reverted in https://crrev.com/c/1674250 following conflict with https://crrev.com/c/1673453 PS2 fixes that. Original change's description: > Create ChromeSigninManagerDelegate JNI > > This introduces the Jni counterpart of the java > ChromeSigninManagerDelegate. This interface will provide access to android > specific dependencies on //chrome/browser to the componentized java > SigninManager. > > This first iteration creates the new objects and implements > stopApplyingCloudPolicy, fetchAndApplyCloudPolicy, isAccountManaged and > getManagementDomain. > > As discussed in CLs on the java counterpart (bug 963400) this object > will hold pointers to singletons such as the ActiveUserProfile. > The native object is created by the java object. > > details in document: > https://docs.google.com/document/d/18887XeZNJ9pmoTdJducssk5_yVU2CQ3EqaRFoMqWCCk/ > > Bug: 963402 > Change-Id: Iccbb6b30d23f26fc5960b5d9db9c122df3e589f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642547 > Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671684} Bug: 963402 Change-Id: Ie0f03bb07e722ef2858a5eaee427c7620e4c157f TBR: tedchoc@chromium.org, sdefresne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675426 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
-
