GitLab

BUG=none
TEST=manually

Review URL: http://codereview.chromium.org/7925006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102330 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org

Review URL: http://codereview.chromium.org/7994009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102329 0039d316-1c4b-4281-b951-d872f2087c98

substitution in the resource_ids file correctly when it is invoked by
ninja (which uses a relative path for this, whereas our gyp-generated
make files use an absolute path).

BUG=97420
TEST=this builds: ninja -C out/Debug chrome_extra_resources

Review URL: http://codereview.chromium.org/7995013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102327 0039d316-1c4b-4281-b951-d872f2087c98

Changed Panel.xib to add icon in NSView type.

BUG=none
TEST=manul test to verify it exists

Review URL: http://codereview.chromium.org/7981035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102326 0039d316-1c4b-4281-b951-d872f2087c98

Revert 102322 - For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". (This isn't possible by simply naming the enum as technically the enum doesn't define all of the possible combinations of bits.) This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too.

I also added CERT_STATUS_NO_ERROR in place of "0" as a magic number.

Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots...

The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph.

BUG=92247
TEST=Compiles
Review URL: http://codereview.chromium.org/7819009

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/7995014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102325 0039d316-1c4b-4281-b951-d872f2087c98

For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". (This isn't possible by simply naming the enum as technically the enum doesn't define all of the possible combinations of bits.) This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too.

I also added CERT_STATUS_NO_ERROR in place of "0" as a magic number.

Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots...

The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph.

BUG=92247
TEST=Compiles
Review URL: http://codereview.chromium.org/7819009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102322 0039d316-1c4b-4281-b951-d872f2087c98

RLZ strings for the omnibox and home page access points instead of just
invalidating, so that the first time the code tries to use the strings after
the ping they are valid.

BUG=None
TEST=Install chrome.  Chrome will start automatically, do not stop it.
Wait for the RLZ ping to be sent.  Perform a search with the omnibox
and make sure an rlz= CGI parameter is present.  Visit the home page and
make the request contains an X-Rlz-String HTTP header.
To perform these tests, install an official chrome build with a non-organic
brand code.

Review URL: http://codereview.chromium.org/7980013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102321 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit abd8f18a14e1c07f2b0750b1d3c06d5d708a89f1.

Re-enable disabled test due to this

TBR=sail@chromium.org
BUG=97625
TEST=none

Review URL: http://codereview.chromium.org/7996011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102319 0039d316-1c4b-4281-b951-d872f2087c98

The code attempts to detect an image with a garbage in the alpha channel and reset the alpha channel to a sane state in that case.

BUG=97160
TEST=Paste an image into a page using event.ClipboardData with the Windows Basic theme active.

Review URL: http://codereview.chromium.org/7967007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102317 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102316 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96640
TEST=No user visible change.

Review URL: http://codereview.chromium.org/7979007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102315 0039d316-1c4b-4281-b951-d872f2087c98

R=nduca@chromium.org

Review URL: http://codereview.chromium.org/7982015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102314 0039d316-1c4b-4281-b951-d872f2087c98

Fix a flash plugin process crash on Windows which occurs on the field in the context of the SetCursor Windows API
call. We intercept this API to ensure that custom cursors set by flash plugin can be marshaled back to the browser
process. Based on the callstack the crash occurs while clearing the custom data vector in the WebCursor object
in the plugin process. As this field is not used on Windows, it is not clear why this crash occurs. It may well
be due to the fact that the global plugin instance pointer is pointing to an invalid plugin instance. Code inspection
did not reveal much.

We don't need to save away the plugin cursor in the SetCursor intercept. This can be safely done in the HandleEvent
handler, which simplifies the code and should hopefully fix this crash.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=96282

BUG=96282
Review URL: http://codereview.chromium.org/7988009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102313 0039d316-1c4b-4281-b951-d872f2087c98

Adds a NonClientFrameView for generic toplevel windows.Also adds a feeble (but better than what there was) attempt at sometimes updating the cursor. Will have to be replaced by a better system, but it's a start.http://crbug.com/97247TEST=none
Review URL: http://codereview.chromium.org/7977012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102312 0039d316-1c4b-4281-b951-d872f2087c98

BUG=74951
TEST=Compiles

Review URL: http://codereview.chromium.org/7981026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102311 0039d316-1c4b-4281-b951-d872f2087c98

Dialogs shown using ShowHtmlDialog are not added to any tab strip or as a browser window. This CL adds to web_ui_browsertest functions to grab the newly created WebUI instance and run tests on it. This also adds WebUI certificate viewer tests.

BUG=None
TEST=Adds tests CertificateViewerUITest.testDialogURL, CertificateViewerUITest.testCN, CertificateViewerUITest.testDetails.


Review URL: http://codereview.chromium.org/7861024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102310 0039d316-1c4b-4281-b951-d872f2087c98

This should have been committed with http://codereview.chromium.org/7982011/
but something went wrong with the binary being added to the CL.

BUG=none
TEST=none

TBR=miket@chromium.org

Review URL: http://codereview.chromium.org/7990006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102308 0039d316-1c4b-4281-b951-d872f2087c98

I've used a profiler and removed code that takes long time
bug we don't use, and optimized several regular expressions.

BUG=28291

Review URL: http://codereview.chromium.org/7988008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102307 0039d316-1c4b-4281-b951-d872f2087c98

It is not actually supported by gyp; the fact that it works is a bug
that I am working on fixing.

BUG=96629

Review URL: http://codereview.chromium.org/7889051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102306 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102304 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach@chromium.org

Review URL: http://codereview.chromium.org/7994013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97625
TEST=none

Review URL: http://codereview.chromium.org/7989014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102302 0039d316-1c4b-4281-b951-d872f2087c98

This is called only once, better to inline it in the call site, less code.

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7983050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97268
TEST=See bug for details.
Review URL: http://codereview.chromium.org/7980061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102299 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51198
TEST=chromoting client still works.

Review URL: http://codereview.chromium.org/7981025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102297 0039d316-1c4b-4281-b951-d872f2087c98

by adding a flag to ignore path-specific suppression.

This will allow me to file bugs about current suppressions
and just say 'run checklicenses.py --ignore-suppressions some/path to repro'

BUG=28291

Review URL: http://codereview.chromium.org/7979030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102292 0039d316-1c4b-4281-b951-d872f2087c98

We found a better workaround, so removing this one.

BUG=95888
Review URL: http://codereview.chromium.org/7857022

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/7988006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102289 0039d316-1c4b-4281-b951-d872f2087c98

The reason is to be able to share ownership between PeerConnection and Chromium.

TEST=
BUG=
Review URL: http://codereview.chromium.org/7887002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102286 0039d316-1c4b-4281-b951-d872f2087c98

A lot of UITests were failing due to being run without being logged in,
added code to login before the test are run.

Additionally added the tests that fail on the PFQ and BVT's to the
blacklisted tests list.

BUG=chromium-os:20022
TEST=Tested the BrowserTests and UITests wrapper on a ChromeOS VM.
R=zelidrag@chromium.org,nirnimesh@chromium.org

Review URL: http://codereview.chromium.org/7838033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102285 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of synchronous calls to getting plugins to help with http://codereview.chromium.org/7980011/.

The PluginExceptionsTableModel isn't used anymore.

Change print preview and using Reader with unsupported PDFs to tell the plugin filter which plugin name they want to use, instead of giving it the plugin directly. This makes the former not need to block on getting the plugins. The later still does, to know if Reader is installed or not, however it's trivial to make PDFHasUnsupportedFeature() get the plugins asynchronously because it's just a dispatcher for an async message.
Review URL: http://codereview.chromium.org/7977042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102284 0039d316-1c4b-4281-b951-d872f2087c98

Revert 102282 - committed the wrong cl - Turn off checklicenses until it's done more efficiently. Linux try runs now take an hour. This adds anywhere from 6 mintues to 10 minutes (when it times out), which is an unacceptable time.BUG=28291Review URL: http://codereview.chromium.org/7977043TBR=jam@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102283 0039d316-1c4b-4281-b951-d872f2087c98

Turn off checklicenses until it's done more efficiently. Linux try runs now take an hour. This adds anywhere from 6 mintues to 10 minutes (when it times out), which is an unacceptable time.

BUG=28291
Review URL: http://codereview.chromium.org/7977043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102282 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94240
TEST=Input @ character in a Flash text input with a Danish keyboard
Review URL: http://codereview.chromium.org/7978050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102278 0039d316-1c4b-4281-b951-d872f2087c98

This involved:
- Removing a grit->Chrome dependency that had been added in a unit test;
- Moving the very project-specific resource_ids file to not sit in the same directory as the grit files (albeit in a hacky way; will fix this better later as per TODOs in code); and
- Removing the hard-coding of "project base dir is two directories up from grit.py" and instead making that a parameter of resource_ids (as per TODO in code, this should later move to be a parameter of the .grd file).

Also fixed a minor bug in relpath in misc.py, and fixed line length in grd_runner.py.

The next steps will be to copy the tools/grit folder into http://code.google.com/p/grit-i18n, then in a single commit delete tools/grit from the Chrome repo and add it back in via DEPS.

Follow-up fixes will address some of the TODOs, and later fixes will generalize a few things and add some features available in a different version of grit.

BUG=97420
TEST=trybots should catch any breakage here

Review URL: http://codereview.chromium.org/7976026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102276 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7988003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102275 0039d316-1c4b-4281-b951-d872f2087c98

The old path will be deprecated once developers have migrated.

BUG=67203
TEST=FileUtilTest.IsPathControledByAdmin

Review URL: http://codereview.chromium.org/7718021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102274 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7980063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102273 0039d316-1c4b-4281-b951-d872f2087c98

R=hashimoto@chromium.org
BUG=chromium-os:18955
TEST=Manual


Review URL: http://codereview.chromium.org/7978055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102272 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64263
TEST=None

R=willchan@chromium.org

Review URL: http://codereview.chromium.org/7978039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102271 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102270 0039d316-1c4b-4281-b951-d872f2087c98